{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/events", "html_url": "https://github.com/laurent22/joplin/pull/11922", "id": 2893344130, "node_id": "PR_kwDOBLftOs6NQ4f9", "number": 11922, "title": "Translation improvement for zh_CN", "user": { "login": "clsty", "id": 129247596, "node_id": "U_kgDOB7QpbA", "avatar_url": "https://avatars.githubusercontent.com/u/129247596?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clsty", "html_url": "https://github.com/clsty", "followers_url": "https://api.github.com/users/clsty/followers", "following_url": "https://api.github.com/users/clsty/following{/other_user}", "gists_url": "https://api.github.com/users/clsty/gists{/gist_id}", "starred_url": "https://api.github.com/users/clsty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clsty/subscriptions", "organizations_url": "https://api.github.com/users/clsty/orgs", "repos_url": "https://api.github.com/users/clsty/repos", "events_url": "https://api.github.com/users/clsty/events{/privacy}", "received_events_url": "https://api.github.com/users/clsty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1091621259, "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", "name": "translation", "color": "91ca55", "default": false, "description": "i18n and l10n" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2025-03-04T08:11:08Z", "updated_at": "2025-03-06T00:16:28Z", "closed_at": "2025-03-04T23:52:12Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11922", "html_url": "https://github.com/laurent22/joplin/pull/11922", "diff_url": "https://github.com/laurent22/joplin/pull/11922.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11922.patch", "merged_at": "2025-03-04T23:52:12Z" }, "body": "- Improve simplified Chinese translation for corrections, readability and corrections, etc.", "closed_by": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11922/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11922/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696576049", "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696576049", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "id": 2696576049, "node_id": "IC_kwDOBLftOs6gunwx", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-04T08:11:23Z", "updated_at": "2025-03-04T23:52:23Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696576049/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696584996", "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696584996", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "id": 2696584996, "node_id": "IC_kwDOBLftOs6gup8k", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-04T08:15:01Z", "updated_at": "2025-03-04T08:15:01Z", "author_association": "COLLABORATOR", "body": "Oh, and you have to sign the CLA. see https://github.com/laurent22/joplin/pull/11922#issuecomment-2696576049", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696584996/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696593013", "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696593013", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "id": 2696593013, "node_id": "IC_kwDOBLftOs6gur51", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-04T08:18:46Z", "updated_at": "2025-03-04T08:18:46Z", "author_association": "COLLABORATOR", "body": "I'm heading to bed. I'm going to look at it tomorrow.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696593013/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696597451", "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696597451", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "id": 2696597451, "node_id": "IC_kwDOBLftOs6gus_L", "user": { "login": "clsty", "id": 129247596, "node_id": "U_kgDOB7QpbA", "avatar_url": "https://avatars.githubusercontent.com/u/129247596?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clsty", "html_url": "https://github.com/clsty", "followers_url": "https://api.github.com/users/clsty/followers", "following_url": "https://api.github.com/users/clsty/following{/other_user}", "gists_url": "https://api.github.com/users/clsty/gists{/gist_id}", "starred_url": "https://api.github.com/users/clsty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clsty/subscriptions", "organizations_url": "https://api.github.com/users/clsty/orgs", "repos_url": "https://api.github.com/users/clsty/repos", "events_url": "https://api.github.com/users/clsty/events{/privacy}", "received_events_url": "https://api.github.com/users/clsty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-04T08:20:54Z", "updated_at": "2025-03-04T08:20:54Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696597451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696644884", "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2696644884", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "id": 2696644884, "node_id": "IC_kwDOBLftOs6gu4kU", "user": { "login": "clsty", "id": 129247596, "node_id": "U_kgDOB7QpbA", "avatar_url": "https://avatars.githubusercontent.com/u/129247596?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clsty", "html_url": "https://github.com/clsty", "followers_url": "https://api.github.com/users/clsty/followers", "following_url": "https://api.github.com/users/clsty/following{/other_user}", "gists_url": "https://api.github.com/users/clsty/gists{/gist_id}", "starred_url": "https://api.github.com/users/clsty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clsty/subscriptions", "organizations_url": "https://api.github.com/users/clsty/orgs", "repos_url": "https://api.github.com/users/clsty/repos", "events_url": "https://api.github.com/users/clsty/events{/privacy}", "received_events_url": "https://api.github.com/users/clsty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-04T08:39:23Z", "updated_at": "2025-03-06T00:16:28Z", "author_association": "CONTRIBUTOR", "body": "> see inline comment\r\n> \r\n> Other than that, LGTM. Thanks for the update\r\n\r\nThat's a really quick response. Thanks for reviewing.\r\n\r\nI've added the comments back. However may I ask why they are still needed btw?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2696644884/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2699270516", "html_url": "https://github.com/laurent22/joplin/pull/11922#issuecomment-2699270516", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11922", "id": 2699270516, "node_id": "IC_kwDOBLftOs6g45l0", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-04T23:41:24Z", "updated_at": "2025-03-04T23:41:24Z", "author_association": "COLLABORATOR", "body": "Thank you for adding the comments back.\r\n\r\nThe reason for keeping them around is as follows: The translation files are generated from the source code. It is quite possible that a change in the code will be reverted at a later point or a similar text is used as what was previously used and translated.\r\nWe also do not use annotations in translation files, which would help in certain situations to understand the meaning of the text and to translate it properly. Literal translations are often wrong and need correction. If there are a valid translations in the comments, they can help a translator.\r\nI'm not sure but Poedit might make use of them for translation suggestions.\r\n\r\nAdditionally, the .po file are not used in the product. They are converted to JSON files and all comments are stripped out anyway. \r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2699270516/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }