{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14672/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14672/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14672/events", "html_url": "https://github.com/laurent22/joplin/pull/14672", "id": 4050185449, "node_id": "PR_kwDOBLftOs7JToWl", "number": 14672, "title": "Desktop: Fixes #14661 Disables the New Note and New To Do button until a notebook is created. ", "user": { "login": "ddg22004", "id": 125038348, "node_id": "U_kgDOB3PvDA", "avatar_url": "https://avatars.githubusercontent.com/u/125038348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddg22004", "html_url": "https://github.com/ddg22004", "followers_url": "https://api.github.com/users/ddg22004/followers", "following_url": "https://api.github.com/users/ddg22004/following{/other_user}", "gists_url": "https://api.github.com/users/ddg22004/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddg22004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddg22004/subscriptions", "organizations_url": "https://api.github.com/users/ddg22004/orgs", "repos_url": "https://api.github.com/users/ddg22004/repos", "events_url": "https://api.github.com/users/ddg22004/events{/privacy}", "received_events_url": "https://api.github.com/users/ddg22004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 8, "created_at": "2026-03-10T08:19:03Z", "updated_at": "2026-03-10T15:07:00Z", "closed_at": "2026-03-10T12:22:27Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14672", "html_url": "https://github.com/laurent22/joplin/pull/14672", "diff_url": "https://github.com/laurent22/joplin/pull/14672.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14672.patch", "merged_at": null }, "body": "**Summary**\r\nWhen opening a new profile with no notebooks, the \"New note\" and \"New to-do\" buttons are visible in the note list controls but on clicking them it does nothing as no notebook is created.\r\n\r\n**AI Disclosure**\r\nAI was used for suggestions and generating test cases for the stateToWhenClauseContext in stateToWhenClauseContext.test.ts \r\nTests include:\r\nMultiple folder selection disables buttons\r\nNo folder selection disables buttons\r\n\r\nAll generated tests were reviewed and validated. \r\n\r\n**Fix**\r\nIn order to enable/disable the button a property of isActiveFolder is created \r\nand the property is used with hasSelectedNotebook as a condition to enable the buttons. When both the conditions are true then the buttons are enabled.\r\nTo fix this the following files were changed.\r\n1.NoteListControls.tsx\r\n2.stateToWhenClauseContext.ts\r\nVideo:\r\n[Screencast From 2026-03-10 13-40-06.webm](https://github.com/user-attachments/assets/bfed6c3d-49f9-43f0-b349-de86b71a1367)\r\n\r\n\r\n**Testing:**\r\nFew test cases are also added in the stateToWhenClauseContext.test.ts\r\nfor checking Property test of \"isActiveFolder\" and button enabling and disabling condition tests by checking valid folder state.\r\n\r\n1. Creating a new profile.\r\n2. Verifying whether the buttons are disabled or enabled when no notebook is created.\r\n3. Creating a new notebook\r\n4. Verifying whether the buttons are enabled or not.\r\n5. Deleting the notebook and verifying the button are disabled again or not.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14672/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14672/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029525374", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4029525374", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4029525374, "node_id": "IC_kwDOBLftOs7wLa1-", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T08:19:15Z", "updated_at": "2026-03-10T15:07:00Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029525374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029527003", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4029527003", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4029527003, "node_id": "IC_kwDOBLftOs7wLbPb", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T08:19:31Z", "updated_at": "2026-03-10T10:58:55Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nChanges refactor button enable logic in NoteListControls to use computed predicates from an updated command context system. A new `isActiveFolder` flag is introduced to WhenClauseContext to track whether a valid active folder exists.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Command Context**
`packages/lib/services/commands/stateToWhenClauseContext.ts`, `packages/lib/services/commands/stateToWhenClauseContext.test.ts`|Introduced `isActiveFolder` derived flag to WhenClauseContext, computed from settings.activeFolderId and validated against deletion status. Added comprehensive test coverage for isActiveFolder behaviour and button state scenarios across single, multiple, and no folder selection cases.|\n|**Note List Controls**
`packages/app-desktop/gui/NoteListControls/NoteListControls.tsx`|Refactored button enable logic to use computed predicates (`hasSelectedNotebook`, `isActiveFolder`, `canCreateNote`, `canCreateTodo`) combined with `CommandService.isEnabled()` checks, consolidating permission verification into mapStateToProps rather than per-call checks.|\n\n## Suggested labels\n\n`desktop`, `bug`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 4\n\n
\n✅ Passed checks (4 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Description check | ✅ Passed | The description thoroughly explains the bug, the solution, files changed, testing approach, and includes an AI disclosure statement that is directly related to the changeset. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | PR description includes all required sections: clear problem/user-impact description, high-level solution explanation, and comprehensive test plan with automated tests and manual verification steps. |\n| Title check | ✅ Passed | The title accurately reflects the main objective of the pull request: disabling the New Note and New To-Do buttons until a notebook is created, which is the primary functional change across the modified files. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n> [!TIP]\n> Try [Coding Plans](https://www.coderabbit.ai/issue-planner). Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).\n> Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14672)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029527003/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029539608", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4029539608", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4029539608, "node_id": "IC_kwDOBLftOs7wLeUY", "user": { "login": "ddg22004", "id": 125038348, "node_id": "U_kgDOB3PvDA", "avatar_url": "https://avatars.githubusercontent.com/u/125038348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddg22004", "html_url": "https://github.com/ddg22004", "followers_url": "https://api.github.com/users/ddg22004/followers", "following_url": "https://api.github.com/users/ddg22004/following{/other_user}", "gists_url": "https://api.github.com/users/ddg22004/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddg22004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddg22004/subscriptions", "organizations_url": "https://api.github.com/users/ddg22004/orgs", "repos_url": "https://api.github.com/users/ddg22004/repos", "events_url": "https://api.github.com/users/ddg22004/events{/privacy}", "received_events_url": "https://api.github.com/users/ddg22004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T08:21:52Z", "updated_at": "2026-03-10T08:21:52Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029539608/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030238463", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4030238463", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4030238463, "node_id": "IC_kwDOBLftOs7wOI7_", "user": { "login": "mrjo118", "id": 6963004, "node_id": "MDQ6VXNlcjY5NjMwMDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mrjo118", "html_url": "https://github.com/mrjo118", "followers_url": "https://api.github.com/users/mrjo118/followers", "following_url": "https://api.github.com/users/mrjo118/following{/other_user}", "gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}", "starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions", "organizations_url": "https://api.github.com/users/mrjo118/orgs", "repos_url": "https://api.github.com/users/mrjo118/repos", "events_url": "https://api.github.com/users/mrjo118/events{/privacy}", "received_events_url": "https://api.github.com/users/mrjo118/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T10:15:08Z", "updated_at": "2026-03-10T10:15:43Z", "body": "There are many issues with this PR. There is no need for so many tests for a tiny change like this, there are unnecessary formatting / whitespace changes, there's no video or screenshot included.\r\n\r\nAlso its not clear whether the solution actually matches the expected outcome on the issue. The PR description implies (without explicitly saying) that the buttons will now have a disabled state, when no valid notebooks exist upon profile creation. But the issue says they should instead be hidden, to be consistent with existing behaviour after deleting a notebook.", "author_association": "COLLABORATOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030238463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030611673", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4030611673", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4030611673, "node_id": "IC_kwDOBLftOs7wPkDZ", "user": { "login": "ddg22004", "id": 125038348, "node_id": "U_kgDOB3PvDA", "avatar_url": "https://avatars.githubusercontent.com/u/125038348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddg22004", "html_url": "https://github.com/ddg22004", "followers_url": "https://api.github.com/users/ddg22004/followers", "following_url": "https://api.github.com/users/ddg22004/following{/other_user}", "gists_url": "https://api.github.com/users/ddg22004/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddg22004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddg22004/subscriptions", "organizations_url": "https://api.github.com/users/ddg22004/orgs", "repos_url": "https://api.github.com/users/ddg22004/repos", "events_url": "https://api.github.com/users/ddg22004/events{/privacy}", "received_events_url": "https://api.github.com/users/ddg22004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T11:12:07Z", "updated_at": "2026-03-10T11:12:07Z", "body": "I did include a video in this PR but I understand that I worked upon a solution to disable the buttons if there is a non deleted folder but the Issue requires the buttons to be hidden I created a solution based on my discussion in the forum. I'll work along that part if the issue is still open to work on else it's alright. ", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030611673/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030640425", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4030640425", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4030640425, "node_id": "IC_kwDOBLftOs7wPrEp", "user": { "login": "mrjo118", "id": 6963004, "node_id": "MDQ6VXNlcjY5NjMwMDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mrjo118", "html_url": "https://github.com/mrjo118", "followers_url": "https://api.github.com/users/mrjo118/followers", "following_url": "https://api.github.com/users/mrjo118/following{/other_user}", "gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}", "starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions", "organizations_url": "https://api.github.com/users/mrjo118/orgs", "repos_url": "https://api.github.com/users/mrjo118/repos", "events_url": "https://api.github.com/users/mrjo118/events{/privacy}", "received_events_url": "https://api.github.com/users/mrjo118/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T11:17:31Z", "updated_at": "2026-03-10T11:17:31Z", "body": "Apologies, I did not see notice the video link. Regardless, there are still other issues with the PR as mentioned, and it seems like you only partially read the contribution guidelines or did not read them thoroughly", "author_association": "COLLABORATOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030640425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030695368", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4030695368", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4030695368, "node_id": "IC_kwDOBLftOs7wP4fI", "user": { "login": "ddg22004", "id": 125038348, "node_id": "U_kgDOB3PvDA", "avatar_url": "https://avatars.githubusercontent.com/u/125038348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddg22004", "html_url": "https://github.com/ddg22004", "followers_url": "https://api.github.com/users/ddg22004/followers", "following_url": "https://api.github.com/users/ddg22004/following{/other_user}", "gists_url": "https://api.github.com/users/ddg22004/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddg22004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddg22004/subscriptions", "organizations_url": "https://api.github.com/users/ddg22004/orgs", "repos_url": "https://api.github.com/users/ddg22004/repos", "events_url": "https://api.github.com/users/ddg22004/events{/privacy}", "received_events_url": "https://api.github.com/users/ddg22004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T11:28:33Z", "updated_at": "2026-03-10T11:31:53Z", "body": "I read the contribution guidelines before as well , I just wanted to be sure that the code works properly on tests ,that's where I made a few mistakes (including the formatting and whitespaces changes and creating lots of test cases for small changes), I'll take care of that in my next commits and make sure I abide by the guidelines. Thanks for your help and guidance.", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030695368/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030993802", "html_url": "https://github.com/laurent22/joplin/pull/14672#issuecomment-4030993802", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14672", "id": 4030993802, "node_id": "IC_kwDOBLftOs7wRBWK", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T12:22:27Z", "updated_at": "2026-03-10T12:22:27Z", "body": "Hello, this issue has now been fixed in another PR", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030993802/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }