{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11388", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/events", "html_url": "https://github.com/laurent22/joplin/pull/11388", "id": 2656236918, "node_id": "PR_kwDOBLftOs6B0Sdi", "number": 11388, "title": " Desktop: Fixes #11261 : Ensure spell-check toggle works on macOS", "user": { "login": "dhakarRaghu", "id": 149622456, "node_id": "U_kgDOCOsOuA", "avatar_url": "https://avatars.githubusercontent.com/u/149622456?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhakarRaghu", "html_url": "https://github.com/dhakarRaghu", "followers_url": "https://api.github.com/users/dhakarRaghu/followers", "following_url": "https://api.github.com/users/dhakarRaghu/following{/other_user}", "gists_url": "https://api.github.com/users/dhakarRaghu/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhakarRaghu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhakarRaghu/subscriptions", "organizations_url": "https://api.github.com/users/dhakarRaghu/orgs", "repos_url": "https://api.github.com/users/dhakarRaghu/repos", "events_url": "https://api.github.com/users/dhakarRaghu/events{/privacy}", "received_events_url": "https://api.github.com/users/dhakarRaghu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2024-11-13T17:27:29Z", "updated_at": "2024-12-09T15:49:08Z", "closed_at": "2024-12-09T15:48:52Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11388", "html_url": "https://github.com/laurent22/joplin/pull/11388", "diff_url": "https://github.com/laurent22/joplin/pull/11388.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11388.patch", "merged_at": "2024-12-09T15:48:52Z" }, "body": "# Desktop: Fixes #11261 : Ensure spell-check can be toggled off on macOS\r\n\r\nThis pull request addresses an issue where spell-check could not be fully disabled on the macOS desktop app, even when explicitly turned off in the settings.\r\n\r\n## Problem\r\nOn macOS, users encountered a problem when trying to disable spell-check. Although the setting was turned off, spell-check continued to underline words, suggesting that it wasn't fully disabled.\r\n\r\n## Solution\r\nThe fix ensures that:\r\n- When users toggle spell-check off, the language list is set to an empty array, and the spell-checker is explicitly disabled in the session.\r\n- When re-enabling, the spell-checker applies the correct languages and confirms that it is enabled in the session.\r\n\r\n## Technical Summary\r\n- Updated the `SpellCheckerServiceDriverNative.ts` file to explicitly call `setSpellCheckerEnabled(false)` when disabling and `setSpellCheckerEnabled(true)` when enabling.\r\n- Improved logging in `setLanguages` to track the session's state after each toggle and confirm that the changes have taken effect.\r\n\r\n## Testing\r\n- Manually tested the toggling of spell-check on and off on the macOS desktop app to confirm that spell-check does not underline words when disabled.\r\n- Verified that the correct language settings are applied upon re-enabling.\r\n\r\nThis PR resolves the underlying issue and provides a more consistent spell-check toggle experience on the macOS platform.\r\n\r\n**Reference**: Fixes #11261 \r\n\r\ndemo : \r\n\r\nhttps://github.com/user-attachments/assets/a63392ed-3038-481d-95ce-eca052c1f7df\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11388/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474282479", "html_url": "https://github.com/laurent22/joplin/pull/11388#issuecomment-2474282479", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11388", "id": 2474282479, "node_id": "IC_kwDOBLftOs6Teo3v", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-13T17:27:46Z", "updated_at": "2024-12-09T15:49:08Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474282479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474283042", "html_url": "https://github.com/laurent22/joplin/pull/11388#issuecomment-2474283042", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11388", "id": 2474283042, "node_id": "IC_kwDOBLftOs6TepAi", "user": { "login": "dhakarRaghu", "id": 149622456, "node_id": "U_kgDOCOsOuA", "avatar_url": "https://avatars.githubusercontent.com/u/149622456?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhakarRaghu", "html_url": "https://github.com/dhakarRaghu", "followers_url": "https://api.github.com/users/dhakarRaghu/followers", "following_url": "https://api.github.com/users/dhakarRaghu/following{/other_user}", "gists_url": "https://api.github.com/users/dhakarRaghu/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhakarRaghu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhakarRaghu/subscriptions", "organizations_url": "https://api.github.com/users/dhakarRaghu/orgs", "repos_url": "https://api.github.com/users/dhakarRaghu/repos", "events_url": "https://api.github.com/users/dhakarRaghu/events{/privacy}", "received_events_url": "https://api.github.com/users/dhakarRaghu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-13T17:28:00Z", "updated_at": "2024-11-13T17:28:00Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2474283042/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2480811692", "html_url": "https://github.com/laurent22/joplin/pull/11388#issuecomment-2480811692", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11388", "id": 2480811692, "node_id": "IC_kwDOBLftOs6T3i6s", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-16T21:14:32Z", "updated_at": "2024-11-16T21:14:32Z", "author_association": "OWNER", "body": "Too many white space changes, deleted comments and log statements in this pull request. We can't merge it as it is", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2480811692/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }