{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14551/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14551/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14551/events",
"html_url": "https://github.com/laurent22/joplin/pull/14551",
"id": 4018378911,
"node_id": "PR_kwDOBLftOs7HsgLN",
"number": 14551,
"title": "All: Simplified English language names in locale settings",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [
{
"id": 519700743,
"node_id": "MDU6TGFiZWw1MTk3MDA3NDM=",
"url": "https://api.github.com/repos/laurent22/joplin/labels/enhancement",
"name": "enhancement",
"color": "5ebeff",
"default": true,
"description": "Feature requests and code enhancements"
},
{
"id": 1091621259,
"node_id": "MDU6TGFiZWwxMDkxNjIxMjU5",
"url": "https://api.github.com/repos/laurent22/joplin/labels/translation",
"name": "translation",
"color": "91ca55",
"default": false,
"description": "i18n and l10n"
}
],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 19,
"created_at": "2026-03-03T19:40:51Z",
"updated_at": "2026-03-31T16:20:36Z",
"closed_at": "2026-03-27T11:50:01Z",
"assignee": null,
"author_association": "CONTRIBUTOR",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14551",
"html_url": "https://github.com/laurent22/joplin/pull/14551",
"diff_url": "https://github.com/laurent22/joplin/pull/14551.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14551.patch",
"merged_at": null
},
"body": "### Summary\r\nThis PR implements a long-standing **TODO** in the locale service to filter and simplify English language names.\r\n\r\n### Description\r\n\r\nThe internal **ISO 639** list often contains exhaustive or technical names that can clutter the UI (e.g., \"Spanish; Castilian\" or \"Greek, Modern (1453-)\"). This change ensures that only the primary common name is displayed by:\r\n\r\n- Splitting names at the first semicolon or comma.\r\n- Removing parenthetical notes.\r\n- Trimming extraneous whitespace.\r\n\r\nThis makes the language selection list much more approachable and professional for users across all platforms.\r\n\r\n### Testing\r\n\r\n- Logic verified against several complex entries in the ISO list.\r\n- Confirmed that primary names are preserved while technical/secondary info is correctly stripped.\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14551/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14551/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993132896",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-3993132896",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 3993132896,
"node_id": "IC_kwDOBLftOs7uAl9g",
"user": {
"login": "coderabbitai[bot]",
"id": 136622811,
"node_id": "BOT_kgDOCCSy2w",
"avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai%5Bbot%5D",
"html_url": "https://github.com/apps/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-03T19:41:43Z",
"updated_at": "2026-03-21T19:48:46Z",
"body": "\n\n\n> [!NOTE]\n> ## Reviews paused\n> \n> It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the `reviews.auto_review.auto_pause_after_reviewed_commits` setting.\n> \n> Use the following commands to manage reviews:\n> - `@coderabbitai resume` to resume automatic reviews.\n> - `@coderabbitai review` to trigger a single review.\n> \n> Use the checkboxes below for quick actions:\n> - [ ] ▶️ Resume reviews\n> - [ ] 🔍 Trigger review\n\n\n\n\n\n📝 Walkthrough
\n\n## Walkthrough\n\nLocale processing now sanitises English language names by removing semicolons, commas, and parenthetical content from ISO639 data. Two new public functions expose supported locales and language mappings.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Locale data sanitisation**
`packages/lib/locale.ts`|English name sanitisation logic added to ISO639 line processing, splitting on semicolons and commas, removing parenthetical content, and trimming whitespace before assignment to nameEnglish.|\n|**Public API expansion and tests**
`packages/lib/locale.test.ts`|New test cases for two newly exported functions: `supportedLocales()` and `supportedLocalesToLanguages()`, verifying return types and validating sanitised output contains no semicolons or year markers.|\n\n \n\n\n\n\n\n---\n\n\n> [!IMPORTANT]\n> ## Pre-merge checks failed\n> \n> Please resolve all errors before merging. Addressing warnings is optional.\n\n\n### ❌ Failed checks (1 error)\n\n| Check name | Status | Explanation | Resolution |\n| :-----------------------------------: | :------ | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Pr Description Must Follow Guidelines | ❌ Error | PR description includes problem statement and solution explanation, but test plan/verification steps are insufficient. Reviewers requested detailed before/after comparison matrix and edge case testing. | Expand test plan to include comprehensive before/after comparison matrix, explicit edge case tests, detailed verification steps, and confirmation of correct handling. |\n\n\n✅ Passed checks (3 passed)
\n\n| Check name | Status | Explanation |\n| :----------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title accurately describes the main change: simplifying English language names in locale settings by removing technical/secondary information. |\n| Description check | ✅ Passed | The description is directly related to the changeset, explaining the purpose, implementation details, and testing approach for simplifying ISO 639 language names. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n \n\n\n\n\n\n\n✨ Finishing Touches
\n\n\n🧪 Generate unit tests (beta)
\n\n- [ ] Create PR with unit tests\n\n \n\n \n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14551)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n\n❤️ Share
\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n \n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993132896/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 347564,
"client_id": "Iv1.6aaafe4fe882736b",
"slug": "coderabbitai",
"node_id": "A_kwHOB96YWc4ABU2s",
"owner": {
"login": "coderabbitai",
"id": 132028505,
"node_id": "O_kgDOB96YWQ",
"avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai",
"html_url": "https://github.com/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai/followers",
"following_url": "https://api.github.com/users/coderabbitai/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai/orgs",
"repos_url": "https://api.github.com/users/coderabbitai/repos",
"events_url": "https://api.github.com/users/coderabbitai/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "coderabbitai",
"description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n",
"external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github",
"html_url": "https://github.com/apps/coderabbitai",
"created_at": "2023-06-14T15:47:27Z",
"updated_at": "2026-03-14T07:58:44Z",
"permissions": {
"actions": "read",
"checks": "write",
"contents": "write",
"discussions": "read",
"issues": "write",
"members": "read",
"metadata": "read",
"pull_requests": "write",
"statuses": "write"
},
"events": [
"issues",
"issue_comment",
"label",
"organization",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"repository"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993434744",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-3993434744",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 3993434744,
"node_id": "IC_kwDOBLftOs7uBvp4",
"user": {
"login": "tessus",
"id": 223439,
"node_id": "MDQ6VXNlcjIyMzQzOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tessus",
"html_url": "https://github.com/tessus",
"followers_url": "https://api.github.com/users/tessus/followers",
"following_url": "https://api.github.com/users/tessus/following{/other_user}",
"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
"organizations_url": "https://api.github.com/users/tessus/orgs",
"repos_url": "https://api.github.com/users/tessus/repos",
"events_url": "https://api.github.com/users/tessus/events{/privacy}",
"received_events_url": "https://api.github.com/users/tessus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-03T20:44:30Z",
"updated_at": "2026-03-03T20:44:30Z",
"body": "This PR needs serious testing. A before and after matrix would be useful.\r\n\r\nI am most worried about the \"same\" languages that are spoken in different countries. e.g.\r\nPortuguese in Portugal vs Brasil.\r\nSpanish in Spain vs Latin America.\r\nWhat about English? We have a separate entry for `English (US)`.\r\n\r\nAlso, I can't remember seeing any weird ISO numbers in the language dropdown list, unless something has changed and I didn't notice.",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993434744/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3994416885",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-3994416885",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 3994416885,
"node_id": "IC_kwDOBLftOs7uFfb1",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-04T00:28:07Z",
"updated_at": "2026-03-27T12:33:34Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3994416885/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003528801",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4003528801",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4003528801,
"node_id": "IC_kwDOBLftOs7uoQBh",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T09:13:02Z",
"updated_at": "2026-03-05T09:13:02Z",
"body": "@dipanshurdev, please let us know if you want to keep working on this PR",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003528801/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4004392933",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4004392933",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4004392933,
"node_id": "IC_kwDOBLftOs7uri_l",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T11:30:29Z",
"updated_at": "2026-03-05T17:42:33Z",
"body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4004392933/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4006371561",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4006371561",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4006371561,
"node_id": "IC_kwDOBLftOs7uzGDp",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T16:46:14Z",
"updated_at": "2026-03-05T16:46:14Z",
"body": "> @dipanshurdev, please let us know if you want to keep working on this PR\r\n\r\nThanks for the feedback!\r\n\r\nYes, I would like to continue working on this PR.\r\n\r\nI'll add more testing and provide a before/after comparison for the language names to ensure that cases like Portuguese (Portugal) vs Portuguese (Brazil), Spanish (Spain) vs Spanish (Latin America), and English (US) are handled correctly.",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4006371561/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4006502832",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4006502832",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4006502832,
"node_id": "IC_kwDOBLftOs7uzmGw",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T17:19:16Z",
"updated_at": "2026-03-05T17:41:42Z",
"body": "recheck",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4006502832/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4006594240",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4006594240",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4006594240,
"node_id": "IC_kwDOBLftOs7uz8bA",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T17:36:05Z",
"updated_at": "2026-03-05T17:36:05Z",
"body": "@dipanshurdev, I'm not sure why you are quoting the bot when you are signing the CLA on all your PRs, but could you try not quoting it and putting your signature statement on its own comment?",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4006594240/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4007654600",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4007654600",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4007654600,
"node_id": "IC_kwDOBLftOs7u3_TI",
"user": {
"login": "tessus",
"id": 223439,
"node_id": "MDQ6VXNlcjIyMzQzOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tessus",
"html_url": "https://github.com/tessus",
"followers_url": "https://api.github.com/users/tessus/followers",
"following_url": "https://api.github.com/users/tessus/following{/other_user}",
"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
"organizations_url": "https://api.github.com/users/tessus/orgs",
"repos_url": "https://api.github.com/users/tessus/repos",
"events_url": "https://api.github.com/users/tessus/events{/privacy}",
"received_events_url": "https://api.github.com/users/tessus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-05T20:41:39Z",
"updated_at": "2026-03-05T20:41:39Z",
"body": "@dipanshurdev it probably won't work, if you edit a comment. Just copy and paste the following line to a new comment:\r\n\r\n```\r\nI have read the CLA Document and I hereby sign the CLA\r\n```",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4007654600/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009293066",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4009293066",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4009293066,
"node_id": "IC_kwDOBLftOs7u-PUK",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-06T03:25:13Z",
"updated_at": "2026-03-06T03:25:13Z",
"body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009293066/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009317585",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4009317585",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4009317585,
"node_id": "IC_kwDOBLftOs7u-VTR",
"user": {
"login": "tessus",
"id": 223439,
"node_id": "MDQ6VXNlcjIyMzQzOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tessus",
"html_url": "https://github.com/tessus",
"followers_url": "https://api.github.com/users/tessus/followers",
"following_url": "https://api.github.com/users/tessus/following{/other_user}",
"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
"organizations_url": "https://api.github.com/users/tessus/orgs",
"repos_url": "https://api.github.com/users/tessus/repos",
"events_url": "https://api.github.com/users/tessus/events{/privacy}",
"received_events_url": "https://api.github.com/users/tessus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-06T03:33:45Z",
"updated_at": "2026-03-06T03:33:45Z",
"body": "@dipanshurdev did you see the issues with the `test-locales.js` file? also, I am not sure whether this file should be in the root dir of the project. ",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009317585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009364092",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4009364092",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4009364092,
"node_id": "IC_kwDOBLftOs7u-gp8",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-06T03:46:53Z",
"updated_at": "2026-03-06T03:46:53Z",
"body": "> @dipanshurdev did you see the issues with the `test-locales.js` file? also, I am not sure whether this file should be in the root dir of the project.\r\n\r\nYes, I saw the issues with the test-locales.js file and I will fix the lint errors.\r\nRegarding the file location, I added it to the root directory as a simple test, but I can move it to a more appropriate location (for example under packages/lib/tests) if that would be better. Please let me know your preference.\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009364092/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009485926",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4009485926",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4009485926,
"node_id": "IC_kwDOBLftOs7u--Zm",
"user": {
"login": "tessus",
"id": 223439,
"node_id": "MDQ6VXNlcjIyMzQzOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tessus",
"html_url": "https://github.com/tessus",
"followers_url": "https://api.github.com/users/tessus/followers",
"following_url": "https://api.github.com/users/tessus/following{/other_user}",
"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
"organizations_url": "https://api.github.com/users/tessus/orgs",
"repos_url": "https://api.github.com/users/tessus/repos",
"events_url": "https://api.github.com/users/tessus/events{/privacy}",
"received_events_url": "https://api.github.com/users/tessus/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-06T04:31:48Z",
"updated_at": "2026-03-06T04:31:48Z",
"body": "> I can move it to a more appropriate location (for example under packages/lib/tests) if that would be better. Please let me know your preference.\r\n\r\nI can't decide that. @laurent22 please advise.",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4009485926/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4016719545",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4016719545",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4016719545,
"node_id": "IC_kwDOBLftOs7vaka5",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-07T15:36:12Z",
"updated_at": "2026-03-07T15:36:12Z",
"body": "> > I can move it to a more appropriate location (for example under packages/lib/tests) if that would be better. Please let me know your preference.\r\n> \r\n> I can't decide that. @laurent22 please advise.\r\n\r\nThere's a locale.test.ts for this",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4016719545/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030753982",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4030753982",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4030753982,
"node_id": "IC_kwDOBLftOs7wQGy-",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-10T11:39:08Z",
"updated_at": "2026-03-10T11:39:08Z",
"body": "@dipanshurdev, please confirm you still want to work on this",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030753982/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030827310",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4030827310",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4030827310,
"node_id": "IC_kwDOBLftOs7wQYsu",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-10T11:51:43Z",
"updated_at": "2026-03-10T11:51:43Z",
"body": "> @dipanshurdev, please confirm you still want to work on this\r\n\r\nYes, I’ll review the existing `locale.test.ts` and check whether the additional `test-locales.js` file is still necessary. \r\nIf the functionality is already covered there, I can remove my test file and instead update the existing tests where appropriate, also fixing the CI style issues reported for the file.",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030827310/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4037582318",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4037582318",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4037582318,
"node_id": "IC_kwDOBLftOs7wqJ3u",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-11T09:00:33Z",
"updated_at": "2026-03-11T09:00:33Z",
"body": "@laurent22\r\n\r\nI've refactored the test implementation based on your feedback.\r\n\r\n- Removed `test-locales.js` from root \r\n- Merged all test cases into `locale.test.ts` (the existing test file you suggested)\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4037582318/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142050980",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4142050980",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4142050980,
"node_id": "IC_kwDOBLftOs724q6k",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-27T11:50:01Z",
"updated_at": "2026-03-27T11:50:01Z",
"body": "I'm so tired with this PR, honestly. I was really hoping I'll come today and check and merge it, but no. You still have random code here and there that shouldn't be there. Sorry I'm done here, let's close it and move on",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142050980/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142129309",
"html_url": "https://github.com/laurent22/joplin/pull/14551#issuecomment-4142129309",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14551",
"id": 4142129309,
"node_id": "IC_kwDOBLftOs724-Cd",
"user": {
"login": "dipanshurdev",
"id": 124811276,
"node_id": "U_kgDOB3B4DA",
"avatar_url": "https://avatars.githubusercontent.com/u/124811276?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dipanshurdev",
"html_url": "https://github.com/dipanshurdev",
"followers_url": "https://api.github.com/users/dipanshurdev/followers",
"following_url": "https://api.github.com/users/dipanshurdev/following{/other_user}",
"gists_url": "https://api.github.com/users/dipanshurdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dipanshurdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dipanshurdev/subscriptions",
"organizations_url": "https://api.github.com/users/dipanshurdev/orgs",
"repos_url": "https://api.github.com/users/dipanshurdev/repos",
"events_url": "https://api.github.com/users/dipanshurdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/dipanshurdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-27T12:04:40Z",
"updated_at": "2026-03-27T12:04:40Z",
"body": "> I'm so tired with this PR, honestly. I was really hoping I'll come today and check and merge it, but no. You still have random code here and there that shouldn't be there. Sorry I'm done here, let's close it and move on\r\n\r\nThanks for your time reviewing this and for the feedback along the way.\r\n\r\nSorry this PR turned out to be more complicated than expected. I understand the decision to close it. I’ll take the lessons from this experience and be more careful with future contributions.\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142129309/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}