{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8079/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8079/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8079/events", "html_url": "https://github.com/laurent22/joplin/pull/8079", "id": 1680900914, "node_id": "PR_kwDOBLftOs5O-8NQ", "number": 8079, "title": "Desktop: Script: Check libfuse2 dependency", "user": { "login": "djunho", "id": 11857950, "node_id": "MDQ6VXNlcjExODU3OTUw", "avatar_url": "https://avatars.githubusercontent.com/u/11857950?v=4", "gravatar_id": "", "url": "https://api.github.com/users/djunho", "html_url": "https://github.com/djunho", "followers_url": "https://api.github.com/users/djunho/followers", "following_url": "https://api.github.com/users/djunho/following{/other_user}", "gists_url": "https://api.github.com/users/djunho/gists{/gist_id}", "starred_url": "https://api.github.com/users/djunho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/djunho/subscriptions", "organizations_url": "https://api.github.com/users/djunho/orgs", "repos_url": "https://api.github.com/users/djunho/repos", "events_url": "https://api.github.com/users/djunho/events{/privacy}", "received_events_url": "https://api.github.com/users/djunho/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 9, "created_at": "2023-04-24T10:04:02Z", "updated_at": "2023-05-17T14:40:19Z", "closed_at": "2023-05-16T10:57:51Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8079", "html_url": "https://github.com/laurent22/joplin/pull/8079", "diff_url": "https://github.com/laurent22/joplin/pull/8079.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8079.patch", "merged_at": "2023-05-16T10:57:50Z" }, "body": "Check if the libfuse2 is present in the system. If not, present an error.\r\n\r\nAvoid a silent error for the users. Previously, it was installed successfully but was never launching it.\r\nTo get and see the error, the user has to run it by the command line.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8079/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8079/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1519825506", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1519825506", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1519825506, "node_id": "IC_kwDOBLftOs5alrJi", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-24T10:04:17Z", "updated_at": "2023-04-24T10:05:56Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1519825506/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1519828258", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1519828258", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1519828258, "node_id": "IC_kwDOBLftOs5alr0i", "user": { "login": "djunho", "id": 11857950, "node_id": "MDQ6VXNlcjExODU3OTUw", "avatar_url": "https://avatars.githubusercontent.com/u/11857950?v=4", "gravatar_id": "", "url": "https://api.github.com/users/djunho", "html_url": "https://github.com/djunho", "followers_url": "https://api.github.com/users/djunho/followers", "following_url": "https://api.github.com/users/djunho/following{/other_user}", "gists_url": "https://api.github.com/users/djunho/gists{/gist_id}", "starred_url": "https://api.github.com/users/djunho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/djunho/subscriptions", "organizations_url": "https://api.github.com/users/djunho/orgs", "repos_url": "https://api.github.com/users/djunho/repos", "events_url": "https://api.github.com/users/djunho/events{/privacy}", "received_events_url": "https://api.github.com/users/djunho/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-24T10:05:20Z", "updated_at": "2023-04-24T10:05:20Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1519828258/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1527690650", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1527690650", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1527690650, "node_id": "IC_kwDOBLftOs5bDrWa", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-28T14:54:26Z", "updated_at": "2023-04-28T14:54:26Z", "author_association": "OWNER", "body": "Thanks for the PR. How confident are you that the command `ldconfig -p | grep \"libfuse.so.2\"` is going to work on all versions of all Linux distributions out there? What if it fails because `ldconfig` doesn't exist or libfuse is named differently?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1527690650/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1527901439", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1527901439", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1527901439, "node_id": "IC_kwDOBLftOs5bEez_", "user": { "login": "djunho", "id": 11857950, "node_id": "MDQ6VXNlcjExODU3OTUw", "avatar_url": "https://avatars.githubusercontent.com/u/11857950?v=4", "gravatar_id": "", "url": "https://api.github.com/users/djunho", "html_url": "https://github.com/djunho", "followers_url": "https://api.github.com/users/djunho/followers", "following_url": "https://api.github.com/users/djunho/following{/other_user}", "gists_url": "https://api.github.com/users/djunho/gists{/gist_id}", "starred_url": "https://api.github.com/users/djunho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/djunho/subscriptions", "organizations_url": "https://api.github.com/users/djunho/orgs", "repos_url": "https://api.github.com/users/djunho/repos", "events_url": "https://api.github.com/users/djunho/events{/privacy}", "received_events_url": "https://api.github.com/users/djunho/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-28T17:55:28Z", "updated_at": "2023-04-28T17:55:28Z", "author_association": "CONTRIBUTOR", "body": "Hi.\r\n\r\nAbout the `ldconfig`, I am not 100% sure. But it seems to be a [standard for some time](https://man.openbsd.org/ldconfig#HISTORY) and part of [libc binaries](https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/ldconfig.c;h=2fc45ad8255bf5bcaec6eba2238e9c5c9a20d9ee;hb=HEAD). But not sure about its distribution across so many different Linux distributions.\r\n\r\nThe name seems to be a [standard too](https://docs.oracle.com/cd/E19683-01/817-3677/6mj8mbtbo/index.html). If some Linux names it differently, it would be breaking the standard.\r\n\r\nIf the `ldconfig` doesn't exist, it will generate an error. I can try to check if it exists or not if you think it's better. =)\r\n\r\n\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1527901439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549441618", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1549441618", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1549441618, "node_id": "IC_kwDOBLftOs5cWppS", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-16T10:57:32Z", "updated_at": "2023-05-16T10:57:32Z", "author_association": "OWNER", "body": "Ok thank you for checking. Let's merge and hopefully it will be fine. This is an improvement over not displaying any message and having the application crash on startup", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549441618/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551359496", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1551359496", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1551359496, "node_id": "IC_kwDOBLftOs5cd94I", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T13:06:42Z", "updated_at": "2023-05-17T13:06:42Z", "author_association": "OWNER", "body": "Well, that was quick: https://github.com/laurent22/joplin/issues/8203", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551359496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551422541", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1551422541", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1551422541, "node_id": "IC_kwDOBLftOs5ceNRN", "user": { "login": "djunho", "id": 11857950, "node_id": "MDQ6VXNlcjExODU3OTUw", "avatar_url": "https://avatars.githubusercontent.com/u/11857950?v=4", "gravatar_id": "", "url": "https://api.github.com/users/djunho", "html_url": "https://github.com/djunho", "followers_url": "https://api.github.com/users/djunho/followers", "following_url": "https://api.github.com/users/djunho/following{/other_user}", "gists_url": "https://api.github.com/users/djunho/gists{/gist_id}", "starred_url": "https://api.github.com/users/djunho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/djunho/subscriptions", "organizations_url": "https://api.github.com/users/djunho/orgs", "repos_url": "https://api.github.com/users/djunho/repos", "events_url": "https://api.github.com/users/djunho/events{/privacy}", "received_events_url": "https://api.github.com/users/djunho/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T13:41:40Z", "updated_at": "2023-05-17T13:41:40Z", "author_association": "CONTRIBUTOR", "body": "> Well, that was quick: #8203\r\n\r\nYeah. Really quick. :disappointed: ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551422541/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551452937", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1551452937", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1551452937, "node_id": "IC_kwDOBLftOs5ceUsJ", "user": { "login": "sandrotanner", "id": 1583259, "node_id": "MDQ6VXNlcjE1ODMyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1583259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sandrotanner", "html_url": "https://github.com/sandrotanner", "followers_url": "https://api.github.com/users/sandrotanner/followers", "following_url": "https://api.github.com/users/sandrotanner/following{/other_user}", "gists_url": "https://api.github.com/users/sandrotanner/gists{/gist_id}", "starred_url": "https://api.github.com/users/sandrotanner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sandrotanner/subscriptions", "organizations_url": "https://api.github.com/users/sandrotanner/orgs", "repos_url": "https://api.github.com/users/sandrotanner/repos", "events_url": "https://api.github.com/users/sandrotanner/events{/privacy}", "received_events_url": "https://api.github.com/users/sandrotanner/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T13:59:57Z", "updated_at": "2023-05-17T13:59:57Z", "author_association": "NONE", "body": "> > Well, that was quick: #8203\r\n> \r\n> Yeah. Really quick. disappointed\r\n\r\n@djunho Don't worry :) What do you think about the \"hotfix\" in #8204 to continue anyway if dependencies could not be checked?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551452937/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551527299", "html_url": "https://github.com/laurent22/joplin/pull/8079#issuecomment-1551527299", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8079", "id": 1551527299, "node_id": "IC_kwDOBLftOs5cem2D", "user": { "login": "djunho", "id": 11857950, "node_id": "MDQ6VXNlcjExODU3OTUw", "avatar_url": "https://avatars.githubusercontent.com/u/11857950?v=4", "gravatar_id": "", "url": "https://api.github.com/users/djunho", "html_url": "https://github.com/djunho", "followers_url": "https://api.github.com/users/djunho/followers", "following_url": "https://api.github.com/users/djunho/following{/other_user}", "gists_url": "https://api.github.com/users/djunho/gists{/gist_id}", "starred_url": "https://api.github.com/users/djunho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/djunho/subscriptions", "organizations_url": "https://api.github.com/users/djunho/orgs", "repos_url": "https://api.github.com/users/djunho/repos", "events_url": "https://api.github.com/users/djunho/events{/privacy}", "received_events_url": "https://api.github.com/users/djunho/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T14:40:06Z", "updated_at": "2023-05-17T14:40:19Z", "author_association": "CONTRIBUTOR", "body": "> > > Well, that was quick: #8203\r\n> > \r\n> > \r\n> > Yeah. Really quick. disappointed\r\n> \r\n> @djunho Don't worry :) What do you think about the \"hotfix\" in #8204 to continue anyway if dependencies could not be checked?\r\n\r\nThanks. I am checking your PR. I just got a Debian virtual machine here to reproduce too.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551527299/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }