{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/events", "html_url": "https://github.com/laurent22/joplin/pull/11433", "id": 2680896607, "node_id": "PR_kwDOBLftOs6CuZSY", "number": 11433, "title": "ALL: Added Slovak translation", "user": { "login": "dodog", "id": 976639, "node_id": "MDQ6VXNlcjk3NjYzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dodog", "html_url": "https://github.com/dodog", "followers_url": "https://api.github.com/users/dodog/followers", "following_url": "https://api.github.com/users/dodog/following{/other_user}", "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", "organizations_url": "https://api.github.com/users/dodog/orgs", "repos_url": "https://api.github.com/users/dodog/repos", "events_url": "https://api.github.com/users/dodog/events{/privacy}", "received_events_url": "https://api.github.com/users/dodog/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1091621259, "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", "name": "translation", "color": "91ca55", "default": false, "description": "i18n and l10n" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 9, "created_at": "2024-11-21T20:45:00Z", "updated_at": "2024-12-26T20:47:17Z", "closed_at": "2024-11-23T20:41:14Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11433", "html_url": "https://github.com/laurent22/joplin/pull/11433", "diff_url": "https://github.com/laurent22/joplin/pull/11433.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11433.patch", "merged_at": "2024-11-23T20:41:14Z" }, "body": "Added Slovak language translation\r\n\r\n", "closed_by": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11433/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492290686", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2492290686", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2492290686, "node_id": "IC_kwDOBLftOs6UjVZ-", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-21T20:45:13Z", "updated_at": "2024-11-23T20:42:17Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492290686/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492293790", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2492293790", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2492293790, "node_id": "IC_kwDOBLftOs6UjWKe", "user": { "login": "dodog", "id": 976639, "node_id": "MDQ6VXNlcjk3NjYzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dodog", "html_url": "https://github.com/dodog", "followers_url": "https://api.github.com/users/dodog/followers", "following_url": "https://api.github.com/users/dodog/following{/other_user}", "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", "organizations_url": "https://api.github.com/users/dodog/orgs", "repos_url": "https://api.github.com/users/dodog/repos", "events_url": "https://api.github.com/users/dodog/events{/privacy}", "received_events_url": "https://api.github.com/users/dodog/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-21T20:46:24Z", "updated_at": "2024-11-21T20:46:24Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492293790/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492829935", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2492829935", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2492829935, "node_id": "IC_kwDOBLftOs6UlZDv", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-22T04:00:13Z", "updated_at": "2024-11-22T04:00:13Z", "author_association": "COLLABORATOR", "body": "Thanks for the translation. May I ask how this was done? I'm asking this because we had people submit automated translations and a lot of the translations won't be correct without knowing the context.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2492829935/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2493606016", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2493606016", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2493606016, "node_id": "IC_kwDOBLftOs6UoWiA", "user": { "login": "dodog", "id": 976639, "node_id": "MDQ6VXNlcjk3NjYzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dodog", "html_url": "https://github.com/dodog", "followers_url": "https://api.github.com/users/dodog/followers", "following_url": "https://api.github.com/users/dodog/following{/other_user}", "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", "organizations_url": "https://api.github.com/users/dodog/orgs", "repos_url": "https://api.github.com/users/dodog/repos", "events_url": "https://api.github.com/users/dodog/events{/privacy}", "received_events_url": "https://api.github.com/users/dodog/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-22T12:06:06Z", "updated_at": "2024-11-22T12:06:06Z", "author_association": "CONTRIBUTOR", "body": "I translated everything by myself. I use Joplin on my computer and iPhone with its own Joplin server. I really like the app and wanted to contribute my bit. I only tested the translation strings visually because I was not able to load the translation file to the app and test it that way. If there is some simple way to do this, please let me know. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2493606016/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2494441968", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2494441968", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2494441968, "node_id": "IC_kwDOBLftOs6Urinw", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-22T18:00:54Z", "updated_at": "2024-11-22T18:00:54Z", "author_association": "COLLABORATOR", "body": "Awesome, thanks for the info.\r\n\r\n@laurent22 I can't recall, whether we have to do something in particular for new translations. But I believe no extra steps have to be taken, correct? There were extra steps way in the past, but now I think we should be good. am I correct?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2494441968/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495479973", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2495479973", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2495479973, "node_id": "IC_kwDOBLftOs6UvgCl", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-23T13:27:57Z", "updated_at": "2024-11-23T13:27:57Z", "author_association": "OWNER", "body": "No it should just work if we add a language file, there's not special script to run", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495479973/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495648994", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2495648994", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2495648994, "node_id": "IC_kwDOBLftOs6UwJTi", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-23T20:42:22Z", "updated_at": "2024-11-23T20:42:22Z", "author_association": "COLLABORATOR", "body": "Thanks a bunch for your contribution @dodog. Must have been a lot of work.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2495648994/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2562757785", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2562757785", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2562757785, "node_id": "IC_kwDOBLftOs6YwJSZ", "user": { "login": "dodog", "id": 976639, "node_id": "MDQ6VXNlcjk3NjYzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/976639?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dodog", "html_url": "https://github.com/dodog", "followers_url": "https://api.github.com/users/dodog/followers", "following_url": "https://api.github.com/users/dodog/following{/other_user}", "gists_url": "https://api.github.com/users/dodog/gists{/gist_id}", "starred_url": "https://api.github.com/users/dodog/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dodog/subscriptions", "organizations_url": "https://api.github.com/users/dodog/orgs", "repos_url": "https://api.github.com/users/dodog/repos", "events_url": "https://api.github.com/users/dodog/events{/privacy}", "received_events_url": "https://api.github.com/users/dodog/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-26T13:48:44Z", "updated_at": "2024-12-26T13:48:44Z", "author_association": "CONTRIBUTOR", "body": "@tessus I think some extra steps should have been taken after all, because the json files were not generated and the language is not available to select in menu.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2562757785/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2563090424", "html_url": "https://github.com/laurent22/joplin/pull/11433#issuecomment-2563090424", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11433", "id": 2563090424, "node_id": "IC_kwDOBLftOs6Yxaf4", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-26T20:47:16Z", "updated_at": "2024-12-26T20:47:16Z", "author_association": "COLLABORATOR", "body": "Hmm, I thought that creating the translation files was added to the CI workflow at one point. But maybe not. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2563090424/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }