{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/15003/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/15003/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/15003/events", "html_url": "https://github.com/laurent22/joplin/pull/15003", "id": 4201692944, "node_id": "PR_kwDOBLftOs7P2W8Q", "number": 15003, "title": "Desktop: Fixes #14861: Restore window position and size after relaunch on Windows", "user": { "login": "gagansokhal-coder", "id": 230753351, "node_id": "U_kgDODcEERw", "avatar_url": "https://avatars.githubusercontent.com/u/230753351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gagansokhal-coder", "html_url": "https://github.com/gagansokhal-coder", "followers_url": "https://api.github.com/users/gagansokhal-coder/followers", "following_url": "https://api.github.com/users/gagansokhal-coder/following{/other_user}", "gists_url": "https://api.github.com/users/gagansokhal-coder/gists{/gist_id}", "starred_url": "https://api.github.com/users/gagansokhal-coder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gagansokhal-coder/subscriptions", "organizations_url": "https://api.github.com/users/gagansokhal-coder/orgs", "repos_url": "https://api.github.com/users/gagansokhal-coder/repos", "events_url": "https://api.github.com/users/gagansokhal-coder/events{/privacy}", "received_events_url": "https://api.github.com/users/gagansokhal-coder/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" }, { "id": 1366673470, "node_id": "MDU6TGFiZWwxMzY2NjczNDcw", "url": "https://api.github.com/repos/laurent22/joplin/labels/windows", "name": "windows", "color": "bfd4f2", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 6, "created_at": "2026-04-03T18:24:37Z", "updated_at": "2026-04-14T15:18:55Z", "closed_at": "2026-04-14T11:59:39Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/15003", "html_url": "https://github.com/laurent22/joplin/pull/15003", "diff_url": "https://github.com/laurent22/joplin/pull/15003.diff", "patch_url": "https://github.com/laurent22/joplin/pull/15003.patch", "merged_at": null }, "body": "Fixes #14861\r\n\r\n### Problem\r\nOn Windows, when the Joplin window is snapped (docked) to the left or right, closing and reopening the app resets the window position and size.\r\n\r\n### Solution\r\nEnsured that the correct window bounds are saved after snap by handling resize and move events and persisting final bounds.\r\n\r\n### Testing\r\nTested the following scenarios:\r\n- Left snap (Win + Left Arrow)\r\n- Right snap (Win + Right Arrow)\r\n- Manual resize\r\n- Maximized window\r\n\r\nAll cases correctly restore position and size after relaunch.\r\n\r\n### Notes\r\nThis change focuses on Windows behavior and does not affect macOS/Linux.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/15003/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/15003/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184647018", "html_url": "https://github.com/laurent22/joplin/pull/15003#issuecomment-4184647018", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "id": 4184647018, "node_id": "IC_kwDOBLftOs75bKVq", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-03T18:24:49Z", "updated_at": "2026-04-14T15:18:55Z", "body": "All contributors have signed the CLA ✍️ ✅
Posted by the ****CLA Assistant Lite bot****.", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184647018/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184651220", "html_url": "https://github.com/laurent22/joplin/pull/15003#issuecomment-4184651220", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "id": 4184651220, "node_id": "IC_kwDOBLftOs75bLXU", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-03T18:26:04Z", "updated_at": "2026-04-14T11:42:40Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nInserted inline comments in `createWindow()` of `packages/app-desktop/ElectronAppWrapper.ts` explaining a Windows Snap persistence edge case involving `electron-window-state` debounce and Joplin's close handling. No executable code or behavioural changes were made.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Comments only — Window state rationale**
`packages/app-desktop/ElectronAppWrapper.ts`|Added explanatory inline comments in `createWindow()` describing a Windows Snap persistence issue, how `electron-window-state`'s debounce can miss final bounds, and how Joplin's `close` handling (via `event.preventDefault()`) may prevent the library's `closed` handler from running. No logic or behaviour was changed.|\n\n## Suggested reviewers\n\n- personalizedrefrigerator\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 4 | ❌ 2\n\n### ❌ Failed checks (1 warning, 1 inconclusive)\n\n| Check name | Status | Explanation | Resolution |\n| :------------------------: | :------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :----------------------------------------------------------------------------------------------------------------------------------------- |\n| Out of Scope Changes check | ⚠️ Warning | Whitespace/indentation changes in the `quitWithSyncCheck()` method appear unrelated to the window snap fix and may be out of scope. | Remove unrelated whitespace changes from the `quitWithSyncCheck()` method; keep only changes directly addressing issue `#14861`. |\n| Linked Issues check | ❓ Inconclusive | The changeset addresses the core requirement from issue `#14861` by adding handling for window bounds persistence after snap, though the code shows only comments were added without visible functional logic changes. | Clarify whether the comment block represents a complete fix or if additional functional code changes are pending or hidden in the summary. |\n\n
\n✅ Passed checks (4 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title accurately describes the main change: fixing window position/size restoration on Windows after relaunch, which directly addresses the changeset. |\n| Description check | ✅ Passed | The description is related to the changeset, explaining the Windows snap persistence problem and solution, though it claims functional changes beyond what the code summary shows (only comments added). |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The PR description includes all three required sections: problem description (window position/size reset on Windows snap), high-level solution (bounds saved via event handling), and test plan with specific scenarios. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=15003)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184651220/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184686329", "html_url": "https://github.com/laurent22/joplin/pull/15003#issuecomment-4184686329", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "id": 4184686329, "node_id": "IC_kwDOBLftOs75bT75", "user": { "login": "gagansokhal-coder", "id": 230753351, "node_id": "U_kgDODcEERw", "avatar_url": "https://avatars.githubusercontent.com/u/230753351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gagansokhal-coder", "html_url": "https://github.com/gagansokhal-coder", "followers_url": "https://api.github.com/users/gagansokhal-coder/followers", "following_url": "https://api.github.com/users/gagansokhal-coder/following{/other_user}", "gists_url": "https://api.github.com/users/gagansokhal-coder/gists{/gist_id}", "starred_url": "https://api.github.com/users/gagansokhal-coder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gagansokhal-coder/subscriptions", "organizations_url": "https://api.github.com/users/gagansokhal-coder/orgs", "repos_url": "https://api.github.com/users/gagansokhal-coder/repos", "events_url": "https://api.github.com/users/gagansokhal-coder/events{/privacy}", "received_events_url": "https://api.github.com/users/gagansokhal-coder/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-03T18:36:08Z", "updated_at": "2026-04-03T18:36:08Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184686329/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184691729", "html_url": "https://github.com/laurent22/joplin/pull/15003#issuecomment-4184691729", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "id": 4184691729, "node_id": "IC_kwDOBLftOs75bVQR", "user": { "login": "gagansokhal-coder", "id": 230753351, "node_id": "U_kgDODcEERw", "avatar_url": "https://avatars.githubusercontent.com/u/230753351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gagansokhal-coder", "html_url": "https://github.com/gagansokhal-coder", "followers_url": "https://api.github.com/users/gagansokhal-coder/followers", "following_url": "https://api.github.com/users/gagansokhal-coder/following{/other_user}", "gists_url": "https://api.github.com/users/gagansokhal-coder/gists{/gist_id}", "starred_url": "https://api.github.com/users/gagansokhal-coder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gagansokhal-coder/subscriptions", "organizations_url": "https://api.github.com/users/gagansokhal-coder/orgs", "repos_url": "https://api.github.com/users/gagansokhal-coder/repos", "events_url": "https://api.github.com/users/gagansokhal-coder/events{/privacy}", "received_events_url": "https://api.github.com/users/gagansokhal-coder/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-03T18:37:04Z", "updated_at": "2026-04-03T18:37:04Z", "body": "recheck", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4184691729/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4243689027", "html_url": "https://github.com/laurent22/joplin/pull/15003#issuecomment-4243689027", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "id": 4243689027, "node_id": "IC_kwDOBLftOs788Y5D", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-14T11:59:39Z", "updated_at": "2026-04-14T11:59:39Z", "body": "Thanks for the submission.\r\n\r\nWhile this PR targets an existing issue, the proposed solution is not suitable for the project in its current form. Bringing it up to an acceptable standard would require significant redesign and guidance.\r\n\r\nFor future contributions, please ensure changes are well-aligned with the existing architecture and sufficiently tested.\r\n\r\nPlease make sure you read our guidelines: https://github.com/joplin/gsoc\r\n\r\nAnd our AI policy: https://github.com/joplin/gsoc/blob/master/ai_policy.md", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4243689027/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4243983687", "html_url": "https://github.com/laurent22/joplin/pull/15003#issuecomment-4243983687", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15003", "id": 4243983687, "node_id": "IC_kwDOBLftOs789g1H", "user": { "login": "gagansokhal-coder", "id": 230753351, "node_id": "U_kgDODcEERw", "avatar_url": "https://avatars.githubusercontent.com/u/230753351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gagansokhal-coder", "html_url": "https://github.com/gagansokhal-coder", "followers_url": "https://api.github.com/users/gagansokhal-coder/followers", "following_url": "https://api.github.com/users/gagansokhal-coder/following{/other_user}", "gists_url": "https://api.github.com/users/gagansokhal-coder/gists{/gist_id}", "starred_url": "https://api.github.com/users/gagansokhal-coder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gagansokhal-coder/subscriptions", "organizations_url": "https://api.github.com/users/gagansokhal-coder/orgs", "repos_url": "https://api.github.com/users/gagansokhal-coder/repos", "events_url": "https://api.github.com/users/gagansokhal-coder/events{/privacy}", "received_events_url": "https://api.github.com/users/gagansokhal-coder/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-14T12:47:35Z", "updated_at": "2026-04-14T12:47:35Z", "body": "Thank you for the feedback. I understand that the approach doesn't align with the current architecture. \r\n\r\nI’ll review the guidelines and codebase more carefully before attempting another fix.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4243983687/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }