{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8024/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8024/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8024/events", "html_url": "https://github.com/laurent22/joplin/pull/8024", "id": 1658081023, "node_id": "PR_kwDOBLftOs5NzXIj", "number": 8024, "title": "Android: Fixes #7946: Sorting overlay window does not respect user theme", "user": { "login": "gitstart", "id": 1501599, "node_id": "MDQ6VXNlcjE1MDE1OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1501599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitstart", "html_url": "https://github.com/gitstart", "followers_url": "https://api.github.com/users/gitstart/followers", "following_url": "https://api.github.com/users/gitstart/following{/other_user}", "gists_url": "https://api.github.com/users/gitstart/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitstart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitstart/subscriptions", "organizations_url": "https://api.github.com/users/gitstart/orgs", "repos_url": "https://api.github.com/users/gitstart/repos", "events_url": "https://api.github.com/users/gitstart/events{/privacy}", "received_events_url": "https://api.github.com/users/gitstart/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 8, "created_at": "2023-04-06T21:43:47Z", "updated_at": "2023-07-14T13:26:18Z", "closed_at": "2023-07-14T13:26:03Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8024", "html_url": "https://github.com/laurent22/joplin/pull/8024", "diff_url": "https://github.com/laurent22/joplin/pull/8024.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8024.patch", "merged_at": null }, "body": "Fixes [#7946](https://github.com/laurent22/joplin/issues/7946)\r\n\r\nProblem:\r\nhttps://user-images.githubusercontent.com/89805719/226156535-109117c0-8894-4f5e-b8d9-f8b356dfaa81.jpg\r\n\r\nSolution:\r\nhttps://www.loom.com/share/e3076b0efe76470f8820543724f04122\r\n\r\n---\r\nThis code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8024/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8024/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1499663169", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1499663169", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1499663169, "node_id": "IC_kwDOBLftOs5ZYwtB", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-06T21:44:01Z", "updated_at": "2023-07-14T13:26:18Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1499663169/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1499665006", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1499665006", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1499665006, "node_id": "IC_kwDOBLftOs5ZYxJu", "user": { "login": "gitstart", "id": 1501599, "node_id": "MDQ6VXNlcjE1MDE1OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1501599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitstart", "html_url": "https://github.com/gitstart", "followers_url": "https://api.github.com/users/gitstart/followers", "following_url": "https://api.github.com/users/gitstart/following{/other_user}", "gists_url": "https://api.github.com/users/gitstart/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitstart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitstart/subscriptions", "organizations_url": "https://api.github.com/users/gitstart/orgs", "repos_url": "https://api.github.com/users/gitstart/repos", "events_url": "https://api.github.com/users/gitstart/events{/privacy}", "received_events_url": "https://api.github.com/users/gitstart/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-06T21:46:22Z", "updated_at": "2023-04-06T21:46:22Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1499665006/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1543316013", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1543316013", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1543316013, "node_id": "IC_kwDOBLftOs5b_SIt", "user": { "login": "gitstart", "id": 1501599, "node_id": "MDQ6VXNlcjE1MDE1OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1501599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitstart", "html_url": "https://github.com/gitstart", "followers_url": "https://api.github.com/users/gitstart/followers", "following_url": "https://api.github.com/users/gitstart/following{/other_user}", "gists_url": "https://api.github.com/users/gitstart/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitstart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitstart/subscriptions", "organizations_url": "https://api.github.com/users/gitstart/orgs", "repos_url": "https://api.github.com/users/gitstart/repos", "events_url": "https://api.github.com/users/gitstart/events{/privacy}", "received_events_url": "https://api.github.com/users/gitstart/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-11T04:28:47Z", "updated_at": "2023-05-11T04:29:50Z", "author_association": "CONTRIBUTOR", "body": "Hi @laurent22 \r\nWould you mind reviewing this PR it is a great fix for #7946 \r\nThanks", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1543316013/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566934773", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1566934773", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1566934773, "node_id": "IC_kwDOBLftOs5dZYb1", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T10:29:43Z", "updated_at": "2023-05-29T10:29:43Z", "author_association": "OWNER", "body": "We would need to see screenshots for such a change, could you provide them please? And how does it look in portrait vs landscape mode?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566934773/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1571868939", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1571868939", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1571868939, "node_id": "IC_kwDOBLftOs5dsNEL", "user": { "login": "gitstart", "id": 1501599, "node_id": "MDQ6VXNlcjE1MDE1OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1501599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitstart", "html_url": "https://github.com/gitstart", "followers_url": "https://api.github.com/users/gitstart/followers", "following_url": "https://api.github.com/users/gitstart/following{/other_user}", "gists_url": "https://api.github.com/users/gitstart/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitstart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitstart/subscriptions", "organizations_url": "https://api.github.com/users/gitstart/orgs", "repos_url": "https://api.github.com/users/gitstart/repos", "events_url": "https://api.github.com/users/gitstart/events{/privacy}", "received_events_url": "https://api.github.com/users/gitstart/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-01T11:24:29Z", "updated_at": "2023-06-01T11:24:29Z", "author_association": "CONTRIBUTOR", "body": "This will be updated soon @laurent22 \r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1571868939/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1577889491", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1577889491", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1577889491, "node_id": "IC_kwDOBLftOs5eDK7T", "user": { "login": "gitstart", "id": 1501599, "node_id": "MDQ6VXNlcjE1MDE1OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1501599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitstart", "html_url": "https://github.com/gitstart", "followers_url": "https://api.github.com/users/gitstart/followers", "following_url": "https://api.github.com/users/gitstart/following{/other_user}", "gists_url": "https://api.github.com/users/gitstart/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitstart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitstart/subscriptions", "organizations_url": "https://api.github.com/users/gitstart/orgs", "repos_url": "https://api.github.com/users/gitstart/repos", "events_url": "https://api.github.com/users/gitstart/events{/privacy}", "received_events_url": "https://api.github.com/users/gitstart/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-06T04:34:18Z", "updated_at": "2023-06-06T04:35:13Z", "author_association": "CONTRIBUTOR", "body": "> We would need to see screenshots for such a change, could you provide them please? And how does it look in portrait vs landscape mode?\r\n\r\n\r\n@laurent22 Here is the \r\nBefore:\r\n![image](https://github.com/laurent22/joplin/assets/1501599/ca5c1838-467a-4826-a5f4-b21d1b7083ce)\r\nand\r\nAfter:\r\nhttps://www.loom.com/share/e3076b0efe76470f8820543724f04122\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1577889491/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1578260948", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1578260948", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1578260948, "node_id": "IC_kwDOBLftOs5eElnU", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-06T09:11:38Z", "updated_at": "2023-06-06T09:11:38Z", "author_association": "OWNER", "body": "Thanks for the providing the screenshot and video. The blue text on dark background is a bit hard to read and doesn't respect the WCAG contrast we aim for. Could you maybe change it white (or very light gray)?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1578260948/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1580999526", "html_url": "https://github.com/laurent22/joplin/pull/8024#issuecomment-1580999526", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8024", "id": 1580999526, "node_id": "IC_kwDOBLftOs5ePCNm", "user": { "login": "gitstart", "id": 1501599, "node_id": "MDQ6VXNlcjE1MDE1OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1501599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitstart", "html_url": "https://github.com/gitstart", "followers_url": "https://api.github.com/users/gitstart/followers", "following_url": "https://api.github.com/users/gitstart/following{/other_user}", "gists_url": "https://api.github.com/users/gitstart/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitstart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitstart/subscriptions", "organizations_url": "https://api.github.com/users/gitstart/orgs", "repos_url": "https://api.github.com/users/gitstart/repos", "events_url": "https://api.github.com/users/gitstart/events{/privacy}", "received_events_url": "https://api.github.com/users/gitstart/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-07T14:57:06Z", "updated_at": "2023-06-07T14:57:06Z", "author_association": "CONTRIBUTOR", "body": "@laurent22 \r\nThis has been updated with the changes\r\nand here is how it looks now on dark theme\r\n![image](https://github.com/laurent22/joplin/assets/1501599/d3594843-7cdf-4046-98b4-d64c9387062d)\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1580999526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }