{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7515", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7515/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7515/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7515/events", "html_url": "https://github.com/laurent22/joplin/pull/7515", "id": 1507519606, "node_id": "PR_kwDOBLftOs5GBZAV", "number": 7515, "title": "Desktop: Resolve #6254:
elements remain closed when exporting to PDF", "user": { "login": "gtlsgamr", "id": 47787284, "node_id": "MDQ6VXNlcjQ3Nzg3Mjg0", "avatar_url": "https://avatars.githubusercontent.com/u/47787284?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gtlsgamr", "html_url": "https://github.com/gtlsgamr", "followers_url": "https://api.github.com/users/gtlsgamr/followers", "following_url": "https://api.github.com/users/gtlsgamr/following{/other_user}", "gists_url": "https://api.github.com/users/gtlsgamr/gists{/gist_id}", "starred_url": "https://api.github.com/users/gtlsgamr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gtlsgamr/subscriptions", "organizations_url": "https://api.github.com/users/gtlsgamr/orgs", "repos_url": "https://api.github.com/users/gtlsgamr/repos", "events_url": "https://api.github.com/users/gtlsgamr/events{/privacy}", "received_events_url": "https://api.github.com/users/gtlsgamr/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2022-12-22T09:17:49Z", "updated_at": "2022-12-28T16:13:42Z", "closed_at": "2022-12-27T16:57:00Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7515", "html_url": "https://github.com/laurent22/joplin/pull/7515", "diff_url": "https://github.com/laurent22/joplin/pull/7515.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7515.patch", "merged_at": "2022-12-27T16:57:00Z" }, "body": "When exporting a note to pdf, any `
` tags remain closed, which should not be expected behaviour since the data inside them will not be visible.\r\nThis PR opens the tags before printing the pdf and closes them once it is done, thus solving #6254 ", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7515/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7515/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362598951", "html_url": "https://github.com/laurent22/joplin/pull/7515#issuecomment-1362598951", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7515", "id": 1362598951, "node_id": "IC_kwDOBLftOs5RN5wn", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T09:18:02Z", "updated_at": "2022-12-27T16:16:00Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362598951/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362615340", "html_url": "https://github.com/laurent22/joplin/pull/7515#issuecomment-1362615340", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7515", "id": 1362615340, "node_id": "IC_kwDOBLftOs5RN9ws", "user": { "login": "gtlsgamr", "id": 47787284, "node_id": "MDQ6VXNlcjQ3Nzg3Mjg0", "avatar_url": "https://avatars.githubusercontent.com/u/47787284?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gtlsgamr", "html_url": "https://github.com/gtlsgamr", "followers_url": "https://api.github.com/users/gtlsgamr/followers", "following_url": "https://api.github.com/users/gtlsgamr/following{/other_user}", "gists_url": "https://api.github.com/users/gtlsgamr/gists{/gist_id}", "starred_url": "https://api.github.com/users/gtlsgamr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gtlsgamr/subscriptions", "organizations_url": "https://api.github.com/users/gtlsgamr/orgs", "repos_url": "https://api.github.com/users/gtlsgamr/repos", "events_url": "https://api.github.com/users/gtlsgamr/events{/privacy}", "received_events_url": "https://api.github.com/users/gtlsgamr/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T09:34:59Z", "updated_at": "2022-12-22T09:34:59Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362615340/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362615602", "html_url": "https://github.com/laurent22/joplin/pull/7515#issuecomment-1362615602", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7515", "id": 1362615602, "node_id": "IC_kwDOBLftOs5RN90y", "user": { "login": "gtlsgamr", "id": 47787284, "node_id": "MDQ6VXNlcjQ3Nzg3Mjg0", "avatar_url": "https://avatars.githubusercontent.com/u/47787284?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gtlsgamr", "html_url": "https://github.com/gtlsgamr", "followers_url": "https://api.github.com/users/gtlsgamr/followers", "following_url": "https://api.github.com/users/gtlsgamr/following{/other_user}", "gists_url": "https://api.github.com/users/gtlsgamr/gists{/gist_id}", "starred_url": "https://api.github.com/users/gtlsgamr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gtlsgamr/subscriptions", "organizations_url": "https://api.github.com/users/gtlsgamr/orgs", "repos_url": "https://api.github.com/users/gtlsgamr/repos", "events_url": "https://api.github.com/users/gtlsgamr/events{/privacy}", "received_events_url": "https://api.github.com/users/gtlsgamr/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T09:35:19Z", "updated_at": "2022-12-22T09:35:19Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362615602/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366043462", "html_url": "https://github.com/laurent22/joplin/pull/7515#issuecomment-1366043462", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7515", "id": 1366043462, "node_id": "IC_kwDOBLftOs5RbCtG", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-27T16:56:51Z", "updated_at": "2022-12-27T16:56:51Z", "author_association": "OWNER", "body": "All good now, thanks!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366043462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366764636", "html_url": "https://github.com/laurent22/joplin/pull/7515#issuecomment-1366764636", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7515", "id": 1366764636, "node_id": "IC_kwDOBLftOs5Rdyxc", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-28T16:13:42Z", "updated_at": "2022-12-28T16:13:42Z", "author_association": "OWNER", "body": "I shouldn't have merged since the code doesn't pass the linter. Next time please don't commit directly from GitHub because the precommit script doesn't run here.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366764636/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }