{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/6836/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/6836/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/6836/events", "html_url": "https://github.com/laurent22/joplin/pull/6836", "id": 1368429299, "node_id": "PR_kwDOBLftOs4-tbUO", "number": 6836, "title": "Server: Add in ability to use Postgres connection string", "user": { "login": "halkeye", "id": 110087, "node_id": "MDQ6VXNlcjExMDA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/110087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/halkeye", "html_url": "https://github.com/halkeye", "followers_url": "https://api.github.com/users/halkeye/followers", "following_url": "https://api.github.com/users/halkeye/following{/other_user}", "gists_url": "https://api.github.com/users/halkeye/gists{/gist_id}", "starred_url": "https://api.github.com/users/halkeye/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/halkeye/subscriptions", "organizations_url": "https://api.github.com/users/halkeye/orgs", "repos_url": "https://api.github.com/users/halkeye/repos", "events_url": "https://api.github.com/users/halkeye/events{/privacy}", "received_events_url": "https://api.github.com/users/halkeye/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 10, "created_at": "2022-09-10T00:21:21Z", "updated_at": "2022-12-28T14:38:41Z", "closed_at": "2022-12-28T14:38:30Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/6836", "html_url": "https://github.com/laurent22/joplin/pull/6836", "diff_url": "https://github.com/laurent22/joplin/pull/6836.diff", "patch_url": "https://github.com/laurent22/joplin/pull/6836.patch", "merged_at": "2022-12-28T14:38:30Z" }, "body": "I want to be able to deploy joplin to Digital Ocean cloud using the Postgres hosted solution (so I don't have to monitor/maintain/etc)\r\n\r\nAs they are exposed to the internet, it requires an ssl connection. \r\n\r\nThey provide:\r\n```\r\npostgresql://doadmin:[snip]@[snip]/defaultdb?sslmode=require\r\n```\r\n\r\nI based this somewhat on https://github.com/laurent22/joplin/pull/5119, but decided against being able to provide all the different SSL variables, which made things complicated.\r\n\r\ndocker hub halkeye/joplin:pr6836-beta works fine for me \\o/", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/6836/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/6836/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1257442666", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1257442666", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1257442666, "node_id": "IC_kwDOBLftOs5K8w1q", "user": { "login": "halkeye", "id": 110087, "node_id": "MDQ6VXNlcjExMDA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/110087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/halkeye", "html_url": "https://github.com/halkeye", "followers_url": "https://api.github.com/users/halkeye/followers", "following_url": "https://api.github.com/users/halkeye/following{/other_user}", "gists_url": "https://api.github.com/users/halkeye/gists{/gist_id}", "starred_url": "https://api.github.com/users/halkeye/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/halkeye/subscriptions", "organizations_url": "https://api.github.com/users/halkeye/orgs", "repos_url": "https://api.github.com/users/halkeye/repos", "events_url": "https://api.github.com/users/halkeye/events{/privacy}", "received_events_url": "https://api.github.com/users/halkeye/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-09-26T04:02:43Z", "updated_at": "2022-09-26T04:02:43Z", "author_association": "CONTRIBUTOR", "body": "light ping @laurent22 \r\n\r\nIs this okay? should I try something different?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1257442666/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1288109955", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1288109955", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1288109955, "node_id": "IC_kwDOBLftOs5Mxv-D", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-10-23T13:10:52Z", "updated_at": "2022-10-23T13:10:52Z", "author_association": "OWNER", "body": "Thanks for your pull request. To get it merge we'll need you to sign and send this CLA: https://github.com/laurent22/joplin/blob/dev/packages/server/readme/CLA.md", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1288109955/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1296368963", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1296368963", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1296368963, "node_id": "IC_kwDOBLftOs5NRQVD", "user": { "login": "halkeye", "id": 110087, "node_id": "MDQ6VXNlcjExMDA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/110087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/halkeye", "html_url": "https://github.com/halkeye", "followers_url": "https://api.github.com/users/halkeye/followers", "following_url": "https://api.github.com/users/halkeye/following{/other_user}", "gists_url": "https://api.github.com/users/halkeye/gists{/gist_id}", "starred_url": "https://api.github.com/users/halkeye/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/halkeye/subscriptions", "organizations_url": "https://api.github.com/users/halkeye/orgs", "repos_url": "https://api.github.com/users/halkeye/repos", "events_url": "https://api.github.com/users/halkeye/events{/privacy}", "received_events_url": "https://api.github.com/users/halkeye/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-10-30T22:48:38Z", "updated_at": "2022-10-30T22:48:38Z", "author_association": "CONTRIBUTOR", "body": "Sorry for the additional delay, updated the readme as per your suggestions, and sent off the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1296368963/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361332351", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1361332351", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1361332351, "node_id": "IC_kwDOBLftOs5RJEh_", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-21T13:46:56Z", "updated_at": "2022-12-21T13:46:56Z", "author_association": "OWNER", "body": "@halkeye, sorry could you send the CLA again? It seems at the time you sent it that email address wasn't setup. Sorry about that", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361332351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362440077", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1362440077", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1362440077, "node_id": "IC_kwDOBLftOs5RNS-N", "user": { "login": "halkeye", "id": 110087, "node_id": "MDQ6VXNlcjExMDA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/110087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/halkeye", "html_url": "https://github.com/halkeye", "followers_url": "https://api.github.com/users/halkeye/followers", "following_url": "https://api.github.com/users/halkeye/following{/other_user}", "gists_url": "https://api.github.com/users/halkeye/gists{/gist_id}", "starred_url": "https://api.github.com/users/halkeye/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/halkeye/subscriptions", "organizations_url": "https://api.github.com/users/halkeye/orgs", "repos_url": "https://api.github.com/users/halkeye/repos", "events_url": "https://api.github.com/users/halkeye/events{/privacy}", "received_events_url": "https://api.github.com/users/halkeye/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T05:37:21Z", "updated_at": "2022-12-22T05:37:21Z", "author_association": "CONTRIBUTOR", "body": "@laurent22 sent again, lemme know if you get it", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362440077/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362702188", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1362702188", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1362702188, "node_id": "IC_kwDOBLftOs5ROS9s", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T11:02:46Z", "updated_at": "2022-12-22T11:02:46Z", "author_association": "OWNER", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362702188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362702489", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1362702489", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1362702489, "node_id": "IC_kwDOBLftOs5ROTCZ", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T11:03:03Z", "updated_at": "2022-12-22T17:52:40Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362702489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362703643", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1362703643", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1362703643, "node_id": "IC_kwDOBLftOs5ROTUb", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T11:04:03Z", "updated_at": "2022-12-22T11:04:03Z", "author_association": "OWNER", "body": "@halkeye, sorry for some reason I'm not receiving these emails. But I've now implemented the CLA Assistant Bot which I realise can also be used for Joplin Server. So please follow the instructions in the above message and that should do it.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1362703643/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1363180252", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1363180252", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1363180252, "node_id": "IC_kwDOBLftOs5RQHrc", "user": { "login": "halkeye", "id": 110087, "node_id": "MDQ6VXNlcjExMDA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/110087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/halkeye", "html_url": "https://github.com/halkeye", "followers_url": "https://api.github.com/users/halkeye/followers", "following_url": "https://api.github.com/users/halkeye/following{/other_user}", "gists_url": "https://api.github.com/users/halkeye/gists{/gist_id}", "starred_url": "https://api.github.com/users/halkeye/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/halkeye/subscriptions", "organizations_url": "https://api.github.com/users/halkeye/orgs", "repos_url": "https://api.github.com/users/halkeye/repos", "events_url": "https://api.github.com/users/halkeye/events{/privacy}", "received_events_url": "https://api.github.com/users/halkeye/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-22T17:52:26Z", "updated_at": "2022-12-22T17:52:26Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1363180252/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366699140", "html_url": "https://github.com/laurent22/joplin/pull/6836#issuecomment-1366699140", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6836", "id": 1366699140, "node_id": "IC_kwDOBLftOs5RdiyE", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-28T14:38:16Z", "updated_at": "2022-12-28T14:38:16Z", "author_association": "OWNER", "body": "Ok it's good to go now, thanks a lot for this change!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366699140/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }