{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14339", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14339/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14339/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14339/events", "html_url": "https://github.com/laurent22/joplin/pull/14339", "id": 3929483630, "node_id": "PR_kwDOBLftOs7DKEAl", "number": 14339, "title": "All: Fixes #14271: Correct error message for missing app_min_version in plugin manifest", "user": { "login": "hassaansaleem28", "id": 167296971, "node_id": "U_kgDOCfi_yw", "avatar_url": "https://avatars.githubusercontent.com/u/167296971?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hassaansaleem28", "html_url": "https://github.com/hassaansaleem28", "followers_url": "https://api.github.com/users/hassaansaleem28/followers", "following_url": "https://api.github.com/users/hassaansaleem28/following{/other_user}", "gists_url": "https://api.github.com/users/hassaansaleem28/gists{/gist_id}", "starred_url": "https://api.github.com/users/hassaansaleem28/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hassaansaleem28/subscriptions", "organizations_url": "https://api.github.com/users/hassaansaleem28/orgs", "repos_url": "https://api.github.com/users/hassaansaleem28/repos", "events_url": "https://api.github.com/users/hassaansaleem28/events{/privacy}", "received_events_url": "https://api.github.com/users/hassaansaleem28/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 5, "created_at": "2026-02-12T02:05:32Z", "updated_at": "2026-02-12T09:18:55Z", "closed_at": "2026-02-12T07:40:42Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14339", "html_url": "https://github.com/laurent22/joplin/pull/14339", "diff_url": "https://github.com/laurent22/joplin/pull/14339.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14339.patch", "merged_at": null }, "body": "### Proposed Changes\r\n\r\nThis PR fixes the issue by removing the default assignment of `app_min_version` in \"PluginService\". This allows the schema validator \"manifestFromObject\" to correctly identify the missing field and throw the specific error: **\"Missing required field: app_min_version\"**.\r\n\r\n### Test plan\r\n\r\n**Automated Check:**\r\nVerified locally using a standalone script that instantiates \"PluginService\" with mocked dependencies.\r\n1. **Before:** Loading a manifest without `app_min_version` would default it to `1.4` and fail later with a generic compatibility error.\r\n2. **After:** Loading the same manifest immediately throws `Error: Missing required field: app_min_version`.\r\n3. **Regression Check:** Verified that valid manifests (with `app_min_version` present) are still processed correctly.\r\n\r\n**Manual UI Verification:**\r\nVerified in the Joplin Desktop application by loading a test plugin with an invalid manifest. The console correctly displayed the error.\r\n\r\n**Screenshots**\r\n\"Screenshot\r\n\r\n**Related issues**\r\nFixes #14271\n\n\n\n## Summary by CodeRabbit\n\n* **Chores**\n * Removed automatic default minimum application version injection for plugins; explicit version requirements must now be specified in plugin manifests.\n\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14339/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14339/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888256088", "html_url": "https://github.com/laurent22/joplin/pull/14339#issuecomment-3888256088", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14339", "id": 3888256088, "node_id": "IC_kwDOBLftOs7nwhRY", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-12T02:05:43Z", "updated_at": "2026-02-12T07:40:53Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888256088/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888257606", "html_url": "https://github.com/laurent22/joplin/pull/14339#issuecomment-3888257606", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14339", "id": 3888257606, "node_id": "IC_kwDOBLftOs7nwhpG", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-12T02:06:15Z", "updated_at": "2026-02-12T02:08:56Z", "body": "\n\n\n## Walkthrough\n\nRemoves automatic default `app_min_version` injection from plugin manifests and updates type signature formatting. Plugins now require explicit `app_min_version` declarations rather than receiving a fallback value, addressing manifest validation clarity issues.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Plugin Service Type and Logic Updates**
`packages/lib/services/plugins/PluginService.ts`|Formatting standardisation to type signatures (`SettingAndValue` index signature and `viewControllerByViewId` return type); removed automatic injection of default `app_min_version` ('1.4') into manifests and associated deprecation notice logic.|\n\n## Estimated code review effort\n\n🎯 2 (Simple) | ⏱️ ~8 minutes\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 5\n\n
\n✅ Passed checks (5 passed)\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |\n| Title check | ✅ Passed | The title accurately describes the primary change: correcting the error message for missing app_min_version in plugin manifests by removing the default assignment logic. |\n| Linked Issues check | ✅ Passed | The PR successfully addresses issue `#14271` by removing the default app_min_version injection, allowing the schema validator to properly detect and report the specific 'Missing required field: app_min_version' error instead of a generic compatibility error. |\n| Out of Scope Changes check | ✅ Passed | All changes are directly scoped to fixing the error messaging issue: removal of default app_min_version assignment, deprecation notice removal, and minor formatting changes to type signatures are all necessary to achieve the stated objective. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing touches\n\n- [ ] 📝 Generate docstrings\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n---\n\nNo actionable comments were generated in the recent review. 🎉\n\n\n\n> [!TIP]\n> [Issue Planner](https://www.coderabbit.ai/issue-planner) is now in beta. Read the [docs](https://docs.coderabbit.ai/issues/planning) and try it out! Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\n\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888257606/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888269015", "html_url": "https://github.com/laurent22/joplin/pull/14339#issuecomment-3888269015", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14339", "id": 3888269015, "node_id": "IC_kwDOBLftOs7nwkbX", "user": { "login": "hassaansaleem28", "id": 167296971, "node_id": "U_kgDOCfi_yw", "avatar_url": "https://avatars.githubusercontent.com/u/167296971?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hassaansaleem28", "html_url": "https://github.com/hassaansaleem28", "followers_url": "https://api.github.com/users/hassaansaleem28/followers", "following_url": "https://api.github.com/users/hassaansaleem28/following{/other_user}", "gists_url": "https://api.github.com/users/hassaansaleem28/gists{/gist_id}", "starred_url": "https://api.github.com/users/hassaansaleem28/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hassaansaleem28/subscriptions", "organizations_url": "https://api.github.com/users/hassaansaleem28/orgs", "repos_url": "https://api.github.com/users/hassaansaleem28/repos", "events_url": "https://api.github.com/users/hassaansaleem28/events{/privacy}", "received_events_url": "https://api.github.com/users/hassaansaleem28/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-12T02:09:49Z", "updated_at": "2026-02-12T02:09:49Z", "body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888269015/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888270256", "html_url": "https://github.com/laurent22/joplin/pull/14339#issuecomment-3888270256", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14339", "id": 3888270256, "node_id": "IC_kwDOBLftOs7nwkuw", "user": { "login": "hassaansaleem28", "id": 167296971, "node_id": "U_kgDOCfi_yw", "avatar_url": "https://avatars.githubusercontent.com/u/167296971?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hassaansaleem28", "html_url": "https://github.com/hassaansaleem28", "followers_url": "https://api.github.com/users/hassaansaleem28/followers", "following_url": "https://api.github.com/users/hassaansaleem28/following{/other_user}", "gists_url": "https://api.github.com/users/hassaansaleem28/gists{/gist_id}", "starred_url": "https://api.github.com/users/hassaansaleem28/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hassaansaleem28/subscriptions", "organizations_url": "https://api.github.com/users/hassaansaleem28/orgs", "repos_url": "https://api.github.com/users/hassaansaleem28/repos", "events_url": "https://api.github.com/users/hassaansaleem28/events{/privacy}", "received_events_url": "https://api.github.com/users/hassaansaleem28/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-12T02:10:17Z", "updated_at": "2026-02-12T02:10:17Z", "body": "recheck\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3888270256/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3889154135", "html_url": "https://github.com/laurent22/joplin/pull/14339#issuecomment-3889154135", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14339", "id": 3889154135, "node_id": "IC_kwDOBLftOs7nz8hX", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-12T07:40:40Z", "updated_at": "2026-02-12T07:40:40Z", "body": "I'm talking to AI so I'll keep it brief - this is not correct, and please do not open another PR", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3889154135/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }