{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9717/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9717/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/9717/events", "html_url": "https://github.com/laurent22/joplin/pull/9717", "id": 2080730793, "node_id": "PR_kwDOBLftOs5kBfI6", "number": 9717, "title": "Translated text in ro.po and rename file to ro_RO.po", "user": { "login": "idcristi", "id": 17257053, "node_id": "MDQ6VXNlcjE3MjU3MDUz", "avatar_url": "https://avatars.githubusercontent.com/u/17257053?v=4", "gravatar_id": "", "url": "https://api.github.com/users/idcristi", "html_url": "https://github.com/idcristi", "followers_url": "https://api.github.com/users/idcristi/followers", "following_url": "https://api.github.com/users/idcristi/following{/other_user}", "gists_url": "https://api.github.com/users/idcristi/gists{/gist_id}", "starred_url": "https://api.github.com/users/idcristi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/idcristi/subscriptions", "organizations_url": "https://api.github.com/users/idcristi/orgs", "repos_url": "https://api.github.com/users/idcristi/repos", "events_url": "https://api.github.com/users/idcristi/events{/privacy}", "received_events_url": "https://api.github.com/users/idcristi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1091621259, "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", "name": "translation", "color": "91ca55", "default": false, "description": "i18n and l10n" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 8, "created_at": "2024-01-14T13:33:07Z", "updated_at": "2024-02-06T15:49:30Z", "closed_at": "2024-02-06T15:49:12Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/9717", "html_url": "https://github.com/laurent22/joplin/pull/9717", "diff_url": "https://github.com/laurent22/joplin/pull/9717.diff", "patch_url": "https://github.com/laurent22/joplin/pull/9717.patch", "merged_at": "2024-02-06T15:49:12Z" }, "body": "Changes Made:\r\n- Translated text in **ro.po** file.\r\n- Renamed file from **ro.po** to **ro_RO.po**.\r\n- There was a misspelling in **en_US.po** file (1051 msgid \"Could not verify your identify: %s\") corrected to (\"Could not verify your identity: %s\")\r\n\r\nAttached you can find the image:\r\n![Screenshoot](https://github.com/laurent22/joplin/assets/17257053/ce82b9b9-abd7-49ac-801f-7c57b722dbdd)\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9717/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9717/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1890954323", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1890954323", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1890954323, "node_id": "IC_kwDOBLftOs5wtaxT", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-14T13:33:23Z", "updated_at": "2024-02-06T15:49:30Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1890954323/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1890957113", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1890957113", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1890957113, "node_id": "IC_kwDOBLftOs5wtbc5", "user": { "login": "idcristi", "id": 17257053, "node_id": "MDQ6VXNlcjE3MjU3MDUz", "avatar_url": "https://avatars.githubusercontent.com/u/17257053?v=4", "gravatar_id": "", "url": "https://api.github.com/users/idcristi", "html_url": "https://github.com/idcristi", "followers_url": "https://api.github.com/users/idcristi/followers", "following_url": "https://api.github.com/users/idcristi/following{/other_user}", "gists_url": "https://api.github.com/users/idcristi/gists{/gist_id}", "starred_url": "https://api.github.com/users/idcristi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/idcristi/subscriptions", "organizations_url": "https://api.github.com/users/idcristi/orgs", "repos_url": "https://api.github.com/users/idcristi/repos", "events_url": "https://api.github.com/users/idcristi/events{/privacy}", "received_events_url": "https://api.github.com/users/idcristi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-14T13:45:21Z", "updated_at": "2024-01-14T13:45:21Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1890957113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1891214882", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1891214882", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1891214882, "node_id": "IC_kwDOBLftOs5wuaYi", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-15T02:39:42Z", "updated_at": "2024-01-15T02:39:42Z", "author_association": "COLLABORATOR", "body": "> There was a misspelling in en_US.po file (1051 msgid \"Could not verify your identify: %s\") corrected to (\"Could not verify your identity: %s\")\r\n>\r\n> Attached you can find the image:\r\n\r\nThank you for finding this issue!\r\n\r\nThis may need to be fixed in the code (rather than in the `msgid` in the `.po` files):\r\n\r\nhttps://github.com/laurent22/joplin/blob/2b50e99bb17d6640844de90c3705fa77c32da672/packages/app-mobile/components/biometrics/biometricAuthenticate.ts#L20", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1891214882/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1896243930", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1896243930", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1896243930, "node_id": "IC_kwDOBLftOs5xBmLa", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-17T17:11:21Z", "updated_at": "2024-01-17T17:11:21Z", "author_association": "COLLABORATOR", "body": "Fixing source strings is more involved than just changing the code. All `.po` files have to be adjusted, otherwise the translations for that sentence are lost.\r\n\r\n(Many translators actually have used the correct translation, even if the source string is incorrect.)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1896243930/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1898295164", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1898295164", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1898295164, "node_id": "IC_kwDOBLftOs5xJa98", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-18T11:24:19Z", "updated_at": "2024-01-18T11:24:19Z", "author_association": "OWNER", "body": "> Fixing source strings is more involved than just changing the code. All `.po` files have to be adjusted, otherwise the translations for that sentence are lost.\r\n\r\n@idcristi, would you mind adding this to the pull request? Or maybe creating a separate pull request for it? I guess a big search and replace on all the files should take care of it", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1898295164/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1904216325", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1904216325", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1904216325, "node_id": "IC_kwDOBLftOs5xgAkF", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-22T15:14:27Z", "updated_at": "2024-01-22T15:14:27Z", "author_association": "OWNER", "body": "> I am not so sure about the 2 `index.js` files. I have never renamed a translation file before, thus I don't know the exact process. Laurent can probably answer that question.\r\n\r\nI'm not sure what will be the impact of this either, so to be safe it would be better to keep the name as it was. @idcristi, would you mind going back to the orignal name just \"ro.po\"? In some cases, we use the `lang_country` format when there can be significant differences between the countries, such as Portugal and Brasil, or China and Taiwan and we're likely to have language files for both (I guess for Romanian there could be Moldova/Romania? But we don't currently have a ro_MD translation)\r\n\r\nIf you would like to rename the file though we can make the change but it would be in a separate pull request for extra safety.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1904216325/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1909834639", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1909834639", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1909834639, "node_id": "IC_kwDOBLftOs5x1cOP", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-25T10:18:55Z", "updated_at": "2024-01-25T10:19:11Z", "author_association": "OWNER", "body": "@idcristi, there's still an issue with your PR - you didn't rename all instances of \"ro_RO\" back to \"ro\" so the build is failing. You can check on the diff and make sure you rename everything, strings and file names too.\r\n\r\n(This is why it's best to keep pull requests as simple as possible because the more we change the more new problems come up)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1909834639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1930094276", "html_url": "https://github.com/laurent22/joplin/pull/9717#issuecomment-1930094276", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9717", "id": 1930094276, "node_id": "IC_kwDOBLftOs5zCubE", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-02-06T15:49:25Z", "updated_at": "2024-02-06T15:49:25Z", "author_association": "OWNER", "body": "That looks good now, thank you @idcristi!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1930094276/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }