{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10367/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10367/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10367/events", "html_url": "https://github.com/laurent22/joplin/pull/10367", "id": 2261385421, "node_id": "PR_kwDOBLftOs5tm5os", "number": 10367, "title": "Desktop: update isArm64 function", "user": { "login": "ifurther", "id": 55025025, "node_id": "MDQ6VXNlcjU1MDI1MDI1", "avatar_url": "https://avatars.githubusercontent.com/u/55025025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ifurther", "html_url": "https://github.com/ifurther", "followers_url": "https://api.github.com/users/ifurther/followers", "following_url": "https://api.github.com/users/ifurther/following{/other_user}", "gists_url": "https://api.github.com/users/ifurther/gists{/gist_id}", "starred_url": "https://api.github.com/users/ifurther/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ifurther/subscriptions", "organizations_url": "https://api.github.com/users/ifurther/orgs", "repos_url": "https://api.github.com/users/ifurther/repos", "events_url": "https://api.github.com/users/ifurther/events{/privacy}", "received_events_url": "https://api.github.com/users/ifurther/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 8, "created_at": "2024-04-24T14:02:40Z", "updated_at": "2024-04-27T10:42:57Z", "closed_at": "2024-04-27T10:42:44Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10367", "html_url": "https://github.com/laurent22/joplin/pull/10367", "diff_url": "https://github.com/laurent22/joplin/pull/10367.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10367.patch", "merged_at": null }, "body": "Using `process.arch` to detect the arch", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10367/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075029322", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2075029322", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2075029322, "node_id": "IC_kwDOBLftOs57rm9K", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-24T14:02:56Z", "updated_at": "2024-04-27T10:42:57Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075029322/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075039662", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2075039662", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2075039662, "node_id": "IC_kwDOBLftOs57rpeu", "user": { "login": "ifurther", "id": 55025025, "node_id": "MDQ6VXNlcjU1MDI1MDI1", "avatar_url": "https://avatars.githubusercontent.com/u/55025025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ifurther", "html_url": "https://github.com/ifurther", "followers_url": "https://api.github.com/users/ifurther/followers", "following_url": "https://api.github.com/users/ifurther/following{/other_user}", "gists_url": "https://api.github.com/users/ifurther/gists{/gist_id}", "starred_url": "https://api.github.com/users/ifurther/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ifurther/subscriptions", "organizations_url": "https://api.github.com/users/ifurther/orgs", "repos_url": "https://api.github.com/users/ifurther/repos", "events_url": "https://api.github.com/users/ifurther/events{/privacy}", "received_events_url": "https://api.github.com/users/ifurther/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-24T14:07:18Z", "updated_at": "2024-04-24T14:07:18Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075039662/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075738203", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2075738203", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2075738203, "node_id": "IC_kwDOBLftOs57uUBb", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-24T19:59:25Z", "updated_at": "2024-04-24T19:59:25Z", "author_association": "OWNER", "body": "This is to fix which bug?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075738203/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2076453182", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2076453182", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2076453182, "node_id": "IC_kwDOBLftOs57xCk-", "user": { "login": "ifurther", "id": 55025025, "node_id": "MDQ6VXNlcjU1MDI1MDI1", "avatar_url": "https://avatars.githubusercontent.com/u/55025025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ifurther", "html_url": "https://github.com/ifurther", "followers_url": "https://api.github.com/users/ifurther/followers", "following_url": "https://api.github.com/users/ifurther/following{/other_user}", "gists_url": "https://api.github.com/users/ifurther/gists{/gist_id}", "starred_url": "https://api.github.com/users/ifurther/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ifurther/subscriptions", "organizations_url": "https://api.github.com/users/ifurther/orgs", "repos_url": "https://api.github.com/users/ifurther/repos", "events_url": "https://api.github.com/users/ifurther/events{/privacy}", "received_events_url": "https://api.github.com/users/ifurther/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-25T06:20:55Z", "updated_at": "2024-04-25T06:20:55Z", "author_association": "NONE", "body": "Fix the usage of process.platform, which indicates the operating system, and process.arch, which indicates the CPU architecture.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2076453182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2076719474", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2076719474", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2076719474, "node_id": "IC_kwDOBLftOs57yDly", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-25T09:07:48Z", "updated_at": "2024-04-25T09:07:48Z", "author_association": "OWNER", "body": "> Fix the usage of process.platform, which indicates the operating system, and process.arch, which indicates the CPU architecture.\r\n\r\nWhich was causing which bug?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2076719474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077003848", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2077003848", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2077003848, "node_id": "IC_kwDOBLftOs57zJBI", "user": { "login": "ifurther", "id": 55025025, "node_id": "MDQ6VXNlcjU1MDI1MDI1", "avatar_url": "https://avatars.githubusercontent.com/u/55025025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ifurther", "html_url": "https://github.com/ifurther", "followers_url": "https://api.github.com/users/ifurther/followers", "following_url": "https://api.github.com/users/ifurther/following{/other_user}", "gists_url": "https://api.github.com/users/ifurther/gists{/gist_id}", "starred_url": "https://api.github.com/users/ifurther/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ifurther/subscriptions", "organizations_url": "https://api.github.com/users/ifurther/orgs", "repos_url": "https://api.github.com/users/ifurther/repos", "events_url": "https://api.github.com/users/ifurther/events{/privacy}", "received_events_url": "https://api.github.com/users/ifurther/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-25T11:53:14Z", "updated_at": "2024-04-25T11:53:36Z", "author_association": "NONE", "body": "In Github Action, the m1 machine didn't run the for loop\r\nhttps://github.com/laurent22/joplin/blob/13a3c2ca74a6ac466feffa62f03068760a7d55c8/packages/app-desktop/tools/electronRebuild.js#L34-L41", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077003848/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077065756", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2077065756", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2077065756, "node_id": "IC_kwDOBLftOs57zYIc", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-25T12:28:07Z", "updated_at": "2024-04-25T12:28:07Z", "author_association": "OWNER", "body": "So keychain support is not working on macOS M?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077065756/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2080448184", "html_url": "https://github.com/laurent22/joplin/pull/10367#issuecomment-2080448184", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10367", "id": 2080448184, "node_id": "IC_kwDOBLftOs58AR64", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-27T10:42:44Z", "updated_at": "2024-04-27T10:42:44Z", "author_association": "OWNER", "body": "Sorry I'm not able to make an informed decision about this change since I'm not sure what is broken.\r\n\r\nFeel free to comment again if you can describe exactly what's not working at the moment, or point me to the right GitHub issue", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2080448184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }