{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8831/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8831/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8831/events", "html_url": "https://github.com/laurent22/joplin/pull/8831", "id": 1890052567, "node_id": "PR_kwDOBLftOs5Z_7EP", "number": 8831, "title": "Fixed Scrollbar thumb for light mode", "user": { "login": "imshivam-gupta", "id": 93479496, "node_id": "U_kgDOBZJiSA", "avatar_url": "https://avatars.githubusercontent.com/u/93479496?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imshivam-gupta", "html_url": "https://github.com/imshivam-gupta", "followers_url": "https://api.github.com/users/imshivam-gupta/followers", "following_url": "https://api.github.com/users/imshivam-gupta/following{/other_user}", "gists_url": "https://api.github.com/users/imshivam-gupta/gists{/gist_id}", "starred_url": "https://api.github.com/users/imshivam-gupta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imshivam-gupta/subscriptions", "organizations_url": "https://api.github.com/users/imshivam-gupta/orgs", "repos_url": "https://api.github.com/users/imshivam-gupta/repos", "events_url": "https://api.github.com/users/imshivam-gupta/events{/privacy}", "received_events_url": "https://api.github.com/users/imshivam-gupta/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2023-09-11T09:18:15Z", "updated_at": "2023-09-11T16:40:21Z", "closed_at": "2023-09-11T16:27:54Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8831", "html_url": "https://github.com/laurent22/joplin/pull/8831", "diff_url": "https://github.com/laurent22/joplin/pull/8831.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8831.patch", "merged_at": "2023-09-11T16:27:54Z" }, "body": "- Desktop: Resolves #8817: Added new setting to change font\r\n\r\nScrollbar thumb was hardly visible before in light theme now after changing css it is completely visible as shown below\r\n\r\nScroller -\r\n![image](https://github.com/laurent22/joplin/assets/93479496/88f2e423-3f0e-442b-b50e-76ca944095a3)\r\n\r\nScroller on hover-\r\n![image](https://github.com/laurent22/joplin/assets/93479496/440e6489-977c-488e-809f-edc688de5537)\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8831/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8831/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713496457", "html_url": "https://github.com/laurent22/joplin/pull/8831#issuecomment-1713496457", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "id": 1713496457, "node_id": "IC_kwDOBLftOs5mIeGJ", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-09-11T09:18:28Z", "updated_at": "2023-09-11T16:40:21Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713496457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713502667", "html_url": "https://github.com/laurent22/joplin/pull/8831#issuecomment-1713502667", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "id": 1713502667, "node_id": "IC_kwDOBLftOs5mIfnL", "user": { "login": "imshivam-gupta", "id": 93479496, "node_id": "U_kgDOBZJiSA", "avatar_url": "https://avatars.githubusercontent.com/u/93479496?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imshivam-gupta", "html_url": "https://github.com/imshivam-gupta", "followers_url": "https://api.github.com/users/imshivam-gupta/followers", "following_url": "https://api.github.com/users/imshivam-gupta/following{/other_user}", "gists_url": "https://api.github.com/users/imshivam-gupta/gists{/gist_id}", "starred_url": "https://api.github.com/users/imshivam-gupta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imshivam-gupta/subscriptions", "organizations_url": "https://api.github.com/users/imshivam-gupta/orgs", "repos_url": "https://api.github.com/users/imshivam-gupta/repos", "events_url": "https://api.github.com/users/imshivam-gupta/events{/privacy}", "received_events_url": "https://api.github.com/users/imshivam-gupta/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-09-11T09:22:30Z", "updated_at": "2023-09-11T09:22:30Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713502667/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713503031", "html_url": "https://github.com/laurent22/joplin/pull/8831#issuecomment-1713503031", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "id": 1713503031, "node_id": "IC_kwDOBLftOs5mIfs3", "user": { "login": "imshivam-gupta", "id": 93479496, "node_id": "U_kgDOBZJiSA", "avatar_url": "https://avatars.githubusercontent.com/u/93479496?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imshivam-gupta", "html_url": "https://github.com/imshivam-gupta", "followers_url": "https://api.github.com/users/imshivam-gupta/followers", "following_url": "https://api.github.com/users/imshivam-gupta/following{/other_user}", "gists_url": "https://api.github.com/users/imshivam-gupta/gists{/gist_id}", "starred_url": "https://api.github.com/users/imshivam-gupta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imshivam-gupta/subscriptions", "organizations_url": "https://api.github.com/users/imshivam-gupta/orgs", "repos_url": "https://api.github.com/users/imshivam-gupta/repos", "events_url": "https://api.github.com/users/imshivam-gupta/events{/privacy}", "received_events_url": "https://api.github.com/users/imshivam-gupta/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-09-11T09:22:42Z", "updated_at": "2023-09-11T09:22:42Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713503031/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713610238", "html_url": "https://github.com/laurent22/joplin/pull/8831#issuecomment-1713610238", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "id": 1713610238, "node_id": "IC_kwDOBLftOs5mI53-", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-09-11T10:29:36Z", "updated_at": "2023-09-11T10:29:36Z", "author_association": "OWNER", "body": "I think the colors should come from the theme. Otherwise you fix it for dark theme, but now it's broken for the light theme or other themes", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713610238/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713800106", "html_url": "https://github.com/laurent22/joplin/pull/8831#issuecomment-1713800106", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "id": 1713800106, "node_id": "IC_kwDOBLftOs5mJoOq", "user": { "login": "imshivam-gupta", "id": 93479496, "node_id": "U_kgDOBZJiSA", "avatar_url": "https://avatars.githubusercontent.com/u/93479496?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imshivam-gupta", "html_url": "https://github.com/imshivam-gupta", "followers_url": "https://api.github.com/users/imshivam-gupta/followers", "following_url": "https://api.github.com/users/imshivam-gupta/following{/other_user}", "gists_url": "https://api.github.com/users/imshivam-gupta/gists{/gist_id}", "starred_url": "https://api.github.com/users/imshivam-gupta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imshivam-gupta/subscriptions", "organizations_url": "https://api.github.com/users/imshivam-gupta/orgs", "repos_url": "https://api.github.com/users/imshivam-gupta/repos", "events_url": "https://api.github.com/users/imshivam-gupta/events{/privacy}", "received_events_url": "https://api.github.com/users/imshivam-gupta/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-09-11T12:41:04Z", "updated_at": "2023-09-11T12:41:04Z", "author_association": "CONTRIBUTOR", "body": "I have checked for all themes colors are blending perfectly well \r\n![image](https://github.com/laurent22/joplin/assets/93479496/733fae2a-0d58-4cf4-82d8-dc1f465a654b)\r\n\r\n![image](https://github.com/laurent22/joplin/assets/93479496/b27cf4e1-dfb2-4972-a8db-22b4a088ff24)\r\n\r\n![image](https://github.com/laurent22/joplin/assets/93479496/aeca47d6-7eef-490f-a5f3-89357db331c6)\r\n\r\nStill if you wish i can change the color according to theme.\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1713800106/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1714214593", "html_url": "https://github.com/laurent22/joplin/pull/8831#issuecomment-1714214593", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8831", "id": 1714214593, "node_id": "IC_kwDOBLftOs5mLNbB", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-09-11T16:27:22Z", "updated_at": "2023-09-11T16:27:22Z", "author_association": "OWNER", "body": "It would be better if the color comes from the theme, but it's still better than the current situation so let's merge.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1714214593/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }