{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10174/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10174/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10174/events", "html_url": "https://github.com/laurent22/joplin/pull/10174", "id": 2198887798, "node_id": "PR_kwDOBLftOs5qS3BF", "number": 10174, "title": "All: Bump @codemirror/view version.", "user": { "login": "itzTheMeow", "id": 50887230, "node_id": "MDQ6VXNlcjUwODg3MjMw", "avatar_url": "https://avatars.githubusercontent.com/u/50887230?v=4", "gravatar_id": "", "url": "https://api.github.com/users/itzTheMeow", "html_url": "https://github.com/itzTheMeow", "followers_url": "https://api.github.com/users/itzTheMeow/followers", "following_url": "https://api.github.com/users/itzTheMeow/following{/other_user}", "gists_url": "https://api.github.com/users/itzTheMeow/gists{/gist_id}", "starred_url": "https://api.github.com/users/itzTheMeow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/itzTheMeow/subscriptions", "organizations_url": "https://api.github.com/users/itzTheMeow/orgs", "repos_url": "https://api.github.com/users/itzTheMeow/repos", "events_url": "https://api.github.com/users/itzTheMeow/events{/privacy}", "received_events_url": "https://api.github.com/users/itzTheMeow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2024-03-21T01:08:46Z", "updated_at": "2024-03-23T15:04:13Z", "closed_at": "2024-03-23T15:03:59Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10174", "html_url": "https://github.com/laurent22/joplin/pull/10174", "diff_url": "https://github.com/laurent22/joplin/pull/10174.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10174.patch", "merged_at": "2024-03-23T15:03:59Z" }, "body": "\r\n\r\nFixes #10043. (i'm not aware of any other issues this affects)\r\n\r\nBumps the `@codemirror/view` version to [6.26.0](https://github.com/codemirror/view/releases/tag/6.26.0) for the editor.\r\n> Avoid the editor getting confused when iOS autocorrects on pressing Enter and does the correction and the break insertion in two different events.\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10174/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10174/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2011004080", "html_url": "https://github.com/laurent22/joplin/pull/10174#issuecomment-2011004080", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "id": 2011004080, "node_id": "IC_kwDOBLftOs533Xyw", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-21T01:08:58Z", "updated_at": "2024-03-23T15:04:13Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2011004080/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2011008020", "html_url": "https://github.com/laurent22/joplin/pull/10174#issuecomment-2011008020", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "id": 2011008020, "node_id": "IC_kwDOBLftOs533YwU", "user": { "login": "itzTheMeow", "id": 50887230, "node_id": "MDQ6VXNlcjUwODg3MjMw", "avatar_url": "https://avatars.githubusercontent.com/u/50887230?v=4", "gravatar_id": "", "url": "https://api.github.com/users/itzTheMeow", "html_url": "https://github.com/itzTheMeow", "followers_url": "https://api.github.com/users/itzTheMeow/followers", "following_url": "https://api.github.com/users/itzTheMeow/following{/other_user}", "gists_url": "https://api.github.com/users/itzTheMeow/gists{/gist_id}", "starred_url": "https://api.github.com/users/itzTheMeow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/itzTheMeow/subscriptions", "organizations_url": "https://api.github.com/users/itzTheMeow/orgs", "repos_url": "https://api.github.com/users/itzTheMeow/repos", "events_url": "https://api.github.com/users/itzTheMeow/events{/privacy}", "received_events_url": "https://api.github.com/users/itzTheMeow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-21T01:12:07Z", "updated_at": "2024-03-21T01:12:07Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2011008020/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2011207180", "html_url": "https://github.com/laurent22/joplin/pull/10174#issuecomment-2011207180", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "id": 2011207180, "node_id": "IC_kwDOBLftOs534JYM", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-21T04:43:14Z", "updated_at": "2024-03-21T04:43:14Z", "author_association": "COLLABORATOR", "body": "Thank you for contributing!\r\n\r\nHere are a few notes:\r\n- Be sure to also update `yarn.lock` (e.g. by running `yarn install` and committing the result). \r\n- If tests fail after this, it may be necessary to remove all `@codemirror/` and `@lezer/` dependencies from `yarn.lock`, then re-run `yarn install`.\r\n\r\nSee also:\r\n- The comment for the relevant regression test:\r\nhttps://github.com/laurent22/joplin/blob/b29bf7de5d3b3a7469c488602d63782b9febc7c3/packages/editor/CodeMirror/createEditor.test.ts#L23-L31\r\n- [A related thread on the CodeMirror forum](https://discuss.codemirror.net/t/how-to-upgrade-codemirror-past-0-19/5010/4).", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2011207180/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016513394", "html_url": "https://github.com/laurent22/joplin/pull/10174#issuecomment-2016513394", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "id": 2016513394, "node_id": "IC_kwDOBLftOs54MY1y", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-23T14:41:57Z", "updated_at": "2024-03-23T14:41:57Z", "author_association": "OWNER", "body": "CI is passing now. Does that look good to you now @personalizedrefrigerator?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016513394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016513730", "html_url": "https://github.com/laurent22/joplin/pull/10174#issuecomment-2016513730", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "id": 2016513730, "node_id": "IC_kwDOBLftOs54MY7C", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-23T14:43:28Z", "updated_at": "2024-03-23T14:43:28Z", "author_association": "COLLABORATOR", "body": "> CI is passing now. Does that look good to you now @personalizedrefrigerator?\r\n\r\nI haven't tested this locally, but since the automated tests are passing, this looks good to me!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016513730/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016518984", "html_url": "https://github.com/laurent22/joplin/pull/10174#issuecomment-2016518984", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10174", "id": 2016518984, "node_id": "IC_kwDOBLftOs54MaNI", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-23T15:03:55Z", "updated_at": "2024-03-23T15:03:55Z", "author_association": "OWNER", "body": "Great, let's merge then!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016518984/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }