{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/events", "html_url": "https://github.com/laurent22/joplin/pull/11862", "id": 2864348864, "node_id": "PR_kwDOBLftOs6LzZ-3", "number": 11862, "title": "Fix #11663 - Formatting extra buttons now appear on Rich Text Toobar", "user": { "login": "j-scheitler1", "id": 158077662, "node_id": "U_kgDOCWwS3g", "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", "gravatar_id": "", "url": "https://api.github.com/users/j-scheitler1", "html_url": "https://github.com/j-scheitler1", "followers_url": "https://api.github.com/users/j-scheitler1/followers", "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", "repos_url": "https://api.github.com/users/j-scheitler1/repos", "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 7, "created_at": "2025-02-19T20:35:13Z", "updated_at": "2025-02-20T19:18:50Z", "closed_at": "2025-02-20T15:40:55Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11862", "html_url": "https://github.com/laurent22/joplin/pull/11862", "diff_url": "https://github.com/laurent22/joplin/pull/11862.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11862.patch", "merged_at": null }, "body": "Desktop: Resolves #11663: Improved TinyMCE Toolbar Structure (Rich Text)\r\n\r\nThis pull request refactors the TinyMCE toolbar configuration in Joplin’s desktop application to improve button accessibility and appearance when users resize the notes window.\r\n\r\nKey Changes:\r\n- Decoupled formattingExtras buttons: Removed unnecessary grouping to prevent duplicate dropdowns.\r\n- Modified TinyMCE toolbar structure: Placed buttons individually in the toolbar for better visibility.\r\n- Applied CSS adjustments: Fixed height inconsistencies for the forecolor button to keep uniform height.\r\n\r\nBefore\r\n![before_02](https://github.com/user-attachments/assets/6e8ccac3-5e90-4e1b-a1f6-394bcab19c59)\r\n![before_01](https://github.com/user-attachments/assets/1ccdd9ff-6615-47af-b810-0d422f7d3bab)\r\n\r\nAfter\r\n![after_02](https://github.com/user-attachments/assets/9971201e-827c-421c-97af-e53297d165d3)\r\n![after_01](https://github.com/user-attachments/assets/18796d3f-0404-413d-b4a3-afd585fd4177)\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11862/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11862/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669702229", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2669702229", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2669702229, "node_id": "IC_kwDOBLftOs6fIGxV", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-19T20:35:29Z", "updated_at": "2025-02-20T00:33:03Z", "author_association": "CONTRIBUTOR", "body": "**CLA Assistant Lite bot:**
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **2** out of **3** committers have signed the CLA.
:white_check_mark: (personalizedrefrigerator)[https://github.com/personalizedrefrigerator]
:white_check_mark: (j-scheitler1)[https://github.com/j-scheitler1]
:x: @j-scheitler
You can retrigger this bot by commenting **recheck** in this Pull Request", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669702229/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669703024", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2669703024", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2669703024, "node_id": "IC_kwDOBLftOs6fIG9w", "user": { "login": "j-scheitler1", "id": 158077662, "node_id": "U_kgDOCWwS3g", "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", "gravatar_id": "", "url": "https://api.github.com/users/j-scheitler1", "html_url": "https://github.com/j-scheitler1", "followers_url": "https://api.github.com/users/j-scheitler1/followers", "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", "repos_url": "https://api.github.com/users/j-scheitler1/repos", "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-19T20:35:56Z", "updated_at": "2025-02-19T20:35:56Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669703024/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670063523", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2670063523", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2670063523, "node_id": "IC_kwDOBLftOs6fJe-j", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-20T00:12:19Z", "updated_at": "2025-02-20T00:13:41Z", "author_association": "COLLABORATOR", "body": "Thank you for contributing!\r\n\r\nIt looks like the email that authored https://github.com/laurent22/joplin/pull/11862/commits/bb243db7653a2e4f22dbc423b5bcf958478eeaea is associated with a [different GitHub account](https://github.com/j-scheitler) from the one that created this pull request. After [changing the email address globally](https://stackoverflow.com/a/37805844), it should be possible to [fix the email address associated with the commit using `git commit --amend --reset-author`](https://github.com/orgs/community/discussions/38097#discussioncomment-4041234).\r\n\r\nSee also: [GitHub: Setting your commit email address](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address).", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670063523/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670093028", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2670093028", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2670093028, "node_id": "IC_kwDOBLftOs6fJmLk", "user": { "login": "j-scheitler1", "id": 158077662, "node_id": "U_kgDOCWwS3g", "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", "gravatar_id": "", "url": "https://api.github.com/users/j-scheitler1", "html_url": "https://github.com/j-scheitler1", "followers_url": "https://api.github.com/users/j-scheitler1/followers", "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", "repos_url": "https://api.github.com/users/j-scheitler1/repos", "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-20T00:33:39Z", "updated_at": "2025-02-20T00:33:39Z", "author_association": "CONTRIBUTOR", "body": "@personalizedrefrigerator I believe it should be updated, sorry for the mix up.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670093028/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670830435", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2670830435", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2670830435, "node_id": "IC_kwDOBLftOs6fMaNj", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-20T08:49:01Z", "updated_at": "2025-02-20T08:49:01Z", "author_association": "OWNER", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2670830435/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671827592", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2671827592", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2671827592, "node_id": "IC_kwDOBLftOs6fQNqI", "user": { "login": "j-scheitler1", "id": 158077662, "node_id": "U_kgDOCWwS3g", "avatar_url": "https://avatars.githubusercontent.com/u/158077662?v=4", "gravatar_id": "", "url": "https://api.github.com/users/j-scheitler1", "html_url": "https://github.com/j-scheitler1", "followers_url": "https://api.github.com/users/j-scheitler1/followers", "following_url": "https://api.github.com/users/j-scheitler1/following{/other_user}", "gists_url": "https://api.github.com/users/j-scheitler1/gists{/gist_id}", "starred_url": "https://api.github.com/users/j-scheitler1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/j-scheitler1/subscriptions", "organizations_url": "https://api.github.com/users/j-scheitler1/orgs", "repos_url": "https://api.github.com/users/j-scheitler1/repos", "events_url": "https://api.github.com/users/j-scheitler1/events{/privacy}", "received_events_url": "https://api.github.com/users/j-scheitler1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-20T15:23:21Z", "updated_at": "2025-02-20T15:23:21Z", "author_association": "CONTRIBUTOR", "body": "@laurent22 It seems that I pushed the original commit from my university GitHub email that I no longer can log into. I followed the instructions to change the commit author from @personalizedrefrigerator to the account that I am leaving this comment with, but it seems the CLA check is still looking for that other account as well. Would you like me to close this pull request and open a new one or could you possibly bypass the CLA check? Sorry again for the inconvenience. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671827592/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671879236", "html_url": "https://github.com/laurent22/joplin/pull/11862#issuecomment-2671879236", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11862", "id": 2671879236, "node_id": "IC_kwDOBLftOs6fQaRE", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-20T15:40:55Z", "updated_at": "2025-02-20T15:40:55Z", "author_association": "OWNER", "body": "yes please", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2671879236/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }