{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7711/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7711/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7711/events", "html_url": "https://github.com/laurent22/joplin/pull/7711", "id": 1569793016, "node_id": "PR_kwDOBLftOs5JMz4j", "number": 7711, "title": "Desktop: Resolves #6143: Show installed plugins in Help - About Joplin", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 14, "created_at": "2023-02-03T12:49:29Z", "updated_at": "2023-02-16T15:26:46Z", "closed_at": "2023-02-08T14:16:09Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7711", "html_url": "https://github.com/laurent22/joplin/pull/7711", "diff_url": "https://github.com/laurent22/joplin/pull/7711.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7711.patch", "merged_at": "2023-02-08T14:16:09Z" }, "body": "\r\nResolves https://github.com/laurent22/joplin/issues/6143\r\n\r\nThis PR lists in `Help > About Joplin` every installed plugin. If more than 20 plugins are installed then only the first 20 plugins are shown followed by `...`. However when clicking on `Copy` the full list is always copied.\r\n\r\nHere's some screenshots when there are 0, 1, 5, 21 plugins installed.\r\n![plugin-list-no-plugin](https://user-images.githubusercontent.com/32807437/216603394-22003863-8494-44ac-b2b3-9ebae873d9f4.png)\r\n![plugin-list-one-plugin](https://user-images.githubusercontent.com/32807437/216603498-14f4d12a-9e2c-4817-baea-abaeb934f7de.png)\r\n![plugin-list-five-plugin](https://user-images.githubusercontent.com/32807437/216603518-e7d48d72-5cb2-4511-ac15-3c915fc139ad.png)\r\n![plugin-list-twenty-one-plugin](https://user-images.githubusercontent.com/32807437/216603555-3eb04ec2-b681-4ea1-8e8b-62552893d055.png)\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7711/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7711/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1415828550", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1415828550", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1415828550, "node_id": "IC_kwDOBLftOs5UY9RG", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-03T12:49:42Z", "updated_at": "2023-02-07T12:42:46Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1415828550/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1415829940", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1415829940", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1415829940, "node_id": "IC_kwDOBLftOs5UY9m0", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-03T12:51:01Z", "updated_at": "2023-02-03T12:51:01Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1415829940/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418677949", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1418677949", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1418677949, "node_id": "IC_kwDOBLftOs5Uj069", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-06T08:16:01Z", "updated_at": "2023-02-06T08:16:01Z", "author_association": "CONTRIBUTOR", "body": "> In general when modifying something under /lib or any shared package, you should also check how it's used across platforms. In that particular case, this function is also used on the CLI app (`joplin version` command), so could you check please that it's still working?\r\n\r\nThey are not listed.\r\n\r\nI started `app-cli` then used the command `:version`. \r\n\r\nI can see that `app-desktop` writes to `~/.config/joplindev-desktop` on my computer and `app-cli` writes to `~/.config/joplindev`. I guess that's why plugins installed via the desktop application don't appear in the CLI application.\r\n\r\nIs this expected? Or is there a way to install plugins from the CLI application?\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418677949/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418865580", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1418865580", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1418865580, "node_id": "IC_kwDOBLftOs5Ukius", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-06T10:36:18Z", "updated_at": "2023-02-06T10:37:59Z", "author_association": "OWNER", "body": "> They are not listed.\r\n\r\nSorry what do you mean by this? What is not listed?\r\n\r\nAnd no, plugins are not supported on the CLI app at the moment\r\n\r\nEdit: Ok I guess you mean plugins are not listed and that's normal. But does the command work at all? I'm wondering because versionInfo now has a dependency to the plugin service, but plugins are not supported on CLI. (it's half supported because we use it for testing but that's it)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418865580/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418953410", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1418953410", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1418953410, "node_id": "IC_kwDOBLftOs5Uk4LC", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-06T11:46:28Z", "updated_at": "2023-02-06T11:46:28Z", "author_association": "CONTRIBUTOR", "body": "> > They are not listed.\r\n> \r\n> Sorry what do you mean by this? What is not listed?\r\n> \r\n> And no, plugins are not supported on the CLI app at the moment\r\n> \r\n> Edit: Ok I guess you mean plugins are not listed and that's normal. But does the command work at all? I'm wondering because versionInfo now has a dependency to the plugin service, but plugins are not supported on CLI. (it's half supported because we use it for testing but that's it)\r\n\r\nI understand now. Yes it works.\r\n\r\nHere is a screenshot:\r\n![cli-versioninfo-show-plugins-branch](https://user-images.githubusercontent.com/32807437/216963219-d6e44f2b-377d-4d23-a4e8-87f7dfd5d56c.png)\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418953410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418969656", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1418969656", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1418969656, "node_id": "IC_kwDOBLftOs5Uk8I4", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-06T12:01:37Z", "updated_at": "2023-02-06T12:01:37Z", "author_association": "OWNER", "body": "Hmm, ok it works by chance then because the plugin service is not setup on CLI, yet it's used in your updated function. Instead of having versionInfo.ts loads PluginService directly, would it be possible to pass the plugins as a dependency to versionInfo() (in the same way the packageInfo is currently passed)? And on CLI you'd pass an empty array for instance.\r\n\r\nIn the context where versionInfo() is called there's `state.pluginService.plugins`. Does it already contain the necessary info, and if so can you use this? I think it may have been attempted before and it didn't work, so maybe you could add whatever extra info is needed to this array?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418969656/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1419199593", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1419199593", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1419199593, "node_id": "IC_kwDOBLftOs5Ul0Rp", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-06T14:46:05Z", "updated_at": "2023-02-06T14:46:05Z", "author_association": "CONTRIBUTOR", "body": "`state.pluginService.plugins` doesn't seem to contain what we need. But I remember a previous PR attempt that passed `PluginService.instance().plugins` to `versionInfo()`. \r\n\r\nI think that would work.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1419199593/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1419209107", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1419209107", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1419209107, "node_id": "IC_kwDOBLftOs5Ul2mT", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-06T14:52:31Z", "updated_at": "2023-02-06T14:52:31Z", "author_association": "OWNER", "body": "> But I remember a previous PR attempt that passed PluginService.instance().plugins to versionInfo().\r\n\r\nOk let's do that. That way we can pass an empty array on CLI", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1419209107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420189944", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1420189944", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1420189944, "node_id": "IC_kwDOBLftOs5UpmD4", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-07T04:37:14Z", "updated_at": "2023-02-07T04:37:14Z", "author_association": "CONTRIBUTOR", "body": "I updated the code to pass a `Plugins` object to `versionInfo()`.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420189944/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420631633", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1420631633", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1420631633, "node_id": "IC_kwDOBLftOs5UrR5R", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-07T11:36:27Z", "updated_at": "2023-02-07T11:36:27Z", "author_association": "OWNER", "body": "There's a TypeScript error in ErrorBoundary.tsx", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420631633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420724302", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1420724302", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1420724302, "node_id": "IC_kwDOBLftOs5UrohO", "user": { "login": "julien-me", "id": 32807437, "node_id": "MDQ6VXNlcjMyODA3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/32807437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-me", "html_url": "https://github.com/julien-me", "followers_url": "https://api.github.com/users/julien-me/followers", "following_url": "https://api.github.com/users/julien-me/following{/other_user}", "gists_url": "https://api.github.com/users/julien-me/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-me/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-me/subscriptions", "organizations_url": "https://api.github.com/users/julien-me/orgs", "repos_url": "https://api.github.com/users/julien-me/repos", "events_url": "https://api.github.com/users/julien-me/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-me/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-07T12:53:33Z", "updated_at": "2023-02-07T12:53:33Z", "author_association": "CONTRIBUTOR", "body": "> There's a TypeScript error in ErrorBoundary.tsx\r\n\r\nFixed.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420724302/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420833789", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1420833789", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1420833789, "node_id": "IC_kwDOBLftOs5UsDP9", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-07T14:07:57Z", "updated_at": "2023-02-07T14:07:57Z", "author_association": "OWNER", "body": "Thanks! For info we removed the TypeScript build from the precommit hook because it's too slow. So it means before committing you need to check the output of `yarn run watch` to see if there's any error in there", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420833789/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1422666892", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1422666892", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1422666892, "node_id": "IC_kwDOBLftOs5UzCyM", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-08T14:15:59Z", "updated_at": "2023-02-08T14:15:59Z", "author_association": "OWNER", "body": "That's great, thanks @julien-me for implementing this!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1422666892/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1432859114", "html_url": "https://github.com/laurent22/joplin/pull/7711#issuecomment-1432859114", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7711", "id": 1432859114, "node_id": "IC_kwDOBLftOs5VZ7Hq", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-16T10:25:16Z", "updated_at": "2023-02-16T10:25:16Z", "author_association": "OWNER", "body": "@julien-me, since this change the tests now print the version information. Please could you remove these console statements? ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1432859114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }