{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12696", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12696/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12696/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12696/events", "html_url": "https://github.com/laurent22/joplin/pull/12696", "id": 3221693557, "node_id": "PR_kwDOBLftOs6ebomG", "number": 12696, "title": "All: Update frontMatter parser to not output blank titles", "user": { "login": "khemarato", "id": 61610173, "node_id": "MDQ6VXNlcjYxNjEwMTcz", "avatar_url": "https://avatars.githubusercontent.com/u/61610173?v=4", "gravatar_id": "", "url": "https://api.github.com/users/khemarato", "html_url": "https://github.com/khemarato", "followers_url": "https://api.github.com/users/khemarato/followers", "following_url": "https://api.github.com/users/khemarato/following{/other_user}", "gists_url": "https://api.github.com/users/khemarato/gists{/gist_id}", "starred_url": "https://api.github.com/users/khemarato/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/khemarato/subscriptions", "organizations_url": "https://api.github.com/users/khemarato/orgs", "repos_url": "https://api.github.com/users/khemarato/repos", "events_url": "https://api.github.com/users/khemarato/events{/privacy}", "received_events_url": "https://api.github.com/users/khemarato/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2025-07-11T06:15:28Z", "updated_at": "2025-07-11T12:22:53Z", "closed_at": "2025-07-11T12:22:42Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/12696", "html_url": "https://github.com/laurent22/joplin/pull/12696", "diff_url": "https://github.com/laurent22/joplin/pull/12696.diff", "patch_url": "https://github.com/laurent22/joplin/pull/12696.patch", "merged_at": null }, "body": "This PR fixes the issue raised here:\r\n\r\nhttps://discourse.joplinapp.org/t/imported-frontmatter-md-has-untitled-as-title/34105\r\n\r\nI also ran into this issue importing my Obsidian Vault. Obsidian uses the filename to be the title of the note. This is also the expected behavior in Joplin: the importer should fall back to the file basename if no `title: ` is present in the frontmatter.\r\n\r\nIn the markdown with frontmatter importer, we have:\r\nhttps://github.com/laurent22/joplin/blob/8b4ad0aaf75b7ac0f4c975cfed4f62119f52e8ea/packages/lib/services/interop/InteropService_Importer_Md_frontmatter.ts#L14\r\n\r\nThis overwrites the default value for `title` with the frontmatter value if one is returned from the frontmatter helper. Unfortunately the frontmatter helper is returning an empty `title` when one doesn't exist in the frontmatter and this clobbers the default from the filename.\r\n\r\nThe PR fixes the issue by having the frontmatter helper not return any title value if one is not present in the frontmatter.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12696/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12696/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3060762611", "html_url": "https://github.com/laurent22/joplin/pull/12696#issuecomment-3060762611", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12696", "id": 3060762611, "node_id": "IC_kwDOBLftOs62b4fz", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-07-11T06:15:42Z", "updated_at": "2025-07-11T12:22:54Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3060762611/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3060779144", "html_url": "https://github.com/laurent22/joplin/pull/12696#issuecomment-3060779144", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12696", "id": 3060779144, "node_id": "IC_kwDOBLftOs62b8iI", "user": { "login": "khemarato", "id": 61610173, "node_id": "MDQ6VXNlcjYxNjEwMTcz", "avatar_url": "https://avatars.githubusercontent.com/u/61610173?v=4", "gravatar_id": "", "url": "https://api.github.com/users/khemarato", "html_url": "https://github.com/khemarato", "followers_url": "https://api.github.com/users/khemarato/followers", "following_url": "https://api.github.com/users/khemarato/following{/other_user}", "gists_url": "https://api.github.com/users/khemarato/gists{/gist_id}", "starred_url": "https://api.github.com/users/khemarato/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/khemarato/subscriptions", "organizations_url": "https://api.github.com/users/khemarato/orgs", "repos_url": "https://api.github.com/users/khemarato/repos", "events_url": "https://api.github.com/users/khemarato/events{/privacy}", "received_events_url": "https://api.github.com/users/khemarato/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-07-11T06:21:15Z", "updated_at": "2025-07-11T06:21:15Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3060779144/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }