{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14869", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14869/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14869/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14869/events", "html_url": "https://github.com/laurent22/joplin/pull/14869", "id": 4116134201, "node_id": "PR_kwDOBLftOs7MfTSZ", "number": 14869, "title": "Desktop: Fixes #9436: Fix Markdown export losing folders that differ only by special characters", "user": { "login": "lnxd", "id": 48756329, "node_id": "MDQ6VXNlcjQ4NzU2MzI5", "avatar_url": "https://avatars.githubusercontent.com/u/48756329?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lnxd", "html_url": "https://github.com/lnxd", "followers_url": "https://api.github.com/users/lnxd/followers", "following_url": "https://api.github.com/users/lnxd/following{/other_user}", "gists_url": "https://api.github.com/users/lnxd/gists{/gist_id}", "starred_url": "https://api.github.com/users/lnxd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lnxd/subscriptions", "organizations_url": "https://api.github.com/users/lnxd/orgs", "repos_url": "https://api.github.com/users/lnxd/repos", "events_url": "https://api.github.com/users/lnxd/events{/privacy}", "received_events_url": "https://api.github.com/users/lnxd/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" }, { "id": 6987126098, "node_id": "LA_kwDOBLftOs8AAAABoHcVUg", "url": "https://api.github.com/repos/laurent22/joplin/labels/export", "name": "export", "color": "7EDF94", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 4, "created_at": "2026-03-22T13:59:48Z", "updated_at": "2026-03-31T14:13:38Z", "closed_at": "2026-03-31T14:13:22Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14869", "html_url": "https://github.com/laurent22/joplin/pull/14869", "diff_url": "https://github.com/laurent22/joplin/pull/14869.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14869.patch", "merged_at": "2026-03-31T14:13:22Z" }, "body": "# Problem\r\n\r\nWhen exporting to markdown, folders with names that differ only by blacklisted characters (e.g.\r\n`folder:` and `folder?`) are both sanitised to the same filesystem name (`folder_`) by\r\n`friendlySafeFilename`. The second folder silently overwrites the first, and notes end up in the\r\nwrong directory.\r\n\r\nThis also affects folders with Windows-banned names like `CON`, `NUL`, `AUX`, all of which sanitise\r\nto `___`.\r\n\r\n# Solution\r\n\r\nPrecompute unique folder names in `prepareForProcessingItemType(TYPE_FOLDER)` before notes are\r\nprocessed. Folder names are grouped by parent and deduplicated using the existing `findUniqueFilename` mechanism, producing suffixes like `folder_-1` - consistent with how duplicate note names and resource filenames are already handled elsewhere in the exporter.\r\n\r\nThe resolved names are cached in a `folderPaths_` Map, which `makeDirPath_` consults when building paths. This ensures folder creation and note path assignment always agree on the directory name.\r\n\r\nA previous PR (#9867) was closed because it didn't handle all collision cases and used ID-based suffixes. This approach reuses the existing dedup infrastructure, so it handles identical names, blacklisted-character collisions, and banned-name collisions uniformly.\r\n\r\n# Validation\r\n\r\nAdded tests that verify unique directory assignment and that note files exist on disk. All tests pass.\r\n\r\n## Manual testing\r\n\r\n1. Create a notebook `Test>1` with a note\r\n2. Create a notebook `Test<1` with a note\r\n3. Export all > MD Markdown\r\n4. Verify two separate folders exist, each containing the correct note\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14869/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14869/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106304940", "html_url": "https://github.com/laurent22/joplin/pull/14869#issuecomment-4106304940", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14869", "id": 4106304940, "node_id": "IC_kwDOBLftOs70wT2s", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-22T13:59:58Z", "updated_at": "2026-03-31T14:13:38Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106304940/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106305433", "html_url": "https://github.com/laurent22/joplin/pull/14869#issuecomment-4106305433", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14869", "id": 4106305433, "node_id": "IC_kwDOBLftOs70wT-Z", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-22T14:00:15Z", "updated_at": "2026-03-28T11:04:33Z", "body": "\nNo actionable comments were generated in the recent review. 🎉\n\n
\nℹ️ Recent review info\n\n
\n⚙️ Run configuration\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `6dc59c5e-65e9-44fd-94d0-e2d9d0fe831b`\n\n
\n\n
\n📥 Commits\n\nReviewing files that changed from the base of the PR and between dbed88e8fb46ae1b5dd5a7a47c0214942ad4cf25 and 58f1fbdecacd3263bd2739a9d8f97af0f11a0eba.\n\n
\n\n
\n📒 Files selected for processing (1)\n\n* `packages/lib/services/interop/InteropService_Exporter_Md.ts`\n\n
\n\n
\n\n---\n\n\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nPre-computes unique, filesystem-safe folder basenames into a `folderPaths_` map during preparation. Folder path generation no longer uniquifies on-the-fly; note path construction uses the pre-computed folder names. Tests add a helper and verify disambiguation for colliding/special folder titles.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Exporter implementation**
`packages/lib/services/interop/InteropService_Exporter_Md.ts`|Added `folderPaths_ : Map` and a `TYPE_FOLDER` branch in `prepareForProcessingItemType` to compute per-parent unique folder basenames via `findUniqueFilename`; simplified `makeDirPath_` to use pre-computed names instead of on-the-fly uniquification.|\n|**Exporter tests**
`packages/lib/services/interop/InteropService_Exporter_Md.test.ts`|Added `createExportItems()` test helper and a new `it.each` test that queues two folders whose sanitized names would collide (including Windows-reserved names), processes folders and notes, and asserts two distinct note-path mappings and disambiguated output file files on disk.|\n\n## Suggested reviewers\n\n- laurent22\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 4\n\n
\n✅ Passed checks (4 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title clearly and specifically describes the main fix: addressing a Markdown export issue where folders differing only in special characters were losing data through overwriting. |\n| Description check | ✅ Passed | The description is directly relevant to the changeset, explaining the problem, solution, validation approach, and manual testing steps for the folder deduplication fix. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The pull request description includes all required sections per the contribution guidelines, clearly describing the user-impact problem, providing a high-level solution explanation, and documenting the test plan with passing results. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14869)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106305433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106306695", "html_url": "https://github.com/laurent22/joplin/pull/14869#issuecomment-4106306695", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14869", "id": 4106306695, "node_id": "IC_kwDOBLftOs70wUSH", "user": { "login": "lnxd", "id": 48756329, "node_id": "MDQ6VXNlcjQ4NzU2MzI5", "avatar_url": "https://avatars.githubusercontent.com/u/48756329?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lnxd", "html_url": "https://github.com/lnxd", "followers_url": "https://api.github.com/users/lnxd/followers", "following_url": "https://api.github.com/users/lnxd/following{/other_user}", "gists_url": "https://api.github.com/users/lnxd/gists{/gist_id}", "starred_url": "https://api.github.com/users/lnxd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lnxd/subscriptions", "organizations_url": "https://api.github.com/users/lnxd/orgs", "repos_url": "https://api.github.com/users/lnxd/repos", "events_url": "https://api.github.com/users/lnxd/events{/privacy}", "received_events_url": "https://api.github.com/users/lnxd/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-22T14:01:05Z", "updated_at": "2026-03-22T14:01:05Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106306695/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106318449", "html_url": "https://github.com/laurent22/joplin/pull/14869#issuecomment-4106318449", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14869", "id": 4106318449, "node_id": "IC_kwDOBLftOs70wXJx", "user": { "login": "lnxd", "id": 48756329, "node_id": "MDQ6VXNlcjQ4NzU2MzI5", "avatar_url": "https://avatars.githubusercontent.com/u/48756329?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lnxd", "html_url": "https://github.com/lnxd", "followers_url": "https://api.github.com/users/lnxd/followers", "following_url": "https://api.github.com/users/lnxd/following{/other_user}", "gists_url": "https://api.github.com/users/lnxd/gists{/gist_id}", "starred_url": "https://api.github.com/users/lnxd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lnxd/subscriptions", "organizations_url": "https://api.github.com/users/lnxd/orgs", "repos_url": "https://api.github.com/users/lnxd/repos", "events_url": "https://api.github.com/users/lnxd/events{/privacy}", "received_events_url": "https://api.github.com/users/lnxd/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-22T14:08:45Z", "updated_at": "2026-03-22T14:08:45Z", "body": "recheck", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4106318449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }