{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/events", "html_url": "https://github.com/laurent22/joplin/pull/12127", "id": 3003281572, "node_id": "PR_kwDOBLftOs6TCEDf", "number": 12127, "title": "Web: fix webdav", "user": { "login": "looi", "id": 1855766, "node_id": "MDQ6VXNlcjE4NTU3NjY=", "avatar_url": "https://avatars.githubusercontent.com/u/1855766?v=4", "gravatar_id": "", "url": "https://api.github.com/users/looi", "html_url": "https://github.com/looi", "followers_url": "https://api.github.com/users/looi/followers", "following_url": "https://api.github.com/users/looi/following{/other_user}", "gists_url": "https://api.github.com/users/looi/gists{/gist_id}", "starred_url": "https://api.github.com/users/looi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/looi/subscriptions", "organizations_url": "https://api.github.com/users/looi/orgs", "repos_url": "https://api.github.com/users/looi/repos", "events_url": "https://api.github.com/users/looi/events{/privacy}", "received_events_url": "https://api.github.com/users/looi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2025-04-17T19:27:29Z", "updated_at": "2025-04-24T21:23:42Z", "closed_at": "2025-04-24T07:55:10Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/12127", "html_url": "https://github.com/laurent22/joplin/pull/12127", "diff_url": "https://github.com/laurent22/joplin/pull/12127.diff", "patch_url": "https://github.com/laurent22/joplin/pull/12127.patch", "merged_at": "2025-04-24T07:55:10Z" }, "body": "* Currently, webdav PUT/DELETE requests fail due to \"Response with null body status cannot have body\"\r\n* This code uses the logic that chrome uses: https://chromium.googlesource.com/chromium/src/+/c631f71be2e78da5d3ca2cb4dc1a05e08ac5930c/third_party/WebKit/Source/core/fetch/Response.cpp#106\r\n* Also fixes fastDeepEqual import, consistent with other uses in the repo: https://github.com/search?q=repo%3Alaurent22%2Fjoplin%20fastDeepEqual&type=code", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12127/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12127/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2813839155", "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2813839155", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "id": 2813839155, "node_id": "IC_kwDOBLftOs6nt8cz", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-17T19:27:40Z", "updated_at": "2025-04-24T09:00:02Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2813839155/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2814865794", "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2814865794", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "id": 2814865794, "node_id": "IC_kwDOBLftOs6nx3GC", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-18T07:59:13Z", "updated_at": "2025-04-18T07:59:13Z", "author_association": "OWNER", "body": "> Also fixes fastDeepEqual import, consistent with other uses in the repo: https://github.com/search?q=repo%3Alaurent22%2Fjoplin%20fastDeepEqual&type=code\r\n\r\nIsn't the import syntax better because it provides types? But in any case unless it causes some problem with your change it should be changed in a separate PR (or maybe not changed at all if it doesn't impact anything)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2814865794/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2815079594", "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2815079594", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "id": 2815079594, "node_id": "IC_kwDOBLftOs6nyrSq", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-18T09:34:12Z", "updated_at": "2025-04-18T09:34:12Z", "author_association": "OWNER", "body": "Also please sign the CLA when you have a moment", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2815079594/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816251177", "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2816251177", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "id": 2816251177, "node_id": "IC_kwDOBLftOs6n3JUp", "user": { "login": "looi", "id": 1855766, "node_id": "MDQ6VXNlcjE4NTU3NjY=", "avatar_url": "https://avatars.githubusercontent.com/u/1855766?v=4", "gravatar_id": "", "url": "https://api.github.com/users/looi", "html_url": "https://github.com/looi", "followers_url": "https://api.github.com/users/looi/followers", "following_url": "https://api.github.com/users/looi/following{/other_user}", "gists_url": "https://api.github.com/users/looi/gists{/gist_id}", "starred_url": "https://api.github.com/users/looi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/looi/subscriptions", "organizations_url": "https://api.github.com/users/looi/orgs", "repos_url": "https://api.github.com/users/looi/repos", "events_url": "https://api.github.com/users/looi/events{/privacy}", "received_events_url": "https://api.github.com/users/looi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-18T21:54:51Z", "updated_at": "2025-04-18T21:54:51Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816251177/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816257134", "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2816257134", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "id": 2816257134, "node_id": "IC_kwDOBLftOs6n3Kxu", "user": { "login": "looi", "id": 1855766, "node_id": "MDQ6VXNlcjE4NTU3NjY=", "avatar_url": "https://avatars.githubusercontent.com/u/1855766?v=4", "gravatar_id": "", "url": "https://api.github.com/users/looi", "html_url": "https://github.com/looi", "followers_url": "https://api.github.com/users/looi/followers", "following_url": "https://api.github.com/users/looi/following{/other_user}", "gists_url": "https://api.github.com/users/looi/gists{/gist_id}", "starred_url": "https://api.github.com/users/looi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/looi/subscriptions", "organizations_url": "https://api.github.com/users/looi/orgs", "repos_url": "https://api.github.com/users/looi/repos", "events_url": "https://api.github.com/users/looi/events{/privacy}", "received_events_url": "https://api.github.com/users/looi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-18T21:57:30Z", "updated_at": "2025-04-18T21:57:30Z", "author_association": "CONTRIBUTOR", "body": "> > Also fixes fastDeepEqual import, consistent with other uses in the repo: https://github.com/search?q=repo%3Alaurent22%2Fjoplin%20fastDeepEqual&type=code\r\n> \r\n> Isn't the import syntax better because it provides types? But in any case unless it causes some problem with your change it should be changed in a separate PR (or maybe not changed at all if it doesn't impact anything)\r\n\r\nSure i reverted that change for now. It was causing some build problems for me earlier but I think it is ok now.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2816257134/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2828891904", "html_url": "https://github.com/laurent22/joplin/pull/12127#issuecomment-2828891904", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12127", "id": 2828891904, "node_id": "IC_kwDOBLftOs6onXcA", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-24T21:23:41Z", "updated_at": "2025-04-24T21:23:41Z", "author_association": "COLLABORATOR", "body": "I'm linking to the relevant deployment workflow run: https://github.com/joplin/web-app/actions/runs/14651938648\r\n\r\nThank you for contributing!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2828891904/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }