{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14765", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14765/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14765/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14765/events", "html_url": "https://github.com/laurent22/joplin/pull/14765", "id": 4082831438, "node_id": "PR_kwDOBLftOs7K8K_v", "number": 14765, "title": "Mobile: fix openFolder x-callback-url link on Android", "user": { "login": "madhan112007", "id": 192893760, "node_id": "U_kgDOC39TQA", "avatar_url": "https://avatars.githubusercontent.com/u/192893760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/madhan112007", "html_url": "https://github.com/madhan112007", "followers_url": "https://api.github.com/users/madhan112007/followers", "following_url": "https://api.github.com/users/madhan112007/following{/other_user}", "gists_url": "https://api.github.com/users/madhan112007/gists{/gist_id}", "starred_url": "https://api.github.com/users/madhan112007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/madhan112007/subscriptions", "organizations_url": "https://api.github.com/users/madhan112007/orgs", "repos_url": "https://api.github.com/users/madhan112007/repos", "events_url": "https://api.github.com/users/madhan112007/events{/privacy}", "received_events_url": "https://api.github.com/users/madhan112007/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1079605111, "node_id": "MDU6TGFiZWwxMDc5NjA1MTEx", "url": "https://api.github.com/repos/laurent22/joplin/labels/mobile", "name": "mobile", "color": "ffc274", "default": false, "description": "All mobile platforms" }, { "id": 1366672041, "node_id": "MDU6TGFiZWwxMzY2NjcyMDQx", "url": "https://api.github.com/repos/laurent22/joplin/labels/android", "name": "android", "color": "bfd4f2", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 3, "created_at": "2026-03-16T14:27:53Z", "updated_at": "2026-03-16T22:06:31Z", "closed_at": "2026-03-16T20:50:39Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14765", "html_url": "https://github.com/laurent22/joplin/pull/14765", "diff_url": "https://github.com/laurent22/joplin/pull/14765.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14765.patch", "merged_at": "2026-03-16T20:50:39Z" }, "body": "Fixes #14286\r\n\r\n## Summary\r\nFixes `joplin://x-callback-url/openFolder?id=` links not working on Android.\r\n\r\n## Problem\r\nOn Android, clicking a `joplin://x-callback-url/openFolder` link resulted in the error:\r\n\r\nUnsupported item type for links: 2\r\n\r\nThe deep-link handler did not correctly support folder targets, causing the app to fail when attempting to open a notebook via an external link.\r\n\r\n## Solution\r\nUpdate the Android deep-link handling logic so that folder links are recognized and the application navigates to the corresponding notebook instead of treating the link as an unsupported item type.\r\n\r\n## Testing\r\nTested on an Android emulator (Pixel 6, API 34):\r\n\r\n1. Created a notebook in Joplin\r\n2. Copied its external link\r\n3. Triggered the link using:\r\n\r\nadb shell am start -a android.intent.action.VIEW -d \"joplin://x-callback-url/openFolder?id=\"\r\n\r\nResult:\r\n- Joplin opens and navigates to the correct notebook.\r\n- Verified that `openNote` links still work as expected (no regression).\r\n\r\n**Result**\r\n\r\nhttps://github.com/user-attachments/assets/4d254dcf-ff82-46ff-ad5b-c15d7ea492b9\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14765/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14765/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4068070228", "html_url": "https://github.com/laurent22/joplin/pull/14765#issuecomment-4068070228", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14765", "id": 4068070228, "node_id": "IC_kwDOBLftOs7yedNU", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-16T14:28:08Z", "updated_at": "2026-03-16T22:06:31Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ βœ…", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4068070228/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4068072328", "html_url": "https://github.com/laurent22/joplin/pull/14765#issuecomment-4068072328", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14765", "id": 4068072328, "node_id": "IC_kwDOBLftOs7yeduI", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-16T14:28:23Z", "updated_at": "2026-03-16T15:01:59Z", "body": "\nNo actionable comments were generated in the recent review. πŸŽ‰\n\n
\nℹ️ Recent review info\n\n
\nβš™οΈ Run configuration\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `1c939229-2093-4a23-9f8f-7d1ddf525be7`\n\n
\n\n
\nπŸ“₯ Commits\n\nReviewing files that changed from the base of the PR and between 5cb776eb9d9e5c47e7de7cc46fdf7b4f328b3525 and a659e892f74a8ce5263705b403dc81ab56eed0e8.\n\n
\n\n
\nπŸ“’ Files selected for processing (2)\n\n* `.eslintignore`\n* `.gitignore`\n\n
\n\n
\nβœ… Files skipped from review due to trivial changes (1)\n\n* .eslintignore\n\n
\n\n
\n\n---\n\n\n\n\n
\nπŸ“ Walkthrough\n\n## Walkthrough\n\nopenItem was extended to handle Folder items by calling a new goToFolder utility. Item existence validation was added. A new util module loads the Folder and navigates to the Notes view; auxiliary .eslintignore and .gitignore entries for the generated JS file were added.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Command Enhancement**
`packages/app-mobile/commands/openItem.ts`|Imports and uses `goToFolder` for items of type Folder; validates item existence and throws if not found; retains Note and Resource handling.|\n|**Utility Function**
`packages/app-mobile/commands/util/goToFolder.ts`|New default-exported async `goToFolder(id: string)` that loads `Folder.load(id)`, throws if missing, and calls `NavService.go('Notes', { folderId: id })`.|\n|**Ignore Lists**
`.eslintignore`, `.gitignore`|Added `packages/app-mobile/commands/util/goToFolder.js` to ESLint and Git ignore files (generated JS ignored).|\n\n## Sequence Diagram(s)\n\n```mermaid\nsequenceDiagram\n participant Cmd as openItem command\n participant Util as goToFolder\n participant Model as Folder\n participant Nav as NavService\n\n Cmd->>Util: goToFolder(item.id)\n Util->>Model: Folder.load(id)\n alt folder found\n Util->>Nav: NavService.go('Notes', { folderId: id })\n Nav-->>Cmd: navigation complete\n else not found\n Util-->>Cmd: throw Error(\"Folder not found\")\n end\n```\n\n## Suggested labels\n\nmobile, android, bug\n\n## Suggested reviewers\n\n- laurent22\n\n
\n\n\n\n\n\n\n
\nπŸš₯ Pre-merge checks | βœ… 6\n\n
\nβœ… Passed checks (6 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | βœ… Passed | The title clearly describes the main change: fixing openFolder x-callback-url links on Android, which directly addresses the primary objective of the PR. |\n| Description check | βœ… Passed | The description provides detailed context about the problem, solution, and testing methodology, all directly related to the changeset's objective of fixing folder link handling on Android. |\n| Linked Issues check | βœ… Passed | The PR successfully implements support for openFolder x-callback-url links on Android by extending openItemById to handle ModelType.Folder and adding goToFolder utility function, fully addressing issue `#14286`'s requirement to open folders via external links. |\n| Out of Scope Changes check | βœ… Passed | Changes to .eslintignore and .gitignore to ignore the new goToFolder.js file are ancillary to the primary functionality and are standard practice for generated or compiled output files. |\n| Docstring Coverage | βœ… Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | βœ… Passed | The PR description includes all required sections: problem statement (x-callback-url/openFolder failing on Android), solution explanation (changes to openItem.ts and new goToFolder.ts), and test plan (Android emulator verification with specific steps). |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\nπŸ§ͺ Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n
\nπŸ“ Coding Plan\n\n- [ ] Generate coding plan for human review comments\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14765)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❀️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n\n\n\n> [!TIP]\n>
\n> CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.\n> \n> Add a [configuration file](https://biomejs.dev/reference/configuration/) to your project to customize how CodeRabbit runs `biome`.\n> \n>
\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4068072328/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes.Β \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code.Β The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issuesΒ \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4068086841", "html_url": "https://github.com/laurent22/joplin/pull/14765#issuecomment-4068086841", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14765", "id": 4068086841, "node_id": "IC_kwDOBLftOs7yehQ5", "user": { "login": "madhan112007", "id": 192893760, "node_id": "U_kgDOC39TQA", "avatar_url": "https://avatars.githubusercontent.com/u/192893760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/madhan112007", "html_url": "https://github.com/madhan112007", "followers_url": "https://api.github.com/users/madhan112007/followers", "following_url": "https://api.github.com/users/madhan112007/following{/other_user}", "gists_url": "https://api.github.com/users/madhan112007/gists{/gist_id}", "starred_url": "https://api.github.com/users/madhan112007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/madhan112007/subscriptions", "organizations_url": "https://api.github.com/users/madhan112007/orgs", "repos_url": "https://api.github.com/users/madhan112007/repos", "events_url": "https://api.github.com/users/madhan112007/events{/privacy}", "received_events_url": "https://api.github.com/users/madhan112007/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-16T14:30:15Z", "updated_at": "2026-03-16T14:30:15Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4068086841/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }