{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14517/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14517/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14517/events", "html_url": "https://github.com/laurent22/joplin/pull/14517", "id": 4008297496, "node_id": "PR_kwDOBLftOs7HLq37", "number": 14517, "title": "Desktop: Fixes #12327: Load Font Awesome in preview pane to fix checked checkboxes in tables", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 12, "created_at": "2026-03-01T21:20:15Z", "updated_at": "2026-03-07T15:54:37Z", "closed_at": "2026-03-05T08:42:30Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14517", "html_url": "https://github.com/laurent22/joplin/pull/14517", "diff_url": "https://github.com/laurent22/joplin/pull/14517.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14517.patch", "merged_at": null }, "body": "Closes #12327 \r\n\r\n## Summary\r\nChecked checkboxes inside tables were shown as unchecked in the split-screen preview pane.\r\n\r\n## Root Cause\r\nThe preview pane never loaded Font Awesome. Checkboxes inside tables are stored as raw HTML with `
  • ` and rendered via CSS + FA icons (`ul.joplin-checklist li::before`). Without FA, the icon silently failed to render.\r\n\r\nRegular checklists outside tables are unaffected as they render as native `` elements.\r\n\r\n## Fix\r\nInject Font Awesome (already bundled in vendor dir) into the preview webview's `pluginAssets` array in `CodeMirror.tsx` (v5 & v6).\r\n\r\n## Testing\r\n1. Open Rich Text editor\r\n2. Insert a table and add a checked checklist item inside a cell\r\n3. Switch to split-screen (Markdown + preview)\r\n4. Verify checked checkbox renders correctly in preview\r\n\r\n## Demo\r\n\r\nhttps://github.com/user-attachments/assets/ac5de7af-310d-4315-a525-2230ee353a7b\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14517/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3981050560", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3981050560", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3981050560, "node_id": "IC_kwDOBLftOs7tSgLA", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-01T21:20:26Z", "updated_at": "2026-03-05T08:59:38Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ βœ…", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3981050560/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3981051066", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3981051066", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3981051066, "node_id": "IC_kwDOBLftOs7tSgS6", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-01T21:20:45Z", "updated_at": "2026-03-03T22:31:01Z", "body": "\nNo actionable comments were generated in the recent review. πŸŽ‰\n\n
    \nℹ️ Recent review info\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n
    \nπŸ“₯ Commits\n\nReviewing files that changed from the base of the PR and between 9f958985ca263d134a53695fba23592576b02d9a and ee920d4c090e2777fd2a3b40ca5e4efb8ba7ee95.\n\n
    \n\n
    \nπŸ“’ Files selected for processing (1)\n\n* `packages/renderer/noteStyle.ts`\n\n
    \n\n
    \n🚧 Files skipped from review as they are similar to previous changes (1)\n\n* packages/renderer/noteStyle.ts\n\n
    \n\n
    \n\n---\n\n\n\n\n
    \nπŸ“ Walkthrough\n\n## Walkthrough\n\nCheckbox and checklist CSS selectors were re-scoped: global checklist rules moved under a `.jop-tinymce` context in the renderer, and comprehensive `ul.joplin-checklist` styling (checked/unchecked visuals, theme colour, padding) was added to the note stylesheet. No runtime logic or public API changes.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Renderer checkbox rules**
    `packages/renderer/MdToHtml/rules/checkbox.ts`|Re-scoped checklist CSS selectors from global to be under `.jop-tinymce` (selector specificity adjustments; replaced global `ul.joplin-checklist` rules with `.jop-tinymce ul.joplin-checklist`).|\n|**Note stylesheet checklist styling**
    `packages/renderer/noteStyle.ts`|Added `ul.joplin-checklist` rules: removed default bullets, added `li::before` visuals for checked (β˜‘) and unchecked (☐) states, made before-content clickable, applied theme colour and adjusted left padding. Styling duplicated in two locations within the stylesheet string. |\n\n## Suggested labels\n\n`bug`, `desktop`\n\n
    \n\n\n\n\n\n\n
    \nπŸš₯ Pre-merge checks | βœ… 2 | ❌ 4\n\n### ❌ Failed checks (3 warnings, 1 inconclusive)\n\n| Check name | Status | Explanation | Resolution |\n| :-----------------: | :------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ⚠️ Warning | The PR title mentions loading Font Awesome to fix checkboxes, but the actual changes only modify CSS selectors and add styling rules without implementing Font Awesome loading. | Update the title to reflect the actual changes made, such as 'Add scoped checklist styling and CSS updates' or verify that Font Awesome loading code is present in the changeset. |\n| Description check | ⚠️ Warning | The description claims Font Awesome injection was added to CodeMirror.tsx, but the provided changeset only shows CSS modifications in checkbox.ts and noteStyle.ts files. | Either include the CodeMirror.tsx changes in the PR or revise the description to match the actual CSS-only modifications present in the changeset. |\n| Docstring Coverage | ⚠️ Warning | Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |\n| Linked Issues check | ❓ Inconclusive | The PR description mentions switching to Unicode checkbox characters instead of Font Awesome, but the changeset shows only CSS scoping changes without evidence of Unicode character implementation. | Clarify whether Unicode characters were actually implemented in the CSS rules or if the Font Awesome approach is still being used, and provide complete changeset details. |\n\n
    \nβœ… Passed checks (2 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Out of Scope Changes check | βœ… Passed | The changes appear limited to CSS selector scoping in checkbox.ts and styling additions in noteStyle.ts, which are related to fixing checkbox display in the preview pane. |\n| Pr Description Must Follow Guidelines | βœ… Passed | PR description includes all required sections (Problem, Solution, and Test Plan) as specified in Joplin contribution guidelines. |\n\n
    \n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
    \n\n\n\n\n\n
    \n✨ Finishing Touches\n\n
    \nπŸ§ͺ Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
    \n\n
    \n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14517)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
    \n❀️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
    \n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3981051066/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes.Β \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code.Β The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issuesΒ \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3981058729", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3981058729", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3981058729, "node_id": "IC_kwDOBLftOs7tSiKp", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-01T21:25:33Z", "updated_at": "2026-03-01T21:25:33Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3981058729/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3991774832", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3991774832", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3991774832, "node_id": "IC_kwDOBLftOs7t7aZw", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T15:22:31Z", "updated_at": "2026-03-03T15:22:31Z", "body": "Hmm, they are rendered but they don't actually work?", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3991774832/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992128844", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3992128844", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3992128844, "node_id": "IC_kwDOBLftOs7t8w1M", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T16:21:09Z", "updated_at": "2026-03-03T16:21:09Z", "body": "you mean clicking them in the preview window doesn't work?", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992128844/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992235431", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3992235431", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3992235431, "node_id": "IC_kwDOBLftOs7t9K2n", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T16:39:10Z", "updated_at": "2026-03-03T16:39:10Z", "body": "Yes it doesn't work, and I don't think we really support this", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992235431/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992288433", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3992288433", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3992288433, "node_id": "IC_kwDOBLftOs7t9Xyx", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T16:48:45Z", "updated_at": "2026-03-03T16:48:45Z", "body": "got it. so the rendering fix is still valid?", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992288433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993134159", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3993134159", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3993134159, "node_id": "IC_kwDOBLftOs7uAmRP", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T19:42:01Z", "updated_at": "2026-03-03T19:42:01Z", "body": "Well, I don't know. Embedding fonts in the view has a cost in terms of performance and it's just to create pretend checkboxes that don't really work. So no I don't think that's a good fix and maybe we don't need to do anything about this", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993134159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993495635", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3993495635", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3993495635, "node_id": "IC_kwDOBLftOs7uB-hT", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T20:57:11Z", "updated_at": "2026-03-03T20:57:11Z", "body": "okay, i'll try a lighter alternative", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993495635/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993932670", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-3993932670", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 3993932670, "node_id": "IC_kwDOBLftOs7uDpN-", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T22:21:29Z", "updated_at": "2026-03-03T22:21:29Z", "body": "removed Font Awesome injection and switched to Unicode characters instead. checkboxes now render correctly in the preview pane\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8438dce1-1b5d-4506-93fb-713ff04eae78\r\n\r\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3993932670/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003343156", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-4003343156", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 4003343156, "node_id": "IC_kwDOBLftOs7unis0", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-05T08:42:30Z", "updated_at": "2026-03-05T08:42:30Z", "body": "Sorry I don't think we want this change for now. Your PR is a possible improvement but I guess what would be needed is proper support for checkboxes in tables. So for now I would prefer to close the PR. Thanks anyway for giving it a try", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003343156/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4004209870", "html_url": "https://github.com/laurent22/joplin/pull/14517#issuecomment-4004209870", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14517", "id": 4004209870, "node_id": "IC_kwDOBLftOs7uq2TO", "user": { "login": "manjhss", "id": 121970162, "node_id": "U_kgDOB0Ud8g", "avatar_url": "https://avatars.githubusercontent.com/u/121970162?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manjhss", "html_url": "https://github.com/manjhss", "followers_url": "https://api.github.com/users/manjhss/followers", "following_url": "https://api.github.com/users/manjhss/following{/other_user}", "gists_url": "https://api.github.com/users/manjhss/gists{/gist_id}", "starred_url": "https://api.github.com/users/manjhss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manjhss/subscriptions", "organizations_url": "https://api.github.com/users/manjhss/orgs", "repos_url": "https://api.github.com/users/manjhss/repos", "events_url": "https://api.github.com/users/manjhss/events{/privacy}", "received_events_url": "https://api.github.com/users/manjhss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-05T10:56:37Z", "updated_at": "2026-03-05T10:56:37Z", "body": "understood, thanks for the feedback", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4004209870/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }