{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8163", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8163/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8163/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8163/events", "html_url": "https://github.com/laurent22/joplin/pull/8163", "id": 1705912028, "node_id": "PR_kwDOBLftOs5QTDZS", "number": 8163, "title": "Desktop: Resolves #3535: Configure tinymce to handle the first table row as header", "user": { "login": "marph91", "id": 33229141, "node_id": "MDQ6VXNlcjMzMjI5MTQx", "avatar_url": "https://avatars.githubusercontent.com/u/33229141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marph91", "html_url": "https://github.com/marph91", "followers_url": "https://api.github.com/users/marph91/followers", "following_url": "https://api.github.com/users/marph91/following{/other_user}", "gists_url": "https://api.github.com/users/marph91/gists{/gist_id}", "starred_url": "https://api.github.com/users/marph91/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marph91/subscriptions", "organizations_url": "https://api.github.com/users/marph91/orgs", "repos_url": "https://api.github.com/users/marph91/repos", "events_url": "https://api.github.com/users/marph91/events{/privacy}", "received_events_url": "https://api.github.com/users/marph91/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2023-05-11T14:16:39Z", "updated_at": "2023-06-10T16:16:00Z", "closed_at": "2023-06-10T16:08:16Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8163", "html_url": "https://github.com/laurent22/joplin/pull/8163", "diff_url": "https://github.com/laurent22/joplin/pull/8163.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8163.patch", "merged_at": "2023-06-10T16:08:16Z" }, "body": "Resolves #3535\r\n\r\nConsider the first table row as header in the richtext editor automatically. Switching isn't needed anymore. This is based on https://tinymce.github.io/tinymce-demos/tables/customizing-the-table-toolbar.html.\r\n\r\nOpen questions:\r\n\r\n1. The new menu only contains the table size selection. As far as I see, most of the options are either covered by the table tooltip (insert, delete, properties) or incompatible with markdown (merge and split cells). Only the cut/paste options are missing. I could either try to add the cut/paste options to the tooltip or build the menu manually, as it was before. What would be the preferred way?\r\n2. There are some `any` types. I left them for now, since the surrounding code has them, too. Let me know if I should try to fix them.\r\n\r\nScreenshot:\r\n\r\n![Screenshot_20230511_155150](https://github.com/laurent22/joplin/assets/33229141/3b2fe2a4-70a8-4570-b229-22609d2c3e9e)", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8163/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8163/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1544067309", "html_url": "https://github.com/laurent22/joplin/pull/8163#issuecomment-1544067309", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8163", "id": 1544067309, "node_id": "IC_kwDOBLftOs5cCJjt", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-11T14:16:54Z", "updated_at": "2023-05-29T17:38:08Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1544067309/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1544068856", "html_url": "https://github.com/laurent22/joplin/pull/8163#issuecomment-1544068856", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8163", "id": 1544068856, "node_id": "IC_kwDOBLftOs5cCJ74", "user": { "login": "marph91", "id": 33229141, "node_id": "MDQ6VXNlcjMzMjI5MTQx", "avatar_url": "https://avatars.githubusercontent.com/u/33229141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marph91", "html_url": "https://github.com/marph91", "followers_url": "https://api.github.com/users/marph91/followers", "following_url": "https://api.github.com/users/marph91/following{/other_user}", "gists_url": "https://api.github.com/users/marph91/gists{/gist_id}", "starred_url": "https://api.github.com/users/marph91/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marph91/subscriptions", "organizations_url": "https://api.github.com/users/marph91/orgs", "repos_url": "https://api.github.com/users/marph91/repos", "events_url": "https://api.github.com/users/marph91/events{/privacy}", "received_events_url": "https://api.github.com/users/marph91/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-11T14:17:44Z", "updated_at": "2023-05-11T14:17:44Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1544068856/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549432355", "html_url": "https://github.com/laurent22/joplin/pull/8163#issuecomment-1549432355", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8163", "id": 1549432355, "node_id": "IC_kwDOBLftOs5cWnYj", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-16T10:49:58Z", "updated_at": "2023-05-16T10:49:58Z", "author_association": "OWNER", "body": "Thank you, that looks very good. The menu we have at the moment is indeed needlessly complex.\r\n\r\nRegarding `any`, please could you check if you can get the types from TinyMCE? If too complicated, don't worry, but in general for new code we try to set types everywhere", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549432355/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551561012", "html_url": "https://github.com/laurent22/joplin/pull/8163#issuecomment-1551561012", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8163", "id": 1551561012, "node_id": "IC_kwDOBLftOs5cevE0", "user": { "login": "marph91", "id": 33229141, "node_id": "MDQ6VXNlcjMzMjI5MTQx", "avatar_url": "https://avatars.githubusercontent.com/u/33229141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marph91", "html_url": "https://github.com/marph91", "followers_url": "https://api.github.com/users/marph91/followers", "following_url": "https://api.github.com/users/marph91/following{/other_user}", "gists_url": "https://api.github.com/users/marph91/gists{/gist_id}", "starred_url": "https://api.github.com/users/marph91/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marph91/subscriptions", "organizations_url": "https://api.github.com/users/marph91/orgs", "repos_url": "https://api.github.com/users/marph91/repos", "events_url": "https://api.github.com/users/marph91/events{/privacy}", "received_events_url": "https://api.github.com/users/marph91/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T15:00:17Z", "updated_at": "2023-05-17T15:00:17Z", "author_association": "CONTRIBUTOR", "body": "I added the missing functions to the table toolbar. Some were removed, because they were non-functional or duplicated. This is how it looks now:\r\n\r\n![Screenshot_20230516_182656](https://github.com/laurent22/joplin/assets/33229141/2f51ad93-95c2-4746-bbe2-74072bdca5fc)\r\n\r\nThis allows for example easy copy pasting of rows/columns by only three clicks.\r\n\r\nTypes should be complete now, too.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1551561012/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1585716658", "html_url": "https://github.com/laurent22/joplin/pull/8163#issuecomment-1585716658", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8163", "id": 1585716658, "node_id": "IC_kwDOBLftOs5ehB2y", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-10T16:08:31Z", "updated_at": "2023-06-10T16:08:31Z", "author_association": "OWNER", "body": "Thanks for implementing this @marph91!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1585716658/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }