{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12055", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/events", "html_url": "https://github.com/laurent22/joplin/pull/12055", "id": 2973537834, "node_id": "PR_kwDOBLftOs6ReC9_", "number": 12055, "title": "Desktop: Fixes #9588: Removed download button on mermaid diagrams in rich text editor", "user": { "login": "outrodani", "id": 134531018, "node_id": "U_kgDOCATHyg", "avatar_url": "https://avatars.githubusercontent.com/u/134531018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/outrodani", "html_url": "https://github.com/outrodani", "followers_url": "https://api.github.com/users/outrodani/followers", "following_url": "https://api.github.com/users/outrodani/following{/other_user}", "gists_url": "https://api.github.com/users/outrodani/gists{/gist_id}", "starred_url": "https://api.github.com/users/outrodani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/outrodani/subscriptions", "organizations_url": "https://api.github.com/users/outrodani/orgs", "repos_url": "https://api.github.com/users/outrodani/repos", "events_url": "https://api.github.com/users/outrodani/events{/privacy}", "received_events_url": "https://api.github.com/users/outrodani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2025-04-04T23:21:31Z", "updated_at": "2025-04-15T11:42:06Z", "closed_at": null, "author_association": "FIRST_TIMER", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/12055", "html_url": "https://github.com/laurent22/joplin/pull/12055", "diff_url": "https://github.com/laurent22/joplin/pull/12055.diff", "patch_url": "https://github.com/laurent22/joplin/pull/12055.patch", "merged_at": null }, "body": "This PR fixes #9588 by removing the download button while hovering over a mermaid diagram in the rich text editor.\r\n\r\nI simply added a verification that checks if the tox-tinymce class is used. If that is the case, the exportButtonMarkup constant will simply be an empty string, resulting in the download button not being visible. Since this class is only found in the rich text editor, the download button will remain visible and functional in the markdown editor.\r\n\r\nhttps://github.com/user-attachments/assets/697115a4-f4de-4295-9b14-77726b48bfb0", "closed_by": null, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12055/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12055/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892283", "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2779892283", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", "id": 2779892283, "node_id": "IC_kwDOBLftOs6lsco7", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-04T23:21:43Z", "updated_at": "2025-04-11T18:02:35Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892283/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892643", "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2779892643", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", "id": 2779892643, "node_id": "IC_kwDOBLftOs6lscuj", "user": { "login": "outrodani", "id": 134531018, "node_id": "U_kgDOCATHyg", "avatar_url": "https://avatars.githubusercontent.com/u/134531018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/outrodani", "html_url": "https://github.com/outrodani", "followers_url": "https://api.github.com/users/outrodani/followers", "following_url": "https://api.github.com/users/outrodani/following{/other_user}", "gists_url": "https://api.github.com/users/outrodani/gists{/gist_id}", "starred_url": "https://api.github.com/users/outrodani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/outrodani/subscriptions", "organizations_url": "https://api.github.com/users/outrodani/orgs", "repos_url": "https://api.github.com/users/outrodani/repos", "events_url": "https://api.github.com/users/outrodani/events{/privacy}", "received_events_url": "https://api.github.com/users/outrodani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-04T23:22:07Z", "updated_at": "2025-04-04T23:22:07Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2779892643/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784335330", "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2784335330", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", "id": 2784335330, "node_id": "IC_kwDOBLftOs6l9ZXi", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-07T19:14:01Z", "updated_at": "2025-04-07T19:14:01Z", "author_association": "COLLABORATOR", "body": "Thank you for working on this!\r\n\r\nFor reference, I'm linking to [a commit that takes an alternate approach that *might* fix this](https://github.com/personalizedrefrigerator/joplin/commit/3cffd0c55dc62a9298cd9276a18e5595accf5b47) if we do eventually want to support the download button in the Rich Text Editor. (If I recall correctly, there was an issue with the linked commit (e.g. right-click menus opened with the keyboard didn't work?)).", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784335330/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2798086048", "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2798086048", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", "id": 2798086048, "node_id": "IC_kwDOBLftOs6mx2eg", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-11T22:03:44Z", "updated_at": "2025-04-11T22:03:44Z", "author_association": "COLLABORATOR", "body": "**Note**: #9588 should now be partially fixed by https://github.com/laurent22/joplin/pull/12076 (the download button now shows a menu, but it doesn't have download options).", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2798086048/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2804763543", "html_url": "https://github.com/laurent22/joplin/pull/12055#issuecomment-2804763543", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12055", "id": 2804763543, "node_id": "IC_kwDOBLftOs6nLUuX", "user": { "login": "outrodani", "id": 134531018, "node_id": "U_kgDOCATHyg", "avatar_url": "https://avatars.githubusercontent.com/u/134531018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/outrodani", "html_url": "https://github.com/outrodani", "followers_url": "https://api.github.com/users/outrodani/followers", "following_url": "https://api.github.com/users/outrodani/following{/other_user}", "gists_url": "https://api.github.com/users/outrodani/gists{/gist_id}", "starred_url": "https://api.github.com/users/outrodani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/outrodani/subscriptions", "organizations_url": "https://api.github.com/users/outrodani/orgs", "repos_url": "https://api.github.com/users/outrodani/repos", "events_url": "https://api.github.com/users/outrodani/events{/privacy}", "received_events_url": "https://api.github.com/users/outrodani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-15T11:42:05Z", "updated_at": "2025-04-15T11:42:05Z", "author_association": "NONE", "body": "The purpose of this PR was to remove the download button because it wasn't functional. However, now that it does show a menu (even if without download options), is there still a reason to remove the button?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2804763543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }