{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14774/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14774/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14774/events", "html_url": "https://github.com/laurent22/joplin/pull/14774", "id": 4084013023, "node_id": "PR_kwDOBLftOs7LAAu5", "number": 14774, "title": "Desktop: Resolves #13896 : Dragging-and-dropping an image within a Joplin note t…", "user": { "login": "p1961999", "id": 51691915, "node_id": "MDQ6VXNlcjUxNjkxOTE1", "avatar_url": "https://avatars.githubusercontent.com/u/51691915?v=4", "gravatar_id": "", "url": "https://api.github.com/users/p1961999", "html_url": "https://github.com/p1961999", "followers_url": "https://api.github.com/users/p1961999/followers", "following_url": "https://api.github.com/users/p1961999/following{/other_user}", "gists_url": "https://api.github.com/users/p1961999/gists{/gist_id}", "starred_url": "https://api.github.com/users/p1961999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/p1961999/subscriptions", "organizations_url": "https://api.github.com/users/p1961999/orgs", "repos_url": "https://api.github.com/users/p1961999/repos", "events_url": "https://api.github.com/users/p1961999/events{/privacy}", "received_events_url": "https://api.github.com/users/p1961999/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" }, { "id": 1366672371, "node_id": "MDU6TGFiZWwxMzY2NjcyMzcx", "url": "https://api.github.com/repos/laurent22/joplin/labels/editor", "name": "editor", "color": "91ca55", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 7, "created_at": "2026-03-16T18:10:45Z", "updated_at": "2026-03-23T12:45:14Z", "closed_at": "2026-03-23T12:13:50Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14774", "html_url": "https://github.com/laurent22/joplin/pull/14774", "diff_url": "https://github.com/laurent22/joplin/pull/14774.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14774.patch", "merged_at": null }, "body": "Fixes #13896.\r\n\r\nThis PR handles internal image drag-and-drop in the Rich Text editor separately from generic drop handling.\r\n\r\nPreviously, dragging an image within a note could be treated as a regular HTML/file drop by TinyMCE, which could insert incorrect dropped content instead of moving only the image element.\r\n\r\n## Changes\r\n\r\n- Detect internal image drags in TinyMCE\r\n- Prevent default TinyMCE drop handling for internal image moves\r\n- Move only the dragged image element instead of using the dropped HTML fragment\r\n- Clean up empty parent elements left behind after moving the image\r\n- Add an undo step for the manual move operation\r\n\r\n## Testing\r\n\r\nTested manually by:\r\n\r\n- dragging an image within normal paragraph text\r\n- dragging an image from a heading into paragraph text\r\n- verifying the image is moved instead of duplicated\r\n- verifying unwanted wrapper formatting is not inserted\r\n- verifying undo works correctly\r\n\r\n\r\nvideo demonstration for above issue.\r\n\r\nhttps://github.com/user-attachments/assets/2ff84224-8bbf-4382-976b-9cc7d72b3b7a\r\n\r\nthe above video bug resolved\r\n\r\nhttps://github.com/user-attachments/assets/ba6d83c6-3c69-4c0d-9623-6c80e77ce1f3", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14774/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14774/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4069644831", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4069644831", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4069644831, "node_id": "IC_kwDOBLftOs7ykdof", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-16T18:11:14Z", "updated_at": "2026-03-17T08:14:49Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nAdds internal tracking of images dragged inside the TinyMCE editor and special-case drop handling: when an internally dragged IMG is dropped, its saved HTML is inserted at the drop point, the original is removed, caret restored, and Joplin change/undo events are triggered to avoid base64 pasting.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Image drag-and-drop handling**
`packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/TinyMCE.tsx`|Adds `internalDraggedImageRef` and `internalDraggedImageHtmlRef`; registers editor `dragstart`/`dragend` handlers to capture IMG elements; enhances `drop` handling to insert saved image HTML at drop location, remove original node (and empty wrappers), restore caret, and trigger Joplin change + undo step. Removes a ScrollIntoView override and related comments; preserves previous `props_onDrop` fallback when no internal image is detected.|\n\n## Sequence Diagram(s)\n\n```mermaid\nsequenceDiagram\n participant User\n participant TinyMCE as TinyMCE Editor\n participant DOM\n participant Joplin as Joplin Core\n\n User->>TinyMCE: dragstart on IMG\n TinyMCE->>TinyMCE: save IMG element & HTML (refs)\n User->>TinyMCE: drop at location\n TinyMCE->>TinyMCE: detect internalDraggedImageRef\n TinyMCE->>DOM: insert saved image HTML at drop point\n TinyMCE->>DOM: remove original IMG and empty wrapper if present\n TinyMCE->>TinyMCE: restore caret position\n TinyMCE->>Joplin: emit change event with undo step\n TinyMCE-->>User: drop handled (prevent default)\n```\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 6\n\n
\n✅ Passed checks (6 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Description check | ✅ Passed | The description comprehensively explains the problem, the changes made, and testing performed, all of which align with the changeset for handling internal image drag-and-drop in TinyMCE. |\n| Linked Issues check | ✅ Passed | The changes successfully implement the solution to issue `#13896` by detecting internal image drags, preventing default drop handling for internal moves, and moving only the dragged image element rather than pasting base64-encoded data. |\n| Out of Scope Changes check | ✅ Passed | All changes are scoped to the TinyMCE editor's drag-and-drop handling for internal images, directly addressing the linked issue without introducing unrelated modifications. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The PR description adequately fulfils all three required sections: problem (base64 encoding issue from `#13896`), high-level solution (separate TinyMCE image drag handling), and test plan (manual verification of drag scenarios). |\n| Title check | ✅ Passed | The title clearly and specifically describes the main change: fixing issue `#13896` regarding drag-and-drop functionality for images within Joplin notes, which aligns with the primary purpose of the changeset. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n\n
\n\n
\n\n\n\n\n\n
\n📝 Coding Plan\n\n- [ ] Generate coding plan for human review comments\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14774)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4069644831/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4069771061", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4069771061", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4069771061, "node_id": "IC_kwDOBLftOs7yk8c1", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-16T18:34:27Z", "updated_at": "2026-03-17T07:52:35Z", "body": "**CLA Assistant Lite bot:**
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **1** out of **2** committers have signed the CLA.
:white_check_mark: (p1961999)[https://github.com/p1961999]
:x: @Prachi Gupta
**Prachi Gupta** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).
You can retrigger this bot by commenting **recheck** in this Pull Request", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4069771061/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4073025924", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4073025924", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4073025924, "node_id": "IC_kwDOBLftOs7yxXGE", "user": { "login": "p1961999", "id": 51691915, "node_id": "MDQ6VXNlcjUxNjkxOTE1", "avatar_url": "https://avatars.githubusercontent.com/u/51691915?v=4", "gravatar_id": "", "url": "https://api.github.com/users/p1961999", "html_url": "https://github.com/p1961999", "followers_url": "https://api.github.com/users/p1961999/followers", "following_url": "https://api.github.com/users/p1961999/following{/other_user}", "gists_url": "https://api.github.com/users/p1961999/gists{/gist_id}", "starred_url": "https://api.github.com/users/p1961999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/p1961999/subscriptions", "organizations_url": "https://api.github.com/users/p1961999/orgs", "repos_url": "https://api.github.com/users/p1961999/repos", "events_url": "https://api.github.com/users/p1961999/events{/privacy}", "received_events_url": "https://api.github.com/users/p1961999/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-17T07:52:23Z", "updated_at": "2026-03-17T07:52:23Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4073025924/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4096855031", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4096855031", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4096855031, "node_id": "IC_kwDOBLftOs70MQv3", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-20T09:37:08Z", "updated_at": "2026-03-20T09:37:08Z", "body": "As per the guidelines, please post a video of the bug being replicated before the change, and a video of it being fixed after the change.", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4096855031/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4100540465", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4100540465", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4100540465, "node_id": "IC_kwDOBLftOs70aUgx", "user": { "login": "p1961999", "id": 51691915, "node_id": "MDQ6VXNlcjUxNjkxOTE1", "avatar_url": "https://avatars.githubusercontent.com/u/51691915?v=4", "gravatar_id": "", "url": "https://api.github.com/users/p1961999", "html_url": "https://github.com/p1961999", "followers_url": "https://api.github.com/users/p1961999/followers", "following_url": "https://api.github.com/users/p1961999/following{/other_user}", "gists_url": "https://api.github.com/users/p1961999/gists{/gist_id}", "starred_url": "https://api.github.com/users/p1961999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/p1961999/subscriptions", "organizations_url": "https://api.github.com/users/p1961999/orgs", "repos_url": "https://api.github.com/users/p1961999/repos", "events_url": "https://api.github.com/users/p1961999/events{/privacy}", "received_events_url": "https://api.github.com/users/p1961999/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-20T19:34:47Z", "updated_at": "2026-03-20T19:34:47Z", "body": "sure...i'll update", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4100540465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4110175035", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4110175035", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4110175035, "node_id": "IC_kwDOBLftOs70_Es7", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-23T12:13:50Z", "updated_at": "2026-03-23T12:13:50Z", "body": "Please let me know when it's done and I'll reopen the PR. As we have a large backlog we're trying to keep it manageable", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4110175035/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4110352513", "html_url": "https://github.com/laurent22/joplin/pull/14774#issuecomment-4110352513", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14774", "id": 4110352513, "node_id": "IC_kwDOBLftOs70_wCB", "user": { "login": "p1961999", "id": 51691915, "node_id": "MDQ6VXNlcjUxNjkxOTE1", "avatar_url": "https://avatars.githubusercontent.com/u/51691915?v=4", "gravatar_id": "", "url": "https://api.github.com/users/p1961999", "html_url": "https://github.com/p1961999", "followers_url": "https://api.github.com/users/p1961999/followers", "following_url": "https://api.github.com/users/p1961999/following{/other_user}", "gists_url": "https://api.github.com/users/p1961999/gists{/gist_id}", "starred_url": "https://api.github.com/users/p1961999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/p1961999/subscriptions", "organizations_url": "https://api.github.com/users/p1961999/orgs", "repos_url": "https://api.github.com/users/p1961999/repos", "events_url": "https://api.github.com/users/p1961999/events{/privacy}", "received_events_url": "https://api.github.com/users/p1961999/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-23T12:45:14Z", "updated_at": "2026-03-23T12:45:14Z", "body": "done...you can check", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4110352513/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }