{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/events", "html_url": "https://github.com/laurent22/joplin/pull/11857", "id": 2861576373, "node_id": "PR_kwDOBLftOs6LqJRh", "number": 11857, "title": "Desktop, Mobile: Fixes #11845: Fixes issues with converting nested lists between bullet and numbered.", "user": { "login": "rabbabansh", "id": 31804810, "node_id": "MDQ6VXNlcjMxODA0ODEw", "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rabbabansh", "html_url": "https://github.com/rabbabansh", "followers_url": "https://api.github.com/users/rabbabansh/followers", "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", "organizations_url": "https://api.github.com/users/rabbabansh/orgs", "repos_url": "https://api.github.com/users/rabbabansh/repos", "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", "received_events_url": "https://api.github.com/users/rabbabansh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 13, "created_at": "2025-02-18T20:32:05Z", "updated_at": "2025-03-27T14:29:38Z", "closed_at": "2025-03-27T14:29:14Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11857", "html_url": "https://github.com/laurent22/joplin/pull/11857", "diff_url": "https://github.com/laurent22/joplin/pull/11857.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11857.patch", "merged_at": null }, "body": "\r\n\r\nFixes #11845 now, this\"\r\n\r\n- test\r\n - test\r\n - test\r\n- test\r\n\r\nconverts to:\r\n\r\n![Image](https://github.com/user-attachments/assets/a67555fa-d146-40cb-a003-b41b32266f14)\r\n\r\nChecklists also convert nested lists fully, rather than just converting the first indent to checklists.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11857/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11857/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666870893", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2666870893", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2666870893, "node_id": "IC_kwDOBLftOs6e9Tht", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-18T20:32:22Z", "updated_at": "2025-03-27T14:29:37Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666870893/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666874335", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2666874335", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2666874335, "node_id": "IC_kwDOBLftOs6e9UXf", "user": { "login": "rabbabansh", "id": 31804810, "node_id": "MDQ6VXNlcjMxODA0ODEw", "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rabbabansh", "html_url": "https://github.com/rabbabansh", "followers_url": "https://api.github.com/users/rabbabansh/followers", "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", "organizations_url": "https://api.github.com/users/rabbabansh/orgs", "repos_url": "https://api.github.com/users/rabbabansh/repos", "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", "received_events_url": "https://api.github.com/users/rabbabansh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-18T20:34:26Z", "updated_at": "2025-02-18T20:34:26Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2666874335/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669245353", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2669245353", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2669245353, "node_id": "IC_kwDOBLftOs6fGXOp", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-19T17:04:32Z", "updated_at": "2025-02-19T17:04:32Z", "author_association": "COLLABORATOR", "body": "Thank you for working on this! Be sure to also update the automated tests in `packages/editor/` with the expected output.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2669245353/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686501181", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2686501181", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2686501181, "node_id": "IC_kwDOBLftOs6gIME9", "user": { "login": "rabbabansh", "id": 31804810, "node_id": "MDQ6VXNlcjMxODA0ODEw", "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rabbabansh", "html_url": "https://github.com/rabbabansh", "followers_url": "https://api.github.com/users/rabbabansh/followers", "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", "organizations_url": "https://api.github.com/users/rabbabansh/orgs", "repos_url": "https://api.github.com/users/rabbabansh/repos", "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", "received_events_url": "https://api.github.com/users/rabbabansh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-27T00:21:46Z", "updated_at": "2025-02-27T00:21:46Z", "author_association": "NONE", "body": "Done! Please review", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686501181/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686740124", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2686740124", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2686740124, "node_id": "IC_kwDOBLftOs6gJGac", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-27T03:08:09Z", "updated_at": "2025-02-27T03:08:09Z", "author_association": "COLLABORATOR", "body": "Thank you! Be sure to update the existing tests, too — one is failing:\r\n```\r\n➤ YN0000: [@joplin/editor]: FAIL CodeMirror/markdown/markdownCommands.toggleList.test.ts\r\n➤ YN0000: [@joplin/editor]: ● markdownCommands.toggleList › should toggle a numbered list without changing its sublists\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: expect(received).toBe(expected) // Object.is equality\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: - Expected - 3\r\n➤ YN0000: [@joplin/editor]: + Received + 3\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: - [ ] Foo\r\n➤ YN0000: [@joplin/editor]: - [ ] Bar\r\n➤ YN0000: [@joplin/editor]: - [ ] Baz\r\n➤ YN0000: [@joplin/editor]: - \t- Test\r\n➤ YN0000: [@joplin/editor]: + \t- [ ] Test\r\n➤ YN0000: [@joplin/editor]: - \t- of\r\n➤ YN0000: [@joplin/editor]: + \t- [ ] of\r\n➤ YN0000: [@joplin/editor]: - \t- sublists\r\n➤ YN0000: [@joplin/editor]: + \t- [ ] sublists\r\n➤ YN0000: [@joplin/editor]: - [ ] Foo\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: 191 |\r\n➤ YN0000: [@joplin/editor]: 192 | \t\ttoggleList(ListType.CheckList)(editor);\r\n➤ YN0000: [@joplin/editor]: > 193 | \t\texpect(editor.state.doc.toString()).toBe(\r\n➤ YN0000: [@joplin/editor]: | \t\t ^\r\n➤ YN0000: [@joplin/editor]: 194 | \t\t\t'- [ ] Foo\\n- [ ] Bar\\n- [ ] Baz\\n\\t- Test\\n\\t- of\\n\\t- sublists\\n- [ ] Foo',\r\n➤ YN0000: [@joplin/editor]: 195 | \t\t);\r\n➤ YN0000: [@joplin/editor]: 196 | \t});\r\n➤ YN0000: [@joplin/editor]: \r\n➤ YN0000: [@joplin/editor]: at Object. (CodeMirror/markdown/markdownCommands.toggleList.test.ts:193:39)\r\n```", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2686740124/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2687865469", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2687865469", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2687865469, "node_id": "IC_kwDOBLftOs6gNZJ9", "user": { "login": "rabbabansh", "id": 31804810, "node_id": "MDQ6VXNlcjMxODA0ODEw", "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rabbabansh", "html_url": "https://github.com/rabbabansh", "followers_url": "https://api.github.com/users/rabbabansh/followers", "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", "organizations_url": "https://api.github.com/users/rabbabansh/orgs", "repos_url": "https://api.github.com/users/rabbabansh/repos", "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", "received_events_url": "https://api.github.com/users/rabbabansh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-27T12:47:44Z", "updated_at": "2025-02-27T12:47:44Z", "author_association": "NONE", "body": "That tests passes now! I rewrote the expected results for a nested checklist that gives checklists to the sublists as well.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2687865469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688789478", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2688789478", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2688789478, "node_id": "IC_kwDOBLftOs6gQ6vm", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-02-27T18:35:09Z", "updated_at": "2025-02-27T18:35:09Z", "author_association": "OWNER", "body": "@personalizedrefrigerator, please let me know when you think it's ready to merge, as I don't know enough about the CM6 implementation to review", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2688789478/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692729176", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2692729176", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2692729176, "node_id": "IC_kwDOBLftOs6gf8lY", "user": { "login": "rabbabansh", "id": 31804810, "node_id": "MDQ6VXNlcjMxODA0ODEw", "avatar_url": "https://avatars.githubusercontent.com/u/31804810?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rabbabansh", "html_url": "https://github.com/rabbabansh", "followers_url": "https://api.github.com/users/rabbabansh/followers", "following_url": "https://api.github.com/users/rabbabansh/following{/other_user}", "gists_url": "https://api.github.com/users/rabbabansh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rabbabansh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabbabansh/subscriptions", "organizations_url": "https://api.github.com/users/rabbabansh/orgs", "repos_url": "https://api.github.com/users/rabbabansh/repos", "events_url": "https://api.github.com/users/rabbabansh/events{/privacy}", "received_events_url": "https://api.github.com/users/rabbabansh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-02T13:18:51Z", "updated_at": "2025-03-02T13:18:51Z", "author_association": "NONE", "body": "any updates @personalizedrefrigerator ?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692729176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692857697", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2692857697", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2692857697, "node_id": "IC_kwDOBLftOs6ggb9h", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-02T18:53:16Z", "updated_at": "2025-03-02T18:53:16Z", "author_association": "COLLABORATOR", "body": "> any updates @personalizedrefrigerator ?\r\n\r\nThe code looks good to me! I plan to test the change locally before approving the pull request.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2692857697/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695783056", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2695783056", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2695783056, "node_id": "IC_kwDOBLftOs6grmKQ", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-03T23:16:03Z", "updated_at": "2025-03-03T23:17:10Z", "author_association": "COLLABORATOR", "body": "I've tested this locally. I've noticed that changing the list type with the cursor anywhere in the toplevel list (with an empty selection) changes the list types of all sublists. The description of #11845 includes only the case where all text is selected.\r\n - **Note**: This is different from how Joplin's Rich Text Editor behaves and thus may not be desired behavior (but to be confirmed by @laurent22). For comparison, moving the cursor to a bulleted list in the Rich Text Editor with bulleted sublists, then clicking \"numbered list\" only changes the outer list.\r\n - For example, with this pull request clicking \"numbered list\" with the following\r\n ```\r\n - This is a test. Cursor here ->> |\r\n - Sublist\r\n - Sub sublist.\r\n - Testing\r\n - Test.\r\n ```\r\n produces\r\n ```\r\n 1. This is a test. Cursor here ->> |\r\n 1. Sublist\r\n 1. Sub sublist.\r\n 2. Testing\r\n 3. Test.\r\n ```\r\n Whereas in the Rich Text Editor, it would preserve the bulleted sublists.\r\n\r\nThank you @rabbabansh for the work you've done on this so far!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2695783056/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2708236936", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2708236936", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2708236936, "node_id": "IC_kwDOBLftOs6hbGqI", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-08T12:13:42Z", "updated_at": "2025-03-08T12:13:42Z", "author_association": "OWNER", "body": "Not sure what's best here? What do other editors do in this situation?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2708236936/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2727304447", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2727304447", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2727304447, "node_id": "IC_kwDOBLftOs6ij1z_", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-16T09:51:06Z", "updated_at": "2025-03-16T09:51:06Z", "author_association": "OWNER", "body": "> Note: This is different from how Joplin's Rich Text Editor behaves and thus may not be desired behavior (but to be confirmed by @laurent22). For comparison, moving the cursor to a bulleted list in the Rich Text Editor with bulleted sublists, then clicking \"numbered list\" only changes the outer list.\r\n\r\nI agree that's not ideal. I think as a general rule we should limit all kind of \"smart\" behaviour when it comes to lists so in this case it should:\r\n\r\n- Either changes only what's selected\r\n- Or if nothing is selected it should just change the current line\r\n\r\nAnything else may or may not be what the user wants and we should avoid that. I'd rather have the editor be more plain but with a predictable behaviour.\r\n\r\n@rabbabansh, are you able to complete this pull request?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2727304447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758269361", "html_url": "https://github.com/laurent22/joplin/pull/11857#issuecomment-2758269361", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11857", "id": 2758269361, "node_id": "IC_kwDOBLftOs6kZ9mx", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-27T14:29:15Z", "updated_at": "2025-03-27T14:29:15Z", "author_association": "OWNER", "body": "Closing stale pull request", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2758269361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }