{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7815", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7815/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7815/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7815/events", "html_url": "https://github.com/laurent22/joplin/pull/7815", "id": 1593298475, "node_id": "PR_kwDOBLftOs5Ka5VK", "number": 7815, "title": "Include strikethrough in Markdown Guide", "user": { "login": "rddunphy", "id": 10012625, "node_id": "MDQ6VXNlcjEwMDEyNjI1", "avatar_url": "https://avatars.githubusercontent.com/u/10012625?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rddunphy", "html_url": "https://github.com/rddunphy", "followers_url": "https://api.github.com/users/rddunphy/followers", "following_url": "https://api.github.com/users/rddunphy/following{/other_user}", "gists_url": "https://api.github.com/users/rddunphy/gists{/gist_id}", "starred_url": "https://api.github.com/users/rddunphy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rddunphy/subscriptions", "organizations_url": "https://api.github.com/users/rddunphy/orgs", "repos_url": "https://api.github.com/users/rddunphy/repos", "events_url": "https://api.github.com/users/rddunphy/events{/privacy}", "received_events_url": "https://api.github.com/users/rddunphy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2023-02-21T11:19:30Z", "updated_at": "2023-02-21T14:23:45Z", "closed_at": "2023-02-21T14:23:32Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7815", "html_url": "https://github.com/laurent22/joplin/pull/7815", "diff_url": "https://github.com/laurent22/joplin/pull/7815.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7815.patch", "merged_at": null }, "body": "As discussed in this [Forum post](https://discourse.joplinapp.org/t/strikethrough-not-supported/9655), the Markdown Guide incorrectly says that ~~strikethrough~~ is not supported. This PR adds it to the cheat sheet section, and changes the HTML support example to something that can't be achieved with regular markdown.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7815/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7815/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438307952", "html_url": "https://github.com/laurent22/joplin/pull/7815#issuecomment-1438307952", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7815", "id": 1438307952, "node_id": "IC_kwDOBLftOs5VutZw", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-21T11:19:47Z", "updated_at": "2023-02-21T11:22:47Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438307952/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438310871", "html_url": "https://github.com/laurent22/joplin/pull/7815#issuecomment-1438310871", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7815", "id": 1438310871, "node_id": "IC_kwDOBLftOs5VuuHX", "user": { "login": "rddunphy", "id": 10012625, "node_id": "MDQ6VXNlcjEwMDEyNjI1", "avatar_url": "https://avatars.githubusercontent.com/u/10012625?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rddunphy", "html_url": "https://github.com/rddunphy", "followers_url": "https://api.github.com/users/rddunphy/followers", "following_url": "https://api.github.com/users/rddunphy/following{/other_user}", "gists_url": "https://api.github.com/users/rddunphy/gists{/gist_id}", "starred_url": "https://api.github.com/users/rddunphy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rddunphy/subscriptions", "organizations_url": "https://api.github.com/users/rddunphy/orgs", "repos_url": "https://api.github.com/users/rddunphy/repos", "events_url": "https://api.github.com/users/rddunphy/events{/privacy}", "received_events_url": "https://api.github.com/users/rddunphy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-21T11:22:11Z", "updated_at": "2023-02-21T11:22:11Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438310871/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438578746", "html_url": "https://github.com/laurent22/joplin/pull/7815#issuecomment-1438578746", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7815", "id": 1438578746, "node_id": "IC_kwDOBLftOs5Vvvg6", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-21T14:23:32Z", "updated_at": "2023-02-21T14:23:32Z", "author_association": "OWNER", "body": "Thanks for the PR, but although it works it's not CommonMark, so I'd rather not document it", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1438578746/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }