{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8249/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8249/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8249/events", "html_url": "https://github.com/laurent22/joplin/pull/8249", "id": 1729139706, "node_id": "PR_kwDOBLftOs5RhUor", "number": 8249, "title": "Desktop: Fixes #8159: Set minimum search/sort bar width", "user": { "login": "rio-codes", "id": 791713, "node_id": "MDQ6VXNlcjc5MTcxMw==", "avatar_url": "https://avatars.githubusercontent.com/u/791713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rio-codes", "html_url": "https://github.com/rio-codes", "followers_url": "https://api.github.com/users/rio-codes/followers", "following_url": "https://api.github.com/users/rio-codes/following{/other_user}", "gists_url": "https://api.github.com/users/rio-codes/gists{/gist_id}", "starred_url": "https://api.github.com/users/rio-codes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rio-codes/subscriptions", "organizations_url": "https://api.github.com/users/rio-codes/orgs", "repos_url": "https://api.github.com/users/rio-codes/repos", "events_url": "https://api.github.com/users/rio-codes/events{/privacy}", "received_events_url": "https://api.github.com/users/rio-codes/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 10, "created_at": "2023-05-28T03:49:58Z", "updated_at": "2023-06-05T17:22:47Z", "closed_at": "2023-06-05T17:22:32Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8249", "html_url": "https://github.com/laurent22/joplin/pull/8249", "diff_url": "https://github.com/laurent22/joplin/pull/8249.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8249.patch", "merged_at": "2023-06-05T17:22:32Z" }, "body": "### Problem:\r\nWhen changing the note list panel to a certain width, the search bar becomes so small that it is unusable before flowing to the next line.\r\n\r\n### Solution:\r\nChange the flex-basis CSS property of the first-row search and sort bar to 60%, rather than auto. This ensures that the search bar will never become too small.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8249/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1565848926", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1565848926", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1565848926, "node_id": "IC_kwDOBLftOs5dVPVe", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-28T03:50:13Z", "updated_at": "2023-05-29T17:31:52Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1565848926/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1565852074", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1565852074", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1565852074, "node_id": "IC_kwDOBLftOs5dVQGq", "user": { "login": "rio-codes", "id": 791713, "node_id": "MDQ6VXNlcjc5MTcxMw==", "avatar_url": "https://avatars.githubusercontent.com/u/791713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rio-codes", "html_url": "https://github.com/rio-codes", "followers_url": "https://api.github.com/users/rio-codes/followers", "following_url": "https://api.github.com/users/rio-codes/following{/other_user}", "gists_url": "https://api.github.com/users/rio-codes/gists{/gist_id}", "starred_url": "https://api.github.com/users/rio-codes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rio-codes/subscriptions", "organizations_url": "https://api.github.com/users/rio-codes/orgs", "repos_url": "https://api.github.com/users/rio-codes/repos", "events_url": "https://api.github.com/users/rio-codes/events{/privacy}", "received_events_url": "https://api.github.com/users/rio-codes/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-28T03:55:09Z", "updated_at": "2023-05-28T03:55:09Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1565852074/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566896755", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1566896755", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1566896755, "node_id": "IC_kwDOBLftOs5dZPJz", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T10:09:28Z", "updated_at": "2023-05-29T10:09:28Z", "author_association": "OWNER", "body": "That's a good start, but it needs to work with all languages, and for example it doesn't with French:\r\n\r\n\"image\"\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566896755/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567278047", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1567278047", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1567278047, "node_id": "IC_kwDOBLftOs5dasPf", "user": { "login": "tomasz1986", "id": 5626656, "node_id": "MDQ6VXNlcjU2MjY2NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/5626656?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tomasz1986", "html_url": "https://github.com/tomasz1986", "followers_url": "https://api.github.com/users/tomasz1986/followers", "following_url": "https://api.github.com/users/tomasz1986/following{/other_user}", "gists_url": "https://api.github.com/users/tomasz1986/gists{/gist_id}", "starred_url": "https://api.github.com/users/tomasz1986/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tomasz1986/subscriptions", "organizations_url": "https://api.github.com/users/tomasz1986/orgs", "repos_url": "https://api.github.com/users/tomasz1986/repos", "events_url": "https://api.github.com/users/tomasz1986/events{/privacy}", "received_events_url": "https://api.github.com/users/tomasz1986/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T15:29:47Z", "updated_at": "2023-05-29T15:29:47Z", "author_association": "NONE", "body": "Can you include a screenshot of how this looks when using a different layout, e.g. note list on top?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567278047/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567327334", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1567327334", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1567327334, "node_id": "IC_kwDOBLftOs5da4Rm", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T16:26:28Z", "updated_at": "2023-05-29T16:26:28Z", "author_association": "OWNER", "body": "Yes please provide a video. I've just spent 10 minutes testing this and I see no differences. As far as I can see \"Md\" is not even a valid property so your code is ignored and it reverts back to the previous behaviour.\r\n\r\nIs this pull request for GSoC or other open source program?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567327334/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567353591", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1567353591", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1567353591, "node_id": "IC_kwDOBLftOs5da-r3", "user": { "login": "rio-codes", "id": 791713, "node_id": "MDQ6VXNlcjc5MTcxMw==", "avatar_url": "https://avatars.githubusercontent.com/u/791713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rio-codes", "html_url": "https://github.com/rio-codes", "followers_url": "https://api.github.com/users/rio-codes/followers", "following_url": "https://api.github.com/users/rio-codes/following{/other_user}", "gists_url": "https://api.github.com/users/rio-codes/gists{/gist_id}", "starred_url": "https://api.github.com/users/rio-codes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rio-codes/subscriptions", "organizations_url": "https://api.github.com/users/rio-codes/orgs", "repos_url": "https://api.github.com/users/rio-codes/repos", "events_url": "https://api.github.com/users/rio-codes/events{/privacy}", "received_events_url": "https://api.github.com/users/rio-codes/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T17:04:44Z", "updated_at": "2023-05-29T17:04:44Z", "author_association": "CONTRIBUTOR", "body": "Yes, I just noticed that Md does not work, I'm so sorry about that. Setting it to 50% rather than 60% seems to do the trick though.\r\n\r\n## Issue behavior\r\n\r\n![issue_behavior](https://github.com/laurent22/joplin/assets/791713/15cd3033-3567-4627-ae7b-14184452c295)\r\n\r\n## Fixed behavior - English\r\n\r\n![fiixed_behavior_english](https://github.com/laurent22/joplin/assets/791713/7332167e-9075-41e4-abab-17194d4ba62d)\r\n\r\n## Fixed behavior - French\r\n\r\n![fiixed_behavior_french](https://github.com/laurent22/joplin/assets/791713/ac897d8d-c784-4ebb-8675-d0e921434627)\r\n\r\nI'm sorry you wasted your time testing it, I was in the process of fixing it and recording gifs. I can submit another commit. This is not for any program, I am just new to contributing. Thanks for your patience with me.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567353591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567357981", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1567357981", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1567357981, "node_id": "IC_kwDOBLftOs5da_wd", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T17:09:27Z", "updated_at": "2023-05-29T17:09:27Z", "author_association": "OWNER", "body": "No problem, and thanks for recording the videos. It indeed looks better and as long as it looks good on the most common languages (those with higher % of translation) that should be fine.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567357981/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567373645", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1567373645", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1567373645, "node_id": "IC_kwDOBLftOs5dbDlN", "user": { "login": "rio-codes", "id": 791713, "node_id": "MDQ6VXNlcjc5MTcxMw==", "avatar_url": "https://avatars.githubusercontent.com/u/791713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rio-codes", "html_url": "https://github.com/rio-codes", "followers_url": "https://api.github.com/users/rio-codes/followers", "following_url": "https://api.github.com/users/rio-codes/following{/other_user}", "gists_url": "https://api.github.com/users/rio-codes/gists{/gist_id}", "starred_url": "https://api.github.com/users/rio-codes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rio-codes/subscriptions", "organizations_url": "https://api.github.com/users/rio-codes/orgs", "repos_url": "https://api.github.com/users/rio-codes/repos", "events_url": "https://api.github.com/users/rio-codes/events{/privacy}", "received_events_url": "https://api.github.com/users/rio-codes/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T17:33:44Z", "updated_at": "2023-05-29T17:33:44Z", "author_association": "CONTRIBUTOR", "body": "I tried it with German, Spanish, French, and a few others. Seems to work fine. I committed and pushed the change just now.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1567373645/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1568699390", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1568699390", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1568699390, "node_id": "IC_kwDOBLftOs5dgHP-", "user": { "login": "rio-codes", "id": 791713, "node_id": "MDQ6VXNlcjc5MTcxMw==", "avatar_url": "https://avatars.githubusercontent.com/u/791713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rio-codes", "html_url": "https://github.com/rio-codes", "followers_url": "https://api.github.com/users/rio-codes/followers", "following_url": "https://api.github.com/users/rio-codes/following{/other_user}", "gists_url": "https://api.github.com/users/rio-codes/gists{/gist_id}", "starred_url": "https://api.github.com/users/rio-codes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rio-codes/subscriptions", "organizations_url": "https://api.github.com/users/rio-codes/orgs", "repos_url": "https://api.github.com/users/rio-codes/repos", "events_url": "https://api.github.com/users/rio-codes/events{/privacy}", "received_events_url": "https://api.github.com/users/rio-codes/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-30T16:05:38Z", "updated_at": "2023-05-30T16:05:38Z", "author_association": "CONTRIBUTOR", "body": "fixes #8159", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1568699390/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1577185205", "html_url": "https://github.com/laurent22/joplin/pull/8249#issuecomment-1577185205", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8249", "id": 1577185205, "node_id": "IC_kwDOBLftOs5eAe-1", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-05T17:22:02Z", "updated_at": "2023-06-05T17:22:02Z", "author_association": "OWNER", "body": "Looks like it's working well. Thanks a lot for fixing this @rio-codes!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1577185205/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }