{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7559", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7559/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7559/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7559/events", "html_url": "https://github.com/laurent22/joplin/pull/7559", "id": 1514856394, "node_id": "PR_kwDOBLftOs5GaEMr", "number": 7559, "title": "Revert \"Linux: Fix AppImage icon when installing using Joplin_install…", "user": { "login": "roman-r-m", "id": 995612, "node_id": "MDQ6VXNlcjk5NTYxMg==", "avatar_url": "https://avatars.githubusercontent.com/u/995612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/roman-r-m", "html_url": "https://github.com/roman-r-m", "followers_url": "https://api.github.com/users/roman-r-m/followers", "following_url": "https://api.github.com/users/roman-r-m/following{/other_user}", "gists_url": "https://api.github.com/users/roman-r-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/roman-r-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/roman-r-m/subscriptions", "organizations_url": "https://api.github.com/users/roman-r-m/orgs", "repos_url": "https://api.github.com/users/roman-r-m/repos", "events_url": "https://api.github.com/users/roman-r-m/events{/privacy}", "received_events_url": "https://api.github.com/users/roman-r-m/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2022-12-30T21:34:37Z", "updated_at": "2022-12-30T23:21:44Z", "closed_at": "2022-12-30T23:21:30Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7559", "html_url": "https://github.com/laurent22/joplin/pull/7559", "diff_url": "https://github.com/laurent22/joplin/pull/7559.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7559.patch", "merged_at": "2022-12-30T23:21:30Z" }, "body": "This reverts https://github.com/laurent22/joplin/pull/7346\r\nThe above change broke the icon when installing Joplin using the script so reverting the change.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7559/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7559/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368097236", "html_url": "https://github.com/laurent22/joplin/pull/7559#issuecomment-1368097236", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7559", "id": 1368097236, "node_id": "IC_kwDOBLftOs5Ri4HU", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-30T21:34:57Z", "updated_at": "2022-12-30T21:35:55Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368097236/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368097304", "html_url": "https://github.com/laurent22/joplin/pull/7559#issuecomment-1368097304", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7559", "id": 1368097304, "node_id": "IC_kwDOBLftOs5Ri4IY", "user": { "login": "roman-r-m", "id": 995612, "node_id": "MDQ6VXNlcjk5NTYxMg==", "avatar_url": "https://avatars.githubusercontent.com/u/995612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/roman-r-m", "html_url": "https://github.com/roman-r-m", "followers_url": "https://api.github.com/users/roman-r-m/followers", "following_url": "https://api.github.com/users/roman-r-m/following{/other_user}", "gists_url": "https://api.github.com/users/roman-r-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/roman-r-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/roman-r-m/subscriptions", "organizations_url": "https://api.github.com/users/roman-r-m/orgs", "repos_url": "https://api.github.com/users/roman-r-m/repos", "events_url": "https://api.github.com/users/roman-r-m/events{/privacy}", "received_events_url": "https://api.github.com/users/roman-r-m/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-30T21:35:12Z", "updated_at": "2022-12-30T21:35:12Z", "author_association": "CONTRIBUTOR", "body": "I have verified that reverting it fixes the icon.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368097304/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368097337", "html_url": "https://github.com/laurent22/joplin/pull/7559#issuecomment-1368097337", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7559", "id": 1368097337, "node_id": "IC_kwDOBLftOs5Ri4I5", "user": { "login": "roman-r-m", "id": 995612, "node_id": "MDQ6VXNlcjk5NTYxMg==", "avatar_url": "https://avatars.githubusercontent.com/u/995612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/roman-r-m", "html_url": "https://github.com/roman-r-m", "followers_url": "https://api.github.com/users/roman-r-m/followers", "following_url": "https://api.github.com/users/roman-r-m/following{/other_user}", "gists_url": "https://api.github.com/users/roman-r-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/roman-r-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/roman-r-m/subscriptions", "organizations_url": "https://api.github.com/users/roman-r-m/orgs", "repos_url": "https://api.github.com/users/roman-r-m/repos", "events_url": "https://api.github.com/users/roman-r-m/events{/privacy}", "received_events_url": "https://api.github.com/users/roman-r-m/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-30T21:35:22Z", "updated_at": "2022-12-30T21:35:22Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368097337/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368121313", "html_url": "https://github.com/laurent22/joplin/pull/7559#issuecomment-1368121313", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7559", "id": 1368121313, "node_id": "IC_kwDOBLftOs5Ri9_h", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-30T23:21:15Z", "updated_at": "2022-12-30T23:21:15Z", "author_association": "OWNER", "body": "Ok let's merge, thanks for checking!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368121313/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }