{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9603/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9603/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/9603/events", "html_url": "https://github.com/laurent22/joplin/pull/9603", "id": 2055282037, "node_id": "PR_kwDOBLftOs5iuJdh", "number": 9603, "title": " Desktop: Resolves #1752: New: Option to automatically hide the menu bar", "user": { "login": "tinyoverflow", "id": 6287093, "node_id": "MDQ6VXNlcjYyODcwOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/6287093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tinyoverflow", "html_url": "https://github.com/tinyoverflow", "followers_url": "https://api.github.com/users/tinyoverflow/followers", "following_url": "https://api.github.com/users/tinyoverflow/following{/other_user}", "gists_url": "https://api.github.com/users/tinyoverflow/gists{/gist_id}", "starred_url": "https://api.github.com/users/tinyoverflow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tinyoverflow/subscriptions", "organizations_url": "https://api.github.com/users/tinyoverflow/orgs", "repos_url": "https://api.github.com/users/tinyoverflow/repos", "events_url": "https://api.github.com/users/tinyoverflow/events{/privacy}", "received_events_url": "https://api.github.com/users/tinyoverflow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 12, "created_at": "2023-12-25T01:39:09Z", "updated_at": "2024-03-27T06:23:24Z", "closed_at": "2024-01-10T15:55:51Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/9603", "html_url": "https://github.com/laurent22/joplin/pull/9603", "diff_url": "https://github.com/laurent22/joplin/pull/9603.diff", "patch_url": "https://github.com/laurent22/joplin/pull/9603.patch", "merged_at": null }, "body": "This PR adds an option to automatically hide the menu bar on desktop. It can still be shown with the alt key. There were two other related posts to this:\r\n- https://discourse.joplinapp.org/t/hide-menubar/8731\r\n- https://github.com/laurent22/joplin/pull/1752\r\n\r\nI noticed on caveat: When toggling the menu bar, the webview or it's content doesn't resize automatically. This can be fixed by resizing the window, though. I have absolutely no experience with Electron and therefore couldn't solve this. Any help regarding this issue is appreciated.\r\n\r\n![image](https://github.com/laurent22/joplin/assets/6287093/d718c263-f87f-4d4e-8c37-85e9d7880323)\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9603/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9603/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1868651209", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1868651209", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1868651209, "node_id": "IC_kwDOBLftOs5vYVrJ", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-25T01:39:25Z", "updated_at": "2024-01-10T15:56:09Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1868651209/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1868651862", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1868651862", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1868651862, "node_id": "IC_kwDOBLftOs5vYV1W", "user": { "login": "tinyoverflow", "id": 6287093, "node_id": "MDQ6VXNlcjYyODcwOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/6287093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tinyoverflow", "html_url": "https://github.com/tinyoverflow", "followers_url": "https://api.github.com/users/tinyoverflow/followers", "following_url": "https://api.github.com/users/tinyoverflow/following{/other_user}", "gists_url": "https://api.github.com/users/tinyoverflow/gists{/gist_id}", "starred_url": "https://api.github.com/users/tinyoverflow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tinyoverflow/subscriptions", "organizations_url": "https://api.github.com/users/tinyoverflow/orgs", "repos_url": "https://api.github.com/users/tinyoverflow/repos", "events_url": "https://api.github.com/users/tinyoverflow/events{/privacy}", "received_events_url": "https://api.github.com/users/tinyoverflow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-25T01:40:54Z", "updated_at": "2023-12-25T01:40:54Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1868651862/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1871406669", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1871406669", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1871406669, "node_id": "IC_kwDOBLftOs5vi2ZN", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-28T18:37:08Z", "updated_at": "2023-12-28T18:37:19Z", "author_association": "COLLABORATOR", "body": "Thank you for working on this!\r\n\r\nBe aware that we have a [script that generates release notes](https://github.com/laurent22/joplin/blob/f8a25cb275a0beb9ba3ef9bf4271d38947449f42/packages/tools/git-changelog.ts#L358) from pull request titles. As such, I suggest changing `Desktop: Implement PR #1752: Option to automatically hide the menu bar` to `Desktop: Resolves #1752: New: Option to automatically hide the menu bar`. It may also make sense to check whether there's an issue (rather than a pull request) for this already (maybe https://github.com/laurent22/joplin/issues/3894?).\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1871406669/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1871651839", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1871651839", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1871651839, "node_id": "IC_kwDOBLftOs5vjyP_", "user": { "login": "tinyoverflow", "id": 6287093, "node_id": "MDQ6VXNlcjYyODcwOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/6287093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tinyoverflow", "html_url": "https://github.com/tinyoverflow", "followers_url": "https://api.github.com/users/tinyoverflow/followers", "following_url": "https://api.github.com/users/tinyoverflow/following{/other_user}", "gists_url": "https://api.github.com/users/tinyoverflow/gists{/gist_id}", "starred_url": "https://api.github.com/users/tinyoverflow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tinyoverflow/subscriptions", "organizations_url": "https://api.github.com/users/tinyoverflow/orgs", "repos_url": "https://api.github.com/users/tinyoverflow/repos", "events_url": "https://api.github.com/users/tinyoverflow/events{/privacy}", "received_events_url": "https://api.github.com/users/tinyoverflow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-29T00:55:02Z", "updated_at": "2023-12-29T00:57:26Z", "author_association": "NONE", "body": "Thanks for your feedback!\r\nI've updated the PR title accordingly to your suggestion :ok_hand: \r\n\r\n#3894 targets a different issue/feature request, imho. Though it is related to this PR, I'd prefer to create a seperate pull request for the feature requested in that issue.\r\n\r\nI've also changed a few more bits in this PR:\r\nThe `updateMenuBar` method is now only called when the current device is not a Mac. The method itself also received a guard clause to return early in case it's called anyway somewhere else in the future.\r\n\r\nIn addition to that, I've changed the window instantiation to hide the menu bar by default on startup. This is to prevent the menu bar from being visible for a short amount of time when the window loads before it get's hidden again. If hiding is disabled, it will be shown together with when the app gets rendered.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1871651839/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1877271305", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1877271305", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1877271305, "node_id": "IC_kwDOBLftOs5v5OMJ", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-04T15:20:25Z", "updated_at": "2024-01-04T15:20:25Z", "author_association": "OWNER", "body": "As discussed in the original PR it should be a View menu item, like in VSCode for example:\r\n\r\n![image](https://github.com/laurent22/joplin/assets/1285584/1d5ed12d-dc3f-48ee-a2e5-3e2718ee1c8e)\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1877271305/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1880869503", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1880869503", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1880869503, "node_id": "IC_kwDOBLftOs5wG8p_", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-08T12:02:13Z", "updated_at": "2024-01-08T12:02:13Z", "author_association": "OWNER", "body": "@tinyoverflow, thank you for the pull request but as mentioned above it would be better if it's a menu item. Making it a menu item appears to be more in line with other commonly used applications, and it also makes it possible to associate a keyboard shortcut with the action.\r\n\r\nPlease let us know if you need any assistance to complete the pull request.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1880869503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1885128068", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1885128068", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1885128068, "node_id": "IC_kwDOBLftOs5wXMWE", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-10T15:55:51Z", "updated_at": "2024-01-10T15:55:51Z", "author_association": "OWNER", "body": "Closing for now but feel free to let us know if you'd like to give it another try. Sorry we couldn't merge the PR as it is.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1885128068/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1885220786", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-1885220786", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 1885220786, "node_id": "IC_kwDOBLftOs5wXi-y", "user": { "login": "tinyoverflow", "id": 6287093, "node_id": "MDQ6VXNlcjYyODcwOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/6287093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tinyoverflow", "html_url": "https://github.com/tinyoverflow", "followers_url": "https://api.github.com/users/tinyoverflow/followers", "following_url": "https://api.github.com/users/tinyoverflow/following{/other_user}", "gists_url": "https://api.github.com/users/tinyoverflow/gists{/gist_id}", "starred_url": "https://api.github.com/users/tinyoverflow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tinyoverflow/subscriptions", "organizations_url": "https://api.github.com/users/tinyoverflow/orgs", "repos_url": "https://api.github.com/users/tinyoverflow/repos", "events_url": "https://api.github.com/users/tinyoverflow/events{/privacy}", "received_events_url": "https://api.github.com/users/tinyoverflow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-10T16:47:42Z", "updated_at": "2024-01-10T16:47:49Z", "author_association": "NONE", "body": "@laurent22 Thanks. I unfortunately do not have that much time available at the moment. I'll give it another shot at the weekend :)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1885220786/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016724667", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-2016724667", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 2016724667, "node_id": "IC_kwDOBLftOs54NMa7", "user": { "login": "LightTreasure", "id": 1550856, "node_id": "MDQ6VXNlcjE1NTA4NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/1550856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LightTreasure", "html_url": "https://github.com/LightTreasure", "followers_url": "https://api.github.com/users/LightTreasure/followers", "following_url": "https://api.github.com/users/LightTreasure/following{/other_user}", "gists_url": "https://api.github.com/users/LightTreasure/gists{/gist_id}", "starred_url": "https://api.github.com/users/LightTreasure/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LightTreasure/subscriptions", "organizations_url": "https://api.github.com/users/LightTreasure/orgs", "repos_url": "https://api.github.com/users/LightTreasure/repos", "events_url": "https://api.github.com/users/LightTreasure/events{/privacy}", "received_events_url": "https://api.github.com/users/LightTreasure/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-24T07:48:11Z", "updated_at": "2024-03-24T07:48:11Z", "author_association": "CONTRIBUTOR", "body": "Hi @tinyoverflow, I've implemented @laurent22's suggestion of making this a menu item, making my changes off of your fork+branch. Would you like me to create a PR on your fork, or should I make a new PR in this repo?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2016724667/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2021003826", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-2021003826", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 2021003826, "node_id": "IC_kwDOBLftOs54dhIy", "user": { "login": "tinyoverflow", "id": 6287093, "node_id": "MDQ6VXNlcjYyODcwOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/6287093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tinyoverflow", "html_url": "https://github.com/tinyoverflow", "followers_url": "https://api.github.com/users/tinyoverflow/followers", "following_url": "https://api.github.com/users/tinyoverflow/following{/other_user}", "gists_url": "https://api.github.com/users/tinyoverflow/gists{/gist_id}", "starred_url": "https://api.github.com/users/tinyoverflow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tinyoverflow/subscriptions", "organizations_url": "https://api.github.com/users/tinyoverflow/orgs", "repos_url": "https://api.github.com/users/tinyoverflow/repos", "events_url": "https://api.github.com/users/tinyoverflow/events{/privacy}", "received_events_url": "https://api.github.com/users/tinyoverflow/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-26T17:05:55Z", "updated_at": "2024-03-26T17:05:55Z", "author_association": "NONE", "body": "Hello @LightTreasure,\r\n\r\nunfortunately I couldn't find any time digging deeper into this.\r\nI'm fine with both ways you've suggested. If you want to do a PR to my repo, so this PR gets updated, I'll make sure to credit you in this PR.\r\n\r\nThanks for taking this!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2021003826/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2021942746", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-2021942746", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 2021942746, "node_id": "IC_kwDOBLftOs54hGXa", "user": { "login": "LightTreasure", "id": 1550856, "node_id": "MDQ6VXNlcjE1NTA4NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/1550856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LightTreasure", "html_url": "https://github.com/LightTreasure", "followers_url": "https://api.github.com/users/LightTreasure/followers", "following_url": "https://api.github.com/users/LightTreasure/following{/other_user}", "gists_url": "https://api.github.com/users/LightTreasure/gists{/gist_id}", "starred_url": "https://api.github.com/users/LightTreasure/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LightTreasure/subscriptions", "organizations_url": "https://api.github.com/users/LightTreasure/orgs", "repos_url": "https://api.github.com/users/LightTreasure/repos", "events_url": "https://api.github.com/users/LightTreasure/events{/privacy}", "received_events_url": "https://api.github.com/users/LightTreasure/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-27T05:05:55Z", "updated_at": "2024-03-27T05:05:55Z", "author_association": "CONTRIBUTOR", "body": "@tinyoverflow I'll make a PR on you repo! I built on top of your work :)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2021942746/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2022048129", "html_url": "https://github.com/laurent22/joplin/pull/9603#issuecomment-2022048129", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9603", "id": 2022048129, "node_id": "IC_kwDOBLftOs54hgGB", "user": { "login": "LightTreasure", "id": 1550856, "node_id": "MDQ6VXNlcjE1NTA4NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/1550856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LightTreasure", "html_url": "https://github.com/LightTreasure", "followers_url": "https://api.github.com/users/LightTreasure/followers", "following_url": "https://api.github.com/users/LightTreasure/following{/other_user}", "gists_url": "https://api.github.com/users/LightTreasure/gists{/gist_id}", "starred_url": "https://api.github.com/users/LightTreasure/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LightTreasure/subscriptions", "organizations_url": "https://api.github.com/users/LightTreasure/orgs", "repos_url": "https://api.github.com/users/LightTreasure/repos", "events_url": "https://api.github.com/users/LightTreasure/events{/privacy}", "received_events_url": "https://api.github.com/users/LightTreasure/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-27T06:23:23Z", "updated_at": "2024-03-27T06:23:23Z", "author_association": "CONTRIBUTOR", "body": "@tinyoverflow Here's the PR: https://github.com/tinyoverflow/joplin/pull/1", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2022048129/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }