{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14893/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14893/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14893/events", "html_url": "https://github.com/laurent22/joplin/pull/14893", "id": 4130767055, "node_id": "PR_kwDOBLftOs7NJAHQ", "number": 14893, "title": "Desktop: Fixes #12877: Viewer word count includes CSS-hidden text causing editor/viewer count mismatch", "user": { "login": "trueharmonyalan", "id": 92385446, "node_id": "U_kgDOBYGwpg", "avatar_url": "https://avatars.githubusercontent.com/u/92385446?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trueharmonyalan", "html_url": "https://github.com/trueharmonyalan", "followers_url": "https://api.github.com/users/trueharmonyalan/followers", "following_url": "https://api.github.com/users/trueharmonyalan/following{/other_user}", "gists_url": "https://api.github.com/users/trueharmonyalan/gists{/gist_id}", "starred_url": "https://api.github.com/users/trueharmonyalan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trueharmonyalan/subscriptions", "organizations_url": "https://api.github.com/users/trueharmonyalan/orgs", "repos_url": "https://api.github.com/users/trueharmonyalan/repos", "events_url": "https://api.github.com/users/trueharmonyalan/events{/privacy}", "received_events_url": "https://api.github.com/users/trueharmonyalan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1802916084, "node_id": "MDU6TGFiZWwxODAyOTE2MDg0", "url": "https://api.github.com/repos/laurent22/joplin/labels/renderer", "name": "renderer", "color": "91ca55", "default": false, "description": "About the note renderer" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 8, "created_at": "2026-03-24T21:28:17Z", "updated_at": "2026-04-02T17:09:12Z", "closed_at": "2026-04-02T15:37:56Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14893", "html_url": "https://github.com/laurent22/joplin/pull/14893", "diff_url": "https://github.com/laurent22/joplin/pull/14893.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14893.patch", "merged_at": null }, "body": "\r\n\r\n\r\nThis PR fixes #12877.\r\n\r\nWhen a note contains HTML elements hidden via CSS (e.g. `visibility: hidden`, `display: none`), the Viewer word count was incorrectly including that hidden text in its total β€” causing a mismatch with what the user actually sees in the preview.\r\n\r\nThe Editor count is intentionally unaffected, as it reflects everything the user has typed regardless of styling.\r\n\r\n**Fix:** `stripHtml` now detects and skips CSS-hidden elements during text \r\nextraction, so the Viewer count only reflects visible, rendered content.\r\n\r\n**Tests:** Added test cases to `htmlUtils.test.ts` covering all supported \r\nCSS hiding methods (`visibility: hidden`, `display: none`, etc.), \r\nnested hidden elements, and mixed visible/hidden content.\r\n\r\n**Before**\r\n\r\nJoplin 3.5.13 (prod, linux)\r\nDevice: linux, Intel(R) Core(TM) i3-8100 CPU @ 3.60GHz\r\nClient ID: e3dcf4bbb98c4873b7229cd3a859a4aa\r\nSync Version: 3\r\nProfile Version: 49\r\nKeychain Supported: No\r\nAlternative instance ID: -\r\nRevision: 0c1511f\r\nBackup: 1.5.1\r\nFreehand Drawing: 4.2.0\r\n\r\nhttps://github.com/user-attachments/assets/d79b3286-65e1-4451-8e67-2296ee5637dd\r\n\r\n**After**\r\nJoplin 3.6.6 (dev, linux)\r\nDevice: linux, Intel(R) Core(TM) i3-8100 CPU @ 3.60GHz\r\nClient ID: 463bfd1c6f0e487298782bdebf4a6d09\r\nSync Version: 3\r\nProfile Version: 49\r\nKeychain Supported: No\r\nAlternative instance ID: -\r\nSync target: (None)\r\nEditor: Markdown\r\nRevision: dfdc0f3c3 (dev)\r\nBackup: 1.5.1\r\nFreehand Drawing: 4.3.0\r\n\r\nhttps://github.com/user-attachments/assets/11e83d2c-2650-4830-abc8-99097f1ca0d3\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14893/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14893/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4121513518", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4121513518", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4121513518, "node_id": "IC_kwDOBLftOs71qU4u", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-24T21:28:28Z", "updated_at": "2026-04-02T17:09:12Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ βœ…", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4121513518/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4121515731", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4121515731", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4121515731, "node_id": "IC_kwDOBLftOs71qVbT", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-24T21:28:43Z", "updated_at": "2026-04-01T10:42:30Z", "body": "\nNo actionable comments were generated in the recent review. πŸŽ‰\n\n
\nℹ️ Recent review info\n\n
\nβš™οΈ Run configuration\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `297cace7-48e3-486c-a596-828906fb2568`\n\n
\n\n
\nπŸ“₯ Commits\n\nReviewing files that changed from the base of the PR and between 8634c1baefb255a2b428a4014594bccb88db4845 and 640f5c653bf004d1455672e893ea3c62197a810e.\n\n
\n\n
\nπŸ“’ Files selected for processing (2)\n\n* `packages/renderer/htmlUtils.test.ts`\n* `packages/renderer/htmlUtils.ts`\n\n
\n\n
\nβœ… Files skipped from review due to trivial changes (1)\n\n* packages/renderer/htmlUtils.ts\n\n
\n\n
\n🚧 Files skipped from review as they are similar to previous changes (1)\n\n* packages/renderer/htmlUtils.test.ts\n\n
\n\n
\n\n---\n\n\n\n\n
\nπŸ“ Walkthrough\n\n## Walkthrough\n\nDetects and excludes text inside HTML elements that are visually hidden via inline CSS when stripping HTML to plain text. Adds a style-parsing helper and tracks nested hidden elements to suppress their text during parsing.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**HTML utilities & tests**
`packages/renderer/htmlUtils.ts`, `packages/renderer/htmlUtils.test.ts`|Added `isHiddenByStyle()` to classify inline styles that hide content (e.g., `display:none`, `visibility:hidden`, `opacity:0`, `font-size:0`, `color:transparent`, off-screen `text-indent`, zero-dimension with `overflow:hidden`, `transform:scale(0)`, `clip-path:inset(100%)`). `stripHtml()` now receives tag attributes, maintains a hidden-state stack and `hiddenDepth` counter to skip text inside hidden elements. Tests cover multiple hiding patterns, nested hidden parents, whitespace-robust parsing and negative cases that should not be treated as hidden.|\n\n## Suggested labels\n\n`bug`, `renderer`\n\n
\n\n\n\n\n\n\n
\nπŸš₯ Pre-merge checks | βœ… 6\n\n
\nβœ… Passed checks (6 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | βœ… Passed | The title clearly summarises the main change: fixing viewer word count to exclude CSS-hidden text and resolve the editor/viewer count mismatch. |\n| Description check | βœ… Passed | The description is directly related to the changeset, explaining the fix for CSS-hidden text in word counts with before/after screenshots and test coverage details. |\n| Linked Issues check | βœ… Passed | The PR fully addresses `#12877` by implementing detection and exclusion of CSS-hidden elements (display: none, visibility: hidden, and other methods) during text extraction in stripHtml, with comprehensive test coverage for all hiding methods and nested cases. |\n| Out of Scope Changes check | βœ… Passed | All changes are scoped to fixing the viewer word count issue: modifications to stripHtml in htmlUtils.ts and test cases in htmlUtils.test.ts are directly related to detecting and excluding CSS-hidden text. |\n| Docstring Coverage | βœ… Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | βœ… Passed | PR description includes all required sections: problem statement (CSS-hidden text counted incorrectly), solution explanation (stripHtml updated to detect hidden elements), test plan (comprehensive test coverage), and self-contained format with issue reference. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\nπŸ§ͺ Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14893)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❀️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4121515731/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes.Β \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code.Β The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issuesΒ \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4121544336", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4121544336", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4121544336, "node_id": "IC_kwDOBLftOs71qcaQ", "user": { "login": "trueharmonyalan", "id": 92385446, "node_id": "U_kgDOBYGwpg", "avatar_url": "https://avatars.githubusercontent.com/u/92385446?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trueharmonyalan", "html_url": "https://github.com/trueharmonyalan", "followers_url": "https://api.github.com/users/trueharmonyalan/followers", "following_url": "https://api.github.com/users/trueharmonyalan/following{/other_user}", "gists_url": "https://api.github.com/users/trueharmonyalan/gists{/gist_id}", "starred_url": "https://api.github.com/users/trueharmonyalan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trueharmonyalan/subscriptions", "organizations_url": "https://api.github.com/users/trueharmonyalan/orgs", "repos_url": "https://api.github.com/users/trueharmonyalan/repos", "events_url": "https://api.github.com/users/trueharmonyalan/events{/privacy}", "received_events_url": "https://api.github.com/users/trueharmonyalan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-24T21:31:42Z", "updated_at": "2026-03-24T21:31:42Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4121544336/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142207543", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4142207543", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4142207543, "node_id": "IC_kwDOBLftOs725RI3", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-27T12:20:47Z", "updated_at": "2026-03-27T12:20:47Z", "body": "CodeRabbit's comments need to be adressed", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142207543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142991685", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4142991685", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4142991685, "node_id": "IC_kwDOBLftOs728QlF", "user": { "login": "trueharmonyalan", "id": 92385446, "node_id": "U_kgDOBYGwpg", "avatar_url": "https://avatars.githubusercontent.com/u/92385446?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trueharmonyalan", "html_url": "https://github.com/trueharmonyalan", "followers_url": "https://api.github.com/users/trueharmonyalan/followers", "following_url": "https://api.github.com/users/trueharmonyalan/following{/other_user}", "gists_url": "https://api.github.com/users/trueharmonyalan/gists{/gist_id}", "starred_url": "https://api.github.com/users/trueharmonyalan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trueharmonyalan/subscriptions", "organizations_url": "https://api.github.com/users/trueharmonyalan/orgs", "repos_url": "https://api.github.com/users/trueharmonyalan/repos", "events_url": "https://api.github.com/users/trueharmonyalan/events{/privacy}", "received_events_url": "https://api.github.com/users/trueharmonyalan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-27T14:24:58Z", "updated_at": "2026-03-27T14:24:58Z", "body": "> CodeRabbit's comments need to be adressed\r\n\r\nsure, working on it.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4142991685/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4145143637", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4145143637", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4145143637, "node_id": "IC_kwDOBLftOs73Ed9V", "user": { "login": "trueharmonyalan", "id": 92385446, "node_id": "U_kgDOBYGwpg", "avatar_url": "https://avatars.githubusercontent.com/u/92385446?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trueharmonyalan", "html_url": "https://github.com/trueharmonyalan", "followers_url": "https://api.github.com/users/trueharmonyalan/followers", "following_url": "https://api.github.com/users/trueharmonyalan/following{/other_user}", "gists_url": "https://api.github.com/users/trueharmonyalan/gists{/gist_id}", "starred_url": "https://api.github.com/users/trueharmonyalan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trueharmonyalan/subscriptions", "organizations_url": "https://api.github.com/users/trueharmonyalan/orgs", "repos_url": "https://api.github.com/users/trueharmonyalan/repos", "events_url": "https://api.github.com/users/trueharmonyalan/events{/privacy}", "received_events_url": "https://api.github.com/users/trueharmonyalan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-27T20:44:05Z", "updated_at": "2026-03-27T21:10:58Z", "body": "> > CodeRabbit's comments need to be adressed\r\n> \r\n> sure, working on it.\r\n\r\nI fixed the changes that coderabbitai proposed and created pr with those changes. ", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4145143637/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4178746227", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4178746227", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4178746227, "node_id": "IC_kwDOBLftOs75Eptz", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-02T15:37:56Z", "updated_at": "2026-04-02T15:37:56Z", "body": "Sorry I'm not confident about merging this as it's hard to evaluate the impact of the change, and it's just for a minor annoyance", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4178746227/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4178784826", "html_url": "https://github.com/laurent22/joplin/pull/14893#issuecomment-4178784826", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14893", "id": 4178784826, "node_id": "IC_kwDOBLftOs75EzI6", "user": { "login": "trueharmonyalan", "id": 92385446, "node_id": "U_kgDOBYGwpg", "avatar_url": "https://avatars.githubusercontent.com/u/92385446?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trueharmonyalan", "html_url": "https://github.com/trueharmonyalan", "followers_url": "https://api.github.com/users/trueharmonyalan/followers", "following_url": "https://api.github.com/users/trueharmonyalan/following{/other_user}", "gists_url": "https://api.github.com/users/trueharmonyalan/gists{/gist_id}", "starred_url": "https://api.github.com/users/trueharmonyalan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trueharmonyalan/subscriptions", "organizations_url": "https://api.github.com/users/trueharmonyalan/orgs", "repos_url": "https://api.github.com/users/trueharmonyalan/repos", "events_url": "https://api.github.com/users/trueharmonyalan/events{/privacy}", "received_events_url": "https://api.github.com/users/trueharmonyalan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-02T15:44:59Z", "updated_at": "2026-04-02T15:44:59Z", "body": "> Sorry I'm not confident about merging this as it's hard to evaluate the impact of the change, and it's just for a minor annoyance\r\n\r\n\r\n\r\n> Sorry I'm not confident about merging this as it's hard to evaluate the impact of the change, and it's just for a minor annoyance\r\n\r\nI understand you concern and Thank you for your time.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4178784826/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }