{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10539/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10539/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10539/events", "html_url": "https://github.com/laurent22/joplin/pull/10539", "id": 2334145496, "node_id": "PR_kwDOBLftOs5xddQn", "number": 10539, "title": "Desktop: Resolves #10529 Korean translation error for new sub-notebook", "user": { "login": "tushar-coin", "id": 72160708, "node_id": "MDQ6VXNlcjcyMTYwNzA4", "avatar_url": "https://avatars.githubusercontent.com/u/72160708?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tushar-coin", "html_url": "https://github.com/tushar-coin", "followers_url": "https://api.github.com/users/tushar-coin/followers", "following_url": "https://api.github.com/users/tushar-coin/following{/other_user}", "gists_url": "https://api.github.com/users/tushar-coin/gists{/gist_id}", "starred_url": "https://api.github.com/users/tushar-coin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tushar-coin/subscriptions", "organizations_url": "https://api.github.com/users/tushar-coin/orgs", "repos_url": "https://api.github.com/users/tushar-coin/repos", "events_url": "https://api.github.com/users/tushar-coin/events{/privacy}", "received_events_url": "https://api.github.com/users/tushar-coin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1091621259, "node_id": "MDU6TGFiZWwxMDkxNjIxMjU5", "url": "https://api.github.com/repos/laurent22/joplin/labels/translation", "name": "translation", "color": "91ca55", "default": false, "description": "i18n and l10n" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 13, "created_at": "2024-06-04T18:36:57Z", "updated_at": "2024-06-07T18:18:33Z", "closed_at": "2024-06-07T18:18:21Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10539", "html_url": "https://github.com/laurent22/joplin/pull/10539", "diff_url": "https://github.com/laurent22/joplin/pull/10539.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10539.patch", "merged_at": null }, "body": "Desktop: Resolves #10529 Korean translation error for new sub-notebook\r\n\r\nReplaced the translation of new notebook with new sub-notebook in korean in ko.json resource file for desktop", "closed_by": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10539/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10539/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148169101", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2148169101", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2148169101, "node_id": "IC_kwDOBLftOs6ACnWN", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-04T18:37:14Z", "updated_at": "2024-06-07T18:18:33Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148169101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148172386", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2148172386", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2148172386, "node_id": "IC_kwDOBLftOs6ACoJi", "user": { "login": "tushar-coin", "id": 72160708, "node_id": "MDQ6VXNlcjcyMTYwNzA4", "avatar_url": "https://avatars.githubusercontent.com/u/72160708?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tushar-coin", "html_url": "https://github.com/tushar-coin", "followers_url": "https://api.github.com/users/tushar-coin/followers", "following_url": "https://api.github.com/users/tushar-coin/following{/other_user}", "gists_url": "https://api.github.com/users/tushar-coin/gists{/gist_id}", "starred_url": "https://api.github.com/users/tushar-coin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tushar-coin/subscriptions", "organizations_url": "https://api.github.com/users/tushar-coin/orgs", "repos_url": "https://api.github.com/users/tushar-coin/repos", "events_url": "https://api.github.com/users/tushar-coin/events{/privacy}", "received_events_url": "https://api.github.com/users/tushar-coin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-04T18:38:52Z", "updated_at": "2024-06-04T18:38:52Z", "author_association": "NONE", "body": "hey moderators would love to have your say on the edit", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148172386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148173102", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2148173102", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2148173102, "node_id": "IC_kwDOBLftOs6ACoUu", "user": { "login": "tushar-coin", "id": 72160708, "node_id": "MDQ6VXNlcjcyMTYwNzA4", "avatar_url": "https://avatars.githubusercontent.com/u/72160708?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tushar-coin", "html_url": "https://github.com/tushar-coin", "followers_url": "https://api.github.com/users/tushar-coin/followers", "following_url": "https://api.github.com/users/tushar-coin/following{/other_user}", "gists_url": "https://api.github.com/users/tushar-coin/gists{/gist_id}", "starred_url": "https://api.github.com/users/tushar-coin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tushar-coin/subscriptions", "organizations_url": "https://api.github.com/users/tushar-coin/orgs", "repos_url": "https://api.github.com/users/tushar-coin/repos", "events_url": "https://api.github.com/users/tushar-coin/events{/privacy}", "received_events_url": "https://api.github.com/users/tushar-coin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-04T18:39:09Z", "updated_at": "2024-06-04T18:39:09Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148173102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148247043", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2148247043", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2148247043, "node_id": "IC_kwDOBLftOs6AC6YD", "user": { "login": "roman-r-m", "id": 995612, "node_id": "MDQ6VXNlcjk5NTYxMg==", "avatar_url": "https://avatars.githubusercontent.com/u/995612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/roman-r-m", "html_url": "https://github.com/roman-r-m", "followers_url": "https://api.github.com/users/roman-r-m/followers", "following_url": "https://api.github.com/users/roman-r-m/following{/other_user}", "gists_url": "https://api.github.com/users/roman-r-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/roman-r-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/roman-r-m/subscriptions", "organizations_url": "https://api.github.com/users/roman-r-m/orgs", "repos_url": "https://api.github.com/users/roman-r-m/repos", "events_url": "https://api.github.com/users/roman-r-m/events{/privacy}", "received_events_url": "https://api.github.com/users/roman-r-m/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-04T19:27:13Z", "updated_at": "2024-06-04T19:27:13Z", "author_association": "CONTRIBUTOR", "body": "I'm pretty sure this file is automatically generated and must not be edited manually.\r\nRead the docs on how to edit translations.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2148247043/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2150795516", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2150795516", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2150795516, "node_id": "IC_kwDOBLftOs6AMoj8", "user": { "login": "tushar-coin", "id": 72160708, "node_id": "MDQ6VXNlcjcyMTYwNzA4", "avatar_url": "https://avatars.githubusercontent.com/u/72160708?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tushar-coin", "html_url": "https://github.com/tushar-coin", "followers_url": "https://api.github.com/users/tushar-coin/followers", "following_url": "https://api.github.com/users/tushar-coin/following{/other_user}", "gists_url": "https://api.github.com/users/tushar-coin/gists{/gist_id}", "starred_url": "https://api.github.com/users/tushar-coin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tushar-coin/subscriptions", "organizations_url": "https://api.github.com/users/tushar-coin/orgs", "repos_url": "https://api.github.com/users/tushar-coin/repos", "events_url": "https://api.github.com/users/tushar-coin/events{/privacy}", "received_events_url": "https://api.github.com/users/tushar-coin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-05T19:23:44Z", "updated_at": "2024-06-05T19:23:44Z", "author_association": "NONE", "body": "hey @roman-r-m currently i am really new to this but tried taking reference from old prs and made new commits please review them\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2150795516/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2150806002", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2150806002", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2150806002, "node_id": "IC_kwDOBLftOs6AMrHy", "user": { "login": "roman-r-m", "id": 995612, "node_id": "MDQ6VXNlcjk5NTYxMg==", "avatar_url": "https://avatars.githubusercontent.com/u/995612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/roman-r-m", "html_url": "https://github.com/roman-r-m", "followers_url": "https://api.github.com/users/roman-r-m/followers", "following_url": "https://api.github.com/users/roman-r-m/following{/other_user}", "gists_url": "https://api.github.com/users/roman-r-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/roman-r-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/roman-r-m/subscriptions", "organizations_url": "https://api.github.com/users/roman-r-m/orgs", "repos_url": "https://api.github.com/users/roman-r-m/repos", "events_url": "https://api.github.com/users/roman-r-m/events{/privacy}", "received_events_url": "https://api.github.com/users/roman-r-m/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-05T19:30:34Z", "updated_at": "2024-06-05T19:30:34Z", "author_association": "CONTRIBUTOR", "body": "I don't speak Korean, so can't check. Google translates it as \"new sub note\".\r\n@doyun0202 can you pls check if the translation is correct. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2150806002/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2151175684", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2151175684", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2151175684, "node_id": "IC_kwDOBLftOs6AOFYE", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-06T00:40:13Z", "updated_at": "2024-06-06T00:40:13Z", "author_association": "COLLABORATOR", "body": "btw, did you use poedit? Also, there is an additional empty line that isn't needed.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2151175684/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2151209327", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2151209327", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2151209327, "node_id": "IC_kwDOBLftOs6AONlv", "user": { "login": "doyun0202", "id": 80564665, "node_id": "MDQ6VXNlcjgwNTY0NjY1", "avatar_url": "https://avatars.githubusercontent.com/u/80564665?v=4", "gravatar_id": "", "url": "https://api.github.com/users/doyun0202", "html_url": "https://github.com/doyun0202", "followers_url": "https://api.github.com/users/doyun0202/followers", "following_url": "https://api.github.com/users/doyun0202/following{/other_user}", "gists_url": "https://api.github.com/users/doyun0202/gists{/gist_id}", "starred_url": "https://api.github.com/users/doyun0202/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/doyun0202/subscriptions", "organizations_url": "https://api.github.com/users/doyun0202/orgs", "repos_url": "https://api.github.com/users/doyun0202/repos", "events_url": "https://api.github.com/users/doyun0202/events{/privacy}", "received_events_url": "https://api.github.com/users/doyun0202/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-06T01:07:48Z", "updated_at": "2024-06-06T01:14:58Z", "author_association": "NONE", "body": "@roman-r-m The \"새 하위 노트\" is suitable for Korean. \r\n@tessus The \"새 서브 노트\" is not suitable in Korean. \r\nSo you have to translate it like this. \r\n new sub notebook ->> 새 하위 노트북\r\nnew notebook ->> 새 노트북", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2151209327/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2151224207", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2151224207", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2151224207, "node_id": "IC_kwDOBLftOs6AOROP", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-06T01:17:56Z", "updated_at": "2024-06-06T01:25:58Z", "author_association": "COLLABORATOR", "body": "@doyun0202 Thanks for your help. (Btw, I didn't translate it. My Korean is very basic thus I would not dare trying to. ;-)) I find it very interesting that Korean uses a lot of English load words like 노트북\r\n\r\n@tushar-coin can you please make the changes accordingly.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2151224207/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155014430", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2155014430", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2155014430, "node_id": "IC_kwDOBLftOs6Acuke", "user": { "login": "tushar-coin", "id": 72160708, "node_id": "MDQ6VXNlcjcyMTYwNzA4", "avatar_url": "https://avatars.githubusercontent.com/u/72160708?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tushar-coin", "html_url": "https://github.com/tushar-coin", "followers_url": "https://api.github.com/users/tushar-coin/followers", "following_url": "https://api.github.com/users/tushar-coin/following{/other_user}", "gists_url": "https://api.github.com/users/tushar-coin/gists{/gist_id}", "starred_url": "https://api.github.com/users/tushar-coin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tushar-coin/subscriptions", "organizations_url": "https://api.github.com/users/tushar-coin/orgs", "repos_url": "https://api.github.com/users/tushar-coin/repos", "events_url": "https://api.github.com/users/tushar-coin/events{/privacy}", "received_events_url": "https://api.github.com/users/tushar-coin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-07T14:56:37Z", "updated_at": "2024-06-07T14:56:37Z", "author_association": "NONE", "body": "@tessus on it\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155014430/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155026589", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2155026589", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2155026589, "node_id": "IC_kwDOBLftOs6Acxid", "user": { "login": "tushar-coin", "id": 72160708, "node_id": "MDQ6VXNlcjcyMTYwNzA4", "avatar_url": "https://avatars.githubusercontent.com/u/72160708?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tushar-coin", "html_url": "https://github.com/tushar-coin", "followers_url": "https://api.github.com/users/tushar-coin/followers", "following_url": "https://api.github.com/users/tushar-coin/following{/other_user}", "gists_url": "https://api.github.com/users/tushar-coin/gists{/gist_id}", "starred_url": "https://api.github.com/users/tushar-coin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tushar-coin/subscriptions", "organizations_url": "https://api.github.com/users/tushar-coin/orgs", "repos_url": "https://api.github.com/users/tushar-coin/repos", "events_url": "https://api.github.com/users/tushar-coin/events{/privacy}", "received_events_url": "https://api.github.com/users/tushar-coin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-07T15:03:42Z", "updated_at": "2024-06-07T15:03:42Z", "author_association": "NONE", "body": "> btw, did you use poedit? Also, there is an additional empty line that isn't needed.\r\n\r\ni didn't also i am not able to understand the usecase of poedit here\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155026589/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155114300", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2155114300", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2155114300, "node_id": "IC_kwDOBLftOs6AdG88", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-07T15:56:08Z", "updated_at": "2024-06-07T15:56:08Z", "author_association": "COLLABORATOR", "body": "You should always use Poedit, because manually hacking the file can lead to a broken translation file.\r\n\r\nAlso, I am not sure whether you read the other comments, but your translation is wrong. Additionally one is missing.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155114300/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155308697", "html_url": "https://github.com/laurent22/joplin/pull/10539#issuecomment-2155308697", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10539", "id": 2155308697, "node_id": "IC_kwDOBLftOs6Ad2aZ", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-07T18:18:22Z", "updated_at": "2024-06-07T18:18:22Z", "author_association": "COLLABORATOR", "body": "I am sorry, but I am closing this. I've pushed to correct translation in df8c7fd31", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2155308697/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }