{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13311", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13311/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13311/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/13311/events", "html_url": "https://github.com/laurent22/joplin/pull/13311", "id": 3459296321, "node_id": "PR_kwDOBLftOs6qzqxR", "number": 13311, "title": "Desktop: Fixes #13196: Fixed red close button not working on macOS 26", "user": { "login": "yingli-lab", "id": 212174424, "node_id": "U_kgDODKWGWA", "avatar_url": "https://avatars.githubusercontent.com/u/212174424?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yingli-lab", "html_url": "https://github.com/yingli-lab", "followers_url": "https://api.github.com/users/yingli-lab/followers", "following_url": "https://api.github.com/users/yingli-lab/following{/other_user}", "gists_url": "https://api.github.com/users/yingli-lab/gists{/gist_id}", "starred_url": "https://api.github.com/users/yingli-lab/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yingli-lab/subscriptions", "organizations_url": "https://api.github.com/users/yingli-lab/orgs", "repos_url": "https://api.github.com/users/yingli-lab/repos", "events_url": "https://api.github.com/users/yingli-lab/events{/privacy}", "received_events_url": "https://api.github.com/users/yingli-lab/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2025-09-26T22:37:01Z", "updated_at": "2025-09-30T16:39:49Z", "closed_at": "2025-09-30T15:43:59Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/13311", "html_url": "https://github.com/laurent22/joplin/pull/13311", "diff_url": "https://github.com/laurent22/joplin/pull/13311.diff", "patch_url": "https://github.com/laurent22/joplin/pull/13311.patch", "merged_at": "2025-09-30T15:43:59Z" }, "body": "### Summary\r\nOn macOS 26, the red close button did not close the main Joplin window.\r\nUsers had to force quit the app. This PR fixes the issue.\r\n\r\n### Fix\r\n- Prevent default close event and properly hide the main window.\r\n- Handle fullscreen exit before hiding to ensure consistent behavior.\r\n\r\n### Testing\r\n- Verified on macOS 26 (Apple M2).\r\n- Confirmed that the red close button now hides the app window as expected.\r\n\r\n### Demo\r\nBefore: Clicking the red close button did not close the window (macOS 26).\r\nAfter: The window now hides correctly when the red close button is clicked.\r\n\r\nhttps://github.com/user-attachments/assets/3c75908b-2927-4f70-acd1-c0d6b590c6ad\r\n\r\nFixes #13196", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13311/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13311/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340699975", "html_url": "https://github.com/laurent22/joplin/pull/13311#issuecomment-3340699975", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13311", "id": 3340699975, "node_id": "IC_kwDOBLftOs7HHwlH", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-26T22:37:12Z", "updated_at": "2025-09-30T16:39:49Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340699975/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-11-12T15:38:39Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340716237", "html_url": "https://github.com/laurent22/joplin/pull/13311#issuecomment-3340716237", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13311", "id": 3340716237, "node_id": "IC_kwDOBLftOs7HH0jN", "user": { "login": "yingli-lab", "id": 212174424, "node_id": "U_kgDODKWGWA", "avatar_url": "https://avatars.githubusercontent.com/u/212174424?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yingli-lab", "html_url": "https://github.com/yingli-lab", "followers_url": "https://api.github.com/users/yingli-lab/followers", "following_url": "https://api.github.com/users/yingli-lab/following{/other_user}", "gists_url": "https://api.github.com/users/yingli-lab/gists{/gist_id}", "starred_url": "https://api.github.com/users/yingli-lab/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yingli-lab/subscriptions", "organizations_url": "https://api.github.com/users/yingli-lab/orgs", "repos_url": "https://api.github.com/users/yingli-lab/repos", "events_url": "https://api.github.com/users/yingli-lab/events{/privacy}", "received_events_url": "https://api.github.com/users/yingli-lab/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-26T22:50:28Z", "updated_at": "2025-09-26T22:50:28Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340716237/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }