{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14360", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14360/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14360/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14360/events", "html_url": "https://github.com/laurent22/joplin/pull/14360", "id": 3945933635, "node_id": "PR_kwDOBLftOs7EASSZ", "number": 14360, "title": "Desktop: Fixes #14350: Make notebook search accent-insensitive in GotoAnything", "user": { "login": "yousef-genedy", "id": 115221628, "node_id": "U_kgDOBt4kfA", "avatar_url": "https://avatars.githubusercontent.com/u/115221628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yousef-genedy", "html_url": "https://github.com/yousef-genedy", "followers_url": "https://api.github.com/users/yousef-genedy/followers", "following_url": "https://api.github.com/users/yousef-genedy/following{/other_user}", "gists_url": "https://api.github.com/users/yousef-genedy/gists{/gist_id}", "starred_url": "https://api.github.com/users/yousef-genedy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yousef-genedy/subscriptions", "organizations_url": "https://api.github.com/users/yousef-genedy/orgs", "repos_url": "https://api.github.com/users/yousef-genedy/repos", "events_url": "https://api.github.com/users/yousef-genedy/events{/privacy}", "received_events_url": "https://api.github.com/users/yousef-genedy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 3, "created_at": "2026-02-16T05:17:44Z", "updated_at": "2026-02-17T08:37:25Z", "closed_at": "2026-02-17T08:37:13Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14360", "html_url": "https://github.com/laurent22/joplin/pull/14360", "diff_url": "https://github.com/laurent22/joplin/pull/14360.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14360.patch", "merged_at": "2026-02-17T08:37:13Z" }, "body": "## Summary\r\n\r\nThis PR fixes accent-sensitive notebook search in GotoAnything when using the `@` prefix followed by a notebook name.\r\n\r\nIssue: #14350\r\n\r\n---\r\n\r\n## Problem\r\n\r\nNotebook search with the `@` prefix is accent-sensitive.\r\n\r\nExample:\r\n\r\n- `@vetement` → does NOT return `Vêtement`\r\n- `@vêtement` → returns only the accented notebook\r\n\r\n---\r\n\r\n## Root Cause\r\n\r\nNotebook search uses: `Folder.search({ titlePattern })`\r\n\r\n\r\nThis relies on a SQLite `LIKE` query, which can be accent-sensitive depending on configuration.\r\n\r\nNormal search goes through `SearchEngine`, which performs diacritic normalization.\r\n\r\nThis creates inconsistent behavior.\r\n\r\n---\r\n\r\n## Solution\r\n\r\nReplaced database-based folder search with client-side filtering using `this.props.folders`, which are already available in Redux state.\r\n\r\nImplementation details:\r\n\r\n- Remove leading `@`\r\n- Normalize query using `removeDiacritics()`\r\n- Normalize folder titles using `removeDiacritics()`\r\n- Perform lowercase accent-insensitive `indexOf()` comparison\r\n- Skip deleted folders\r\n- Preserve path calculation via `Folder.folderPathString()`\r\n\r\n---\r\n\r\n## Manual Testing Plan\r\n\r\n### 1. Basic Accent Matching\r\n- Create notebook: `Vêtement`\r\n- Search `@vetement`\r\n- Notebook appears\r\n\r\n### 2. Accent Query\r\n- Search `@vêtement`\r\n- Notebook appears\r\n\r\n### 3. Mixed Notebooks\r\n- Create notebook: `vetement_plain`\r\n- Search `@vetement`\r\n- Both relevant notebooks appear\r\n\r\n### 4. Nested Notebooks\r\n- Create nested notebook under `Vêtement`\r\n- Search `@vetement`\r\n- Correct path is displayed\r\n\r\n### 5. Empty Query\r\n- Type `@`\r\n- All notebooks appear as before\r\n\r\n---\r\n\r\n## Screenshots\r\n\r\n### Case Setup\r\n\r\nTwo notebooks exist:\r\n- `Vêtement`\r\n- `vetement_plain`\r\n\r\n### Search: `@vetement`\r\n\r\nBoth notebooks are returned:\r\n- `Vêtement`\r\n- `vetement_plain`\r\n\r\n\"image\"\r\n\r\n### Search: `@vêtement`\r\n\r\nBoth notebooks are also returned:\r\n\r\n- `Vêtement`\r\n- `vetement_plain`\r\n\r\n\"image\"\n\n\n## Summary by CodeRabbit\n\n* **Bug Fixes**\n * Folder search now ignores deleted folders and matches queries regardless of accents or case, improving accuracy in Go to Anything.\n\n* **New Features**\n * Search results now include each folder's path (defaults to '/'), making it easier to locate items at a glance.\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14360/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 2, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14360/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3906498949", "html_url": "https://github.com/laurent22/joplin/pull/14360#issuecomment-3906498949", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14360", "id": 3906498949, "node_id": "IC_kwDOBLftOs7o2HGF", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-16T05:17:55Z", "updated_at": "2026-02-17T08:37:25Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3906498949/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3906500417", "html_url": "https://github.com/laurent22/joplin/pull/14360#issuecomment-3906500417", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14360", "id": 3906500417, "node_id": "IC_kwDOBLftOs7o2HdB", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-16T05:18:35Z", "updated_at": "2026-02-17T07:05:31Z", "body": "\nNo actionable comments were generated in the recent review. 🎉\n\n---\n\n\n\n\n## Walkthrough\n\nThe search logic for folders in the GotoAnything plugin was refactored to use client-side filtering instead of a server-side search call. The implementation normalises both user input and folder titles (handling diacritics), filters matching folders, and constructs result objects with computed folder paths.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Folder Search Logic**
`packages/app-desktop/plugins/GotoAnything.tsx`|Replaced `Folder.search` call with client-side filtering using diacritics-insensitive, lowercase-normalised queries; skips deleted folders; iterates over `this.props.folders`, matches normalised titles, computes `path` via `Folder.folderPathString`, and builds results directly.|\n\n## Estimated code review effort\n\n🎯 2 (Simple) | ⏱️ ~10 minutes\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 3\n\n
\n✅ Passed checks (3 passed)\n\n| Check name | Status | Explanation |\n| :----------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |\n| Title check | ✅ Passed | The title directly relates to the main change: making notebook search accent-insensitive in GotoAnything, which matches the PR's primary objective of fixing issue `#14350`. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing touches\n\n- [ ] 📝 Generate docstrings\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n> [!TIP]\n> [Issue Planner](https://www.coderabbit.ai/issue-planner) is now in beta. Read the [docs](https://docs.coderabbit.ai/issues/planning) and try it out! Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\n\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3906500417/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3906520399", "html_url": "https://github.com/laurent22/joplin/pull/14360#issuecomment-3906520399", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14360", "id": 3906520399, "node_id": "IC_kwDOBLftOs7o2MVP", "user": { "login": "yousef-genedy", "id": 115221628, "node_id": "U_kgDOBt4kfA", "avatar_url": "https://avatars.githubusercontent.com/u/115221628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yousef-genedy", "html_url": "https://github.com/yousef-genedy", "followers_url": "https://api.github.com/users/yousef-genedy/followers", "following_url": "https://api.github.com/users/yousef-genedy/following{/other_user}", "gists_url": "https://api.github.com/users/yousef-genedy/gists{/gist_id}", "starred_url": "https://api.github.com/users/yousef-genedy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yousef-genedy/subscriptions", "organizations_url": "https://api.github.com/users/yousef-genedy/orgs", "repos_url": "https://api.github.com/users/yousef-genedy/repos", "events_url": "https://api.github.com/users/yousef-genedy/events{/privacy}", "received_events_url": "https://api.github.com/users/yousef-genedy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-16T05:27:57Z", "updated_at": "2026-02-16T05:27:57Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3906520399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }