{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14401", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14401/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14401/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14401/events", "html_url": "https://github.com/laurent22/joplin/pull/14401", "id": 3969182488, "node_id": "PR_kwDOBLftOs7FMvSr", "number": 14401, "title": "Server: Fixes #14384: Error logged on first startup", "user": { "login": "yugalkaushik", "id": 138966980, "node_id": "U_kgDOCEh3xA", "avatar_url": "https://avatars.githubusercontent.com/u/138966980?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yugalkaushik", "html_url": "https://github.com/yugalkaushik", "followers_url": "https://api.github.com/users/yugalkaushik/followers", "following_url": "https://api.github.com/users/yugalkaushik/following{/other_user}", "gists_url": "https://api.github.com/users/yugalkaushik/gists{/gist_id}", "starred_url": "https://api.github.com/users/yugalkaushik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yugalkaushik/subscriptions", "organizations_url": "https://api.github.com/users/yugalkaushik/orgs", "repos_url": "https://api.github.com/users/yugalkaushik/repos", "events_url": "https://api.github.com/users/yugalkaushik/events{/privacy}", "received_events_url": "https://api.github.com/users/yugalkaushik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 2115946553, "node_id": "MDU6TGFiZWwyMTE1OTQ2NTUz", "url": "https://api.github.com/repos/laurent22/joplin/labels/database", "name": "database", "color": "91ca55", "default": false, "description": "Database issues" }, { "id": 2676541710, "node_id": "MDU6TGFiZWwyNjc2NTQxNzEw", "url": "https://api.github.com/repos/laurent22/joplin/labels/server", "name": "server", "color": "ffc274", "default": false, "description": "Issues related to Joplin Server" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 5, "created_at": "2026-02-20T15:47:03Z", "updated_at": "2026-02-22T10:28:13Z", "closed_at": "2026-02-20T19:35:38Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14401", "html_url": "https://github.com/laurent22/joplin/pull/14401", "diff_url": "https://github.com/laurent22/joplin/pull/14401.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14401.patch", "merged_at": "2026-02-20T19:35:38Z" }, "body": "Fixes #14384\r\nThe fixMigrationNames function tries to update the knex_migrations table before migrations run. The knex error event handler logged the error before the catch block could handle it silently.\r\nAdded a QueryContext with noSuchTableErrorLoggingDisabled: true to the query, preventing the error from being logged while still allowing the catch block to handle it.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14401/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14401/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3935683607", "html_url": "https://github.com/laurent22/joplin/pull/14401#issuecomment-3935683607", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14401", "id": 3935683607, "node_id": "IC_kwDOBLftOs7qlcQX", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-20T15:47:16Z", "updated_at": "2026-02-20T19:50:26Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ βœ…", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3935683607/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3935685167", "html_url": "https://github.com/laurent22/joplin/pull/14401#issuecomment-3935685167", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14401", "id": 3935685167, "node_id": "IC_kwDOBLftOs7qlcov", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-20T15:47:36Z", "updated_at": "2026-02-20T18:47:08Z", "body": "\nNo actionable comments were generated in the recent review. πŸŽ‰\n\n---\n\n\n\n\n
\nπŸ“ Walkthrough\n\n## Walkthrough\n\nUpdated the migration-name fix in the server DB code to apply a QueryContext with `noSuchTableErrorLoggingDisabled: true` to the Knex update query, suppressing \"no such table\" error logging when the `knex_migrations` table is absent during startup.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Database error handling**
`packages/server/src/db.ts`|In `fixMigrationNames`, construct a QueryContext with `noSuchTableErrorLoggingDisabled: true` and apply `.queryContext(context)` to the Knex update query so that \"no such table\" errors are not logged when `knex_migrations` doesn't exist on first startup.|\n\n
\n\n\n\n\n\n\n
\nπŸš₯ Pre-merge checks | βœ… 5\n\n
\nβœ… Passed checks (5 passed)\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | βœ… Passed | The title clearly summarises the main change: fixing issue `#14384` regarding an error logged on first startup. |\n| Description check | βœ… Passed | The description accurately explains the problem and solution, detailing the fixMigrationNames function issue and the QueryContext approach used. |\n| Linked Issues check | βœ… Passed | The PR successfully addresses issue `#14384` by preventing the 'no such table' error from being logged whilst preserving existing error handling logic. |\n| Out of Scope Changes check | βœ… Passed | All changes are directly related to fixing the logging issue in fixMigrationNames; no out-of-scope modifications are present. |\n| Docstring Coverage | βœ… Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n- [ ] πŸ“ Generate docstrings (stacked PR)\n- [ ] πŸ“ Generate docstrings (commit on current branch)\n
\nπŸ§ͺ Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n---\n\n\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3935685167/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes.Β \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code.Β The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issuesΒ \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3935917190", "html_url": "https://github.com/laurent22/joplin/pull/14401#issuecomment-3935917190", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14401", "id": 3935917190, "node_id": "IC_kwDOBLftOs7qmVSG", "user": { "login": "yugalkaushik", "id": 138966980, "node_id": "U_kgDOCEh3xA", "avatar_url": "https://avatars.githubusercontent.com/u/138966980?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yugalkaushik", "html_url": "https://github.com/yugalkaushik", "followers_url": "https://api.github.com/users/yugalkaushik/followers", "following_url": "https://api.github.com/users/yugalkaushik/following{/other_user}", "gists_url": "https://api.github.com/users/yugalkaushik/gists{/gist_id}", "starred_url": "https://api.github.com/users/yugalkaushik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yugalkaushik/subscriptions", "organizations_url": "https://api.github.com/users/yugalkaushik/orgs", "repos_url": "https://api.github.com/users/yugalkaushik/repos", "events_url": "https://api.github.com/users/yugalkaushik/events{/privacy}", "received_events_url": "https://api.github.com/users/yugalkaushik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-20T16:35:51Z", "updated_at": "2026-02-20T16:35:51Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3935917190/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3936512610", "html_url": "https://github.com/laurent22/joplin/pull/14401#issuecomment-3936512610", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14401", "id": 3936512610, "node_id": "IC_kwDOBLftOs7qompi", "user": { "login": "yugalkaushik", "id": 138966980, "node_id": "U_kgDOCEh3xA", "avatar_url": "https://avatars.githubusercontent.com/u/138966980?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yugalkaushik", "html_url": "https://github.com/yugalkaushik", "followers_url": "https://api.github.com/users/yugalkaushik/followers", "following_url": "https://api.github.com/users/yugalkaushik/following{/other_user}", "gists_url": "https://api.github.com/users/yugalkaushik/gists{/gist_id}", "starred_url": "https://api.github.com/users/yugalkaushik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yugalkaushik/subscriptions", "organizations_url": "https://api.github.com/users/yugalkaushik/orgs", "repos_url": "https://api.github.com/users/yugalkaushik/repos", "events_url": "https://api.github.com/users/yugalkaushik/events{/privacy}", "received_events_url": "https://api.github.com/users/yugalkaushik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-20T18:45:08Z", "updated_at": "2026-02-20T18:45:08Z", "body": "@personalizedrefrigerator thank you for the suggestion.", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3936512610/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3936721955", "html_url": "https://github.com/laurent22/joplin/pull/14401#issuecomment-3936721955", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14401", "id": 3936721955, "node_id": "IC_kwDOBLftOs7qpZwj", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-20T19:34:55Z", "updated_at": "2026-02-20T19:34:55Z", "body": "Looks good, thank you!", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3936721955/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }