{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14753/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14753/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14753/events", "html_url": "https://github.com/laurent22/joplin/pull/14753", "id": 4078526195, "node_id": "PR_kwDOBLftOs7Kuo2S", "number": 14753, "title": "Mobile: fix Android new to-do keyboard focus", "user": { "login": "zainAwan9175", "id": 157986920, "node_id": "U_kgDOCWqwaA", "avatar_url": "https://avatars.githubusercontent.com/u/157986920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zainAwan9175", "html_url": "https://github.com/zainAwan9175", "followers_url": "https://api.github.com/users/zainAwan9175/followers", "following_url": "https://api.github.com/users/zainAwan9175/following{/other_user}", "gists_url": "https://api.github.com/users/zainAwan9175/gists{/gist_id}", "starred_url": "https://api.github.com/users/zainAwan9175/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zainAwan9175/subscriptions", "organizations_url": "https://api.github.com/users/zainAwan9175/orgs", "repos_url": "https://api.github.com/users/zainAwan9175/repos", "events_url": "https://api.github.com/users/zainAwan9175/events{/privacy}", "received_events_url": "https://api.github.com/users/zainAwan9175/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1079605111, "node_id": "MDU6TGFiZWwxMDc5NjA1MTEx", "url": "https://api.github.com/repos/laurent22/joplin/labels/mobile", "name": "mobile", "color": "ffc274", "default": false, "description": "All mobile platforms" }, { "id": 1366672041, "node_id": "MDU6TGFiZWwxMzY2NjcyMDQx", "url": "https://api.github.com/repos/laurent22/joplin/labels/android", "name": "android", "color": "bfd4f2", "default": false, "description": "" }, { "id": 1366672371, "node_id": "MDU6TGFiZWwxMzY2NjcyMzcx", "url": "https://api.github.com/repos/laurent22/joplin/labels/editor", "name": "editor", "color": "91ca55", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 11, "created_at": "2026-03-15T14:50:06Z", "updated_at": "2026-03-16T12:09:27Z", "closed_at": "2026-03-16T12:09:17Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14753", "html_url": "https://github.com/laurent22/joplin/pull/14753", "diff_url": "https://github.com/laurent22/joplin/pull/14753.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14753.patch", "merged_at": null }, "body": "\r\nFixes #14747\r\n### **Problem**\r\nOn Android, creating a new to-do while edit mode is active could focus the title field without opening the keyboard. If the title field was tapped and typing started, the keyboard could then dismiss unexpectedly.\r\n\r\n\r\n### **Solution**\r\nThis change updates note focus behavior on mobile so it matches expected behavior in both scenarios.\r\nFor newly created provisional to-dos, focus handling now tolerates Android timing around navigation so the keyboard appears reliably when title autofocus is expected.\r\nFor existing notes, title re-focus is prevented in view mode, so opening an existing note does not auto-focus a field or open the keyboard.\r\nThe title input behavior was also adjusted to avoid focus loss during title layout changes, which prevents the keyboard from being dismissed while typing.\r\n### **Test Plan**\r\nAutomated\r\n\r\nRan targeted note screen tests and confirmed they pass.\r\n### **Manual (Android)**\r\n\r\nOpen an existing note.\r\nExpected: no focused field, no keyboard shown.\r\nWhile edit mode is active, create a new to-do.\r\nExpected: title is focused and keyboard appears.\r\nStart typing in title.\r\nExpected: keyboard remains visible.\r\n### ** Video**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/75330ff7-9090-43e6-bc72-4bdbb441b7e9\r\n\r\n\r\n\r\n\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14753/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14753/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063155400", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063155400", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063155400, "node_id": "IC_kwDOBLftOs7yLtTI", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T14:50:28Z", "updated_at": "2026-03-15T19:09:16Z", "body": "\n\n\n
\nđź“ť Walkthrough\n\n## Walkthrough\n\nRestricts autofocus to edit mode in the Note component and adds an Android-specific focus-retry loop with timing/grace rules. Adds tests that mock focusHandler, provide a provisional-note helper, and verify autofocus for new notes and absence of autofocus for existing notes.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Tests**
`packages/app-mobile/components/screens/Note/Note.test.tsx`|Adds `focusHandler` mock and exposes focus for assertions; introduces `openProvisionalNote` test helper; resets mocks in beforeEach; adds autofocus tests for provisional to-dos and non-autofocus behaviour for existing notes; minor type hints and test utility types.|\n|**Focus & Retry Logic**
`packages/app-mobile/components/screens/Note/Note.tsx`|Restricts title autofocus to edit mode; implements Android-specific `scheduleFocusUpdate` retry loop with `wasFocused`/`didFocus` tracking, minimum retry duration (350ms), and termination/grace rules; removes TextInput key-based render optimisation.|\n\n## Sequence Diagram(s)\n\nmermaid\nsequenceDiagram\n participant Note as Note component\n participant Focus as focusHandler\n participant System as Android Keyboard/System\n Note->>Focus: scheduleFocusUpdate(field)\n Note->>Note: start retry loop (wasFocused=false, didFocus=false, grace timer)\n Note->>Focus: attempt focus(field)\n Focus-->>Note: focus result (success/failure)\n alt focus succeeded\n Note->>Note: set didFocus=true, wasFocused=true if applicable\n Note->>System: request keyboard show\n else focus failed or before minDuration\n Note->>Note: continue retries until minDuration elapsed or editor hidden or field cleared\n end\n\n## Possibly related PRs\n\n- laurent22/joplin#14533: Modifies Note focus/keyboard behaviour and touches title/key handling; closely related to the autofocus changes here.\n\n## Suggested reviewers\n\n- laurent22\n- Kaushalendra-Marcus\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 6\n\n
\nâś… Passed checks (6 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | âś… Passed | The title clearly and specifically describes the main fix: addressing Android keyboard focus issues when creating new to-dos on mobile. |\n| Linked Issues check | âś… Passed | The changeset addresses all coding requirements from issue `#14747`: reliable keyboard focus for new provisional to-dos [`#14747`], prevented auto-focus in view mode [`#14747`], and prevented keyboard dismissal during typing [`#14747`]. |\n| Out of Scope Changes check | âś… Passed | All changes are directly scoped to the linked issue: focus retry logic for Android navigation timing, mode-aware focus triggering, test additions for autofocus verification, and TextInput optimisations. |\n| Docstring Coverage | âś… Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | âś… Passed | PR description fully adheres to required guidelines with all three mandatory sections: problem statement focusing on user impact, high-level solution explanation avoiding implementation details, and comprehensive testing verification. |\n| Description check | âś… Passed | The pull request description clearly describes the problem (Android keyboard focus issues with new to-dos), the solution (updated focus handling for provisional notes and view mode), and includes test plans with manual Android testing steps. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n
\nđź“ť Coding Plan\n\n- [ ] Generate coding plan for human review comments\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14753)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063155400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063175434", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063175434", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063175434, "node_id": "IC_kwDOBLftOs7yLyMK", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:01:16Z", "updated_at": "2026-03-15T15:01:16Z", "body": "Why is there no Edit/View button on your video?", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063175434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063214597", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063214597", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063214597, "node_id": "IC_kwDOBLftOs7yL7wF", "user": { "login": "zainAwan9175", "id": 157986920, "node_id": "U_kgDOCWqwaA", "avatar_url": "https://avatars.githubusercontent.com/u/157986920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zainAwan9175", "html_url": "https://github.com/zainAwan9175", "followers_url": "https://api.github.com/users/zainAwan9175/followers", "following_url": "https://api.github.com/users/zainAwan9175/following{/other_user}", "gists_url": "https://api.github.com/users/zainAwan9175/gists{/gist_id}", "starred_url": "https://api.github.com/users/zainAwan9175/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zainAwan9175/subscriptions", "organizations_url": "https://api.github.com/users/zainAwan9175/orgs", "repos_url": "https://api.github.com/users/zainAwan9175/repos", "events_url": "https://api.github.com/users/zainAwan9175/events{/privacy}", "received_events_url": "https://api.github.com/users/zainAwan9175/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:21:25Z", "updated_at": "2026-03-15T15:21:25Z", "body": "> Why is there no Edit/View button on your video?\r\n\r\nYou’re right. My previous video starts too late and doesn’t clearly show the note in view mode. I will upload an updated recording that first shows an existing note opened in view mode with the Edit button visible (and no keyboard), then shows creating a new to-do while edit mode is active, with title autofocus and keyboard staying open while typing.", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063214597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063217915", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063217915", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063217915, "node_id": "IC_kwDOBLftOs7yL8j7", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:23:31Z", "updated_at": "2026-03-16T12:09:27Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063217915/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063221797", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063221797", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063221797, "node_id": "IC_kwDOBLftOs7yL9gl", "user": { "login": "zainAwan9175", "id": 157986920, "node_id": "U_kgDOCWqwaA", "avatar_url": "https://avatars.githubusercontent.com/u/157986920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zainAwan9175", "html_url": "https://github.com/zainAwan9175", "followers_url": "https://api.github.com/users/zainAwan9175/followers", "following_url": "https://api.github.com/users/zainAwan9175/following{/other_user}", "gists_url": "https://api.github.com/users/zainAwan9175/gists{/gist_id}", "starred_url": "https://api.github.com/users/zainAwan9175/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zainAwan9175/subscriptions", "organizations_url": "https://api.github.com/users/zainAwan9175/orgs", "repos_url": "https://api.github.com/users/zainAwan9175/repos", "events_url": "https://api.github.com/users/zainAwan9175/events{/privacy}", "received_events_url": "https://api.github.com/users/zainAwan9175/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:25:52Z", "updated_at": "2026-03-15T15:25:52Z", "body": "I have read the CLA Document and I hereby sign the CLA\r\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063221797/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063223200", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063223200", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063223200, "node_id": "IC_kwDOBLftOs7yL92g", "user": { "login": "zainAwan9175", "id": 157986920, "node_id": "U_kgDOCWqwaA", "avatar_url": "https://avatars.githubusercontent.com/u/157986920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zainAwan9175", "html_url": "https://github.com/zainAwan9175", "followers_url": "https://api.github.com/users/zainAwan9175/followers", "following_url": "https://api.github.com/users/zainAwan9175/following{/other_user}", "gists_url": "https://api.github.com/users/zainAwan9175/gists{/gist_id}", "starred_url": "https://api.github.com/users/zainAwan9175/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zainAwan9175/subscriptions", "organizations_url": "https://api.github.com/users/zainAwan9175/orgs", "repos_url": "https://api.github.com/users/zainAwan9175/repos", "events_url": "https://api.github.com/users/zainAwan9175/events{/privacy}", "received_events_url": "https://api.github.com/users/zainAwan9175/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:26:36Z", "updated_at": "2026-03-15T15:26:36Z", "body": "recheck", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063223200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063225632", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063225632", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063225632, "node_id": "IC_kwDOBLftOs7yL-cg", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:28:00Z", "updated_at": "2026-03-15T15:28:00Z", "body": "> You’re right. My previous video starts too late and doesn’t clearly show the note in view mode. I will upload an updated recording that first shows an existing note opened in view mode with the Edit button visible (and no keyboard), then shows creating a new to-do while edit mode is active, with title autofocus and keyboard staying open while typing.\r\n\r\nThat's not what I mean at all", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063225632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063253821", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063253821", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063253821, "node_id": "IC_kwDOBLftOs7yMFU9", "user": { "login": "zainAwan9175", "id": 157986920, "node_id": "U_kgDOCWqwaA", "avatar_url": "https://avatars.githubusercontent.com/u/157986920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zainAwan9175", "html_url": "https://github.com/zainAwan9175", "followers_url": "https://api.github.com/users/zainAwan9175/followers", "following_url": "https://api.github.com/users/zainAwan9175/following{/other_user}", "gists_url": "https://api.github.com/users/zainAwan9175/gists{/gist_id}", "starred_url": "https://api.github.com/users/zainAwan9175/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zainAwan9175/subscriptions", "organizations_url": "https://api.github.com/users/zainAwan9175/orgs", "repos_url": "https://api.github.com/users/zainAwan9175/repos", "events_url": "https://api.github.com/users/zainAwan9175/events{/privacy}", "received_events_url": "https://api.github.com/users/zainAwan9175/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T15:43:32Z", "updated_at": "2026-03-15T15:43:32Z", "body": "> > You’re right. My previous video starts too late and doesn’t clearly show the note in view mode. I will upload an updated recording that first shows an existing note opened in view mode with the Edit button visible (and no keyboard), then shows creating a new to-do while edit mode is active, with title autofocus and keyboard staying open while typing.\r\n> \r\n> That's not what I mean at all\r\n\r\nlaurent Thanks for clarifying. Could you please specify what exact evidence you want in the video?\r\nI can currently show:\r\n\r\nexisting note in view mode with the pencil edit control visible and keyboard hidden,\r\nswitching to edit mode,\r\ncreating a new to-do while edit mode is active,\r\ntitle autofocus with keyboard visible, and\r\nkeyboard staying open while typing.", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063253821/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063386527", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063386527", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063386527, "node_id": "IC_kwDOBLftOs7yMluf", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T16:48:49Z", "updated_at": "2026-03-15T16:48:49Z", "body": "You don't appear to be using the right version of Joplin. How can you replicate and fix this, if you're using a different version? And if you were using the dev version you would know what I'm talking about, and I wouldn't even ask the question", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063386527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063694286", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4063694286", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4063694286, "node_id": "IC_kwDOBLftOs7yNw3O", "user": { "login": "zainAwan9175", "id": 157986920, "node_id": "U_kgDOCWqwaA", "avatar_url": "https://avatars.githubusercontent.com/u/157986920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zainAwan9175", "html_url": "https://github.com/zainAwan9175", "followers_url": "https://api.github.com/users/zainAwan9175/followers", "following_url": "https://api.github.com/users/zainAwan9175/following{/other_user}", "gists_url": "https://api.github.com/users/zainAwan9175/gists{/gist_id}", "starred_url": "https://api.github.com/users/zainAwan9175/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zainAwan9175/subscriptions", "organizations_url": "https://api.github.com/users/zainAwan9175/orgs", "repos_url": "https://api.github.com/users/zainAwan9175/repos", "events_url": "https://api.github.com/users/zainAwan9175/events{/privacy}", "received_events_url": "https://api.github.com/users/zainAwan9175/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-15T19:08:21Z", "updated_at": "2026-03-15T19:08:21Z", "body": "> You don't appear to be using the right version of Joplin. How can you replicate and fix this, if you're using a different version? And if you were using the dev version you would know what I'm talking about, and I wouldn't even ask the question\r\n\r\nI have since synced with the latest upstream/dev and rebuilt from scratch. The toggle Edit/View button now appears correctly. I will upload a new video", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063694286/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4067203783", "html_url": "https://github.com/laurent22/joplin/pull/14753#issuecomment-4067203783", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14753", "id": 4067203783, "node_id": "IC_kwDOBLftOs7ybJrH", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-16T12:09:17Z", "updated_at": "2026-03-16T12:09:17Z", "body": "Hello, this was actually fixed in https://github.com/laurent22/joplin/pull/14533", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4067203783/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }