wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/AliceHincu_53339016.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

907 行
43 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10222/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10222/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/10222/events",
"html_url": "https://github.com/laurent22/joplin/pull/10222",
"id": 2212131364,
"node_id": "PR_kwDOBLftOs5q_wDu",
"number": 10222,
"title": "Desktop: Focus is lost and notebook disappears (laurent22#10194)",
"user": {
"login": "AliceHincu",
"id": 53339016,
"node_id": "MDQ6VXNlcjUzMzM5MDE2",
"avatar_url": "https://avatars.githubusercontent.com/u/53339016?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AliceHincu",
"html_url": "https://github.com/AliceHincu",
"followers_url": "https://api.github.com/users/AliceHincu/followers",
"following_url": "https://api.github.com/users/AliceHincu/following{/other_user}",
"gists_url": "https://api.github.com/users/AliceHincu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AliceHincu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AliceHincu/subscriptions",
"organizations_url": "https://api.github.com/users/AliceHincu/orgs",
"repos_url": "https://api.github.com/users/AliceHincu/repos",
"events_url": "https://api.github.com/users/AliceHincu/events{/privacy}",
"received_events_url": "https://api.github.com/users/AliceHincu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 16,
"created_at": "2024-03-28T00:42:39Z",
"updated_at": "2024-04-28T19:59:56Z",
"closed_at": "2024-04-25T13:10:50Z",
"author_association": "CONTRIBUTOR",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/10222",
"html_url": "https://github.com/laurent22/joplin/pull/10222",
"diff_url": "https://github.com/laurent22/joplin/pull/10222.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/10222.patch",
"merged_at": null
},
"body": "The problem here arises from the fact that \"All notes\" has as `selectedFolderId` the value _Folder_, even though it should have the value _SmartFilter_. By switching those two lines, the type is correctly set. Before, \"All notes\" section was treated as a Folder, and for each note it wouldn't show from what notebook it came. After this modification, the UI is correct.\r\n\r\nWhen the selected folder id is null, I set the default option to be the \"All notes\" folder.\r\n\r\nUnfortunately I am unable to screen record to showcase this fix, because of some issues with my laptop, I am sorry.",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/10222/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10222/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2024207453",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2024207453",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2024207453,
"node_id": "IC_kwDOBLftOs54pvRd",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T00:42:55Z",
"updated_at": "2024-04-15T16:51:36Z",
"author_association": "CONTRIBUTOR",
"body": "**CLA Assistant Lite bot:** <br/>Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.<br/>\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **2** out of **3** committers have signed the CLA.<br/>:white_check_mark: (AliceHincu)[https://github.com/AliceHincu]<br/>:white_check_mark: (personalizedrefrigerator)[https://github.com/personalizedrefrigerator]<br/>:x: @Alice Hincu<br/>**Alice Hincu** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You can retrigger this bot by commenting **recheck** in this Pull Request</sub>",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2024207453/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2025-03-07T16:35:00Z",
"permissions": {
"actions": "write",
"administration": "read",
"attestations": "write",
"checks": "write",
"contents": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"project",
"project_card",
"project_column",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2024210034",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2024210034",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2024210034,
"node_id": "IC_kwDOBLftOs54pv5y",
"user": {
"login": "AliceHincu",
"id": 53339016,
"node_id": "MDQ6VXNlcjUzMzM5MDE2",
"avatar_url": "https://avatars.githubusercontent.com/u/53339016?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AliceHincu",
"html_url": "https://github.com/AliceHincu",
"followers_url": "https://api.github.com/users/AliceHincu/followers",
"following_url": "https://api.github.com/users/AliceHincu/following{/other_user}",
"gists_url": "https://api.github.com/users/AliceHincu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AliceHincu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AliceHincu/subscriptions",
"organizations_url": "https://api.github.com/users/AliceHincu/orgs",
"repos_url": "https://api.github.com/users/AliceHincu/repos",
"events_url": "https://api.github.com/users/AliceHincu/events{/privacy}",
"received_events_url": "https://api.github.com/users/AliceHincu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T00:46:38Z",
"updated_at": "2024-03-28T00:46:38Z",
"author_association": "CONTRIBUTOR",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2024210034/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2024802732",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2024802732",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2024802732,
"node_id": "IC_kwDOBLftOs54sAms",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T09:52:54Z",
"updated_at": "2024-03-28T09:52:54Z",
"author_association": "CONTRIBUTOR",
"body": "Hi! Thank you for working on the issue. I made these changes, and yeah, I did not catch that. Calling the `folderItem_click(ALL_NOTES_FILTER_ID);` first is indeed better, in this case, to show what notes belong to what notebooks.\r\n\r\nCan you check whether your changes affect `Toggle own sort order` for All notes? You can test it by right-clicking on the `All Notes`.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2024802732/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025019562",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2025019562",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2025019562,
"node_id": "IC_kwDOBLftOs54s1iq",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T12:03:38Z",
"updated_at": "2024-03-28T12:03:38Z",
"author_association": "OWNER",
"body": "By the way does this pull request need to be labelled for GSoC?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025019562/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025077459",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2025077459",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2025077459,
"node_id": "IC_kwDOBLftOs54tDrT",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T12:32:36Z",
"updated_at": "2024-03-28T14:00:36Z",
"author_association": "CONTRIBUTOR",
"body": "Update: Your changes will not work for the `Toggle own sort order`. However, because I understand much better the Joplin codebase than few weeks ago, we can make the solution smarter and not change the folder type twice by doing this: \r\n\r\n```typescript\r\n// In togglePerFolderSortOrder.ts\r\n// Added another parameter called: folderName\r\n\r\nexecute: async (_context: CommandContext, folderId?: string, own?: boolean, folderName?: string) => {\r\n\t PerFolderSortOrderService.set(folderId, own, folderName);\r\n},\r\n```\r\n\r\n```typescript\r\n// Siderbar.tsx\r\nconst onAllNotesClick_ = useCallback(() => {\r\n props.dispatch({\r\n\t type: 'SMART_FILTER_SELECT',\r\n\t id: ALL_NOTES_FILTER_ID,\r\n });\r\n PerFolderSortOrderService.selectNonFolder('All Notes');\r\n}, [props.dispatch]);\r\n\r\n...menuUtils.commandToStatefulMenuItem('togglePerFolderSortOrder', ALL_NOTES_FILTER_ID, undefined, 'All Notes'),\r\n```\r\n\r\n```typescript\r\n// PerFolderSortOrderService.ts\r\n// We will dynamically change the folderName\r\n\r\npublic static selectNonFolder(folderName: string) {\r\n\tthis.folderName = folderName;\r\n}\r\n\r\npublic static set(folderId?: string, own?: boolean, folderName?: string) {\r\n\tlet targetId = folderId;\r\n\tif (folderName !== undefined) {\r\n\t\tthis.folderName = folderName;\r\n\t} else {\r\n\t\tthis.folderName = null;\r\n\t}\r\n .\r\n .\r\n}\r\n\r\nprivate static getSelectedFolderId(): string {\r\n if (this.folderState.notesParentType === 'Folder') {\r\n\t return this.folderState.selectedFolderId;\r\n } else if (this.folderState.notesParentType === 'SmartFilter') {\r\n\t if (this.folderName === 'All Notes') {\r\n\t\t return ALL_NOTES_FILTER_ID;\r\n\t }\r\n } else {\r\n\t return '';\r\n }\r\n}\r\n```\r\n\r\nThis works and solves the bug :) \r\n\r\nAlso, this solves the problem of other folders being `SmartFilter` as well as we discussed in our PR, if you remember laurent22. The solution will keep things decoupled.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025077459/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025241667",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2025241667",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2025241667,
"node_id": "IC_kwDOBLftOs54trxD",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T13:53:28Z",
"updated_at": "2024-03-28T14:50:58Z",
"author_association": "CONTRIBUTOR",
"body": "My fixes might be out of the scope of the PR. \r\n\r\nI suggest that we use AliceHincu's implementation to fix the bug as fast as possible since this issue is a high priority and the deadline for the GSoC application is approaching soon. When this PR is merged, I will fix the `Toggle own sort order` in another PR.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025241667/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025540868",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2025540868",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2025540868,
"node_id": "IC_kwDOBLftOs54u00E",
"user": {
"login": "Aitchessbee",
"id": 45175270,
"node_id": "MDQ6VXNlcjQ1MTc1Mjcw",
"avatar_url": "https://avatars.githubusercontent.com/u/45175270?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Aitchessbee",
"html_url": "https://github.com/Aitchessbee",
"followers_url": "https://api.github.com/users/Aitchessbee/followers",
"following_url": "https://api.github.com/users/Aitchessbee/following{/other_user}",
"gists_url": "https://api.github.com/users/Aitchessbee/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Aitchessbee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Aitchessbee/subscriptions",
"organizations_url": "https://api.github.com/users/Aitchessbee/orgs",
"repos_url": "https://api.github.com/users/Aitchessbee/repos",
"events_url": "https://api.github.com/users/Aitchessbee/events{/privacy}",
"received_events_url": "https://api.github.com/users/Aitchessbee/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T15:46:52Z",
"updated_at": "2024-03-28T18:05:55Z",
"author_association": "NONE",
"body": "> My fixes might be out of the scope of the PR.\r\n> \r\n> I suggest that we use AliceHincu's implementation to fix the bug as fast as possible since this issue is a high priority and the deadline for the GSoC application is approaching soon. When this PR is merged, I will fix the `Toggle own sort order` in another PR.\r\n\r\nAny comments on the approach I tried in https://github.com/laurent22/joplin/pull/10220? To me, the approach in this PR looks better... (Edit- by this, I meant Alice's PR)",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025540868/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025777903",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2025777903",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2025777903,
"node_id": "IC_kwDOBLftOs54vurv",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-28T17:42:00Z",
"updated_at": "2024-03-28T17:42:00Z",
"author_association": "CONTRIBUTOR",
"body": "> > My fixes might be out of the scope of the PR.\r\n> > I suggest that we use AliceHincu's implementation to fix the bug as fast as possible since this issue is a high priority and the deadline for the GSoC application is approaching soon. When this PR is merged, I will fix the `Toggle own sort order` in another PR.\r\n> \r\n> Any comments on the approach I tried in #10220? To me, the approach in this PR looks better...\r\n\r\nThanks for looking at the issue, too! I had a look and tried to test it, but unfortunately, your changes do not fix the current bug for this issue.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2025777903/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2026856332",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2026856332",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2026856332,
"node_id": "IC_kwDOBLftOs54z1-M",
"user": {
"login": "AliceHincu",
"id": 53339016,
"node_id": "MDQ6VXNlcjUzMzM5MDE2",
"avatar_url": "https://avatars.githubusercontent.com/u/53339016?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AliceHincu",
"html_url": "https://github.com/AliceHincu",
"followers_url": "https://api.github.com/users/AliceHincu/followers",
"following_url": "https://api.github.com/users/AliceHincu/following{/other_user}",
"gists_url": "https://api.github.com/users/AliceHincu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AliceHincu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AliceHincu/subscriptions",
"organizations_url": "https://api.github.com/users/AliceHincu/orgs",
"repos_url": "https://api.github.com/users/AliceHincu/repos",
"events_url": "https://api.github.com/users/AliceHincu/events{/privacy}",
"received_events_url": "https://api.github.com/users/AliceHincu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-29T08:20:40Z",
"updated_at": "2024-03-29T08:20:40Z",
"author_association": "CONTRIBUTOR",
"body": "Hi! Sorry for not replying earlier. Yes, this should be labeled for gsoc. ",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2026856332/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2027158689",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2027158689",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2027158689,
"node_id": "IC_kwDOBLftOs540_yh",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-29T12:03:24Z",
"updated_at": "2024-03-29T12:03:24Z",
"author_association": "OWNER",
"body": "@AliceHincu, ok that's done. Also please remember that the deadline to submit your application is 2 April so if you haven't done so already consider preparing it in parallel. You can also send us a PM so that we can review your project proposal before you submit it as described here: https://discourse.joplinapp.org/t/the-gsoc-application-deadline-is-on-april-2/37107/2",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2027158689/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2047700800",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2047700800",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2047700800,
"node_id": "IC_kwDOBLftOs56DW9A",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-04-10T14:25:01Z",
"updated_at": "2024-04-10T14:25:01Z",
"author_association": "OWNER",
"body": "@AliceHincu, it looks good now but there's a conflict. Could you please fix it and then we can merge?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2047700800/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2057399135",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2057399135",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2057399135,
"node_id": "IC_kwDOBLftOs56oWtf",
"user": {
"login": "personalizedrefrigerator",
"id": 46334387,
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/personalizedrefrigerator",
"html_url": "https://github.com/personalizedrefrigerator",
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-04-15T16:59:10Z",
"updated_at": "2024-04-15T16:59:10Z",
"author_association": "COLLABORATOR",
"body": "It looks like https://github.com/laurent22/joplin/pull/10222/commits/89acde9035d8fe5c3b6d7adf6592debab87f0a4e has incorrect authorship information (uses an email not associated with the @AliceHincu GitHub account). This seems to be causing the CLA Assistant check to fail.\r\n\r\n[This StackOverflow post](https://stackoverflow.com/a/1320317) may be helpful in changing the author information for 89acde9035d8fe5c3b6d7adf6592debab87f0a4e.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2057399135/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2058329028",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2058329028",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2058329028,
"node_id": "IC_kwDOBLftOs56r5vE",
"user": {
"login": "AliceHincu",
"id": 53339016,
"node_id": "MDQ6VXNlcjUzMzM5MDE2",
"avatar_url": "https://avatars.githubusercontent.com/u/53339016?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AliceHincu",
"html_url": "https://github.com/AliceHincu",
"followers_url": "https://api.github.com/users/AliceHincu/followers",
"following_url": "https://api.github.com/users/AliceHincu/following{/other_user}",
"gists_url": "https://api.github.com/users/AliceHincu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AliceHincu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AliceHincu/subscriptions",
"organizations_url": "https://api.github.com/users/AliceHincu/orgs",
"repos_url": "https://api.github.com/users/AliceHincu/repos",
"events_url": "https://api.github.com/users/AliceHincu/events{/privacy}",
"received_events_url": "https://api.github.com/users/AliceHincu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-04-16T06:31:23Z",
"updated_at": "2024-04-16T06:31:23Z",
"author_association": "CONTRIBUTOR",
"body": "Hi, sorry for not responding earlier, I was sick for a few days. I will take a look at the article today to fix the issue",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2058329028/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077146672",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2077146672",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2077146672,
"node_id": "IC_kwDOBLftOs57zr4w",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-04-25T13:10:50Z",
"updated_at": "2024-04-25T13:10:50Z",
"author_association": "OWNER",
"body": "Thanks for looking into this but this issue has now been fixed in #10370",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077146672/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2081632548",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2081632548",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2081632548,
"node_id": "IC_kwDOBLftOs58EzEk",
"user": {
"login": "Dricc123",
"id": 75565258,
"node_id": "MDQ6VXNlcjc1NTY1MjU4",
"avatar_url": "https://avatars.githubusercontent.com/u/75565258?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Dricc123",
"html_url": "https://github.com/Dricc123",
"followers_url": "https://api.github.com/users/Dricc123/followers",
"following_url": "https://api.github.com/users/Dricc123/following{/other_user}",
"gists_url": "https://api.github.com/users/Dricc123/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Dricc123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Dricc123/subscriptions",
"organizations_url": "https://api.github.com/users/Dricc123/orgs",
"repos_url": "https://api.github.com/users/Dricc123/repos",
"events_url": "https://api.github.com/users/Dricc123/events{/privacy}",
"received_events_url": "https://api.github.com/users/Dricc123/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-04-28T19:51:50Z",
"updated_at": "2024-04-28T19:52:06Z",
"author_association": "NONE",
"body": "Not sure where I shall post this because there are many merged/duplicate issues but I still have something wrong going on related to that. most of it has been fixed, but when I'm in the 'all notes' folder and search for a word, I then go in one of the results of my search and modify the note, and there the note disappears and it jumps to the next note",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2081632548/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2081634958",
"html_url": "https://github.com/laurent22/joplin/pull/10222#issuecomment-2081634958",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10222",
"id": 2081634958,
"node_id": "IC_kwDOBLftOs58EzqO",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-04-28T19:59:55Z",
"updated_at": "2024-04-28T19:59:55Z",
"author_association": "CONTRIBUTOR",
"body": "> Not sure where I shall post this because there are many merged/duplicate issues but I still have something wrong going on related to that. most of it has been fixed, but when I'm in the 'all notes' folder and search for a word, I then go in one of the results of my search and modify the note, and there the note disappears and it jumps to the next note\r\n\r\nThis particular issue can be found here: https://github.com/laurent22/joplin/issues/10236",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2081634958/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接