文件
mynode/readme/cla/consent_records/Ehtesham-Zahid_98094052.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

391 行
32 KiB
JSON

此文件含有不可见的 Unicode 字符

此文件含有人类无法区分的不可见的 Unicode 字符,但可以由计算机进行不同的处理。 如果您是想特意这样的,可以安全地忽略该警告。 使用 Escape 按钮显示他们。

此文件含有可能会与其他字符混淆的 Unicode 字符。 如果您是想特意这样的,可以安全地忽略该警告。 使用 Escape 按钮显示他们。

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14689",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14689/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14689/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14689/events",
"html_url": "https://github.com/laurent22/joplin/pull/14689",
"id": 4055450903,
"node_id": "PR_kwDOBLftOs7JkXhW",
"number": 14689,
"title": "Desktop: Fixes #14687: Prevent TypeError in handleAppFailure when window is destroyed",
"user": {
"login": "Ehtesham-Zahid",
"id": 98094052,
"node_id": "U_kgDOBdjL5A",
"avatar_url": "https://avatars.githubusercontent.com/u/98094052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ehtesham-Zahid",
"html_url": "https://github.com/Ehtesham-Zahid",
"followers_url": "https://api.github.com/users/Ehtesham-Zahid/followers",
"following_url": "https://api.github.com/users/Ehtesham-Zahid/following{/other_user}",
"gists_url": "https://api.github.com/users/Ehtesham-Zahid/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ehtesham-Zahid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ehtesham-Zahid/subscriptions",
"organizations_url": "https://api.github.com/users/Ehtesham-Zahid/orgs",
"repos_url": "https://api.github.com/users/Ehtesham-Zahid/repos",
"events_url": "https://api.github.com/users/Ehtesham-Zahid/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ehtesham-Zahid/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [
{
"id": 519700741,
"node_id": "MDU6TGFiZWw1MTk3MDA3NDE=",
"url": "https://api.github.com/repos/laurent22/joplin/labels/bug",
"name": "bug",
"color": "cf353b",
"default": true,
"description": "It's a bug"
},
{
"id": 1080341216,
"node_id": "MDU6TGFiZWwxMDgwMzQxMjE2",
"url": "https://api.github.com/repos/laurent22/joplin/labels/desktop",
"name": "desktop",
"color": "ffc274",
"default": false,
"description": "All desktop platforms"
}
],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 3,
"created_at": "2026-03-11T03:17:32Z",
"updated_at": "2026-03-14T12:49:30Z",
"closed_at": "2026-03-14T12:44:11Z",
"assignee": null,
"author_association": "CONTRIBUTOR",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14689",
"html_url": "https://github.com/laurent22/joplin/pull/14689",
"diff_url": "https://github.com/laurent22/joplin/pull/14689.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14689.patch",
"merged_at": "2026-03-14T12:44:10Z"
},
"body": "## Problem\r\nFixes #14687\r\n\r\nOn Windows environments (observed during Electron 39 testing), a violent renderer process crash triggers the `handleAppFailure` recovery dialog. While the application successfully initiates a restart when the user selects \"Restart in safe mode,\" a race condition exists during the process teardown.\r\n\r\nBy the time the restart logic attempts to forcefully crash the old renderer to ensure a clean exit, the `BrowserWindow` object has often been destroyed asynchronously by the system. Accessing `this.win_.webContents` at this stage throws a `TypeError: Object has been destroyed`, leading to an unhandled promise rejection in the Main Process. While the app re-opens, this error indicates an unstable teardown and can mask other critical logs during a failure event.\r\n\r\n## Solution\r\nI have implemented defensive guard clauses using the Electron `isDestroyed()` API to harden the failure path:\r\n\r\n1. **Entry Guard:** Added a check at the start of `handleAppFailure`. If the window is already destroyed (due to a violent crash or multiple triggers), the error is captured via the `bridge().captureException` service for logging, and the function returns gracefully.\r\n2. **Restart Guard:** Added a check within the \"Restart in safe mode\" logic. We now verify that `this.win_` is not destroyed before attempting to access `webContents.forcefullyCrashRenderer()`.\r\n\r\nThese changes ensure the Main Process remains stable during recovery and completes the handover to the new process without unhandled exceptions.\r\n\r\n*Note: This is a GSoC 2026 contribution. AI was used to assist in refining the Jest test mocks and environment troubleshooting.*\r\n\r\n## Test Plan\r\n\r\n### Manual Verification\r\nTested on Windows 11 using a development build. \r\n1. Triggered a renderer crash (assertion failure).\r\n2. Confirmed the recovery dialog appeared.\r\n3. Selected \"Restart in safe mode.\"\r\n4. Verified that the app successfully restarted and the terminal logs no longer showed the `TypeError: Object has been destroyed` or unhandled promise rejection.\r\n\r\n### Automated Test\r\nAdded `packages/app-desktop/ElectronAppWrapper.test.ts`. \r\n- This test utilizes a stateful mock to simulate a window that is valid at the handler's entry but becomes destroyed before the restart cleanup logic executes.\r\n- Verified the fix prevents the exception and allows the function to resolve.\r\n\r\n**Run Command:**\r\n`yarn jest ElectronAppWrapper.test.ts`\r\n\r\n## Video\r\nhttps://www.loom.com/share/f8596558952443f7a0645a02825510a3",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14689/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14689/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4035925722",
"html_url": "https://github.com/laurent22/joplin/pull/14689#issuecomment-4035925722",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14689",
"id": 4035925722,
"node_id": "IC_kwDOBLftOs7wj1ba",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-11T03:17:43Z",
"updated_at": "2026-03-14T12:49:30Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4035925722/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4035926550",
"html_url": "https://github.com/laurent22/joplin/pull/14689#issuecomment-4035926550",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14689",
"id": 4035926550,
"node_id": "IC_kwDOBLftOs7wj1oW",
"user": {
"login": "coderabbitai[bot]",
"id": 136622811,
"node_id": "BOT_kgDOCCSy2w",
"avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai%5Bbot%5D",
"html_url": "https://github.com/apps/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-11T03:17:58Z",
"updated_at": "2026-03-11T04:34:26Z",
"body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\nNo actionable comments were generated in the recent review. 🎉\n\n<details>\n<summary>ℹ️ Recent review info</summary>\n\n<details>\n<summary>⚙️ Run configuration</summary>\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `e21eb025-ffb4-4187-bb6a-b8a5799e7bac`\n\n</details>\n\n<details>\n<summary>📥 Commits</summary>\n\nReviewing files that changed from the base of the PR and between 676d290d980ab214cbd19ac7cef3e15a5e47368d and eba493c4c81572a1498709c59251156e640aea9a.\n\n</details>\n\n<details>\n<summary>📒 Files selected for processing (2)</summary>\n\n* `.eslintignore`\n* `.gitignore`\n\n</details>\n\n<details>\n<summary>✅ Files skipped from review due to trivial changes (2)</summary>\n\n* .gitignore\n* .eslintignore\n\n</details>\n\n</details>\n\n---\n\n\n<!-- walkthrough_start -->\n\n<details>\n<summary>📝 Walkthrough</summary>\n\n## Walkthrough\n\nAdds defensive checks in ElectronAppWrapper.handleAppFailure to avoid accessing a destroyed BrowserWindow during restart, a Jest test that reproduces the race condition and verifies no exception is thrown, and updates ignore lists for the generated test artifact.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Window Destruction Guards** <br> `packages/app-desktop/ElectronAppWrapper.ts`|Added early-return guard and additional `isDestroyed()` checks in `handleAppFailure` to prevent calling `webContents.forcefullyCrashRenderer()` when the main window has been destroyed.|\n|**Test Coverage** <br> `packages/app-desktop/ElectronAppWrapper.test.ts`|New test that mocks bridge/electron and restart utilities, injects a mock window with controlled destruction timing, and asserts `handleAppFailure` resolves without throwing and that `forcefullyCrashRenderer` is not called when the window is destroyed after selecting restart in safe mode.|\n|**Ignore Lists** <br> `/.eslintignore`, `/.gitignore` (entries: `packages/app-desktop/ElectronAppWrapper.test.js`)|Added ignore entries for the generated test artifact file to prevent linting/tracking of the transpiled test output.|\n\n## Suggested labels\n\nbug, desktop\n\n</details>\n\n<!-- walkthrough_end -->\n\n\n<!-- pre_merge_checks_walkthrough_start -->\n\n<details>\n<summary>🚥 Pre-merge checks | ✅ 6</summary>\n\n<details>\n<summary>✅ Passed checks (6 passed)</summary>\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | ✅ Passed | The title accurately describes the main fix: preventing a TypeError in handleAppFailure when the window is destroyed, directly addressing issue `#14687`. |\n| Description check | ✅ Passed | The description clearly relates to the changeset, detailing the problem, solution, and testing approach for the window destruction race condition fix. |\n| Linked Issues check | ✅ Passed | The code changes fully address issue `#14687` by implementing defensive guard clauses using isDestroyed() at both entry and restart points, preventing TypeError when accessing destroyed window objects. |\n| Out of Scope Changes check | ✅ Passed | All changes are scoped to fixing the race condition: ElectronAppWrapper.ts guards, test file addition, and configuration file updates (.eslintignore, .gitignore) for the new test. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The pull request description includes all three required sections: comprehensive problem statement, high-level solution explanation, and detailed test plan. |\n\n</details>\n\n<sub>✏️ Tip: You can configure your own custom pre-merge checks in the settings.</sub>\n\n</details>\n\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Post copyable unit tests in a comment\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14689)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAItIDWBNxcAGLwAB7SkGYAjAAsAGwAHADsXFYUJFIYuDCy3CQAohQU+HzwWLCYtF4AgtzcIdoe2JmQAO6wZB0VtPjtKMhKiLilsnSQABS20fHJAJwAlJBykIWwNIhVzGAAWmgItAA09vitDCQrVBgMsJAAZhEA9GgNYPfNrSRgIyrwHup5IAkwkgSgkGiMfkQDAo8G44nwGA4BigGUEXmYXAA8lgAOq9frISaCRCUKT0drqO6FLxiUpYADMSxOaEgmQwSkyfBhaC2kFG8CIpAoyCqHLqDSa/y+GkgPlaFSI/JIzj67QwJ1wXUgACFSu1SRR8Rz+oxMCtLsNRvhxvRebIbrB6WdEB5ZABudAMC6IRCK/kIRAaSkYAD6wZIAgAwoiaDlkFr9cgAAbQfJFEplbHCUS5KoyEjdK1jOjJk4MNDYP0YJXm7AYMU1Ca8FhIS6ZERieCIlBYLWXACy2iwaJ9yE6/0u/fQDTZ0lwzlwQZRkAAyvgWgikZBarQlPQlPcyH6pJAiNhVYwPJXScgq/6abn6QByZBIKHW22TRbIyCQGKyoUOQuGeF4UPQFSQI2EqNJ8mRcPA9wBpcIZqoMoLziWxxmvCXzIZAlClHwEjwKyAiwrQpDfhoFa4ZkhThBc8Ldlg1RzrgrQYBCf4AEyyjY86LqBqpcFIsL3PIWpIMGFShuhGD4LkxY2hMAgkPcZSXBWHgAjWHSRjGOTsEGGkUBc9zYDpshRlQWwCRylCUNRK7QPOiBcEOGAXh4kBiYh8AVlu/B4gSBr/jEc4trQ2AMP6PJ8mxmS/BQuSUlqkAKXkBTFERnqVgQzDUBMmy5Gge4TNQPBoAw/hoKQiAvG8wyBPg3BPI+dKIvU3C4lQDSUBoJWDXe1a1vYC40BZPnMPgNX8vg9jwMwllFegPQmgMym2hauDtIWlTVF4fDsCBiWCSlV4ql53AQlAAByinSFwADi65RpAPEAAw8QkCjAfAAh4Cxnq1AAkugvpIDQFJUpAABS87KiMkAzTVQaQAAavASgLUoM0YCMVBbsgun+HQsqucjTBOByXCyM4WAiMjHXWhg3W9a8BQUIN87DeYlhYjmXZSMg9ylMwkCkxMSAONIRghOLgyy7MiSpMiUACVFMWXKy7KcpQjC2XcPbGmq45dG006ZEwYnyLQpEePgtb9c4yBsQARAJyW5JBiBoEeKOKCQ7voaStLQ7dO57klbtstVWmIvbQWdI5+GFRUYAtmOl2YNg3DoLgNDMPCCYLdpPlSUGIbhnt0axsZGimeZllujZvKwPZ+sUN+6D3DQfDTnqhKUKbpr5haRaYSp2EVveempumOVZpAgudnmvIT1gW2lugHK75A9bQc24ttnOa8sZHQEOG0R/dVKLRtH5jxRNOqGmr8NBTHPSrvlPX6LMsNSpkdbemkKNfSdcjLxlOPhIckFRxgLnOnAm40VBeF3vQRsyB8BiXmvhcgAws6ILSrAM4uREz9H9NONM2VMzc35pAGMrBjL2EcIVFwRgoDrE2NsPYBxsZcEMo8CgbB6B+iIBgKh2oowABlagQhRGAQwBgTBQDIPQfASF8qEFIOQImExqZsByFwXg/AhbiBFiseQTBOQqDUJobQuglEqPAFAOAqBUDmm0cQMgyhoYKGYcYuOAwHBOBAqsGxyhVDqC0DofQRgXGmAMNwaqtV6qNW4GAZqQR2rh3pOzPqXMeYjGGsid25SDAWB3KDHxeiipiLYc4eQmjGBinqkYXctBY4EKRrkR46DKopJqnVaQGSskBBySzfJDQOb9W5kNJcFNtQlUDtFdBqN/AyAoqQE4JA8k9hmms6QLI9663OrkIGAJcCyBOQedSFQoishWQ4dQlxTJrH2WzGZhSBqQFBrkJgBNRgxSXPvKZXVvmcwNiQ3p/BmKIkQCcCoa9Y4bPWmhQQa8ejpUBdaHSExiwgpYvyJaipbm+UoP5F+VR17ihIHfOC7ZpAbksSQshAZ9T+jYlqSqTd1It2skbTujlyjIAUgCtA+KKRdD7NqN+AxUDbztH3A204qwGzDrmZAXsFwXV9v7S4hySAKKqbUDw/dqAsVLvhJQDBrxEytfwJCJBwjcDKP4soPBsACABAwAiOR1DwDliuB6rTMD1TwS6t1KU6BPG4N631/rxDXMWhI6gXwhgkBoGIcmDDPKIURmEdBtQMCStkAAL0oAkyplhoB1QeJ6l1cZcgtLzrQIqiAjAyIecgW44a6BcAANQJB4k8MAn0DDlPdpwpJQy0mjM5uMxALU2rgq+T1H58z3KToqaampui/ETFCew5pSE+01mDVAZ6YE7TlQggdOlDLpSWwWi69QBFnBuhQEhacyD0WmkVX/XNUBOmBsRJK/9m1MJEp7LcUQ/h0B3rwdOQFScWIQZ5eQ2EQpKCxz5fQPWIrDbt2CnOb2VUtQKO7eQXtbSB2QEHQAVjHTEIwhQRhLXqQoJQc4SIkAGOpUynBIADjoPARwO7p2KLAEYDQ0hdLiAkZpMpu7LBg1qYehpYTT1hovZ2gwnTY6jXQSk9KBB8KFFXNRn2Sm2gAhGCY1JIyGqLuya1XJT4IUbqhfM3mQh0ahqUF4Ym/A+CKQtrp+qnpMrnojeZwinroL+k9bi0oPl7iO3aFRntkX6ODpiGOidBh2PiEKv4yJvGg0CfuEJrgMj+iSZnTJgwGgiCBts94Rre6NP6K0yep1uX9MgaQ6yHp/SpwLTUigDr9BVhWxIG6v0BAXCOeGek1zEz3NroKT54pmh/OylDRZG4W4IOOza362L0hPSIi/W1xTCk2gnXkGVfcspq2mvNX4x15npy2vtZahFA2o3uomJ6+NPqApJsDZeyAD1yB5swAW5GRbLglrLZWigXactXdoEOgr462McbKwYoOlX+MERq+6urDWp0zuUao/1GitF4B0b43rASjHCaoCExp4TrFByoNEhxcTnGM8MeoUM2NEChkyHxvatBQzkfiYkqAcQBBJBiO2lIPEBAJBSCkT69xPqMbiJr+4SQGR7h4vMHiPE0A8QYEkHiOv5gO4ZIxpxhhGf64SLQG3n1aDzCSJ9FQPF4gMAELQGIbuGApHMgyEgMRGNoEYyQOIKQGTJHoPExnkY0BxHmAyBgcQnfJ512geIwfDfzAYIx23jGYjJ4SCQBIcRQ8qjd174wrjOeS+l7LrIVW6ChnUd3xnvASChjYBQUgoY4NoyV7q3IKuADeBg/zuyQLYHUjsap0CYVzqw+ARh0HdlwD4HhSRHA35ALfiAsRiQokoDA5+HiSuv7f92fQGCE0VDGMSEZUGIyCgUtDwVcCaYOLgVfAAXxv030iRsDsXUF6kegyHcFwC8Df0v0/03y2DOA8FoF31mn8FsGwI/xIHgLv3tloBsHrB8FmggNhBrEQCjC6Bqjf2BUoK/xoLoIwAwK8DYPg04IoGwG4M314PoOkBhDhC3CEI4K4C4KoPdilloFBl9DEMQCYLf3dgAB0MB9DdDcAjCTDjCzDgBVCpcNCSA9BDCzDTDTCLBLBYhVY0hIAABtKEFdAAXSygzCImzCxXHjUknkJmnl7CgkOnpUlEZVBAVD0iSmX0MIMPsNSKMKqQEJIGSM8M224F8JoX8OXlXlzEiILFCM/GlgfSbCfQfktHiKVESMXGSKqShBkPhQMI6KcJXi5ktT0kQFkFP2YGSNHgNGaKqThlal0gpRFBYmSKjCrAKjlCyF1GwH+HoEmDXUgCZA0D4gZEgCeDhzJztw0BiBSBOMWDGMsC8KCGmL9B7AqA0mSImO4CmIZA0HCCmDBBOBDAZB4guIwDXS4G2N2P0IeiUA0H8y4GONOJOMuMYVaHZFyDUiqBIjOAoGSIAkgBkUrEdHhkmMgjFhYFOHOEuEmHplANQRSkWA0H0L4hgGw2FDWkIy5GIz5GJCwAuBSmHEgBGOQDIBInpC50RQDFQFmgYFaHNm6DtRPy5UOJoCeGgEUAWjdXjW4GpP0LeJgG1F0M9nUSIwQV9EgGekRCyJDmthwUoDtgdidhnAKFdhpIwDiFlCjF9QQ2nEBkLh7B1J1SEn1QDiNRpL0IwEY1lAACpQzBZDQJBAckRwytSdYGhfUYzWFQFfQpov0KhA0O18JGiLozowBWpjwIi/Z/Sg5ZQAAJfoLISgTUbUMoQUCoCDOBEcUobOChMKVkcMgopeCgQIko4I/aDCMI20OMyCacfuZgRsjwJ4c7AsYBAicIQNGsB0hIMM0M1yW4SRbSRhG8bwOMuAJlcjQxNiSYXM3AYA1cA1AcIOBWFgZs5YVABwVMxAKaE4D0/CBwAQUkAARzEJyBzmum40uEgm20hTmWGgLiLhLjwWqjbMDBkjDAjEgWbRMjKGbisjbjsj1K5Gol1EkkDBJTYFrJQlClKM3ghgdFuGdCrC/SVSsQ/IGKLhOC8DKioQWjrAbCiPoBbEnNJDPlzAvn0LOJ5IQHQWnE5jnALIKAJlrNQEPi4oIjoV7HtkCkeSwHrF+B9SnBVHAn6CwBaWnEn1RKrB4FbMQTYgrCwEKmXX4H7G5FhHEG3NnLiOYLGnijuGrJyAdP0PDKxhxiWPxkJmTIMu1CoAuD+jQx7DYm7LoQ4HDP0I2FwG4HcieCeHaHSo0EdhYBohYCeC2GcBICeFb0jybwYGD3uEYxLwYFoAEEryLwLxiE+nmELFD1oEjzhIYgKBzVmxIBRO7FaGSIPMiMfRiOfUNSzVITEVIUsnoCfnwpIo2lfFQU/m/kGA/Cwh7iAU0kgpIGLnED0nM1guIQMnrnjCWUHG5INOQHwJmqQW5M0oGT3ifLHHTPkEbH4FwVSw3GQ21B6RLO+CNVMtmmISpHZXbNlJiqIm8owC6PqyIEQGSOTCRv0IAFVOK6VuKT4+KOwBKew0ReLLhV99C/xgAcbuq9A/Cey+yxAyKQit4gNaBia/xmbKpQLvNwLb5RraipgQgOBdDdCsRpL1wST+bnjdJ+ahB8SDDdC51nN+aNtl0gh+a2bZkiklwOAeJ28OAPd/jmaWbchcQTqoFFlgBMBERZAZoqwKbJheb+bBayBhazIsjdCxaKgJapb+bZb6p5ampcjlbPkdtwL1aPceIOAUh/iYC5xeREQuBIaijzFabBylUma/xWaA6wKilObYIxqea+aBaha0SLhRaPbdDJaXi3aZanNvbdCFaV1/bPN11VaBp1bNbPptbGNdb9aeSjaUKNBTaFIMALaXRrbbb86HbC7nbXbpay7xbK61tpAfbMk3NuB67OpG7N1SkQ6w7/ikbkw7CHDUjgAZyKgyZFcZYxC9B3ZlDrwRh5D/AvZLIlw393Db8/x189aED2D/A7o0A2AdDMjWlhCqC9b3YP4qwRCxDgHmb3Yo1rxS0tx/7llPAQFxT9FaLpDYQ1IExtQ/1HhwgTE5d2AIbF4lLIIs7748IU5ZUFq0JANhy6ATh7ZrZMCXto4wF/Rz7LgXDkgzir7X7oGjUdD2gGZFQ+GP679zSMBHhzxMhyCr9xCP73Z6y2swC76f6/6uB3Zk0sD+G4D+H37FGF9v7f6oC79WjYR2jAGOCoG8CJpwHFDRCFGQHYHMAYzEHLQMHZDiU7UdKv1MhrxNgfqtI6NSRcBGGs1mgpFLgWwtLmAThEANwgZERyUSouUGhShqo7h3lX5SLCUuwewwqE4OQwMsA8GNAxHFHBHNHhHQDRGbGJHRBERpGvg5HcDFHlGpy1GTGdDhg2iEHdGoGDGQGjH1HTH3ZqNT6/lrDaMgH+HbH01EAIGnHoGXH4GWJ3GgLBsHgBVENaAY4lYxCVYeH6KloXjdqiG9JDxjxJBLhzxLw7VdyRoOHEB1rp4e5KoBBwsk1To94zyeB8AKglwTgjKLmlQ46+AqGvQxx/Q6L5UzEUVyn6n3Yqm78anJEawKmQHJHmnZGL8KCkWOnVGv7RmdDVD1DZZEBahfQwEudp09a9G9ahnoGRnunNGsQ8ABtVwmAChGEQmrH/BMXoGwHFmHHIG5m79Vm3HNGzUfIrs3Y2hoRCz6BzM8Gom45wrUMSmuAVaN7QU7nwJhSVlxtdmSnyVAUcXkzjW21szJg5NXRAXBRHtKDIBWt2snXlhsnfqKchpBXN8UX3Y0W6nxX3ZsXBQWm8X5GCXsNOniXWW78yEsR7guXCy2D+1KXqXfRaWBn9Hg2WWNGzHZo/89IADlBSBfW79hWlmkXJWEHNGjt6x8mUENJ6x718JccHhJxrUshJULxP4f8i2lQbZS3jU1x/A4RuAYXC2BQ9Ih2qBSB+XEXg2kpEna279epXlQQp3XLRZPVpxjtG3kBeLwF+wJZzM/ZxAXz5qFBAD53ExpBSFCDF3xHkWg4hGRGMWo2GyiX4MSXNH+3p34a6XmaGXmamXN8a31nNGhr40dI5xfzEZemLGgoKg7VsBhh0BYO72mVfz4BMgxFcaCYuBqZJ8ZUTxonShYnlrzmcgTgEAiBYAwAvApAfIEnNxiUIPkmMEMIFxJxlXEYXjMAn3DHY3833YMgljoQkPiUBwFjIAQgNxMsjTVigse1y2X2lAdCEsKA1PK3RXlnN9Q2ZHTGcD9P43o3v2apf279xSRgWAgO/wYDb9vDr7eRcBbBzGvHEQdCUgVQUh7gEhPokgQ8yokgo8Uh28GRU8UhGMGQUgYh7gGBA97h5hGMEh/ZUgBBGMkg4g4hdd4vWqSBbc4hfifPwuEgS9GMKmVDXPbBMidCyryuk8Eg3cC8LgeJ1Jsv5hbcDcPh1cR1qqYhvQkgC9aB7gBA8ufOeJUgYhUhS9K9I921Cx5gzdp1HPVdTKp8Z858jGZcx9c9e9tFQwUl1Ul8ipTuLo19quRgrBdzaBahcABJ5cD8WBJzcAYx6xcBz9Po1vGdDvjvSRTuaBR8959AgA= -->\n\n<!-- internal state end -->",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4035926550/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 347564,
"client_id": "Iv1.6aaafe4fe882736b",
"slug": "coderabbitai",
"node_id": "A_kwHOB96YWc4ABU2s",
"owner": {
"login": "coderabbitai",
"id": 132028505,
"node_id": "O_kgDOB96YWQ",
"avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai",
"html_url": "https://github.com/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai/followers",
"following_url": "https://api.github.com/users/coderabbitai/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai/orgs",
"repos_url": "https://api.github.com/users/coderabbitai/repos",
"events_url": "https://api.github.com/users/coderabbitai/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "coderabbitai",
"description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n",
"external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github",
"html_url": "https://github.com/apps/coderabbitai",
"created_at": "2023-06-14T15:47:27Z",
"updated_at": "2026-03-14T07:58:44Z",
"permissions": {
"actions": "read",
"checks": "write",
"contents": "write",
"discussions": "read",
"issues": "write",
"members": "read",
"metadata": "read",
"pull_requests": "write",
"statuses": "write"
},
"events": [
"issues",
"issue_comment",
"label",
"organization",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"repository"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4035954282",
"html_url": "https://github.com/laurent22/joplin/pull/14689#issuecomment-4035954282",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14689",
"id": 4035954282,
"node_id": "IC_kwDOBLftOs7wj8Zq",
"user": {
"login": "Ehtesham-Zahid",
"id": 98094052,
"node_id": "U_kgDOBdjL5A",
"avatar_url": "https://avatars.githubusercontent.com/u/98094052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ehtesham-Zahid",
"html_url": "https://github.com/Ehtesham-Zahid",
"followers_url": "https://api.github.com/users/Ehtesham-Zahid/followers",
"following_url": "https://api.github.com/users/Ehtesham-Zahid/following{/other_user}",
"gists_url": "https://api.github.com/users/Ehtesham-Zahid/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ehtesham-Zahid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ehtesham-Zahid/subscriptions",
"organizations_url": "https://api.github.com/users/Ehtesham-Zahid/orgs",
"repos_url": "https://api.github.com/users/Ehtesham-Zahid/repos",
"events_url": "https://api.github.com/users/Ehtesham-Zahid/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ehtesham-Zahid/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-11T03:23:44Z",
"updated_at": "2026-03-11T03:23:44Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4035954282/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}