wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/Fardin96_56617001.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

362 行
17 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14042",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14042/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14042/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14042/events",
"html_url": "https://github.com/laurent22/joplin/pull/14042",
"id": 3784051586,
"node_id": "PR_kwDOBLftOs67qjJz",
"number": 14042,
"title": "Mobile: Align tag search-input-clear behavior across input methods (#13243)",
"user": {
"login": "Fardin96",
"id": 56617001,
"node_id": "MDQ6VXNlcjU2NjE3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/56617001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Fardin96",
"html_url": "https://github.com/Fardin96",
"followers_url": "https://api.github.com/users/Fardin96/followers",
"following_url": "https://api.github.com/users/Fardin96/following{/other_user}",
"gists_url": "https://api.github.com/users/Fardin96/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Fardin96/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Fardin96/subscriptions",
"organizations_url": "https://api.github.com/users/Fardin96/orgs",
"repos_url": "https://api.github.com/users/Fardin96/repos",
"events_url": "https://api.github.com/users/Fardin96/events{/privacy}",
"received_events_url": "https://api.github.com/users/Fardin96/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 4,
"created_at": "2026-01-06T07:18:49Z",
"updated_at": "2026-01-26T16:19:09Z",
"closed_at": "2026-01-26T15:12:06Z",
"assignee": null,
"author_association": "CONTRIBUTOR",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14042",
"html_url": "https://github.com/laurent22/joplin/pull/14042",
"diff_url": "https://github.com/laurent22/joplin/pull/14042.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14042.patch",
"merged_at": "2026-01-26T15:12:06Z"
},
"body": "This PR fixes the inconsistent tag search input clear behavior in the mobile tag association screen. Now, creating new tags always clears the input and selecting previous tags always retains the input.\r\n\r\n## Problem\r\n\r\nCurrently, the tag search combobox has inconsistent behavior when adding tags:\r\n- **Adding an existing tag** (via keyboard or touchscreen) → retains search input \r\n- **Adding a new tag via keyboard Enter** → clears search input\r\n- **Adding a new tag via \"+ Add new\" button** → clears search input\r\n\r\nThis inconsistency was confusing for users as reported in #13243.\r\n\r\n## Solution\r\n\r\nAfter reviewing the [[ARIA Combobox Pattern](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/)](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/) and discussion on the issue #13243, the solution was finalized:\r\n\r\nhttps://github.com/laurent22/joplin/issues/13243#issuecomment-3707268498\r\n\r\n> ...It would be better to retain the search term if enter is pressed when an existing tag is selected, and clear the input if the add new tag option is selected when pressing enter. Then it would be consistent with the behaviour of the touch interactions.\r\n\r\n## Changes Made\r\n\r\n- Removed `setSearch` from the `useInputEventHandlers` hook's `onSubmit` method (line 438) and from its dependency array in `ComboBox.tsx`\r\n\r\n## Testing\r\n\r\n### Manual Testing Steps\r\n\r\n1. **Open the tag association screen** on a note\r\n2. **Test adding existing tags via keyboard**:\r\n - Type a search term that matches existing tags\r\n - Press Enter or tap a result\r\n - ✅ Verify: Search input is retained\r\n3. **Test adding new tags via keyboard**:\r\n - Type a new tag name\r\n - Press Enter\r\n - ✅ Verify: Search input is cleared\r\n4. **Test adding new tags via button**:\r\n - Type a new tag name\r\n - Tap the \"+ Add new\" button\r\n - ✅ Verify: Search input is cleared\r\n5. **Test adding existing tags via touch**:\r\n - Type a search term\r\n - Tap on a search result\r\n - ✅ Verify: Search input is retained\r\n6. **Test rapid multi-tag addition**:\r\n - Add 5+ tags in quick succession using different methods\r\n - ✅ Verify: Behavior is consistent across all methods\r\n\r\n### Related Functionality Verification\r\n\r\n- Note editing still works as expected\r\n- Tag list updates correctly after additions\r\n- Search results filter properly as you type\r\n- Tag removal functionality unchanged\r\n\r\n## Benefits\r\n\r\n- ✅ Consistent behavior across all input methods for note tags input box\r\n\r\n## Screenshots/Videos\r\n\r\n[View demo video](https://github.com/user-attachments/assets/94b6a4da-512a-4291-bcb1-16746fdfc9de)\r\n## Related Issue\r\n\r\nFixes #13243",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14042/reactions",
"total_count": 2,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 2,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14042/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3713460990",
"html_url": "https://github.com/laurent22/joplin/pull/14042#issuecomment-3713460990",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14042",
"id": 3713460990,
"node_id": "IC_kwDOBLftOs7dVur-",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-06T07:19:01Z",
"updated_at": "2026-01-26T16:19:09Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3713460990/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3713470040",
"html_url": "https://github.com/laurent22/joplin/pull/14042#issuecomment-3713470040",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14042",
"id": 3713470040,
"node_id": "IC_kwDOBLftOs7dVw5Y",
"user": {
"login": "Fardin96",
"id": 56617001,
"node_id": "MDQ6VXNlcjU2NjE3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/56617001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Fardin96",
"html_url": "https://github.com/Fardin96",
"followers_url": "https://api.github.com/users/Fardin96/followers",
"following_url": "https://api.github.com/users/Fardin96/following{/other_user}",
"gists_url": "https://api.github.com/users/Fardin96/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Fardin96/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Fardin96/subscriptions",
"organizations_url": "https://api.github.com/users/Fardin96/orgs",
"repos_url": "https://api.github.com/users/Fardin96/repos",
"events_url": "https://api.github.com/users/Fardin96/events{/privacy}",
"received_events_url": "https://api.github.com/users/Fardin96/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-06T07:20:07Z",
"updated_at": "2026-01-06T07:20:07Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3713470040/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3714884724",
"html_url": "https://github.com/laurent22/joplin/pull/14042#issuecomment-3714884724",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14042",
"id": 3714884724,
"node_id": "IC_kwDOBLftOs7dbKR0",
"user": {
"login": "mrjo118",
"id": 6963004,
"node_id": "MDQ6VXNlcjY5NjMwMDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mrjo118",
"html_url": "https://github.com/mrjo118",
"followers_url": "https://api.github.com/users/mrjo118/followers",
"following_url": "https://api.github.com/users/mrjo118/following{/other_user}",
"gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions",
"organizations_url": "https://api.github.com/users/mrjo118/orgs",
"repos_url": "https://api.github.com/users/mrjo118/repos",
"events_url": "https://api.github.com/users/mrjo118/events{/privacy}",
"received_events_url": "https://api.github.com/users/mrjo118/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-06T14:20:57Z",
"updated_at": "2026-01-06T14:20:57Z",
"body": "Thank you for working on this! FYI I'm a contributer to the project, not a maintainer. So my proposed solution does not necessarily mean the solution is 'finalized'",
"author_association": "COLLABORATOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3714884724/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3717391810",
"html_url": "https://github.com/laurent22/joplin/pull/14042#issuecomment-3717391810",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14042",
"id": 3717391810,
"node_id": "IC_kwDOBLftOs7dkuXC",
"user": {
"login": "Fardin96",
"id": 56617001,
"node_id": "MDQ6VXNlcjU2NjE3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/56617001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Fardin96",
"html_url": "https://github.com/Fardin96",
"followers_url": "https://api.github.com/users/Fardin96/followers",
"following_url": "https://api.github.com/users/Fardin96/following{/other_user}",
"gists_url": "https://api.github.com/users/Fardin96/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Fardin96/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Fardin96/subscriptions",
"organizations_url": "https://api.github.com/users/Fardin96/orgs",
"repos_url": "https://api.github.com/users/Fardin96/repos",
"events_url": "https://api.github.com/users/Fardin96/events{/privacy}",
"received_events_url": "https://api.github.com/users/Fardin96/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-07T05:38:22Z",
"updated_at": "2026-01-07T05:38:22Z",
"body": "@mrjo118 considering all perspectives and guidelines, that does seem the most appropriate! ",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3717391810/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接