wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/HahaBill_32552798.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

817 行
41 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9983/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9983/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/9983/events",
"html_url": "https://github.com/laurent22/joplin/pull/9983",
"id": 2150169705,
"node_id": "PR_kwDOBLftOs5ntNfF",
"number": 9983,
"title": "Desktop: Fixes #7834: Merged shorthand variants of spellcheck languages",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 14,
"created_at": "2024-02-23T00:27:10Z",
"updated_at": "2024-03-01T20:59:30Z",
"closed_at": "2024-02-26T10:27:34Z",
"author_association": "CONTRIBUTOR",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/9983",
"html_url": "https://github.com/laurent22/joplin/pull/9983",
"diff_url": "https://github.com/laurent22/joplin/pull/9983.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/9983.patch",
"merged_at": "2024-02-26T10:27:34Z"
},
"body": "# Summary\r\n\r\n**Introduction from the Joplin Forum**: https://discourse.joplinapp.org/t/introducing-hahabill/36075/3\r\n\r\nI fixed the issue regarding the multiple variants of the same spellcheck languages showing duplicate values in the title bar. Merged shorthand variants, e.g. [en-US, en-GB, en-AU] -> 'en'\r\n\r\n- added \"spellCheckerMenu.test.ts\" to test the changes and the expected behavior: all passed!\r\n- added jest.mock in \"jest.setup.js\" to mock the Menu from @electron/remote.\r\n- modified \"buildScriptIndexes\" to ignore \".test.ts\" files so it does not include them in index.ts. That caused some issues with duplicate identifiers and more errors.\r\n\r\n🐛 Fixes: #7834 \r\n\r\n# Testing and Verification Process\r\n\r\n### 1. To ensure the changes are working as expected:\r\n\r\nhttps://github.com/laurent22/joplin/assets/32552798/71617d33-ed0d-4845-8ea5-091b363387f0\r\n\r\n### 2. Unit Testing: showSpellCheckerMenu.test.ts\r\n\r\n![Screenshot 2024-02-22 at 22 30 41](https://github.com/laurent22/joplin/assets/32552798/6ed39a26-a891-424f-82b4-c5b2fd9c02ab)\r\n\r\n# Notes\r\n\r\nI noticed that when I add multiple spellchecker languages, the block expands to the point that it covers the notebook's title. \r\n\r\n<img width=\"1426\" alt=\"Screenshot 2024-02-23 at 0 20 16\" src=\"https://github.com/laurent22/joplin/assets/32552798/5c9775a2-126f-4d8d-9cc4-c4b898915696\">\r\n\r\nThis is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title. \r\n\r\nWhat do you think? \r\n(this suggestion would be out of the scope of this PR, a new issue would be created)\r\n\r\n# Checklist:\r\n\r\n- [x] Fixed the issue\r\n- [x] Created test units\r\n- [x] Complete and working PR\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/9983/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9983/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1960561562",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1960561562",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1960561562,
"node_id": "IC_kwDOBLftOs5028ua",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T00:27:26Z",
"updated_at": "2024-02-26T10:27:45Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1960561562/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2025-03-07T16:35:00Z",
"permissions": {
"actions": "write",
"administration": "read",
"attestations": "write",
"checks": "write",
"contents": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"project",
"project_card",
"project_column",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1960570750",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1960570750",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1960570750,
"node_id": "IC_kwDOBLftOs502-9-",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T00:33:03Z",
"updated_at": "2024-02-23T00:33:03Z",
"author_association": "CONTRIBUTOR",
"body": "recheck",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1960570750/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961004178",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1961004178",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1961004178,
"node_id": "IC_kwDOBLftOs504oyS",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T09:38:33Z",
"updated_at": "2024-02-23T09:38:33Z",
"author_association": "OWNER",
"body": "You need to accept the CLA.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961004178/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961437269",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1961437269",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1961437269,
"node_id": "IC_kwDOBLftOs506ShV",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T14:30:44Z",
"updated_at": "2024-02-23T14:30:44Z",
"author_association": "CONTRIBUTOR",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961437269/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961437728",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1961437728",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1961437728,
"node_id": "IC_kwDOBLftOs506Sog",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T14:31:01Z",
"updated_at": "2024-02-23T14:31:01Z",
"author_association": "CONTRIBUTOR",
"body": "recheck",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961437728/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961484681",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1961484681",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1961484681,
"node_id": "IC_kwDOBLftOs506eGJ",
"user": {
"login": "personalizedrefrigerator",
"id": 46334387,
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/personalizedrefrigerator",
"html_url": "https://github.com/personalizedrefrigerator",
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T14:59:23Z",
"updated_at": "2024-02-23T14:59:23Z",
"author_association": "COLLABORATOR",
"body": "> This is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title.\r\n\r\nBecause it's possible to click on the spellcheck button and show the full list of languages, I think limiting its size and using [`text-overflow: ellipsis`](https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow) (or something similar in JS) might make sense. I agree that this would probably be best in a separate PR.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961484681/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961531276",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1961531276",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1961531276,
"node_id": "IC_kwDOBLftOs506peM",
"user": {
"login": "tomasz1986",
"id": 5626656,
"node_id": "MDQ6VXNlcjU2MjY2NTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5626656?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tomasz1986",
"html_url": "https://github.com/tomasz1986",
"followers_url": "https://api.github.com/users/tomasz1986/followers",
"following_url": "https://api.github.com/users/tomasz1986/following{/other_user}",
"gists_url": "https://api.github.com/users/tomasz1986/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tomasz1986/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tomasz1986/subscriptions",
"organizations_url": "https://api.github.com/users/tomasz1986/orgs",
"repos_url": "https://api.github.com/users/tomasz1986/repos",
"events_url": "https://api.github.com/users/tomasz1986/events{/privacy}",
"received_events_url": "https://api.github.com/users/tomasz1986/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T15:26:17Z",
"updated_at": "2024-02-23T15:26:34Z",
"author_association": "NONE",
"body": "> > This is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title.\r\n> \r\n> Because it's possible to click on the spellcheck button and show the full list of languages, I think limiting its size and using [`text-overflow: ellipsis`](https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow) (or something similar in JS) might make sense. I agree that this would probably be best in a separate PR.\r\n\r\nI think there is an issue with the spellcheck button, as it only shows one language enabled in the menu that pops up on click,\r\n\r\n![image](https://github.com/laurent22/joplin/assets/5626656/35aaa5f9-0398-41f7-b409-da732fbe721b)\r\n\r\neven though there are actually four languages enabled. You need to go through the whole \"Change language\" list to see all of them.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1961531276/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962028780",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1962028780",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1962028780,
"node_id": "IC_kwDOBLftOs508i7s",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T21:38:14Z",
"updated_at": "2024-02-23T21:41:06Z",
"author_association": "CONTRIBUTOR",
"body": "> > This is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title.\r\n> \r\n> Because it's possible to click on the spellcheck button and show the full list of languages, I think limiting its size and using [`text-overflow: ellipsis`](https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow) (or something similar in JS) might make sense. I agree that this would probably be best in a separate PR.\r\n\r\nYeah, limiting the size and using something like text overflow makes much more sense. Let's talk about that more after this PR and see if other members agree. \r\n\r\nAnother example of using 3 languages where it doesn't look nice:\r\n\r\n<img width=\"705\" alt=\"Screenshot 2024-02-23 at 21 36 30\" src=\"https://github.com/laurent22/joplin/assets/32552798/c151e078-5097-402d-be48-051359694059\">\r\n\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962028780/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962115156",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1962115156",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1962115156,
"node_id": "IC_kwDOBLftOs5084BU",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-23T23:05:06Z",
"updated_at": "2024-02-23T23:05:06Z",
"author_association": "CONTRIBUTOR",
"body": "I made all the necessary changes. I hope I got everything.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962115156/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962336659",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1962336659",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1962336659,
"node_id": "IC_kwDOBLftOs509uGT",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-24T11:43:58Z",
"updated_at": "2024-02-24T11:43:58Z",
"author_association": "OWNER",
"body": "> # Notes\r\n> \r\n> I noticed that when I add multiple spellchecker languages, the block expands to the point that it covers the notebook's title.\r\n> <img alt=\"Screenshot 2024-02-23 at 0 20 16\" width=\"1426\" src=\"https://private-user-images.githubusercontent.com/32552798/307192740-5c9775a2-126f-4d8d-9cc4-c4b898915696.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDg3NzUxNTMsIm5iZiI6MTcwODc3NDg1MywicGF0aCI6Ii8zMjU1Mjc5OC8zMDcxOTI3NDAtNWM5Nzc1YTItMTI2Zi00ZDhkLTljYzQtYzRiODk4OTE1Njk2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI0VDExNDA1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhNzJmM2MxYzBjOGM2OTgyZTU5ZGZlNDcwNjJjMTE1MjBhMDIzYmE5MzFlMTUxOTQ1ZWI0MWQ2NjdmYjY1Y2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZHeLPKk6Txejhke10yoLk3Zyv4lxBLmLBh_pD9ZQxAU\">\r\n> \r\n> This is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title.\r\n> \r\n> What do you think? (this suggestion would be out of the scope of this PR, a new issue would be created)\r\n\r\nWould you mind creating a new issue for this? As a fix we'll just make the languages not wrap. We don't need to do anything smart because the UI is not really usable at a very small size anyway.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962336659/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962890639",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1962890639",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1962890639,
"node_id": "IC_kwDOBLftOs50_1WP",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-25T10:44:26Z",
"updated_at": "2024-02-25T10:44:26Z",
"author_association": "CONTRIBUTOR",
"body": "> > # Notes\r\n> > I noticed that when I add multiple spellchecker languages, the block expands to the point that it covers the notebook's title.\r\n> > <img alt=\"Screenshot 2024-02-23 at 0 20 16\" width=\"1426\" src=\"https://private-user-images.githubusercontent.com/32552798/307192740-5c9775a2-126f-4d8d-9cc4-c4b898915696.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDg3NzUxNTMsIm5iZiI6MTcwODc3NDg1MywicGF0aCI6Ii8zMjU1Mjc5OC8zMDcxOTI3NDAtNWM5Nzc1YTItMTI2Zi00ZDhkLTljYzQtYzRiODk4OTE1Njk2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI0VDExNDA1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhNzJmM2MxYzBjOGM2OTgyZTU5ZGZlNDcwNjJjMTE1MjBhMDIzYmE5MzFlMTUxOTQ1ZWI0MWQ2NjdmYjY1Y2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZHeLPKk6Txejhke10yoLk3Zyv4lxBLmLBh_pD9ZQxAU\">\r\n> > This is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title.\r\n> > What do you think? (this suggestion would be out of the scope of this PR, a new issue would be created)\r\n> \r\n> Would you mind creating a new issue for this? As a fix we'll just make the languages not wrap. We don't need to do anything smart because the UI is not really usable at a very small size anyway.\r\n\r\nRight, also, by removing duplicates, we have partially solved the issue. I think overflowing the text should suffice. I am happy to create a new issue for that!",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962890639/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962903852",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1962903852",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1962903852,
"node_id": "IC_kwDOBLftOs50_4ks",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-25T11:36:00Z",
"updated_at": "2024-02-25T11:36:00Z",
"author_association": "CONTRIBUTOR",
"body": "> > > # Notes\r\n> > > I noticed that when I add multiple spellchecker languages, the block expands to the point that it covers the notebook's title.\r\n> > > <img alt=\"Screenshot 2024-02-23 at 0 20 16\" width=\"1426\" src=\"https://private-user-images.githubusercontent.com/32552798/307192740-5c9775a2-126f-4d8d-9cc4-c4b898915696.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDg3NzUxNTMsIm5iZiI6MTcwODc3NDg1MywicGF0aCI6Ii8zMjU1Mjc5OC8zMDcxOTI3NDAtNWM5Nzc1YTItMTI2Zi00ZDhkLTljYzQtYzRiODk4OTE1Njk2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI0VDExNDA1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhNzJmM2MxYzBjOGM2OTgyZTU5ZGZlNDcwNjJjMTE1MjBhMDIzYmE5MzFlMTUxOTQ1ZWI0MWQ2NjdmYjY1Y2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZHeLPKk6Txejhke10yoLk3Zyv4lxBLmLBh_pD9ZQxAU\">\r\n> > > This is out of the scope of this PR, but I would suggest maybe making the \"spellchecker language\" block in the title bar horizontally scrollable so that it does not cover the notebook title.\r\n> > > What do you think? (this suggestion would be out of the scope of this PR, a new issue would be created)\r\n> > \r\n> > \r\n> > Would you mind creating a new issue for this? As a fix we'll just make the languages not wrap. We don't need to do anything smart because the UI is not really usable at a very small size anyway.\r\n> \r\n> Right, also, by removing duplicates, we have partially solved the issue. I think overflowing the text should suffice. I am happy to create a new issue for that!\r\n\r\nHere's the issue: https://github.com/laurent22/joplin/issues/9998",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1962903852/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1963786214",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1963786214",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1963786214,
"node_id": "IC_kwDOBLftOs51DP_m",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-02-26T10:27:19Z",
"updated_at": "2024-02-26T10:27:19Z",
"author_association": "OWNER",
"body": "That looks good now, thanks everyone!",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1963786214/reactions",
"total_count": 3,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 2,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1973495654",
"html_url": "https://github.com/laurent22/joplin/pull/9983#issuecomment-1973495654",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9983",
"id": 1973495654,
"node_id": "IC_kwDOBLftOs51oSdm",
"user": {
"login": "HahaBill",
"id": 32552798,
"node_id": "MDQ6VXNlcjMyNTUyNzk4",
"avatar_url": "https://avatars.githubusercontent.com/u/32552798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HahaBill",
"html_url": "https://github.com/HahaBill",
"followers_url": "https://api.github.com/users/HahaBill/followers",
"following_url": "https://api.github.com/users/HahaBill/following{/other_user}",
"gists_url": "https://api.github.com/users/HahaBill/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HahaBill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HahaBill/subscriptions",
"organizations_url": "https://api.github.com/users/HahaBill/orgs",
"repos_url": "https://api.github.com/users/HahaBill/repos",
"events_url": "https://api.github.com/users/HahaBill/events{/privacy}",
"received_events_url": "https://api.github.com/users/HahaBill/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2024-03-01T16:29:24Z",
"updated_at": "2024-03-01T16:29:24Z",
"author_association": "CONTRIBUTOR",
"body": "@PackElend label me please",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1973495654/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接