文件
mynode/readme/cla/consent_records/JackGruber_24863925.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

549 行
27 KiB
JSON

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7622/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7622/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/7622/events",
"html_url": "https://github.com/laurent22/joplin/pull/7622",
"id": 1533872928,
"node_id": "PR_kwDOBLftOs5HaTDK",
"number": 7622,
"title": "Desktop: Add option to select the search result order",
"user": {
"login": "JackGruber",
"id": 24863925,
"node_id": "MDQ6VXNlcjI0ODYzOTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/24863925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JackGruber",
"html_url": "https://github.com/JackGruber",
"followers_url": "https://api.github.com/users/JackGruber/followers",
"following_url": "https://api.github.com/users/JackGruber/following{/other_user}",
"gists_url": "https://api.github.com/users/JackGruber/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JackGruber/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JackGruber/subscriptions",
"organizations_url": "https://api.github.com/users/JackGruber/orgs",
"repos_url": "https://api.github.com/users/JackGruber/repos",
"events_url": "https://api.github.com/users/JackGruber/events{/privacy}",
"received_events_url": "https://api.github.com/users/JackGruber/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": true,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 10,
"created_at": "2023-01-15T15:39:15Z",
"updated_at": "2023-01-16T15:44:55Z",
"closed_at": "2023-01-16T15:44:40Z",
"author_association": "CONTRIBUTOR",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/7622",
"html_url": "https://github.com/laurent22/joplin/pull/7622",
"diff_url": "https://github.com/laurent22/joplin/pull/7622.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/7622.patch",
"merged_at": null
},
"body": "Add option to select the search result order.\r\n![grafik](https://user-images.githubusercontent.com/24863925/212550621-c3bce3b1-0fcb-4957-b3af-002ebf809953.png)\r\n\r\nThe topic of search result order has already come up several times and the relevance (bm25) sorting is not always what the user wants. \r\n\r\nhttps://discourse.joplinapp.org/t/search-result-order/3763/12\r\nhttps://discourse.joplinapp.org/t/sort-search-results-by-date/28875\r\nhttps://github.com/laurent22/joplin/issues/1388\r\nhttps://github.com/laurent22/joplin/issues/5524\r\nhttps://github.com/laurent22/joplin/issues/4220\r\n\r\n## Changes made\r\n- Add a menue option to sort search results by BM25, title, creation or updated date\r\n- BM25 is selected as the default sort order\r\n- For title sorting the `localeCompare` is used to get numbers in strings correct sorted\r\n- `SearchEngine.test.js` converted into typescript\r\n\r\n\r\n\r\n\r\n\r\n<!--\r\n\r\nPlease prefix the title with the platform you are targetting:\r\n\r\nHere are some examples of good titles:\r\n\r\n- Desktop: Resolves #123: Added new setting to change font\r\n- Mobile, Desktop: Fixes #456: Fixed config screen error\r\n- All: Resolves #777: Made synchronisation faster\r\n\r\nAnd here's an explanation of the title format:\r\n\r\n- \"Desktop\" for the Windows/macOS/Linux app (Electron app)\r\n- \"Mobile\" for the mobile app (or \"Android\" / \"iOS\" if the pull request only applies to one of the mobile platforms)\r\n- \"CLI\" for the CLI app\r\n\r\nIf it's two platforms, separate them with commas - \"Desktop, Mobile\" or if it's for all platforms, prefix with \"All\".\r\n\r\nIf it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.\r\n\r\nThen please append the issue that you've addressed or fixed. Use \"Resolves #123\" for new features or improvements and \"Fixes #123\" for bug fixes.\r\n\r\nAND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md\r\n\r\n-->\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7622/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7622/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383182754",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1383182754",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1383182754,
"node_id": "IC_kwDOBLftOs5ScbGi",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-15T15:39:36Z",
"updated_at": "2023-01-15T21:24:24Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383182754/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383183803",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1383183803",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1383183803,
"node_id": "IC_kwDOBLftOs5ScbW7",
"user": {
"login": "JackGruber",
"id": 24863925,
"node_id": "MDQ6VXNlcjI0ODYzOTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/24863925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JackGruber",
"html_url": "https://github.com/JackGruber",
"followers_url": "https://api.github.com/users/JackGruber/followers",
"following_url": "https://api.github.com/users/JackGruber/following{/other_user}",
"gists_url": "https://api.github.com/users/JackGruber/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JackGruber/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JackGruber/subscriptions",
"organizations_url": "https://api.github.com/users/JackGruber/orgs",
"repos_url": "https://api.github.com/users/JackGruber/repos",
"events_url": "https://api.github.com/users/JackGruber/events{/privacy}",
"received_events_url": "https://api.github.com/users/JackGruber/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-15T15:44:36Z",
"updated_at": "2023-01-15T15:44:36Z",
"author_association": "CONTRIBUTOR",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383183803/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383197236",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1383197236",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1383197236,
"node_id": "IC_kwDOBLftOs5Sceo0",
"user": {
"login": "Daeraxa",
"id": 58074586,
"node_id": "MDQ6VXNlcjU4MDc0NTg2",
"avatar_url": "https://avatars.githubusercontent.com/u/58074586?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Daeraxa",
"html_url": "https://github.com/Daeraxa",
"followers_url": "https://api.github.com/users/Daeraxa/followers",
"following_url": "https://api.github.com/users/Daeraxa/following{/other_user}",
"gists_url": "https://api.github.com/users/Daeraxa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Daeraxa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Daeraxa/subscriptions",
"organizations_url": "https://api.github.com/users/Daeraxa/orgs",
"repos_url": "https://api.github.com/users/Daeraxa/repos",
"events_url": "https://api.github.com/users/Daeraxa/events{/privacy}",
"received_events_url": "https://api.github.com/users/Daeraxa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-15T16:45:29Z",
"updated_at": "2023-01-15T16:45:29Z",
"author_association": "CONTRIBUTOR",
"body": "I think maybe the bm25 part of the label should be left off, I feel that most users aren't going to know what it means and might not understand that it was the default one so will avoid choosing it.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383197236/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383235899",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1383235899",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1383235899,
"node_id": "IC_kwDOBLftOs5ScoE7",
"user": {
"login": "chevdor",
"id": 738724,
"node_id": "MDQ6VXNlcjczODcyNA==",
"avatar_url": "https://avatars.githubusercontent.com/u/738724?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chevdor",
"html_url": "https://github.com/chevdor",
"followers_url": "https://api.github.com/users/chevdor/followers",
"following_url": "https://api.github.com/users/chevdor/following{/other_user}",
"gists_url": "https://api.github.com/users/chevdor/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chevdor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chevdor/subscriptions",
"organizations_url": "https://api.github.com/users/chevdor/orgs",
"repos_url": "https://api.github.com/users/chevdor/repos",
"events_url": "https://api.github.com/users/chevdor/events{/privacy}",
"received_events_url": "https://api.github.com/users/chevdor/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-15T19:50:13Z",
"updated_at": "2023-01-15T19:50:13Z",
"author_association": "NONE",
"body": "I def. welcome this PR, thanks for the great work @JackGruber.\r\n\r\nMy only question is whether we really need to have (and potentially confuse the user) an option for the note list and another for the search. If it is easier to merge this PR without making such a decision yet, I think this would already provide a good value in the current state.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383235899/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383256090",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1383256090",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1383256090,
"node_id": "IC_kwDOBLftOs5SctAa",
"user": {
"login": "JackGruber",
"id": 24863925,
"node_id": "MDQ6VXNlcjI0ODYzOTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/24863925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JackGruber",
"html_url": "https://github.com/JackGruber",
"followers_url": "https://api.github.com/users/JackGruber/followers",
"following_url": "https://api.github.com/users/JackGruber/following{/other_user}",
"gists_url": "https://api.github.com/users/JackGruber/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JackGruber/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JackGruber/subscriptions",
"organizations_url": "https://api.github.com/users/JackGruber/orgs",
"repos_url": "https://api.github.com/users/JackGruber/repos",
"events_url": "https://api.github.com/users/JackGruber/events{/privacy}",
"received_events_url": "https://api.github.com/users/JackGruber/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-15T21:21:50Z",
"updated_at": "2023-01-15T21:21:50Z",
"author_association": "CONTRIBUTOR",
"body": "I first thought about using the option to display the notes, but since the search also has a relevance-based sorting, the same option cannot be used. ",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383256090/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383484313",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1383484313",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1383484313,
"node_id": "IC_kwDOBLftOs5SdkuZ",
"user": {
"login": "JackGruber",
"id": 24863925,
"node_id": "MDQ6VXNlcjI0ODYzOTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/24863925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JackGruber",
"html_url": "https://github.com/JackGruber",
"followers_url": "https://api.github.com/users/JackGruber/followers",
"following_url": "https://api.github.com/users/JackGruber/following{/other_user}",
"gists_url": "https://api.github.com/users/JackGruber/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JackGruber/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JackGruber/subscriptions",
"organizations_url": "https://api.github.com/users/JackGruber/orgs",
"repos_url": "https://api.github.com/users/JackGruber/repos",
"events_url": "https://api.github.com/users/JackGruber/events{/privacy}",
"received_events_url": "https://api.github.com/users/JackGruber/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-16T04:43:28Z",
"updated_at": "2023-01-16T04:43:28Z",
"author_association": "CONTRIBUTOR",
"body": "After a bit of thought, it might be possible to add a `Sort search by relevance` option like the `Reverse sort order` and only sort by relevance if this is ticked, otherwise sort like the note sort. \r\nIt's not quite as flexible, but I think it's ok, and for relevance sorting, ignore than the reverse order option. ",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1383484313/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384076214",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1384076214",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1384076214,
"node_id": "IC_kwDOBLftOs5Sf1O2",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-16T13:38:30Z",
"updated_at": "2023-01-16T13:38:30Z",
"author_association": "OWNER",
"body": "I wish this had been discussed on the forum first so as not to spend too much time on the implementation. I'm not very keen to add this to be honest because I don't think it's the right solution to whatever problem there is.\r\n\r\nWhen I look at the linked threads, it seems people usually want to sort by date, but Naveen added this at some point - more recent notes have a higher weight. So maybe it's a matter of tweaking the algorithm further and give more importance to the note date.\r\n\r\nAnother advantage of improving the search engine itself is that it will benefit the mobile app, CLI, API and plugins too.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384076214/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384130894",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1384130894",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1384130894,
"node_id": "IC_kwDOBLftOs5SgClO",
"user": {
"login": "JackGruber",
"id": 24863925,
"node_id": "MDQ6VXNlcjI0ODYzOTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/24863925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JackGruber",
"html_url": "https://github.com/JackGruber",
"followers_url": "https://api.github.com/users/JackGruber/followers",
"following_url": "https://api.github.com/users/JackGruber/following{/other_user}",
"gists_url": "https://api.github.com/users/JackGruber/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JackGruber/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JackGruber/subscriptions",
"organizations_url": "https://api.github.com/users/JackGruber/orgs",
"repos_url": "https://api.github.com/users/JackGruber/repos",
"events_url": "https://api.github.com/users/JackGruber/events{/privacy}",
"received_events_url": "https://api.github.com/users/JackGruber/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-16T14:16:30Z",
"updated_at": "2023-01-16T14:17:14Z",
"author_association": "CONTRIBUTOR",
"body": "> as not to spend too much time on the implementation.\r\n\r\nThis is no problem, since i have only adapted this implementation a bit and added the test, since i use it myself, since i don't like the relevancy sorting and and therefore build my own application. \r\n\r\nIf there is no interest in the PR, just close it. \r\n\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384130894/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384138475",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1384138475",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1384138475,
"node_id": "IC_kwDOBLftOs5SgEbr",
"user": {
"login": "chevdor",
"id": 738724,
"node_id": "MDQ6VXNlcjczODcyNA==",
"avatar_url": "https://avatars.githubusercontent.com/u/738724?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chevdor",
"html_url": "https://github.com/chevdor",
"followers_url": "https://api.github.com/users/chevdor/followers",
"following_url": "https://api.github.com/users/chevdor/following{/other_user}",
"gists_url": "https://api.github.com/users/chevdor/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chevdor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chevdor/subscriptions",
"organizations_url": "https://api.github.com/users/chevdor/orgs",
"repos_url": "https://api.github.com/users/chevdor/repos",
"events_url": "https://api.github.com/users/chevdor/events{/privacy}",
"received_events_url": "https://api.github.com/users/chevdor/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-16T14:21:08Z",
"updated_at": "2023-01-16T14:21:08Z",
"author_association": "NONE",
"body": "Please don't delete the PR's branch, until there is a full spec and matching implementation, I think your option is great @JackGruber, thanks for spending some time on that and sharing.\r\n\r\nI personally don't need/want to sort by `<you name it>`, instead what I need is `it depends` !\r\nSometimes I need to sort by note title, sometimes by creation date, sometimes by updated date, size, etc....\r\nSo I don't think we can find **the** right sorting algorithm but need to let the user switch back and forth between a few options.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384138475/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384232706",
"html_url": "https://github.com/laurent22/joplin/pull/7622#issuecomment-1384232706",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7622",
"id": 1384232706,
"node_id": "IC_kwDOBLftOs5SgbcC",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-16T15:44:40Z",
"updated_at": "2023-01-16T15:44:40Z",
"author_association": "OWNER",
"body": "> This is no problem, since i have only adapted this implementation a bit and added the test, since i use it myself, since i don't like the relevancy sorting and and therefore build my own application.\r\n\r\nOk that's great if it's still of use to you. And I appreciate you spending time creating the PR but I feel what's missing, but that might be for another day, is a review of search in existing apps, weighting the pros and cons, and finding a solution that fits Joplin well. In the meantime I will close the PR then.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1384232706/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}