一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
790 行
35 KiB
JSON
790 行
35 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13675/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13675/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/13675/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675",
|
|
"id": 3614072079,
|
|
"node_id": "PR_kwDOBLftOs6y2eMg",
|
|
"number": 13675,
|
|
"title": "Mobile: Resolves #11521: Remember the viewing / editing mode",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [],
|
|
"state": "open",
|
|
"locked": false,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 14,
|
|
"created_at": "2025-11-11T22:03:52Z",
|
|
"updated_at": "2025-11-18T12:47:43Z",
|
|
"closed_at": null,
|
|
"author_association": "FIRST_TIME_CONTRIBUTOR",
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/13675",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/13675.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/13675.patch",
|
|
"merged_at": null
|
|
},
|
|
"body": "# Summary\r\n\r\nMakes the mobile note editor remember the editing mode ('view' or 'edit') across different notes and sessions, like on desktop. Suggested here #11521. Makes it much faster to open > edit > exit existing notes. \r\n\r\n- Notes open in the mode that was last used instead of always opening in 'view' mode\r\n- Adds a view toggle button to the right side of the top bar\r\n- The back button now exits the note editor without going trough 'view' mode first\r\n\r\n## Demo\r\n\r\nhttps://github.com/user-attachments/assets/7cb91431-a4e3-4a74-a6ab-62fad47116f1",
|
|
"closed_by": null,
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/13675/reactions",
|
|
"total_count": 1,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 1,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13675/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3518896535",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3518896535",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3518896535,
|
|
"node_id": "IC_kwDOBLftOs7RvhmX",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-11T22:04:04Z",
|
|
"updated_at": "2025-11-12T10:17:26Z",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"author_association": "CONTRIBUTOR",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3518896535/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": {
|
|
"id": 15368,
|
|
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
|
"slug": "github-actions",
|
|
"node_id": "MDM6QXBwMTUzNjg=",
|
|
"owner": {
|
|
"login": "github",
|
|
"id": 9919,
|
|
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github",
|
|
"html_url": "https://github.com/github",
|
|
"followers_url": "https://api.github.com/users/github/followers",
|
|
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github/orgs",
|
|
"repos_url": "https://api.github.com/users/github/repos",
|
|
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github/received_events",
|
|
"type": "Organization",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"name": "GitHub Actions",
|
|
"description": "Automate your workflow from idea to production",
|
|
"external_url": "https://help.github.com/en/actions",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"created_at": "2018-07-30T09:30:17Z",
|
|
"updated_at": "2025-11-12T15:38:39Z",
|
|
"permissions": {
|
|
"actions": "write",
|
|
"administration": "read",
|
|
"artifact_metadata": "write",
|
|
"attestations": "write",
|
|
"checks": "write",
|
|
"contents": "write",
|
|
"deployments": "write",
|
|
"discussions": "write",
|
|
"issues": "write",
|
|
"merge_queues": "write",
|
|
"metadata": "read",
|
|
"models": "read",
|
|
"packages": "write",
|
|
"pages": "write",
|
|
"pull_requests": "write",
|
|
"repository_hooks": "write",
|
|
"repository_projects": "write",
|
|
"security_events": "write",
|
|
"statuses": "write",
|
|
"vulnerability_alerts": "read"
|
|
},
|
|
"events": [
|
|
"branch_protection_rule",
|
|
"check_run",
|
|
"check_suite",
|
|
"create",
|
|
"delete",
|
|
"deployment",
|
|
"deployment_status",
|
|
"discussion",
|
|
"discussion_comment",
|
|
"fork",
|
|
"gollum",
|
|
"issues",
|
|
"issue_comment",
|
|
"label",
|
|
"merge_group",
|
|
"milestone",
|
|
"page_build",
|
|
"public",
|
|
"pull_request",
|
|
"pull_request_review",
|
|
"pull_request_review_comment",
|
|
"push",
|
|
"registry_package",
|
|
"release",
|
|
"repository",
|
|
"repository_dispatch",
|
|
"status",
|
|
"watch",
|
|
"workflow_dispatch",
|
|
"workflow_run"
|
|
]
|
|
}
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3518908862",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3518908862",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3518908862,
|
|
"node_id": "IC_kwDOBLftOs7Rvkm-",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-11T22:09:41Z",
|
|
"updated_at": "2025-11-11T22:09:41Z",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3518908862/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3521498438",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3521498438",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3521498438,
|
|
"node_id": "IC_kwDOBLftOs7R5c1G",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T11:38:57Z",
|
|
"updated_at": "2025-11-12T11:38:57Z",
|
|
"body": "Do we need that extra button? I think the button in the bottom right corner alone could do the job?",
|
|
"author_association": "OWNER",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3521498438/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3521541172",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3521541172",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3521541172,
|
|
"node_id": "IC_kwDOBLftOs7R5nQ0",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T11:50:04Z",
|
|
"updated_at": "2025-11-12T11:50:04Z",
|
|
"body": "> Do we need that extra button? I think the button in the bottom right corner alone could do the job?\n\nWe need some way to switch back to view mode from edit mode. Do you think it would be better to add a floating button to edit mode like there is currently in view mode? Personally I prefer the top bar toggle since it's not in the way when typing.",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3521541172/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3521683477",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3521683477",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3521683477,
|
|
"node_id": "IC_kwDOBLftOs7R6KAV",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T12:25:55Z",
|
|
"updated_at": "2025-11-12T12:25:55Z",
|
|
"body": "Right, I forgot that the bottom button is hidden in Edit mode. But I think it's fine to make it visible in that case since it's always possible to scroll up and down when the button is on the way. We may have to ensure that the editor scrolls past the bottom to leave a gap for the button, like it's done for the viewer, but other than that that seems like a simpler, more consistent solution",
|
|
"author_association": "OWNER",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3521683477/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522130328",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3522130328",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3522130328,
|
|
"node_id": "IC_kwDOBLftOs7R73GY",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T14:08:32Z",
|
|
"updated_at": "2025-11-12T14:08:32Z",
|
|
"body": "\n\nWhat should happen in this scenario? Should the view scroll down so that the currently active text line can't go behind the button? If so the user can only see very few lines of the note body when in edit mode.",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522130328/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522223977",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3522223977",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3522223977,
|
|
"node_id": "IC_kwDOBLftOs7R8N9p",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T14:27:44Z",
|
|
"updated_at": "2025-11-12T14:27:44Z",
|
|
"body": "This is what I mentioned above - it should be possible to scroll past the end of the text editor, as is done in the viewer (and the desktop app I believe). I think some padding or maybe built-in CodeMirror option allows this",
|
|
"author_association": "OWNER",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522223977/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522329287",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3522329287",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3522329287,
|
|
"node_id": "IC_kwDOBLftOs7R8nrH",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T14:49:29Z",
|
|
"updated_at": "2025-11-12T14:50:23Z",
|
|
"body": "Right, we should add padding to the bottom like in view mode. But should we also scroll down automatically when the user is editing on a line that is partly covered by the button like in the screenshot above?",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522329287/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522877976",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3522877976",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3522877976,
|
|
"node_id": "IC_kwDOBLftOs7R-toY",
|
|
"user": {
|
|
"login": "mrjo118",
|
|
"id": 6963004,
|
|
"node_id": "MDQ6VXNlcjY5NjMwMDQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/mrjo118",
|
|
"html_url": "https://github.com/mrjo118",
|
|
"followers_url": "https://api.github.com/users/mrjo118/followers",
|
|
"following_url": "https://api.github.com/users/mrjo118/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/mrjo118/orgs",
|
|
"repos_url": "https://api.github.com/users/mrjo118/repos",
|
|
"events_url": "https://api.github.com/users/mrjo118/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/mrjo118/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-12T16:44:40Z",
|
|
"updated_at": "2025-11-12T21:19:57Z",
|
|
"body": "@laurent22 FYI the current position of the edit button on the note viewer covers where the Markdown toolbar is on the note editor, so the button has to be shifted up a bit to accomodate it, therefore bringing the button further up the screen when in edit mode. Also if you open the search bar or even the find and replace, it will push the button up even further to make space for the toolbar extensions, and the button becomes even more in the way as the viewing space decreases. Are you sure keeping the floating button all the time in edit mode is the best approach?\r\n\r\nMy vote would be to follow the original implemented solution and have a new button in the header. If you think the header is too cluttered with the extra button, I would suggest to remove the Beta button (web app only) from the note viewer / editor header and only put it on the header when displaying the note list\r\n\r\n@Kallemakela Thanks for working on this!",
|
|
"author_association": "CONTRIBUTOR",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3522877976/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3540521128",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3540521128",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3540521128,
|
|
"node_id": "IC_kwDOBLftOs7TCBCo",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-17T08:26:28Z",
|
|
"updated_at": "2025-11-17T08:26:28Z",
|
|
"body": "I would also prefer the toggle button. Any thoughts @laurent22?",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3540521128/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3544026623",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3544026623",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3544026623,
|
|
"node_id": "IC_kwDOBLftOs7TPY3_",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-17T22:02:20Z",
|
|
"updated_at": "2025-11-17T22:02:20Z",
|
|
"body": "I'm not sure what's best, but I'd rather not have two different buttons to switch modes",
|
|
"author_association": "OWNER",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3544026623/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3544041149",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3544041149",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3544041149,
|
|
"node_id": "IC_kwDOBLftOs7TPca9",
|
|
"user": {
|
|
"login": "mrjo118",
|
|
"id": 6963004,
|
|
"node_id": "MDQ6VXNlcjY5NjMwMDQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/mrjo118",
|
|
"html_url": "https://github.com/mrjo118",
|
|
"followers_url": "https://api.github.com/users/mrjo118/followers",
|
|
"following_url": "https://api.github.com/users/mrjo118/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/mrjo118/orgs",
|
|
"repos_url": "https://api.github.com/users/mrjo118/repos",
|
|
"events_url": "https://api.github.com/users/mrjo118/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/mrjo118/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-17T22:07:12Z",
|
|
"updated_at": "2025-11-17T22:08:14Z",
|
|
"body": "> I'm not sure what's best, but I'd rather not have two different buttons to switch modes\r\n\r\n@laurent22 FYI I wasn't proposing having 2 different buttons. I think we should have 1 button in the header which switches between the view and edit icons, and the existing floating button in the bottom right (currently used to switch to edit mode), can be removed completely",
|
|
"author_association": "CONTRIBUTOR",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3544041149/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3546172932",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3546172932",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3546172932,
|
|
"node_id": "IC_kwDOBLftOs7TXk4E",
|
|
"user": {
|
|
"login": "Kallemakela",
|
|
"id": 31903287,
|
|
"node_id": "MDQ6VXNlcjMxOTAzMjg3",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/31903287?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Kallemakela",
|
|
"html_url": "https://github.com/Kallemakela",
|
|
"followers_url": "https://api.github.com/users/Kallemakela/followers",
|
|
"following_url": "https://api.github.com/users/Kallemakela/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Kallemakela/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Kallemakela/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Kallemakela/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Kallemakela/orgs",
|
|
"repos_url": "https://api.github.com/users/Kallemakela/repos",
|
|
"events_url": "https://api.github.com/users/Kallemakela/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Kallemakela/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-18T08:30:55Z",
|
|
"updated_at": "2025-11-18T08:30:55Z",
|
|
"body": "> I think we should have 1 button in the header which switches between the view and edit icons, and the existing floating button in the bottom right (currently used to switch to edit mode), can be removed completely\r\n\r\nI would also personally prefer this to only the floating button. If @laurent22 confirms that this is the correct design choice, I'll implement it right away.\r\n\r\n",
|
|
"author_association": "NONE",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3546172932/reactions",
|
|
"total_count": 1,
|
|
"+1": 1,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3546473621",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/13675#issuecomment-3546473621",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13675",
|
|
"id": 3546473621,
|
|
"node_id": "IC_kwDOBLftOs7TYuSV",
|
|
"user": {
|
|
"login": "mrjo118",
|
|
"id": 6963004,
|
|
"node_id": "MDQ6VXNlcjY5NjMwMDQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/mrjo118",
|
|
"html_url": "https://github.com/mrjo118",
|
|
"followers_url": "https://api.github.com/users/mrjo118/followers",
|
|
"following_url": "https://api.github.com/users/mrjo118/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/mrjo118/orgs",
|
|
"repos_url": "https://api.github.com/users/mrjo118/repos",
|
|
"events_url": "https://api.github.com/users/mrjo118/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/mrjo118/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2025-11-18T09:35:45Z",
|
|
"updated_at": "2025-11-18T09:35:45Z",
|
|
"body": "As an aside, not sure what the current implementation does, but from a usability perspective, the global editing state should auto switch to edit mode when creating a note / todo / etc",
|
|
"author_association": "CONTRIBUTOR",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3546473621/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |