wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/ManavSarkar_42129636.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

324 行
15 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7541",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7541/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7541/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/7541/events",
"html_url": "https://github.com/laurent22/joplin/pull/7541",
"id": 1511679326,
"node_id": "PR_kwDOBLftOs5GPYh3",
"number": 7541,
"title": "Windows 10 Desktop: Fixes #7528: Fixed the Joplin crashing Full Screen PDF error",
"user": {
"login": "ManavSarkar",
"id": 42129636,
"node_id": "MDQ6VXNlcjQyMTI5NjM2",
"avatar_url": "https://avatars.githubusercontent.com/u/42129636?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ManavSarkar",
"html_url": "https://github.com/ManavSarkar",
"followers_url": "https://api.github.com/users/ManavSarkar/followers",
"following_url": "https://api.github.com/users/ManavSarkar/following{/other_user}",
"gists_url": "https://api.github.com/users/ManavSarkar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ManavSarkar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ManavSarkar/subscriptions",
"organizations_url": "https://api.github.com/users/ManavSarkar/orgs",
"repos_url": "https://api.github.com/users/ManavSarkar/repos",
"events_url": "https://api.github.com/users/ManavSarkar/events{/privacy}",
"received_events_url": "https://api.github.com/users/ManavSarkar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": true,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 5,
"created_at": "2022-12-27T10:45:02Z",
"updated_at": "2022-12-31T00:36:58Z",
"closed_at": "2022-12-31T00:36:44Z",
"author_association": "NONE",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/7541",
"html_url": "https://github.com/laurent22/joplin/pull/7541",
"diff_url": "https://github.com/laurent22/joplin/pull/7541.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/7541.patch",
"merged_at": null
},
"body": "<!--\r\n\r\nPlease prefix the title with the platform you are targetting:\r\n\r\nHere are some examples of good titles:\r\n\r\n- Desktop: Resolves #123: Added new setting to change font\r\n- Mobile, Desktop: Fixes #456: Fixed config screen error\r\n- All: Resolves #777: Made synchronisation faster\r\n\r\nAnd here's an explanation of the title format:\r\n\r\n- \"Desktop\" for the Windows/macOS/Linux app (Electron app)\r\n- \"Mobile\" for the mobile app (or \"Android\" / \"iOS\" if the pull request only applies to one of the mobile platforms)\r\n- \"CLI\" for the CLI app\r\n\r\nIf it's two platforms, separate them with commas - \"Desktop, Mobile\" or if it's for all platforms, prefix with \"All\".\r\n\r\nIf it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.\r\n\r\nThen please append the issue that you've addressed or fixed. Use \"Resolves #123\" for new features or improvements and \"Fixes #123\" for bug fixes.\r\n\r\nAND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md\r\n\r\n-->\r\n## Fixed the Full-Screen window crashing on the desktop whenever the close button on the top-right corner was clicked.\r\n\r\nIssue #7528 is fixed. Previously whenever the PDF was closed, it showed an error, now it is being fixed. The problem was removing the event listener from the null object. Hence a null check is required. Here is the attached result.\r\n\r\nhttps://user-images.githubusercontent.com/42129636/209654974-074692b0-3034-400a-9073-786d8c0540b2.mp4\r\n\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7541/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7541/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365801749",
"html_url": "https://github.com/laurent22/joplin/pull/7541#issuecomment-1365801749",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7541",
"id": 1365801749,
"node_id": "IC_kwDOBLftOs5RaHsV",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-27T10:45:16Z",
"updated_at": "2022-12-28T17:19:08Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365801749/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365803305",
"html_url": "https://github.com/laurent22/joplin/pull/7541#issuecomment-1365803305",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7541",
"id": 1365803305,
"node_id": "IC_kwDOBLftOs5RaIEp",
"user": {
"login": "ManavSarkar",
"id": 42129636,
"node_id": "MDQ6VXNlcjQyMTI5NjM2",
"avatar_url": "https://avatars.githubusercontent.com/u/42129636?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ManavSarkar",
"html_url": "https://github.com/ManavSarkar",
"followers_url": "https://api.github.com/users/ManavSarkar/followers",
"following_url": "https://api.github.com/users/ManavSarkar/following{/other_user}",
"gists_url": "https://api.github.com/users/ManavSarkar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ManavSarkar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ManavSarkar/subscriptions",
"organizations_url": "https://api.github.com/users/ManavSarkar/orgs",
"repos_url": "https://api.github.com/users/ManavSarkar/repos",
"events_url": "https://api.github.com/users/ManavSarkar/events{/privacy}",
"received_events_url": "https://api.github.com/users/ManavSarkar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-27T10:48:19Z",
"updated_at": "2022-12-27T10:48:19Z",
"author_association": "NONE",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365803305/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365803518",
"html_url": "https://github.com/laurent22/joplin/pull/7541#issuecomment-1365803518",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7541",
"id": 1365803518,
"node_id": "IC_kwDOBLftOs5RaIH-",
"user": {
"login": "ManavSarkar",
"id": 42129636,
"node_id": "MDQ6VXNlcjQyMTI5NjM2",
"avatar_url": "https://avatars.githubusercontent.com/u/42129636?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ManavSarkar",
"html_url": "https://github.com/ManavSarkar",
"followers_url": "https://api.github.com/users/ManavSarkar/followers",
"following_url": "https://api.github.com/users/ManavSarkar/following{/other_user}",
"gists_url": "https://api.github.com/users/ManavSarkar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ManavSarkar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ManavSarkar/subscriptions",
"organizations_url": "https://api.github.com/users/ManavSarkar/orgs",
"repos_url": "https://api.github.com/users/ManavSarkar/repos",
"events_url": "https://api.github.com/users/ManavSarkar/events{/privacy}",
"received_events_url": "https://api.github.com/users/ManavSarkar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-27T10:48:44Z",
"updated_at": "2022-12-27T10:48:44Z",
"author_association": "NONE",
"body": "recheck",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365803518/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365865230",
"html_url": "https://github.com/laurent22/joplin/pull/7541#issuecomment-1365865230",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7541",
"id": 1365865230,
"node_id": "IC_kwDOBLftOs5RaXMO",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-27T12:23:10Z",
"updated_at": "2022-12-27T12:23:10Z",
"author_association": "OWNER",
"body": "But why is the element being unmounted before the event handler has been removed? There's something not right to the logic here, and solving it with `?` is not the way to go.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365865230/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368135129",
"html_url": "https://github.com/laurent22/joplin/pull/7541#issuecomment-1368135129",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7541",
"id": 1368135129,
"node_id": "IC_kwDOBLftOs5RjBXZ",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-31T00:36:44Z",
"updated_at": "2022-12-31T00:36:44Z",
"author_association": "OWNER",
"body": "Since this is urgent I ended up fixing it myself",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368135129/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接