wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/Om7035_130749526.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

315 行
14 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/13287",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13287/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13287/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/13287/events",
"html_url": "https://github.com/laurent22/joplin/pull/13287",
"id": 3450604706,
"node_id": "PR_kwDOBLftOs6qWZlE",
"number": 13287,
"title": "Fix german keyboard layout issue 13270",
"user": {
"login": "Om7035",
"id": 130749526,
"node_id": "U_kgDOB8sUVg",
"avatar_url": "https://avatars.githubusercontent.com/u/130749526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Om7035",
"html_url": "https://github.com/Om7035",
"followers_url": "https://api.github.com/users/Om7035/followers",
"following_url": "https://api.github.com/users/Om7035/following{/other_user}",
"gists_url": "https://api.github.com/users/Om7035/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Om7035/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Om7035/subscriptions",
"organizations_url": "https://api.github.com/users/Om7035/orgs",
"repos_url": "https://api.github.com/users/Om7035/repos",
"events_url": "https://api.github.com/users/Om7035/events{/privacy}",
"received_events_url": "https://api.github.com/users/Om7035/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 3,
"created_at": "2025-09-24T19:12:01Z",
"updated_at": "2025-10-09T22:58:01Z",
"closed_at": "2025-10-09T21:00:08Z",
"author_association": "NONE",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/13287",
"html_url": "https://github.com/laurent22/joplin/pull/13287",
"diff_url": "https://github.com/laurent22/joplin/pull/13287.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/13287.patch",
"merged_at": null
},
"body": "## Description\r\nFixes keyboard shortcut recognition for international keyboard layouts, specifically resolving the German keyboard issue where `Ctrl+#` was incorrectly displayed as `Ctrl+/`.\r\n\r\n## Problem\r\n- Users with non-US keyboard layouts (German QWERTZ, French AZERTY, etc.) could not properly set keyboard shortcuts\r\n- The issue was caused by using `event.keyCode` which is layout-dependent (physical key position)\r\n- On German keyboards, the `#` key has a different keyCode than on US keyboards, causing incorrect mapping\r\n\r\n## Solution\r\n- **Replaced keyCode-based mapping with event.key** for layout independence\r\n- **event.key provides the actual character produced** regardless of keyboard layout\r\n- **Maintained backward compatibility** with function keys and special keys using keyCode fallback\r\n- **Added comprehensive tests** for international keyboard support\r\n\r\n## Changes\r\n- Modified [domToElectronAccelerator()](file://f:\\xoxo\\joplin\\packages\\lib\\services\\KeymapService.ts#L399-L439) in `KeymapService.ts` to use `event.key` for character recognition\r\n- Added fallback to `keyCode` for special keys (F1-F24, arrows, etc.)\r\n- Added extensive test coverage for international keyboard layouts\r\n\r\n## Testing\r\n- German keyboard: `Ctrl+#` correctly recognized as `Ctrl+#`\r\n- US keyboard: Maintains full backward compatibility \r\n- Function keys: Still work correctly via keyCode fallback\r\n- International characters: Properly supported across layouts\r\n\r\n## Related Issues\r\nFixes #13270\r\n\r\n## Verification\r\nManual testing confirms the fix resolves the reported issue while maintaining compatibility with existing functionality.",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/13287/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13287/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330298122",
"html_url": "https://github.com/laurent22/joplin/pull/13287#issuecomment-3330298122",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13287",
"id": 3330298122,
"node_id": "IC_kwDOBLftOs7GgFEK",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T19:12:13Z",
"updated_at": "2025-10-09T22:58:02Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330298122/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2025-11-12T15:38:39Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"contents": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330300888",
"html_url": "https://github.com/laurent22/joplin/pull/13287#issuecomment-3330300888",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13287",
"id": 3330300888,
"node_id": "IC_kwDOBLftOs7GgFvY",
"user": {
"login": "Om7035",
"id": 130749526,
"node_id": "U_kgDOB8sUVg",
"avatar_url": "https://avatars.githubusercontent.com/u/130749526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Om7035",
"html_url": "https://github.com/Om7035",
"followers_url": "https://api.github.com/users/Om7035/followers",
"following_url": "https://api.github.com/users/Om7035/following{/other_user}",
"gists_url": "https://api.github.com/users/Om7035/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Om7035/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Om7035/subscriptions",
"organizations_url": "https://api.github.com/users/Om7035/orgs",
"repos_url": "https://api.github.com/users/Om7035/repos",
"events_url": "https://api.github.com/users/Om7035/events{/privacy}",
"received_events_url": "https://api.github.com/users/Om7035/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T19:13:06Z",
"updated_at": "2025-09-24T19:13:06Z",
"body": "> I have read the CLA Document and I hereby sign the CLA\r\n\r\nI have read the CLA Document and I hereby sign the CLA",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330300888/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3347490738",
"html_url": "https://github.com/laurent22/joplin/pull/13287#issuecomment-3347490738",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13287",
"id": 3347490738,
"node_id": "IC_kwDOBLftOs7Hhqey",
"user": {
"login": "Om7035",
"id": 130749526,
"node_id": "U_kgDOB8sUVg",
"avatar_url": "https://avatars.githubusercontent.com/u/130749526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Om7035",
"html_url": "https://github.com/Om7035",
"followers_url": "https://api.github.com/users/Om7035/followers",
"following_url": "https://api.github.com/users/Om7035/following{/other_user}",
"gists_url": "https://api.github.com/users/Om7035/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Om7035/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Om7035/subscriptions",
"organizations_url": "https://api.github.com/users/Om7035/orgs",
"repos_url": "https://api.github.com/users/Om7035/repos",
"events_url": "https://api.github.com/users/Om7035/events{/privacy}",
"received_events_url": "https://api.github.com/users/Om7035/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-29T14:59:24Z",
"updated_at": "2025-09-29T14:59:24Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3347490738/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接