一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
412 行
17 KiB
JSON
412 行
17 KiB
JSON
{
|
|
"issue": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/10087",
|
|
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
|
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10087/labels{/name}",
|
|
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10087/comments",
|
|
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/10087/events",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087",
|
|
"id": 2175144425,
|
|
"node_id": "PR_kwDOBLftOs5pCNlO",
|
|
"number": 10087,
|
|
"title": "Mobile: Fixes #10065 filtered deleted and trash folder when counting active notebooks",
|
|
"user": {
|
|
"login": "Sidd-R",
|
|
"id": 97161173,
|
|
"node_id": "U_kgDOBcqP1Q",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/97161173?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Sidd-R",
|
|
"html_url": "https://github.com/Sidd-R",
|
|
"followers_url": "https://api.github.com/users/Sidd-R/followers",
|
|
"following_url": "https://api.github.com/users/Sidd-R/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Sidd-R/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Sidd-R/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Sidd-R/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Sidd-R/orgs",
|
|
"repos_url": "https://api.github.com/users/Sidd-R/repos",
|
|
"events_url": "https://api.github.com/users/Sidd-R/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Sidd-R/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"labels": [],
|
|
"state": "closed",
|
|
"locked": false,
|
|
"assignee": null,
|
|
"assignees": [],
|
|
"milestone": null,
|
|
"comments": 5,
|
|
"created_at": "2024-03-08T02:12:05Z",
|
|
"updated_at": "2024-03-11T15:22:41Z",
|
|
"closed_at": "2024-03-11T15:22:26Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"sub_issues_summary": {
|
|
"total": 0,
|
|
"completed": 0,
|
|
"percent_completed": 0
|
|
},
|
|
"active_lock_reason": null,
|
|
"draft": false,
|
|
"pull_request": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/pulls/10087",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087",
|
|
"diff_url": "https://github.com/laurent22/joplin/pull/10087.diff",
|
|
"patch_url": "https://github.com/laurent22/joplin/pull/10087.patch",
|
|
"merged_at": "2024-03-11T15:22:26Z"
|
|
},
|
|
"body": "## Summary\r\n\r\nFiltered the array of folders for trash and deleted folders before taking its length. Earlier both were being considered which led to trash and deleted folders to be considered as active notebooks and the ui of an active notebook was being displayed. When there was an attempt to create a new note/todo list, the Folder.defaultFolder() returned null in screens/Notes.tsx and when its id was accessed, it gave cannot read property error.\r\n\r\n\r\n- Fixes #10065\r\n\r\n\r\n## Rationale\r\n\r\nFiltered the folders using the following logic:\r\n - Used the folder id of trash folder to filter it out.\r\n - Filtered folders whose deleted time was not equal to 0 to remove deleted folders.\r\n\r\nNow when there are no active notebooks, create new notebook option is shown and the floating button for creating new note/todo is hidden.\r\n\r\nBefore:\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\nTested on Android 13\r\n\r\n\r\nLink to my introduction in forum: - [https://discourse.joplinapp.org/t/introducing-sidd-r/36498](https://discourse.joplinapp.org/t/introducing-sidd-r/36498)",
|
|
"closed_by": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/10087/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10087/timeline",
|
|
"performed_via_github_app": null,
|
|
"state_reason": null
|
|
},
|
|
"comments": [
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984924886",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087#issuecomment-1984924886",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10087",
|
|
"id": 1984924886,
|
|
"node_id": "IC_kwDOBLftOs52T4zW",
|
|
"user": {
|
|
"login": "github-actions[bot]",
|
|
"id": 41898282,
|
|
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
|
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
|
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
|
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
|
"type": "Bot",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-03-08T02:12:17Z",
|
|
"updated_at": "2024-03-11T15:22:41Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984924886/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": {
|
|
"id": 15368,
|
|
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
|
"slug": "github-actions",
|
|
"node_id": "MDM6QXBwMTUzNjg=",
|
|
"owner": {
|
|
"login": "github",
|
|
"id": 9919,
|
|
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/github",
|
|
"html_url": "https://github.com/github",
|
|
"followers_url": "https://api.github.com/users/github/followers",
|
|
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/github/orgs",
|
|
"repos_url": "https://api.github.com/users/github/repos",
|
|
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/github/received_events",
|
|
"type": "Organization",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"name": "GitHub Actions",
|
|
"description": "Automate your workflow from idea to production",
|
|
"external_url": "https://help.github.com/en/actions",
|
|
"html_url": "https://github.com/apps/github-actions",
|
|
"created_at": "2018-07-30T09:30:17Z",
|
|
"updated_at": "2025-03-07T16:35:00Z",
|
|
"permissions": {
|
|
"actions": "write",
|
|
"administration": "read",
|
|
"attestations": "write",
|
|
"checks": "write",
|
|
"contents": "write",
|
|
"deployments": "write",
|
|
"discussions": "write",
|
|
"issues": "write",
|
|
"merge_queues": "write",
|
|
"metadata": "read",
|
|
"models": "read",
|
|
"packages": "write",
|
|
"pages": "write",
|
|
"pull_requests": "write",
|
|
"repository_hooks": "write",
|
|
"repository_projects": "write",
|
|
"security_events": "write",
|
|
"statuses": "write",
|
|
"vulnerability_alerts": "read"
|
|
},
|
|
"events": [
|
|
"branch_protection_rule",
|
|
"check_run",
|
|
"check_suite",
|
|
"create",
|
|
"delete",
|
|
"deployment",
|
|
"deployment_status",
|
|
"discussion",
|
|
"discussion_comment",
|
|
"fork",
|
|
"gollum",
|
|
"issues",
|
|
"issue_comment",
|
|
"label",
|
|
"merge_group",
|
|
"milestone",
|
|
"page_build",
|
|
"project",
|
|
"project_card",
|
|
"project_column",
|
|
"public",
|
|
"pull_request",
|
|
"pull_request_review",
|
|
"pull_request_review_comment",
|
|
"push",
|
|
"registry_package",
|
|
"release",
|
|
"repository",
|
|
"repository_dispatch",
|
|
"status",
|
|
"watch",
|
|
"workflow_dispatch",
|
|
"workflow_run"
|
|
]
|
|
}
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984926247",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087#issuecomment-1984926247",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10087",
|
|
"id": 1984926247,
|
|
"node_id": "IC_kwDOBLftOs52T5In",
|
|
"user": {
|
|
"login": "Sidd-R",
|
|
"id": 97161173,
|
|
"node_id": "U_kgDOBcqP1Q",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/97161173?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Sidd-R",
|
|
"html_url": "https://github.com/Sidd-R",
|
|
"followers_url": "https://api.github.com/users/Sidd-R/followers",
|
|
"following_url": "https://api.github.com/users/Sidd-R/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Sidd-R/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Sidd-R/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Sidd-R/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Sidd-R/orgs",
|
|
"repos_url": "https://api.github.com/users/Sidd-R/repos",
|
|
"events_url": "https://api.github.com/users/Sidd-R/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Sidd-R/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-03-08T02:14:07Z",
|
|
"updated_at": "2024-03-08T02:14:07Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "I have read the CLA Document and I hereby sign the CLA",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984926247/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984951285",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087#issuecomment-1984951285",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10087",
|
|
"id": 1984951285,
|
|
"node_id": "IC_kwDOBLftOs52T_P1",
|
|
"user": {
|
|
"login": "Sidd-R",
|
|
"id": 97161173,
|
|
"node_id": "U_kgDOBcqP1Q",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/97161173?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Sidd-R",
|
|
"html_url": "https://github.com/Sidd-R",
|
|
"followers_url": "https://api.github.com/users/Sidd-R/followers",
|
|
"following_url": "https://api.github.com/users/Sidd-R/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Sidd-R/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Sidd-R/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Sidd-R/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Sidd-R/orgs",
|
|
"repos_url": "https://api.github.com/users/Sidd-R/repos",
|
|
"events_url": "https://api.github.com/users/Sidd-R/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Sidd-R/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-03-08T02:48:30Z",
|
|
"updated_at": "2024-03-08T02:48:53Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "Hello, this is my first time contributing to Joplin and I have tried my best to follow the given guidelines as much as possible but incase if I missed anything do let me know! Also, any tips to improve my pr would be appreciated!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984951285/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984976196",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087#issuecomment-1984976196",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10087",
|
|
"id": 1984976196,
|
|
"node_id": "IC_kwDOBLftOs52UFVE",
|
|
"user": {
|
|
"login": "Sidd-R",
|
|
"id": 97161173,
|
|
"node_id": "U_kgDOBcqP1Q",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/97161173?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/Sidd-R",
|
|
"html_url": "https://github.com/Sidd-R",
|
|
"followers_url": "https://api.github.com/users/Sidd-R/followers",
|
|
"following_url": "https://api.github.com/users/Sidd-R/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/Sidd-R/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/Sidd-R/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/Sidd-R/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/Sidd-R/orgs",
|
|
"repos_url": "https://api.github.com/users/Sidd-R/repos",
|
|
"events_url": "https://api.github.com/users/Sidd-R/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/Sidd-R/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-03-08T03:23:16Z",
|
|
"updated_at": "2024-03-08T03:23:16Z",
|
|
"author_association": "CONTRIBUTOR",
|
|
"body": "@PackElend label me please",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984976196/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
},
|
|
{
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1988700246",
|
|
"html_url": "https://github.com/laurent22/joplin/pull/10087#issuecomment-1988700246",
|
|
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10087",
|
|
"id": 1988700246,
|
|
"node_id": "IC_kwDOBLftOs52iShW",
|
|
"user": {
|
|
"login": "laurent22",
|
|
"id": 1285584,
|
|
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
|
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
|
"gravatar_id": "",
|
|
"url": "https://api.github.com/users/laurent22",
|
|
"html_url": "https://github.com/laurent22",
|
|
"followers_url": "https://api.github.com/users/laurent22/followers",
|
|
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
|
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
|
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
|
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
|
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
|
"repos_url": "https://api.github.com/users/laurent22/repos",
|
|
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
|
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
|
"type": "User",
|
|
"user_view_type": "public",
|
|
"site_admin": false
|
|
},
|
|
"created_at": "2024-03-11T15:21:47Z",
|
|
"updated_at": "2024-03-11T15:21:47Z",
|
|
"author_association": "OWNER",
|
|
"body": "Looks good now, thanks @Sidd-R!",
|
|
"reactions": {
|
|
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1988700246/reactions",
|
|
"total_count": 0,
|
|
"+1": 0,
|
|
"-1": 0,
|
|
"laugh": 0,
|
|
"hooray": 0,
|
|
"confused": 0,
|
|
"heart": 0,
|
|
"rocket": 0,
|
|
"eyes": 0
|
|
},
|
|
"performed_via_github_app": null
|
|
}
|
|
]
|
|
} |