一些检查失败了
automerge / automerge (push) Has been cancelled
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
Build macOS M1 / Main (push) Has been cancelled
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
Joplin UI tests / Mobile (push) Has been cancelled
Close stale issues / ProcessStaleIssues (push) Has been cancelled
412 行
24 KiB
JSON
412 行
24 KiB
JSON
{
|
||
"issue": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/10083",
|
||
"repository_url": "https://api.github.com/repos/laurent22/joplin",
|
||
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10083/labels{/name}",
|
||
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10083/comments",
|
||
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/10083/events",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083",
|
||
"id": 2174628067,
|
||
"node_id": "PR_kwDOBLftOs5pAdx-",
|
||
"number": 10083,
|
||
"title": "Desktop: Fixes #10037: Changed the minimum width of layout items",
|
||
"user": {
|
||
"login": "ab-elhaddad",
|
||
"id": 113056556,
|
||
"node_id": "U_kgDOBr0bLA",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/113056556?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/ab-elhaddad",
|
||
"html_url": "https://github.com/ab-elhaddad",
|
||
"followers_url": "https://api.github.com/users/ab-elhaddad/followers",
|
||
"following_url": "https://api.github.com/users/ab-elhaddad/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/ab-elhaddad/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/ab-elhaddad/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/ab-elhaddad/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/ab-elhaddad/orgs",
|
||
"repos_url": "https://api.github.com/users/ab-elhaddad/repos",
|
||
"events_url": "https://api.github.com/users/ab-elhaddad/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/ab-elhaddad/received_events",
|
||
"type": "User",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"labels": [],
|
||
"state": "closed",
|
||
"locked": false,
|
||
"assignee": null,
|
||
"assignees": [],
|
||
"milestone": null,
|
||
"comments": 5,
|
||
"created_at": "2024-03-07T19:34:20Z",
|
||
"updated_at": "2024-03-27T15:25:46Z",
|
||
"closed_at": "2024-03-09T11:08:50Z",
|
||
"author_association": "CONTRIBUTOR",
|
||
"sub_issues_summary": {
|
||
"total": 0,
|
||
"completed": 0,
|
||
"percent_completed": 0
|
||
},
|
||
"active_lock_reason": null,
|
||
"draft": false,
|
||
"pull_request": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/pulls/10083",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083",
|
||
"diff_url": "https://github.com/laurent22/joplin/pull/10083.diff",
|
||
"patch_url": "https://github.com/laurent22/joplin/pull/10083.patch",
|
||
"merged_at": null
|
||
},
|
||
"body": "This is a quick fix for #10037 \r\nIt may not be the best solution for the issue, but for now, it serves the purpose.\r\n\r\n### Before\r\n\r\nhttps://github.com/laurent22/joplin/assets/113056556/9584f8e5-b2a1-4bb8-8e38-0aefd0f80114\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/laurent22/joplin/assets/113056556/652a5d8c-939e-4668-9a90-fdcdbeeb2ee2\r\n\r\n",
|
||
"closed_by": {
|
||
"login": "laurent22",
|
||
"id": 1285584,
|
||
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/laurent22",
|
||
"html_url": "https://github.com/laurent22",
|
||
"followers_url": "https://api.github.com/users/laurent22/followers",
|
||
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
||
"repos_url": "https://api.github.com/users/laurent22/repos",
|
||
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
||
"type": "User",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"reactions": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/10083/reactions",
|
||
"total_count": 0,
|
||
"+1": 0,
|
||
"-1": 0,
|
||
"laugh": 0,
|
||
"hooray": 0,
|
||
"confused": 0,
|
||
"heart": 0,
|
||
"rocket": 0,
|
||
"eyes": 0
|
||
},
|
||
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10083/timeline",
|
||
"performed_via_github_app": null,
|
||
"state_reason": null
|
||
},
|
||
"comments": [
|
||
{
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984284035",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083#issuecomment-1984284035",
|
||
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10083",
|
||
"id": 1984284035,
|
||
"node_id": "IC_kwDOBLftOs52RcWD",
|
||
"user": {
|
||
"login": "github-actions[bot]",
|
||
"id": 41898282,
|
||
"node_id": "MDM6Qm90NDE4OTgyODI=",
|
||
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
|
||
"html_url": "https://github.com/apps/github-actions",
|
||
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
|
||
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
|
||
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
|
||
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
|
||
"type": "Bot",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"created_at": "2024-03-07T19:34:32Z",
|
||
"updated_at": "2024-03-09T11:09:03Z",
|
||
"author_association": "CONTRIBUTOR",
|
||
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
|
||
"reactions": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984284035/reactions",
|
||
"total_count": 0,
|
||
"+1": 0,
|
||
"-1": 0,
|
||
"laugh": 0,
|
||
"hooray": 0,
|
||
"confused": 0,
|
||
"heart": 0,
|
||
"rocket": 0,
|
||
"eyes": 0
|
||
},
|
||
"performed_via_github_app": {
|
||
"id": 15368,
|
||
"client_id": "Iv1.05c79e9ad1f6bdfa",
|
||
"slug": "github-actions",
|
||
"node_id": "MDM6QXBwMTUzNjg=",
|
||
"owner": {
|
||
"login": "github",
|
||
"id": 9919,
|
||
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/github",
|
||
"html_url": "https://github.com/github",
|
||
"followers_url": "https://api.github.com/users/github/followers",
|
||
"following_url": "https://api.github.com/users/github/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/github/orgs",
|
||
"repos_url": "https://api.github.com/users/github/repos",
|
||
"events_url": "https://api.github.com/users/github/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/github/received_events",
|
||
"type": "Organization",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"name": "GitHub Actions",
|
||
"description": "Automate your workflow from idea to production",
|
||
"external_url": "https://help.github.com/en/actions",
|
||
"html_url": "https://github.com/apps/github-actions",
|
||
"created_at": "2018-07-30T09:30:17Z",
|
||
"updated_at": "2025-03-07T16:35:00Z",
|
||
"permissions": {
|
||
"actions": "write",
|
||
"administration": "read",
|
||
"attestations": "write",
|
||
"checks": "write",
|
||
"contents": "write",
|
||
"deployments": "write",
|
||
"discussions": "write",
|
||
"issues": "write",
|
||
"merge_queues": "write",
|
||
"metadata": "read",
|
||
"models": "read",
|
||
"packages": "write",
|
||
"pages": "write",
|
||
"pull_requests": "write",
|
||
"repository_hooks": "write",
|
||
"repository_projects": "write",
|
||
"security_events": "write",
|
||
"statuses": "write",
|
||
"vulnerability_alerts": "read"
|
||
},
|
||
"events": [
|
||
"branch_protection_rule",
|
||
"check_run",
|
||
"check_suite",
|
||
"create",
|
||
"delete",
|
||
"deployment",
|
||
"deployment_status",
|
||
"discussion",
|
||
"discussion_comment",
|
||
"fork",
|
||
"gollum",
|
||
"issues",
|
||
"issue_comment",
|
||
"label",
|
||
"merge_group",
|
||
"milestone",
|
||
"page_build",
|
||
"project",
|
||
"project_card",
|
||
"project_column",
|
||
"public",
|
||
"pull_request",
|
||
"pull_request_review",
|
||
"pull_request_review_comment",
|
||
"push",
|
||
"registry_package",
|
||
"release",
|
||
"repository",
|
||
"repository_dispatch",
|
||
"status",
|
||
"watch",
|
||
"workflow_dispatch",
|
||
"workflow_run"
|
||
]
|
||
}
|
||
},
|
||
{
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984286532",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083#issuecomment-1984286532",
|
||
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10083",
|
||
"id": 1984286532,
|
||
"node_id": "IC_kwDOBLftOs52Rc9E",
|
||
"user": {
|
||
"login": "ab-elhaddad",
|
||
"id": 113056556,
|
||
"node_id": "U_kgDOBr0bLA",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/113056556?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/ab-elhaddad",
|
||
"html_url": "https://github.com/ab-elhaddad",
|
||
"followers_url": "https://api.github.com/users/ab-elhaddad/followers",
|
||
"following_url": "https://api.github.com/users/ab-elhaddad/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/ab-elhaddad/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/ab-elhaddad/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/ab-elhaddad/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/ab-elhaddad/orgs",
|
||
"repos_url": "https://api.github.com/users/ab-elhaddad/repos",
|
||
"events_url": "https://api.github.com/users/ab-elhaddad/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/ab-elhaddad/received_events",
|
||
"type": "User",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"created_at": "2024-03-07T19:35:39Z",
|
||
"updated_at": "2024-03-07T19:35:39Z",
|
||
"author_association": "CONTRIBUTOR",
|
||
"body": "I have read the CLA Document and I hereby sign the CLA",
|
||
"reactions": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984286532/reactions",
|
||
"total_count": 0,
|
||
"+1": 0,
|
||
"-1": 0,
|
||
"laugh": 0,
|
||
"hooray": 0,
|
||
"confused": 0,
|
||
"heart": 0,
|
||
"rocket": 0,
|
||
"eyes": 0
|
||
},
|
||
"performed_via_github_app": null
|
||
},
|
||
{
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984463943",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083#issuecomment-1984463943",
|
||
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10083",
|
||
"id": 1984463943,
|
||
"node_id": "IC_kwDOBLftOs52SIRH",
|
||
"user": {
|
||
"login": "personalizedrefrigerator",
|
||
"id": 46334387,
|
||
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/personalizedrefrigerator",
|
||
"html_url": "https://github.com/personalizedrefrigerator",
|
||
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
|
||
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
|
||
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
|
||
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
|
||
"type": "User",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"created_at": "2024-03-07T21:03:17Z",
|
||
"updated_at": "2024-03-07T21:03:32Z",
|
||
"author_association": "COLLABORATOR",
|
||
"body": "Several tests are failing in CI:\r\n\r\n<details>\r\n\r\n````Summary of all failing tests\r\n➤ YN0000: [@joplin/app-desktop]: FAIL gui/ResizableLayout/utils/useLayoutItemSizes.test.js (12.35 s)\r\n➤ YN0000: [@joplin/app-desktop]: ● useLayoutItemSizes › should leave room for the resizer controls\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: expect(received).toEqual(expected) // deep equality\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: - Expected - 4\r\n➤ YN0000: [@joplin/app-desktop]: + Received + 4\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: Object {\r\n➤ YN0000: [@joplin/app-desktop]: \"col1\": Object {\r\n➤ YN0000: [@joplin/app-desktop]: \"height\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: - \"width\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: + \"width\": 105,\r\n➤ YN0000: [@joplin/app-desktop]: },\r\n➤ YN0000: [@joplin/app-desktop]: \"col2\": Object {\r\n➤ YN0000: [@joplin/app-desktop]: \"height\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: - \"width\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: + \"width\": 105,\r\n➤ YN0000: [@joplin/app-desktop]: },\r\n➤ YN0000: [@joplin/app-desktop]: \"root\": Object {\r\n➤ YN0000: [@joplin/app-desktop]: \"height\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: \"width\": 200,\r\n➤ YN0000: [@joplin/app-desktop]: },\r\n➤ YN0000: [@joplin/app-desktop]: \"row1\": Object {\r\n➤ YN0000: [@joplin/app-desktop]: \"height\": 50,\r\n➤ YN0000: [@joplin/app-desktop]: - \"width\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: + \"width\": 105,\r\n➤ YN0000: [@joplin/app-desktop]: },\r\n➤ YN0000: [@joplin/app-desktop]: \"row2\": Object {\r\n➤ YN0000: [@joplin/app-desktop]: \"height\": 50,\r\n➤ YN0000: [@joplin/app-desktop]: - \"width\": 100,\r\n➤ YN0000: [@joplin/app-desktop]: + \"width\": 105,\r\n➤ YN0000: [@joplin/app-desktop]: },\r\n➤ YN0000: [@joplin/app-desktop]: }\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: 124 | \t\tconst sizes = result.current;\r\n➤ YN0000: [@joplin/app-desktop]: 125 |\r\n➤ YN0000: [@joplin/app-desktop]: > 126 | \t\texpect(sizes).toEqual({\r\n➤ YN0000: [@joplin/app-desktop]: | \t\t ^\r\n➤ YN0000: [@joplin/app-desktop]: 127 | \t\t\troot: { width: 200, height: 100 },\r\n➤ YN0000: [@joplin/app-desktop]: 128 | \t\t\tcol1: { width: 100, height: 100 },\r\n➤ YN0000: [@joplin/app-desktop]: 129 | \t\t\tcol2: { width: 100, height: 100 },\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: at Object.toEqual (gui/ResizableLayout/utils/useLayoutItemSizes.test.ts:126:17)\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: ● useLayoutItemSizes › should not allow a minWidth of 0, should still make space for the item\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: expect(received).toBe(expected) // Object.is equality\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: Expected: 160\r\n➤ YN0000: [@joplin/app-desktop]: Received: 95\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: 190 | \t\tconst sizes = result.current;\r\n➤ YN0000: [@joplin/app-desktop]: 191 |\r\n➤ YN0000: [@joplin/app-desktop]: > 192 | \t\texpect(sizes.col1.width).toBe(160);\r\n➤ YN0000: [@joplin/app-desktop]: | \t\t ^\r\n➤ YN0000: [@joplin/app-desktop]: 193 | \t\texpect(sizes.col2.width).toBe(40); // default minWidth is 40\r\n➤ YN0000: [@joplin/app-desktop]: 194 | \t});\r\n➤ YN0000: [@joplin/app-desktop]: 195 |\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: at Object.toBe (gui/ResizableLayout/utils/useLayoutItemSizes.test.ts:192:28)\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: ● useLayoutItemSizes › should give maximum available space this item can take up during resizing\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: expect(received).toBe(expected) // Object.is equality\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: Expected: 90\r\n➤ YN0000: [@joplin/app-desktop]: Received: 50\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: 288 |\r\n➤ YN0000: [@joplin/app-desktop]: 289 | \t\t// maxSize = totalSize - ( [size of items with set size, except for the current item] + [minimum size of items with no set size] )\r\n➤ YN0000: [@joplin/app-desktop]: > 290 | \t\texpect(maxSize1.width).toBe(90); // 90 = layout.width - (col2.width + col3.minWidth(=40) )\r\n➤ YN0000: [@joplin/app-desktop]: | \t\t ^\r\n➤ YN0000: [@joplin/app-desktop]: 291 | \t\texpect(maxSize2.width).toBe(110); // 110 = layout.width - (col1.width + col3.minWidth(=40) )\r\n➤ YN0000: [@joplin/app-desktop]: 292 | \t});\r\n➤ YN0000: [@joplin/app-desktop]: 293 |\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: at Object.toBe (gui/ResizableLayout/utils/useLayoutItemSizes.test.ts:290:26)\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: ● useLayoutItemSizes › should not allow a minWidth of 0, should still leave space for the item\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: expect(received).toBe(expected) // Object.is equality\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: Expected: 160\r\n➤ YN0000: [@joplin/app-desktop]: Received: 95\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: 347 |\r\n➤ YN0000: [@joplin/app-desktop]: 348 | \t\t// maxSize = totalSize - ( [size of items with set size, except for the current item] + [minimum size of items with no set size] )\r\n➤ YN0000: [@joplin/app-desktop]: > 349 | \t\texpect(maxSize1.width).toBe(160); // 160 = layout.width - col2.minWidth(=40)\r\n➤ YN0000: [@joplin/app-desktop]: | \t\t ^\r\n➤ YN0000: [@joplin/app-desktop]: 350 | \t});\r\n➤ YN0000: [@joplin/app-desktop]: 351 |\r\n➤ YN0000: [@joplin/app-desktop]: 352 | });\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: at Object.toBe (gui/ResizableLayout/utils/useLayoutItemSizes.test.ts:349:26)\r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: \r\n➤ YN0000: [@joplin/app-desktop]: Test Suites: 1 failed, 20 passed, 21 total\r\n➤ YN0000: [@joplin/app-desktop]: Tests: 4 failed, 74 passed, 78 total\r\n➤ YN0000: [@joplin/app-desktop]: Snapshots: 0 total\r\n➤ YN0000: [@joplin/app-desktop]: Time: 22.257 s\r\n➤ YN0000: [@joplin/app-desktop]: Ran all test suites.\r\n````\r\n\r\n</details>",
|
||
"reactions": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1984463943/reactions",
|
||
"total_count": 0,
|
||
"+1": 0,
|
||
"-1": 0,
|
||
"laugh": 0,
|
||
"hooray": 0,
|
||
"confused": 0,
|
||
"heart": 0,
|
||
"rocket": 0,
|
||
"eyes": 0
|
||
},
|
||
"performed_via_github_app": null
|
||
},
|
||
{
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1985725473",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083#issuecomment-1985725473",
|
||
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10083",
|
||
"id": 1985725473,
|
||
"node_id": "IC_kwDOBLftOs52W8Qh",
|
||
"user": {
|
||
"login": "ab-elhaddad",
|
||
"id": 113056556,
|
||
"node_id": "U_kgDOBr0bLA",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/113056556?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/ab-elhaddad",
|
||
"html_url": "https://github.com/ab-elhaddad",
|
||
"followers_url": "https://api.github.com/users/ab-elhaddad/followers",
|
||
"following_url": "https://api.github.com/users/ab-elhaddad/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/ab-elhaddad/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/ab-elhaddad/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/ab-elhaddad/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/ab-elhaddad/orgs",
|
||
"repos_url": "https://api.github.com/users/ab-elhaddad/repos",
|
||
"events_url": "https://api.github.com/users/ab-elhaddad/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/ab-elhaddad/received_events",
|
||
"type": "User",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"created_at": "2024-03-08T13:46:57Z",
|
||
"updated_at": "2024-03-08T13:46:57Z",
|
||
"author_association": "CONTRIBUTOR",
|
||
"body": "@personalizedrefrigerator \r\nworking on it",
|
||
"reactions": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1985725473/reactions",
|
||
"total_count": 0,
|
||
"+1": 0,
|
||
"-1": 0,
|
||
"laugh": 0,
|
||
"hooray": 0,
|
||
"confused": 0,
|
||
"heart": 0,
|
||
"rocket": 0,
|
||
"eyes": 0
|
||
},
|
||
"performed_via_github_app": null
|
||
},
|
||
{
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1986827173",
|
||
"html_url": "https://github.com/laurent22/joplin/pull/10083#issuecomment-1986827173",
|
||
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10083",
|
||
"id": 1986827173,
|
||
"node_id": "IC_kwDOBLftOs52bJOl",
|
||
"user": {
|
||
"login": "laurent22",
|
||
"id": 1285584,
|
||
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
|
||
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
|
||
"gravatar_id": "",
|
||
"url": "https://api.github.com/users/laurent22",
|
||
"html_url": "https://github.com/laurent22",
|
||
"followers_url": "https://api.github.com/users/laurent22/followers",
|
||
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
|
||
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
|
||
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
|
||
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
|
||
"organizations_url": "https://api.github.com/users/laurent22/orgs",
|
||
"repos_url": "https://api.github.com/users/laurent22/repos",
|
||
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
|
||
"received_events_url": "https://api.github.com/users/laurent22/received_events",
|
||
"type": "User",
|
||
"user_view_type": "public",
|
||
"site_admin": false
|
||
},
|
||
"created_at": "2024-03-09T11:08:50Z",
|
||
"updated_at": "2024-03-09T11:08:50Z",
|
||
"author_association": "OWNER",
|
||
"body": "Please see my comment on the issue: https://github.com/laurent22/joplin/issues/10037#issuecomment-1984834710 We will go for a different solution",
|
||
"reactions": {
|
||
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1986827173/reactions",
|
||
"total_count": 1,
|
||
"+1": 1,
|
||
"-1": 0,
|
||
"laugh": 0,
|
||
"hooray": 0,
|
||
"confused": 0,
|
||
"heart": 0,
|
||
"rocket": 0,
|
||
"eyes": 0
|
||
},
|
||
"performed_via_github_app": null
|
||
}
|
||
]
|
||
} |