wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/adarsh-sgh_63918341.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

1459 行
72 KiB
JSON
原始文件 永久链接 Blame 文件历史

此文件含有模棱两可的 Unicode 字符

此文件含有可能会与其他字符混淆的 Unicode 字符。 如果您是想特意这样的，可以安全地忽略该警告。 使用 Escape 按钮显示他们。

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7546/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7546/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/7546/events",
"html_url": "https://github.com/laurent22/joplin/pull/7546",
"id": 1512550183,
"node_id": "PR_kwDOBLftOs5GSTF5",
"number": 7546,
"title": "desktop: Fixes #7521 Svg images are correctly sized when exported as png",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [
{
"id": 1080341216,
"node_id": "MDU6TGFiZWwxMDgwMzQxMjE2",
"url": "https://api.github.com/repos/laurent22/joplin/labels/desktop",
"name": "desktop",
"color": "ffc274",
"default": false,
"description": "All desktop platforms"
}
],
"state": "closed",
"locked": true,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 30,
"created_at": "2022-12-28T08:34:01Z",
"updated_at": "2023-02-08T06:24:59Z",
"closed_at": "2023-02-05T11:39:26Z",
"author_association": "CONTRIBUTOR",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/7546",
"html_url": "https://github.com/laurent22/joplin/pull/7546",
"diff_url": "https://github.com/laurent22/joplin/pull/7546.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/7546.patch",
"merged_at": "2023-02-05T11:39:26Z"
},
"body": "Mermaid images when exported as png were having very low resolution.\r\n\r\n### Before \r\nusing rendered image's dimensions as exported image dimension\r\n![image](https://user-images.githubusercontent.com/63918341/209781831-21f9e334-92f3-4cb0-8bfc-57378a465989.png)\r\n### After \r\nusing SVG's [viewBox](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBox) attribute as exported image's dimensions\r\n![image](https://user-images.githubusercontent.com/63918341/209781978-08e7f944-ee43-4e17-9aae-fd80763db5c1.png)\r\n\r\nFixes #7521 \r\n<!--\r\n\r\nPlease prefix the title with the platform you are targetting:\r\n\r\nHere are some examples of good titles:\r\n\r\n- Desktop: Resolves #123: Added new setting to change font\r\n- Mobile, Desktop: Fixes #456: Fixed config screen error\r\n- All: Resolves #777: Made synchronisation faster\r\n\r\nAnd here's an explanation of the title format:\r\n\r\n- \"Desktop\" for the Windows/macOS/Linux app (Electron app)\r\n- \"Mobile\" for the mobile app (or \"Android\" / \"iOS\" if the pull request only applies to one of the mobile platforms)\r\n- \"CLI\" for the CLI app\r\n\r\nIf it's two platforms, separate them with commas - \"Desktop, Mobile\" or if it's for all platforms, prefix with \"All\".\r\n\r\nIf it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.\r\n\r\nThen please append the issue that you've addressed or fixed. Use \"Resolves #123\" for new features or improvements and \"Fixes #123\" for bug fixes.\r\n\r\nAND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md\r\n\r\n-->\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/7546/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7546/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366466599",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366466599",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366466599,
"node_id": "IC_kwDOBLftOs5RcqAn",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T08:34:17Z",
"updated_at": "2023-02-05T11:36:09Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366466599/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366468835",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366468835",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366468835,
"node_id": "IC_kwDOBLftOs5Rcqjj",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T08:38:24Z",
"updated_at": "2022-12-28T08:38:24Z",
"author_association": "CONTRIBUTOR",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366468835/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366537489",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366537489",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366537489,
"node_id": "IC_kwDOBLftOs5Rc7UR",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T10:14:43Z",
"updated_at": "2022-12-28T10:57:44Z",
"author_association": "CONTRIBUTOR",
"body": "~~converted to draft since added jest test fails when run together using `yarn test`, they are passing when only that test file is run individually~~\r\n> TypeError: (0 , contextMenuUtils_1.svgDimensions) is not a function or its return value is not iterable\r\n\r\nedit: was some hoisting err perhaps, solved by removing and reinstalling node_modules",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366537489/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366662870",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366662870",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366662870,
"node_id": "IC_kwDOBLftOs5RdZ7W",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T13:43:14Z",
"updated_at": "2022-12-28T13:43:14Z",
"author_association": "OWNER",
"body": "The viewport is the dimension in user space - doesn't it mean that if the window is small, the exported PNG will be small too? And we wouldn't want that, instead it should be dimensions that make sense (although I don't know what that is), independent of the viewport.\r\n\r\nWhy is the PNG small to begin with? Isn't it one of those things where we can just double the exported dimensions and it will work?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366662870/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366789571",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366789571",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366789571,
"node_id": "IC_kwDOBLftOs5Rd43D",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T16:54:16Z",
"updated_at": "2022-12-29T15:49:07Z",
"author_association": "CONTRIBUTOR",
"body": "> if the window is small, the exported PNG will be small too\r\n\r\n~yeah that would be a problem in this approach 🤔~\r\nviewBox is not affected by resizing window\r\n\r\n> Why is the PNG small to begin with\r\n\r\ncause we are making an `<img>` element for the svg and using it's resolution to set exported image's resolution\r\nimg is a [replaced element](https://developer.mozilla.org/en-US/docs/Web/CSS/Replaced_element) and it's default size is 300 * 150 a/c to google search.\r\n\r\n\r\n> we can just double the exported dimensions and it will work?\r\n\r\nconsidering below two images\r\n![image](https://user-images.githubusercontent.com/63918341/209845715-a96d4449-353b-428d-881d-c6a847b21dba.png)\r\n![image](https://user-images.githubusercontent.com/63918341/209845738-691c2da7-78c8-4c54-98f8-605b6fae1e4b.png)\r\n\r\nboth have same height of 150px (default height of replaced elements)\r\nso if we double them these will still have same height which I guess is not desirable in this case.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366789571/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366799676",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366799676",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366799676,
"node_id": "IC_kwDOBLftOs5Rd7U8",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T17:08:53Z",
"updated_at": "2022-12-28T17:08:53Z",
"author_association": "OWNER",
"body": "So what would be the solution then?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366799676/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366815995",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366815995",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366815995,
"node_id": "IC_kwDOBLftOs5Rd_T7",
"user": {
"login": "personalizedrefrigerator",
"id": 46334387,
"node_id": "MDQ6VXNlcjQ2MzM0Mzg3",
"avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/personalizedrefrigerator",
"html_url": "https://github.com/personalizedrefrigerator",
"followers_url": "https://api.github.com/users/personalizedrefrigerator/followers",
"following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}",
"gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}",
"starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions",
"organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs",
"repos_url": "https://api.github.com/users/personalizedrefrigerator/repos",
"events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}",
"received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T17:39:05Z",
"updated_at": "2022-12-28T17:39:05Z",
"author_association": "COLLABORATOR",
"body": "It might make sense to have a minimum dimension when exporting SVGs. We could then increase the image's width and height if necessary.\r\nFor example, if the minimum dimension is 400, `img.height = 20`, and `img.width = 100`, we could multiply width and height by 20, making $\\min(\\texttt{img.width}, \\texttt{img.height}) = \\min(20\\times 100, 20\\times 20) = \\min(1000, 400) = 400$.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366815995/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366819189",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366819189",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366819189,
"node_id": "IC_kwDOBLftOs5ReAF1",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T17:45:30Z",
"updated_at": "2022-12-28T17:45:30Z",
"author_association": "CONTRIBUTOR",
"body": "> The viewport is the dimension in user space\r\n\r\nit's [viewBox](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBox) actually 🥲.\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366819189/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366823040",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1366823040",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1366823040,
"node_id": "IC_kwDOBLftOs5ReBCA",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-28T17:51:47Z",
"updated_at": "2022-12-28T17:52:13Z",
"author_association": "CONTRIBUTOR",
"body": "> yeah that would be a problem in this approach 🤔\r\n\r\nmy bad 😅 , \r\nthe viewbox's values are not varying when I resize the window of joplin if that's what we are concerned with.\r\n\r\n> it might make sense to have a minimum dimension when exporting SVGs. We could then increase the image's width and height if necessary.\r\n> For example, if the minimum dimension is 400, `img.height = 20`, and `img.width = 100`, we could multiply width and height by 20, making min(img.width,img.height)=min(20×100,20×20)=min(1000,400)=400.\r\n\r\nyeah that would be nice \r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366823040/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367226059",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1367226059",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1367226059,
"node_id": "IC_kwDOBLftOs5RfjbL",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-29T10:38:14Z",
"updated_at": "2022-12-29T10:38:14Z",
"author_association": "CONTRIBUTOR",
"body": "so what is the final implementation ?\r\nIMO combining viewbox information and minimum dimension approach explained by Henry would be sufficient for this ?\r\nshould I implement and push that ?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367226059/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367257043",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1367257043",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1367257043,
"node_id": "IC_kwDOBLftOs5Rfq_T",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-29T11:33:09Z",
"updated_at": "2022-12-29T11:33:09Z",
"author_association": "OWNER",
"body": "> It might make sense to have a minimum dimension when exporting SVGs. We could then increase the image's width and height if necessary. For example, if the minimum dimension is 400, `img.height = 20`, and `img.width = 100`, we could multiply width and height by 20, making min(img.width,img.height)=min(20×100,20×20)=min(1000,400)=400.\r\n\r\nI don't think a hard coded minimum dimension would work, because 400 is way too big for certain tiny diagrams, or way too small for massive ones. Basically there can be all sizes of diagrams so the dimensions we choose need to be based on the diagram.\r\n\r\n@adarsh-sgh, did you check the Mermaid API - do they provide some info about the diagram such as recommended width or similar?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367257043/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367388592",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1367388592",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1367388592,
"node_id": "IC_kwDOBLftOs5RgLGw",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-29T14:57:34Z",
"updated_at": "2022-12-29T14:57:34Z",
"author_association": "CONTRIBUTOR",
"body": "> did you check the Mermaid API\r\n\r\ncould not find anything like that there, but found about their [live editor](https://mermaid.live/) which also has `PNG download` functionality.\r\nthey are using dimensions of rendered svg (on the preview side) as default resolution for downloaded image, and allowing user to override height or width by entering a value for it.\r\n> https://github.com/mermaid-js/mermaid-live-editor/blob/7c64a6549779435986739d48d5dbf3710725c281/src/lib/components/Actions.svelte#L35\r\n\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1367388592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368121716",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1368121716",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1368121716,
"node_id": "IC_kwDOBLftOs5Ri-F0",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-30T23:23:35Z",
"updated_at": "2022-12-30T23:23:35Z",
"author_association": "OWNER",
"body": "> they are using dimensions of rendered svg (on the preview side) as default resolution for downloaded image, and allowing user to override height or width by entering a value for it.\r\n\r\nSounds reasonable. How about using this technique but double the dimensions (just to be sure it's high res enough for printing)?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368121716/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368205886",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1368205886",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1368205886,
"node_id": "IC_kwDOBLftOs5RjSo-",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-31T11:55:26Z",
"updated_at": "2022-12-31T11:55:26Z",
"author_association": "CONTRIBUTOR",
"body": "> Sounds reasonable. How about using this technique but double the dimensions (just to be sure it's high res enough for printing)?\r\n\r\nDimensions of rendered Svg will depend on window size, That's something we want to avoid I guess ?\r\n\r\n> if the window is small, the exported PNG will be small too? And we wouldn't want that\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368205886/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368206032",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1368206032",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1368206032,
"node_id": "IC_kwDOBLftOs5RjSrQ",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-31T11:57:10Z",
"updated_at": "2022-12-31T11:57:10Z",
"author_association": "CONTRIBUTOR",
"body": "> How about using this technique\r\n\r\nYes, allowing user's to override auto detected dimensions would be a very helpful feature IMO not sure about other point.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368206032/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368265714",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1368265714",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1368265714,
"node_id": "IC_kwDOBLftOs5RjhPy",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2022-12-31T19:00:15Z",
"updated_at": "2022-12-31T19:00:15Z",
"author_association": "OWNER",
"body": "> Dimensions of rendered Svg will depend on window size, That's something we want to avoid I guess ?\r\n\r\nBut what's the alternative, do you have any suggestion?\r\n\r\nWe don't want to ask the user for dimensions, just double it and that should work in most cases.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368265714/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368494405",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1368494405",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1368494405,
"node_id": "IC_kwDOBLftOs5RkZFF",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-01T17:35:29Z",
"updated_at": "2023-01-01T17:35:29Z",
"author_association": "CONTRIBUTOR",
"body": "> But what's the alternative, do you have any suggestion?\r\n\r\nusing [viewBox](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBox) attribute's height and width values is a good plan IMO. \r\n - it's independent of window size in which diagram is rendered.\r\n - it's values are proportional to size of mermaid diagram.\r\n <details>\r\n <summary>small and big diagrams example</summary>\r\n\r\nthese are PNGs exported with `viewBox` dimensions\r\n\r\n ![small-fixed](https://user-images.githubusercontent.com/63918341/210179247-72300c74-d7e4-43e1-98de-f2b4b13a9f08.png)\r\nmermaid with a single block (39 * 55)\r\n***\r\n ![mermaid-1672247198591](https://user-images.githubusercontent.com/63918341/210179255-a81d8445-6290-4cd1-948b-79766a413ef0.png)\r\nbigger mermaid diagram (389*303)\r\n\r\n</details>\r\n\r\n\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368494405/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368496770",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1368496770",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1368496770,
"node_id": "IC_kwDOBLftOs5RkZqC",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-01T17:54:40Z",
"updated_at": "2023-01-01T17:54:40Z",
"author_association": "OWNER",
"body": "But since those are user space dimensions, isn't it the same as using the window dimensions? Also what is setting the viewbox? Is that the mermaid lib? And how do they determine the dimensions then?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368496770/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1369158314",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1369158314",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1369158314,
"node_id": "IC_kwDOBLftOs5Rm7Kq",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-02T19:15:08Z",
"updated_at": "2023-01-02T19:17:16Z",
"author_association": "CONTRIBUTOR",
"body": "> what is setting the viewbox? Is that the mermaid lib\r\n\r\nYes.\r\n\r\n> how do they determine the dimensions then?\r\n\r\nThey $draw^1$ the svg and use it's `getBBox` method to get the smallest rectangle in which object fits.\r\n> [setupGraphViewbox fxn of mermaid](https://github.com/mermaid-js/mermaid/blob/967d3bbb608c800b4918aa9ace7f5c9961aea704/packages/mermaid/src/setupGraphViewbox.js#L47)\r\n1. d3 lib is used to draw it \r\n\r\n> But since those are user space dimensions, isn't it the same as using the window dimensions?\r\n\r\nsorry I could not get which window we are talking about.\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1369158314/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1369605085",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1369605085",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1369605085,
"node_id": "IC_kwDOBLftOs5RooPd",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-03T10:26:20Z",
"updated_at": "2023-01-03T10:26:20Z",
"author_association": "OWNER",
"body": "But the part I don't get here is that it's vector graphics, so the vector dimensions are irrelevant and can't be of any help to export to png. And the coordinates are floating values, so for example you could fit an infinity of vector graphics in a 1.0 x 1.0 square. However if you export that to a 1x1 pixels image, that's not going to make any sense.\r\n\r\nSo how is it done normally, are there ways to get reasonable dimensions from some API or calculations? Does the DOM SVG API provides this maybe?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1369605085/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1370552257",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1370552257",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1370552257,
"node_id": "IC_kwDOBLftOs5RsPfB",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-04T07:03:55Z",
"updated_at": "2023-01-05T16:11:26Z",
"author_association": "CONTRIBUTOR",
"body": "> are there ways to get reasonable dimensions from some API or calculations? Does the DOM SVG API provides this maybe?\r\n\r\nCould not find anything useful in DOM svg APIs.\r\ngetBBox was already discussed above but it has same pros and cons as viewBox.\r\n\r\nWhen we render a mermaid diagram using mermaid js in browser, then the size in which browser renders it, can we say that that size is a reasonable dimension ? \r\n\r\n> it's vector graphics, so the vector dimensions are irrelevant and can't be of any help to export to png. And the coordinates are floating values, so for example you could fit an infinity of vector graphics in a 1.0 x 1.0 square.\r\n\r\nyes that is a problem, by using viewBox as exported dimensions we are making this assumption that viewBox size is also the recommended size of svg, which seems true in case of mermaid exported svgs since they render with same size as defined in viewBox not scaled up or down.",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1370552257/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1372542352",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1372542352",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1372542352,
"node_id": "IC_kwDOBLftOs5Rz1WQ",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-05T17:53:17Z",
"updated_at": "2023-01-05T17:53:17Z",
"author_association": "OWNER",
"body": "> When we render a mermaid diagram using mermaid js in browser, then the size in which browser renders it, can we say that that size is a reasonable dimension ?\r\n\r\nYes that's what I meant by window dimensions.\r\n\r\nSo it seems we always go back to this, so let's do this. You don't need the XML regex parsing as that's too unreliable, I think you can get the width and height directly from the DOM. Then double those dimensions to make sure it's always big enough even on hdpi screens.\r\n\r\nIn fact, doesn't it mean that we keep the current code as it is but add `* 2` for the dimensions?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1372542352/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373655969",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1373655969",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1373655969,
"node_id": "IC_kwDOBLftOs5R4FOh",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-06T13:48:10Z",
"updated_at": "2023-01-06T13:48:10Z",
"author_association": "CONTRIBUTOR",
"body": "> You don't need the XML regex parsing as that's too unreliable\r\n\r\nYes already removed that and was using dom parser to get those values, didn't pushed since I was not sure if we will choose this way or not.\r\n\r\n> double those dimensions to make sure it's always big enough even on hdpi screens\r\n\r\nOkay, on it.\r\n\r\n> doesn't it mean that we keep the current code as it is but add `* 2` for the dimensions?\r\n\r\nNo, That will be different, all images will have dimension 600 * 300. 2nd part of comment linked below explains why https://github.com/laurent22/joplin/pull/7546#issuecomment-1366789571",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373655969/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373888783",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1373888783",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1373888783,
"node_id": "IC_kwDOBLftOs5R4-EP",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-06T16:52:52Z",
"updated_at": "2023-01-06T16:52:52Z",
"author_association": "OWNER",
"body": "> No, That will be different, all images will have dimension 600 * 300. 2nd part of comment linked below explains why [#7546 (comment)](https://github.com/laurent22/joplin/pull/7546#issuecomment-1366789571)\r\n\r\nI don't know about the technical details, but the dimensions of all the exported diagrams should not be 600x300 - at a minimum the aspect ratio should match the diagram aspect ratio, which I assume we can get accurately. And the size should be based on the note viewer size.\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373888783/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373905758",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1373905758",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1373905758,
"node_id": "IC_kwDOBLftOs5R5CNe",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-06T17:09:57Z",
"updated_at": "2023-01-06T17:09:57Z",
"author_association": "CONTRIBUTOR",
"body": "> dimensions of all the exported diagrams should not be 600x300 - at a minimum the aspect ratio should match the diagram aspect ratio, which I assume we can get accurately. And the size should be based on the note viewer size.\r\n\r\nSure, That's how it will be. 🙌🏼 \r\n\r\nwe will\r\n1. Parse the svg using DOMParser to get id of svg \r\n2. getBoundingClientRect by selecting the svg from dom (like mermaid live editor does)\r\n\r\n\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373905758/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373913881",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1373913881",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1373913881,
"node_id": "IC_kwDOBLftOs5R5EMZ",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-06T17:18:19Z",
"updated_at": "2023-01-06T17:18:19Z",
"author_association": "OWNER",
"body": "> 1. Parse the svg using DOMParser to get id of svg\r\n\r\nBut why do you need to parse the SVG? In svgUriToPng there's full access to the DOM so you shouldn't need to do any [XML regex parsing](https://stackoverflow.com/questions/8577060/why-is-it-such-a-bad-idea-to-parse-xml-with-regex).",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373913881/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373987948",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1373987948",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1373987948,
"node_id": "IC_kwDOBLftOs5R5WRs",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-06T18:30:14Z",
"updated_at": "2023-01-08T05:00:00Z",
"author_association": "CONTRIBUTOR",
"body": "> why do you need to parse the SVG\r\n there's full access to the DOM\r\n\r\nwe have access to the document but we need to select the svg element to get it's rendered size, I was thinking of getting the ID of svg using the svg string we are given, then select svg element from dom using querySelector\r\n\r\n> you shouldn't need to do any [XML regex parsing](https://stackoverflow.com/questions/8577060/why-is-it-such-a-bad-idea-to-parse-xml-with-regex).\r\n\r\ninstead of regex, [DOMParser.parseFromString()](https://developer.mozilla.org/en-US/docs/Web/API/DOMParser/parseFromString) can be used, it wouldn't have those drawbacks I think.\r\n\r\nedit: I have pushed the proposed changes for discussion. will add tests if this approach is fine.\r\n",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1373987948/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1379345623",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1379345623",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1379345623,
"node_id": "IC_kwDOBLftOs5SNyTX",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-11T18:57:16Z",
"updated_at": "2023-01-11T18:57:16Z",
"author_association": "OWNER",
"body": "Please run `yarn run linter ./` since I've updated the linter rules",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1379345623/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1381503773",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1381503773",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1381503773,
"node_id": "IC_kwDOBLftOs5SWBMd",
"user": {
"login": "adarsh-sgh",
"id": 63918341,
"node_id": "MDQ6VXNlcjYzOTE4MzQx",
"avatar_url": "https://avatars.githubusercontent.com/u/63918341?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adarsh-sgh",
"html_url": "https://github.com/adarsh-sgh",
"followers_url": "https://api.github.com/users/adarsh-sgh/followers",
"following_url": "https://api.github.com/users/adarsh-sgh/following{/other_user}",
"gists_url": "https://api.github.com/users/adarsh-sgh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adarsh-sgh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adarsh-sgh/subscriptions",
"organizations_url": "https://api.github.com/users/adarsh-sgh/orgs",
"repos_url": "https://api.github.com/users/adarsh-sgh/repos",
"events_url": "https://api.github.com/users/adarsh-sgh/events{/privacy}",
"received_events_url": "https://api.github.com/users/adarsh-sgh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-01-13T09:01:14Z",
"updated_at": "2023-01-13T09:01:14Z",
"author_association": "CONTRIBUTOR",
"body": "I am facing a problem while trying to write jest tests , jsDom does not render elements so [getBoundingClientRect() always returns all dimensions as 0](https://github.com/jsdom/jsdom/issues/1590). \r\nI was trying to test `svgDimensions` function. any suggestions how to do this ?",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1381503773/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417563366",
"html_url": "https://github.com/laurent22/joplin/pull/7546#issuecomment-1417563366",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7546",
"id": 1417563366,
"node_id": "IC_kwDOBLftOs5Ufkzm",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-02-05T11:39:46Z",
"updated_at": "2023-02-05T11:39:46Z",
"author_association": "OWNER",
"body": "Ok let's drop the testing. Thanks for implementing this",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417563366/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接