wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/brenobaptista_47641641.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

1082 行
60 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14235/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14235/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14235/events",
"html_url": "https://github.com/laurent22/joplin/pull/14235",
"id": 3876190596,
"node_id": "PR_kwDOBLftOs7Aa4xn",
"number": 14235,
"title": "Desktop: Fixes #14224: Update app id to fix generic Wayland icon for AppImage on KDE",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 20,
"created_at": "2026-01-30T15:27:28Z",
"updated_at": "2026-04-05T20:45:35Z",
"closed_at": "2026-02-17T11:06:41Z",
"assignee": null,
"author_association": "CONTRIBUTOR",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14235",
"html_url": "https://github.com/laurent22/joplin/pull/14235",
"diff_url": "https://github.com/laurent22/joplin/pull/14235.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14235.patch",
"merged_at": null
},
"body": "Fixing my own issue: https://github.com/laurent22/joplin/issues/14224\r\n\r\nThis solution keeps the same packageName, but uses extraMetadata to overwrite it while building. This way Yarn Workspaces can work the same, while the bug is fixed.\r\n\r\n### Before\r\n<img width=\"840\" height=\"923\" alt=\"before\" src=\"https://github.com/user-attachments/assets/ce195cf4-0a15-4308-bc03-e6ac0ec012e3\" />\r\n\r\n### After\r\n<img width=\"838\" height=\"914\" alt=\"after\" src=\"https://github.com/user-attachments/assets/ef9656b0-40c6-4346-8025-7b0c9a3426ab\" />\r\n\r\n## StartupWMClass\r\n\r\nAlso, StartupWMClass doesn't seem to do anything for Wayland, only for X11. So in a future PR maybe we could replace the logic in `package.json` and `Joplin_install_and_update.sh` to be just \"Joplin\".\r\n\r\n<img width=\"1396\" height=\"340\" alt=\"image\" src=\"https://github.com/user-attachments/assets/0da7a642-f8e6-4a41-8a2a-cc292eee556c\" />\r\n\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14235/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14235/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3824315572",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3824315572",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3824315572,
"node_id": "IC_kwDOBLftOs7j8my0",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-30T15:27:40Z",
"updated_at": "2026-02-17T12:31:08Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3824315572/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3824318165",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3824318165",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3824318165,
"node_id": "IC_kwDOBLftOs7j8nbV",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-30T15:28:19Z",
"updated_at": "2026-01-30T15:28:19Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3824318165/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3828712443",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3828712443",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3828712443,
"node_id": "IC_kwDOBLftOs7kNYP7",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-31T15:27:32Z",
"updated_at": "2026-01-31T15:27:32Z",
"body": "I think it's possibly better to solve this as an individual issue than via this PR for now. Wayland title icons don't seem to be explained very well in documentation but if we break this down based on what we've got here and what we have so far.\r\n\r\n> Instead of using Joplin icon on AppImage, it's displaying the generic Wayland logo. It happens because a mismatch between the appId (@joplin/app-desktop) and the desktop filename (joplin.desktop).\r\n\r\nIf we propose that as the underlying issue, I think if we consider the Flatpak, Snap, and AppImage all use the same AppID by virtue of never changing it during their respective builds, you can combine it with the second observation that the Flatpak continues to work anyway despite your screenshot showing its StartupWMClass clearly doesn't match the AppID what so ever, and this doesn't cause a problem.\r\n\r\nWhen Electron went Wayland first, it was tested in advance the default installation script and snap, and the observation for both is that on X11, the StartupWMClass doesn't matter but on Wayland it does, to the point if you can only pick one as e.g., Snap does; you'd rather pick Wayland was correct and X11 was wrong, because the X11 users don't have an issue with it being wrong and can fall back to other mechanisms, Wayland afaik is basically currently in the position of if you don't have a valid `.desktop` file you don't get an icon at all. End users won't generally notice but development use cases tend not to do a full package installation or some others run the AppImage without the script, which is where this generally begins to appear.\r\n\r\nLooking at the Flatpak's recent git history, it seems that somehow they've never had to change `StartupWMClass` even after that transition. For the Flatpak then, it's probably been \"wrong\" (compared to the AppImage for example) this entire time, matching neither the non sandboxed X11 class or the Wayland class. Hypothetically I'd imagine there's likely an answer for this in the Gnome runtime the Flatpaks will use, whereby it's likely that e.g., GTK is patched to always return a StartupWMClass from the Flatpak manifest, because this would be one way to help ensure e.g., one app can't impersonate another app that happens to be installed by stealing its icons (So Joplin can't start showing a Firefox icon and get you to login to your bank account through it for example).\r\n\r\nThere's tennes of thousands of users using the current values seemingly without issues so IMO at present this likely to break more situations than it fixes.\r\n\r\nFWIW if you do continue through with this (it's still worth exploring how much Joplin can influence this, because as I say, documentation generally online isn't great) - you'd also need to update https://github.com/laurent22/joplin/blob/dev/Joplin_install_and_update.sh to match",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3828712443/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3829075534",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3829075534",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3829075534,
"node_id": "IC_kwDOBLftOs7kOw5O",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-01-31T19:03:14Z",
"updated_at": "2026-01-31T19:10:58Z",
"body": "I understand that changes in the infrastructure are tricky and I also agree that the documentation for electron-builder could be better on Linux, I had to spent a few hours searching and testing this solution.\r\n\r\nUsers usually face this issue and search for answers online, then follow guides like this: https://epergo.com/posts/fix-generic-wayland-icon or random forums, which basically do what we're doing here (they usually change the desktop filename to match the app id).\r\n\r\nI think I downloaded the AppImage and installed it through Gear Lever, which extracts the AppImage and installs using those files. I'll try using the script later tonight and see if it works differently.\r\n\r\nAbout Flatpak specifically, the app id and desktop filename match (and are different from AppImage):\r\n\r\n<img width=\"837\" height=\"915\" alt=\"Screenshot_20260131_154807\" src=\"https://github.com/user-attachments/assets/d6d299f4-1890-4e99-88e4-83892cfd1524\" />\r\n<img width=\"1127\" height=\"659\" alt=\"Screenshot_20260131_154905\" src=\"https://github.com/user-attachments/assets/84be513c-e085-475a-88a5-5c43e92bb876\" />\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3829075534/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830069195",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830069195",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830069195,
"node_id": "IC_kwDOBLftOs7kSjfL",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T02:01:21Z",
"updated_at": "2026-02-01T03:09:56Z",
"body": "I just tried using the script and got the same result:\r\n\r\n<img width=\"839\" height=\"422\" alt=\"image\" src=\"https://github.com/user-attachments/assets/71a65200-b220-4124-910d-5584ac6e0987\" />\r\n\r\nI prefer to use Gear Lever so I can easily uninstall it if I want. Not sure if the script supports uninstalling. But that's not the point right now, I just wanted to confirm the problem is on the AppImage, not the means of installing it.\r\n\r\nI set up a VM to test it on GNOME vs KDE, X11 vs Wayland (using Debian).\r\nThe result was that on GNOME, Joplin icon currently works on both Wayland and X11. On KDE, it works on X11, but not Wayland. So I'll update the issue specifically for KDE.",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830069195/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830201315",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830201315",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830201315,
"node_id": "IC_kwDOBLftOs7kTDvj",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T03:09:51Z",
"updated_at": "2026-02-01T03:13:00Z",
"body": "> About Flatpak specifically, the app id and desktop filename match\r\n\r\nThe Flatpak AppID matches the `.desktop` file name, but it doesn't actually match what Joplin considers its internal AppID which is what you're changing here - the Flatpak AppID is set entirely independantly and the Flatpak doesn't change Joplins internal ID.\r\n\r\nAssuming this patch works on your machine my thought is that Gear Leaver (or something else) has left an older `.desktop` file lying around from before Electron version 3.5, where being X11 by default, the name `startupWMClass` was infact always `Joplin`, and by making a Wayland version that does override it back to the X11 version, those files are now in sync on your individual machine.\r\n\r\nThe installation script should be setting things right but if there's more than one `.desktop` file at play which is likely with Gear Lever being independent from the installation script, I think it could be confusing things.\r\n\r\nIf it does happen on clean environments please let us now, and it is helpful to know that the ability exists if needed, but my thoughts right now are that the Flatpak wouldn't notice regardless, but the snap and AppImage via the script would both have to make changes, and the AppImage is in the worst position here because `.desktop` in snap is managed by the package manager whereas the AppImage is a free for all.\r\n\r\nFunctionally, if people upgraded from 3.4 to 3.5 whilst using Wayland and didn't regenerate the `.desktop` file for the new class, it would have broken their icons. Whilst this is unfortunate, people who did regenerate the `.desktop` file (or start from 3.5 clean) would then have the same thing again in this new version, losing their icons a second time.\r\n\r\nDoes Gear Lever keep producing `StartupWMClass=Joplin` if you use it in a clean VM?\r\n\r\nIt's awkward because it sounds like if there's no other side effects this would have been brilliant to have included prior to 3.5, but practically with the release having already passed, the damage is already done. (FWIW I believe Henry did try similar but decided it wasn't appropriate/worth it)",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830201315/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830237623",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830237623",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830237623,
"node_id": "IC_kwDOBLftOs7kTMm3",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T03:19:47Z",
"updated_at": "2026-02-01T03:19:47Z",
"body": "> Does Gear Lever keep producing StartupWMClass=Joplin if you use it in a clean VM?\r\n\r\nOn a clean VM (Debian 13 KDE), Gear Lever produces the same file as in my production one. `StartupWMClass=@joplin/app-desktop`\r\n\r\n<img width=\"1920\" height=\"1027\" alt=\"image\" src=\"https://github.com/user-attachments/assets/e9d381d5-48ed-4494-93bc-19d9218ab698\" />\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830237623/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830253645",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830253645",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830253645,
"node_id": "IC_kwDOBLftOs7kTQhN",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T03:25:53Z",
"updated_at": "2026-02-01T03:25:53Z",
"body": "Weird, thanks for checking though!\r\n\r\nTo me for Gear Lever that looks correct, but since you've split it by Gnome/KDE and also X11/Wayland, it's interesting to hear that Gnome works fine for both but KDE only works on X11. It might be something Debian specific since I remember trying this in KDE personally, but that was Fedora not Debian (https://github.com/electron/electron/issues/48298#issuecomment-3294314777)\r\n\r\nI'll let others comment on their thoughts here because I think we'd be keen to understand this a bit more, but at least to me personally it sounds nuanced and risky to change anything without a bit more understanding as to what's going wrong first :)",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830253645/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830301810",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830301810",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830301810,
"node_id": "IC_kwDOBLftOs7kTcRy",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T03:46:14Z",
"updated_at": "2026-02-01T03:55:03Z",
"body": "Sounds good to me, thanks for helping!\r\nMy production machine is Fedora KDE btw. I only chose Debian for the VM so I could easily switch between Wayland and X11.\r\n\r\nJust confirming with you, apparently you reproduced this bug on the link you shared. The fix for the Task Manager was the `StartupWMClass` you shared, and my understanding is that the fix for the Window menu icon is this PR (desktop filename and appid mismatch). If the app id didn't have @ and /, we could just update the desktop filename instead.\r\n\r\nI don't know why KDE Plasma can't reuse the same solution on both, but probably there's a reason.\r\n\r\n<img width=\"2052\" height=\"1744\" alt=\"489779726-a8972d22-c096-4339-ad64-809e7e6b7699\" src=\"https://github.com/user-attachments/assets/4a59ec36-1620-4e8e-9b47-8d8bd48a8558\" />",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830301810/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830341042",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830341042",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830341042,
"node_id": "IC_kwDOBLftOs7kTl2y",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T04:16:09Z",
"updated_at": "2026-02-01T04:19:58Z",
"body": "Ah so you're saying the actual window icon is the issue and this fixes that? Thanks (I'd not picked up the distinction in the screenshots so far apparently thinking that was your task tray instead so the bottom icon above).\r\n\r\nI think Gnome stopped showing icons there at all, but perhaps that's the difference between client side decorations in Gnome and potentially KDE using server side decorations as the underlying difference.\r\n\r\nI guess for Joplin upstream then it sounds like https://github.com/laurent22/joplin/blob/d414c6354a6270102e411244ff3628c81460f0f2/Joplin_install_and_update.sh#L325 would need changing to just `joplin.desktop` without the `AppImage` part, potentially with some cleanup logic for the older file; and I don't know off the top of my head where the `.deb` sets it but would be similar?\r\n\r\nIf the `StartupWMClass` doesn't change as a result then all the better, but if it does then since this fixes an issue that would keep occuring on new installs it's still worth doing to avoid being a problem forever.\r\n\r\nIt's difficult then with the snap because `.desktop` files there are pre-determined by the package manager and although I think there's progress in the works to allow overriding them to use custom filenames, it's not yet a thing - but it's also one of those things that's more than just Joplin (and for Joplin snap isn't an official package anyway). It'd be great if there were somewhere to document what you're seeing for the greater community for sure though because yeah, I guess it shows that I spotted your issue a while back but blanked it since being relatively minor and assuming that it was outside the packaging domain which it seemingly isn't. It'd be worth checking the Flatpak for the same problem too though reasonably I'd expect it probably has a Joplin task tray icon (people pick up on that one I feel) but a Wayland window title icon, and then perhaps that also needs similar work. Edit: Your issue says it works fine actually so ignore :)\r\n\r\nSo apologies for being noisy but I see what you're saying now and agree with you it's worth tackling; if that is a server side decoration it could be worth raising to KDE directly to see if they can fix it on their end, if it's actually a client side decoration then maybe it can be patched to not be shown at all like it is in Gnome.\r\n\r\nBut yeah for Joplin, thanks for your digging into it :)",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830341042/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830369964",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3830369964",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3830369964,
"node_id": "IC_kwDOBLftOs7kTs6s",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-01T04:48:43Z",
"updated_at": "2026-04-05T20:45:35Z",
"body": "I should've provided a full picture, sorry. The Task Manager on the bottom is fine, while the Window Menu icon and the alt+tab one fallback to Wayland icon. I think they both use the desktop filename <> appid match while the bottom uses StartupWMClass.\r\n\r\n<img width=\"1920\" height=\"1080\" alt=\"Screenshot_20260201_011953\" src=\"https://github.com/user-attachments/assets/c05abf24-dbe9-4ebb-a1ca-741fdcc517ff\" />\r\n\r\n> I think Gnome stopped showing icons there at all\r\n\r\nYeah, GNOME doesn't display the Window Menu icon on the top-left corner, I only saw the alt+tab one.\r\n\r\n> would need changing to just joplin.desktop\r\n\r\nI don't think so because the app id is \"@joplin/app-desktop\" for the AppImage even with install script (confirmed).\r\nI didn't touch it because Joplin uses Yarn Workspaces so I digged into a workaround and found out the `extraMetadata` field, so I used it instead of renaming the actual package name. It's a trade-off, if we could simplify the package name to like `joplin-desktop`, it would be easier to match both \"joplin-desktop\" app id and \"joplin-desktop.desktop\" file.\r\n\r\nIn parallel, I also made a PR for Heroic Games Launcher. In their case, the desktop filename is \"heroic_games_launcher.desktop\" and the app id is \"heroic\". https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/5250\r\n\r\n> and I don't know off the top of my head where the .deb sets it but would be similar?\r\n\r\nI totally forgot about `.deb`. I never tested it haha.\r\n\r\n> But yeah for Joplin, thanks for your digging into it :)\r\n\r\nThanks! I've been using Joplin for many years so decided to help a little 😄",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3830369964/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3845838401",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3845838401",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3845838401,
"node_id": "IC_kwDOBLftOs7lOtZB",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-04T07:39:00Z",
"updated_at": "2026-02-04T07:39:00Z",
"body": "Related Wayland Protocol for this issue: https://wayland.app/protocols/xdg-toplevel-icon-v1\r\n\r\nUnfortunately it's still in testing and would take time to roll out to users, so could be a few years away from being viable.",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3845838401/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3845988953",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3845988953",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3845988953,
"node_id": "IC_kwDOBLftOs7lPSJZ",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-04T08:14:43Z",
"updated_at": "2026-02-04T08:14:43Z",
"body": "Doing some more reading, while the server side implementation is basically just for KDE, the client side implementation of this protocol is available in GTK 4.20;\r\n\r\nThe snap in the screenshot above was and still is using GTK 4.18 (it's likely to skip to 4.22 later this year). Debian is based on Gnome 48 and would also be using GTK 4.18.\r\n\r\nIt'd be worth testing this on Fedora KDE where assuming GTK4 4.20 is installed (bearing in mind Electron can also use GTK3), this functionality *might* work without any changes in the AppImage builds.",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3845988953/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3871536697",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3871536697",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3871536697,
"node_id": "IC_kwDOBLftOs7mwvY5",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-09T12:53:00Z",
"updated_at": "2026-02-09T12:53:00Z",
"body": "Based on the discussion above it seems that maybe we shouldn't merge for now?",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3871536697/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3872116431",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3872116431",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3872116431,
"node_id": "IC_kwDOBLftOs7my87P",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-09T14:36:59Z",
"updated_at": "2026-02-09T14:36:59Z",
"body": "Either way it's cool with me, we can close this PR for now then we can test again later. I'm already on Fedora KDE with GTK4-4.20.3-1installed, but apparently Joplin is using GTK3.24.51 (checked using `GTK_DEBUG=interactive ./joplin.appimage`).",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3872116431/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3874326855",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3874326855",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3874326855,
"node_id": "IC_kwDOBLftOs7m7YlH",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-09T23:02:00Z",
"updated_at": "2026-02-09T23:02:14Z",
"body": "> Either way it's cool with me, we can close this PR for now then we can test again later. I'm already on Fedora KDE with GTK4-4.20.3-1installed, but apparently Joplin is using GTK3.24.51 (checked using `GTK_DEBUG=interactive ./joplin.appimage`).\r\n\r\nYou'd be able to force GTK with `--gtk-version=4` on via terminal on the AppImage, I don't know why it would be prefering GTK3, maybe it defaults to that in KDE rather than Gnome shell, since I was under the impression GTK4 is being used in most places if you have it.\r\n\r\n> Based on the discussion above it seems that maybe we shouldn't merge for now?\r\n\r\nAside from the Wayland protocol that would fix it for KDE with GTK4.20 (perhaps) - it's still a valid issue generally. The Wayland spec has no way to do this properly aside from the desktop file. Knowing the Flatpak isn't effected (possibly due to GTK4.20?) - and that the Snap would likely gain GTK 4.20 by June or so, that gives some guidelines for third party packages on how long they might have to wait. With the official .AppImage/Deb though, you're running entirely on the host libs and might have this for a few more years as a result depending on where users are. And the server side protocol is currently only KDE but other platforms like Cosmic or etc might still have the same issue.\r\n\r\nThe one line as is then would need the other tweaks to the .deb and install script to make the `.desktop` name consistent with Gear Lever, but assuming GTK 4.20 does the job for KDE, it's more relevant for the official packages than the unofficial ones generally.",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3874326855/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3874358354",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3874358354",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3874358354,
"node_id": "IC_kwDOBLftOs7m7gRS",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-09T23:09:58Z",
"updated_at": "2026-02-09T23:15:52Z",
"body": "I tried `./joplin.appimage --gtk-version=4`, but still ran using gtk3 according to GTK_DEBUG.\r\n\r\nAbout the Flatpak version, I think the reason it works is because of zypak-wrapper on this line: https://github.com/flathub/net.cozic.joplin_desktop/blob/master/net.cozic.joplin_desktop.yml#L138. I tried fixing this generic Wayland icon on a few flatpaks (didn't work) and as far as I got this wrapper fixes this bug on Electron. Heroic uses the same wrapper under Electron, so it also works there.\r\n\r\nFlatpaks that execute the binary directly without a wrapper sometimes mismatch app id and desktop filename, I think because then the app id uses the binary name instead of the flatpak id or something like that (didn't fully understand, sandbox is weird).",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3874358354/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3914013893",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-3914013893",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 3914013893,
"node_id": "IC_kwDOBLftOs7pSxzF",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-02-17T11:06:41Z",
"updated_at": "2026-02-17T11:06:41Z",
"body": "I'm trying to clear the PR backlog, so for now I'm closing this PR but feel free to ping me when you reach a consensus and I'll reopen and merge",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3914013893/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4189143126",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-4189143126",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 4189143126,
"node_id": "IC_kwDOBLftOs75sUBW",
"user": {
"login": "JGCarroll",
"id": 62413368,
"node_id": "MDQ6VXNlcjYyNDEzMzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JGCarroll",
"html_url": "https://github.com/JGCarroll",
"followers_url": "https://api.github.com/users/JGCarroll/followers",
"following_url": "https://api.github.com/users/JGCarroll/following{/other_user}",
"gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions",
"organizations_url": "https://api.github.com/users/JGCarroll/orgs",
"repos_url": "https://api.github.com/users/JGCarroll/repos",
"events_url": "https://api.github.com/users/JGCarroll/events{/privacy}",
"received_events_url": "https://api.github.com/users/JGCarroll/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-04-05T16:24:44Z",
"updated_at": "2026-04-05T16:24:44Z",
"body": "Just linking to https://github.com/laurent22/joplin/pull/14882 where Electron gained support for https://wayland.app/protocols/xdg-toplevel-icon-v1\r\n\r\nWhich means this is hopefully fixed for you in 3.6.7",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4189143126/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4189379303",
"html_url": "https://github.com/laurent22/joplin/pull/14235#issuecomment-4189379303",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14235",
"id": 4189379303,
"node_id": "IC_kwDOBLftOs75tNrn",
"user": {
"login": "brenobaptista",
"id": 47641641,
"node_id": "MDQ6VXNlcjQ3NjQxNjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/47641641?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/brenobaptista",
"html_url": "https://github.com/brenobaptista",
"followers_url": "https://api.github.com/users/brenobaptista/followers",
"following_url": "https://api.github.com/users/brenobaptista/following{/other_user}",
"gists_url": "https://api.github.com/users/brenobaptista/gists{/gist_id}",
"starred_url": "https://api.github.com/users/brenobaptista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brenobaptista/subscriptions",
"organizations_url": "https://api.github.com/users/brenobaptista/orgs",
"repos_url": "https://api.github.com/users/brenobaptista/repos",
"events_url": "https://api.github.com/users/brenobaptista/events{/privacy}",
"received_events_url": "https://api.github.com/users/brenobaptista/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-04-05T19:13:28Z",
"updated_at": "2026-04-05T19:17:41Z",
"body": "I just confirmed the AppImage v3.6.7 now works on Arch KDE!\r\nI'll close my related issue now.\r\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4189379303/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接