wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/chadcrum_1462069.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

675 行
30 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13286/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13286/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/13286/events",
"html_url": "https://github.com/laurent22/joplin/pull/13286",
"id": 3450360107,
"node_id": "PR_kwDOBLftOs6qVmW8",
"number": 13286,
"title": "Desktop: Fixes #12355: Auto-scroll to selected note from 'Go to Anything' search results",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": false,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 11,
"created_at": "2025-09-24T17:49:19Z",
"updated_at": "2025-10-28T11:39:25Z",
"closed_at": "2025-10-28T10:36:14Z",
"author_association": "NONE",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/13286",
"html_url": "https://github.com/laurent22/joplin/pull/13286",
"diff_url": "https://github.com/laurent22/joplin/pull/13286.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/13286.patch",
"merged_at": null
},
"body": "## Resolves\r\n\r\n- Resolves #12355\r\n\r\n## Summary\r\n\r\nWhen selecting a note from the \"Go to Anything\" search results, Joplin was not automatically scrolling the note list to show the selected note. This made it difficult for users to see which note was selected, especially in large note collections.\r\n\r\nThis fix adds a smart auto-scroll feature in that automatically scrolls to newly selected notes only when they are not currently visible in the viewport.\r\n\r\n## Implementation\r\n\r\nThe solution uses a **pending auto-scroll pattern** with three ref-based state trackers:\r\n\r\n- ****: Tracks the previously selected note ID\r\n- ****: Tracks the previously selected folder ID \r\n- ****: Tracks which note needs auto-scrolling\r\n\r\n**Auto-scroll triggers when:**\r\n1. **New note selection** (different note selected)\r\n2. **Folder change** (switching folders via \"Go to Anything\")\r\n\r\n**Auto-scroll behavior:**\r\n- Only scrolls if the target note is **outside the visible range** ()\r\n- Only triggers for **single note selections** (preserves multi-selection behavior)\r\n- **One-time action**: Each selection change triggers auto-scroll at most once\r\n- **No manual scroll interference**: Manual scrolling doesn't set pending flags\r\n\r\n## Key Features\r\n\r\n✅ **Smart scrolling**: Only auto-scrolls when the selected note is not visible \r\n✅ **Cross-folder support**: Handles \"Go to Anything\" navigation between folders \r\n✅ **Manual scroll preservation**: No interference with user scrolling \r\n✅ **Multi-selection support**: Preserves existing multi-selection behavior \r\n✅ **Performance optimized**: Uses existing function and visibility calculations \r\n\r\n## Testing\r\n\r\n1. **Go to Anything within folder**:\r\n - Use Ctrl+G to search for a note in the current folder that's not visible\r\n - Verify the note list scrolls to show the selected note\r\n\r\n2. **Go to Anything across folders**:\r\n - Use Ctrl+G to search for a note in a different folder\r\n - Verify both folder switch and note scroll work correctly\r\n\r\n3. **Manual scrolling**:\r\n - Scroll the note list manually\r\n - Verify no unexpected auto-scrolling occurs\r\n\r\n4. **Arrow key navigation**:\r\n - Use arrow keys to navigate visible notes\r\n - Verify no unnecessary scrolling for visible notes\r\n\r\n5. **Multi-selection**:\r\n - Select multiple notes using Ctrl+click\r\n - Verify auto-scroll doesn't interfere with multi-selection\r\n\r\nThis solution provides reliable auto-scrolling for \"Go to Anything\" while maintaining all existing navigation behaviors.\r\n\r\n---\r\n\r\n### Screencast show the problem\r\n[joplin-without-fix.webm](https://github.com/user-attachments/assets/de3341c3-c6e7-44ac-b502-5e3f964d24b5)\r\n\r\n### Screencast with the fix\r\n[joplin-with-fix.webm](https://github.com/user-attachments/assets/21da7408-39b7-4c58-83ff-927513caf00a)\r\n",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/13286/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13286/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330032838",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3330032838",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3330032838,
"node_id": "IC_kwDOBLftOs7GfETG",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T17:49:32Z",
"updated_at": "2025-10-28T11:39:26Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330032838/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2025-11-12T15:38:39Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"contents": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330038058",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3330038058",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3330038058,
"node_id": "IC_kwDOBLftOs7GfFkq",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T17:51:17Z",
"updated_at": "2025-09-24T17:51:17Z",
"body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330038058/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330049620",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3330049620",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3330049620,
"node_id": "IC_kwDOBLftOs7GfIZU",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T17:55:05Z",
"updated_at": "2025-09-24T17:55:05Z",
"body": "recheck",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330049620/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330085001",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3330085001",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3330085001,
"node_id": "IC_kwDOBLftOs7GfRCJ",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T18:05:02Z",
"updated_at": "2025-09-24T18:05:02Z",
"body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330085001/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330085474",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3330085474",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3330085474,
"node_id": "IC_kwDOBLftOs7GfRJi",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T18:05:09Z",
"updated_at": "2025-09-24T18:05:09Z",
"body": "recheck",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330085474/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330208387",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3330208387",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3330208387,
"node_id": "IC_kwDOBLftOs7GfvKD",
"user": {
"login": "mrjo118",
"id": 6963004,
"node_id": "MDQ6VXNlcjY5NjMwMDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mrjo118",
"html_url": "https://github.com/mrjo118",
"followers_url": "https://api.github.com/users/mrjo118/followers",
"following_url": "https://api.github.com/users/mrjo118/following{/other_user}",
"gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions",
"organizations_url": "https://api.github.com/users/mrjo118/orgs",
"repos_url": "https://api.github.com/users/mrjo118/repos",
"events_url": "https://api.github.com/users/mrjo118/events{/privacy}",
"received_events_url": "https://api.github.com/users/mrjo118/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-24T18:41:56Z",
"updated_at": "2025-09-24T18:41:56Z",
"body": "Please change the title of the PR to the following so that it matches the naming convention:\r\n\r\nDesktop: Fixes #12355: Auto-scroll to selected note from 'Go to Anything' search results",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3330208387/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340048664",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3340048664",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3340048664,
"node_id": "IC_kwDOBLftOs7HFRkY",
"user": {
"login": "mrjo118",
"id": 6963004,
"node_id": "MDQ6VXNlcjY5NjMwMDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mrjo118",
"html_url": "https://github.com/mrjo118",
"followers_url": "https://api.github.com/users/mrjo118/followers",
"following_url": "https://api.github.com/users/mrjo118/following{/other_user}",
"gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions",
"organizations_url": "https://api.github.com/users/mrjo118/orgs",
"repos_url": "https://api.github.com/users/mrjo118/repos",
"events_url": "https://api.github.com/users/mrjo118/events{/privacy}",
"received_events_url": "https://api.github.com/users/mrjo118/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-26T18:53:13Z",
"updated_at": "2025-09-26T18:53:13Z",
"body": "FYI while probably acceptable in draft stage, it's best not to force push. Once this is ready for review it's not helpful to reviewers if you keep on replacing the history. It's unnecessary to clean up the history on the branch because if it gets merged it will be squashed anyway",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340048664/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340067135",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3340067135",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3340067135,
"node_id": "IC_kwDOBLftOs7HFWE_",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-26T18:58:20Z",
"updated_at": "2025-09-26T18:58:20Z",
"body": "> FYI while probably acceptable in draft stage, it's best not to force push. Once this is ready for review it's not helpful to reviewers if you keep on replacing the history. It's unnecessary to clean up the history on the branch because if it gets merged it will be squashed anyway\r\n\r\nRight - sorry about that. I will keep this in mind in the future. ",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340067135/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340612516",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3340612516",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3340612516,
"node_id": "IC_kwDOBLftOs7HHbOk",
"user": {
"login": "chadcrum",
"id": 1462069,
"node_id": "MDQ6VXNlcjE0NjIwNjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1462069?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chadcrum",
"html_url": "https://github.com/chadcrum",
"followers_url": "https://api.github.com/users/chadcrum/followers",
"following_url": "https://api.github.com/users/chadcrum/following{/other_user}",
"gists_url": "https://api.github.com/users/chadcrum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chadcrum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chadcrum/subscriptions",
"organizations_url": "https://api.github.com/users/chadcrum/orgs",
"repos_url": "https://api.github.com/users/chadcrum/repos",
"events_url": "https://api.github.com/users/chadcrum/events{/privacy}",
"received_events_url": "https://api.github.com/users/chadcrum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-09-26T21:45:53Z",
"updated_at": "2025-09-26T21:45:53Z",
"body": "Really really ready for review this time",
"author_association": "NONE",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3340612516/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3410341992",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3410341992",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3410341992,
"node_id": "IC_kwDOBLftOs7LRbBo",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-10-16T11:07:33Z",
"updated_at": "2025-10-16T11:07:33Z",
"body": "Please let me know if you're still interested in completing this PR",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3410341992/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3455774805",
"html_url": "https://github.com/laurent22/joplin/pull/13286#issuecomment-3455774805",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13286",
"id": 3455774805,
"node_id": "IC_kwDOBLftOs7N-vBV",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2025-10-28T10:36:20Z",
"updated_at": "2025-10-28T10:36:20Z",
"body": "Closed stale PR",
"author_association": "OWNER",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3455774805/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接