wikiboss/mynode
1
0
派生 0
代码 工单 合并请求 Actions 2 软件包 项目 版本发布 百科 动态
文件
dev
mynode/readme/cla/consent_records/cwilby_13686317.json
chen 301194963b
一些检查失败了
automerge / automerge (push) Has been cancelled
详情
react-native-android-build-apk / AssembleRelease (push) Has been cancelled
详情
Build macOS M1 / Main (push) Has been cancelled
详情
Joplin Continuous Integration / Main (macos-15-intel) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-11-vs2026-arm) (push) Has been cancelled
详情
Joplin Continuous Integration / Main (windows-2025) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04) (push) Has been cancelled
详情
Joplin Continuous Integration / ServerDockerImage (ubuntu-22.04-arm) (push) Has been cancelled
详情
Joplin UI tests / Main (ubuntu-22.04) (push) Has been cancelled
详情
Joplin UI tests / Main (windows-2025) (push) Has been cancelled
详情
Joplin UI tests / Mobile (push) Has been cancelled
详情
Close stale issues / ProcessStaleIssues (push) Has been cancelled
详情
feat: Initial clean release of CHM
2026-11-04 11:29:39 +08:00

234 行
12 KiB
JSON
原始文件 永久链接 Blame 文件历史

{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/8259",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8259/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8259/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/8259/events",
"html_url": "https://github.com/laurent22/joplin/pull/8259",
"id": 1733263113,
"node_id": "PR_kwDOBLftOs5RvTED",
"number": 8259,
"title": "Desktop: Resolves #8258: Electron version 19 is EOL",
"user": {
"login": "cwilby",
"id": 13686317,
"node_id": "MDQ6VXNlcjEzNjg2MzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/13686317?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cwilby",
"html_url": "https://github.com/cwilby",
"followers_url": "https://api.github.com/users/cwilby/followers",
"following_url": "https://api.github.com/users/cwilby/following{/other_user}",
"gists_url": "https://api.github.com/users/cwilby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cwilby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cwilby/subscriptions",
"organizations_url": "https://api.github.com/users/cwilby/orgs",
"repos_url": "https://api.github.com/users/cwilby/repos",
"events_url": "https://api.github.com/users/cwilby/events{/privacy}",
"received_events_url": "https://api.github.com/users/cwilby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [],
"state": "closed",
"locked": true,
"assignee": null,
"assignees": [],
"milestone": null,
"comments": 3,
"created_at": "2023-05-31T02:02:54Z",
"updated_at": "2023-05-31T15:35:42Z",
"closed_at": "2023-05-31T15:35:25Z",
"author_association": "NONE",
"sub_issues_summary": {
"total": 0,
"completed": 0,
"percent_completed": 0
},
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/8259",
"html_url": "https://github.com/laurent22/joplin/pull/8259",
"diff_url": "https://github.com/laurent22/joplin/pull/8259.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/8259.patch",
"merged_at": null
},
"body": "This PR resolves #8258.\r\n\r\nUpgrading to Electron 25 would bring a few breaking changes that affect Joplin specifically:\r\n\r\n- Drops support for macOS <=10.12\r\n- Drops support for Windows <=8.1\r\n\r\nOther than that, I read through the [breaking changes](https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-200) from v20 to v24 and compared it with this codebase - here are my notes:\r\n\r\n## 19 => 20\r\n- 🟢 Removed macOS 10.11 / 10.12 support\r\n- 🟢 Renderers now sandboxed by default\r\n- 🟢 Removed `skipTaskbar` on Linux\r\n- 🟢 API Changed: session.setDevicePermissionHandler(handler)\r\n\r\n## 20 => 21\r\n- 🟢 Added memory cage for native modules\r\n- 🟡 API Changed: webContents.printToPDF()\r\n - Used once in `packages/app-desktop/InteropServiceHelper`.\r\n - None of the changed or removed arguments noted in [breaking changes](https://www.electronjs.org/docs/latest/breaking-changes#api-changed-webcontentsprinttopdf) are included in `ExportNoteOptions`.\r\n - Should be compatible.\r\n\r\n## 21 => 22\r\n- 🟢 Deprecated: webContents.incrementCapturerCount(stayHidden, stayAwake)\r\n- 🟢 Deprecated: webContents.decrementCapturerCount(stayHidden, stayAwake)\r\n- 🟢 Removed: WebContents new-window event\r\n- 🟢 Deprecated: BrowserWindow scroll-touch-* events\r\n\r\n## 22 => 23\r\n- 🟡 Behavior Changed: Draggable Regions on macOS\r\n - Need to test dragging/dropping notebooks in sidebar.\r\n- 🟢 Removed: Windows 7 / 8 / 8.1 support\r\n- 🟢 Removed: BrowserWindow scroll-touch-* events\r\n- 🟢 Removed: webContents.incrementCapturerCount(stayHidden, stayAwake)\r\n- 🟢 Removed: webContents.decrementCapturerCount(stayHidden, stayAwake)\r\n\r\n## 23 => 24\r\n- 🟢 API Changed: nativeImage.createThumbnailFromPath(path, size)\r\n\r\n## 24 => 25\r\n- (No documentation yet)\r\n- The changelog mostly contains additions and fixes, though breaking documentation is pending.\r\n ",
"closed_by": {
"login": "cwilby",
"id": 13686317,
"node_id": "MDQ6VXNlcjEzNjg2MzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/13686317?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cwilby",
"html_url": "https://github.com/cwilby",
"followers_url": "https://api.github.com/users/cwilby/followers",
"following_url": "https://api.github.com/users/cwilby/following{/other_user}",
"gists_url": "https://api.github.com/users/cwilby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cwilby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cwilby/subscriptions",
"organizations_url": "https://api.github.com/users/cwilby/orgs",
"repos_url": "https://api.github.com/users/cwilby/repos",
"events_url": "https://api.github.com/users/cwilby/events{/privacy}",
"received_events_url": "https://api.github.com/users/cwilby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/8259/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8259/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1569381824",
"html_url": "https://github.com/laurent22/joplin/pull/8259#issuecomment-1569381824",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8259",
"id": 1569381824,
"node_id": "IC_kwDOBLftOs5dit3A",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-05-31T02:03:07Z",
"updated_at": "2023-05-31T02:08:00Z",
"author_association": "CONTRIBUTOR",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1569381824/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1569385663",
"html_url": "https://github.com/laurent22/joplin/pull/8259#issuecomment-1569385663",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8259",
"id": 1569385663,
"node_id": "IC_kwDOBLftOs5diuy_",
"user": {
"login": "cwilby",
"id": 13686317,
"node_id": "MDQ6VXNlcjEzNjg2MzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/13686317?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cwilby",
"html_url": "https://github.com/cwilby",
"followers_url": "https://api.github.com/users/cwilby/followers",
"following_url": "https://api.github.com/users/cwilby/following{/other_user}",
"gists_url": "https://api.github.com/users/cwilby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cwilby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cwilby/subscriptions",
"organizations_url": "https://api.github.com/users/cwilby/orgs",
"repos_url": "https://api.github.com/users/cwilby/repos",
"events_url": "https://api.github.com/users/cwilby/events{/privacy}",
"received_events_url": "https://api.github.com/users/cwilby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-05-31T02:07:33Z",
"updated_at": "2023-05-31T02:07:33Z",
"author_association": "NONE",
"body": "I have read the CLA Document and I hereby sign the CLA",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1569385663/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1570215027",
"html_url": "https://github.com/laurent22/joplin/pull/8259#issuecomment-1570215027",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8259",
"id": 1570215027,
"node_id": "IC_kwDOBLftOs5dl5Rz",
"user": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2023-05-31T13:14:25Z",
"updated_at": "2023-05-31T13:14:25Z",
"author_association": "OWNER",
"body": "Ok but that's plenty of breaking changes. What testing have you done? You also updated plenty of other packages, why?\r\n\r\nAnd that version of electron-builder it breaks the Windows installer as far as i know.\r\n\r\nNot sure what I'm looking at here to be honest. It seems like a way to break a lot of things at once, unless I'm missing something",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1570215027/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}
在新工单中引用 查看 Git Blame 复制永久链接